From nobody Sun Apr 5 18:22:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E59D83E1234 for ; Mon, 23 Mar 2026 20:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296814; cv=none; b=IiuPcVJQErUV+ywOf7SUceC6cZ4JgtZNGgaR7I5vklRoR/aj2bWv0JkS0gaKswVdZYqlFP4oF8bqiqyel8UwN1sqasNQlc8+BJtpow7UlM/NPLErN19DhKApzzD7woA2cmxwsabdYd5fsu4nr3CAXUma5WxG1v3dTK9a8m5wtIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296814; c=relaxed/simple; bh=2QHtgMqo3TglD7zXCiFywppEZUI75kRalKuvSCgmedA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L03QDf+jUEgJIZErgrUVrK4f0Kpdqj249H59bRk5I52tlFVhFr3t0TxVqZvcAAh3UnvKtc5YQLJi1Ylj5xqqDEZ4mpST01V7LU+/QuRHaLRxyEN7IWL1o7apu1FZnfy5dgQw5H3/qC4+ZWRGnc8ZAB4xTqgggb6W9tpCgaFmLzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R5JcowfY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YeBRDlFH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R5JcowfY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YeBRDlFH" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHqXrU3634275 for ; Mon, 23 Mar 2026 20:13:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= i/EFVjmIq4o0XB7IqAunb20T4qbIQzoB4f8t5D0bKME=; b=R5JcowfYpShE6HKi ZZtR1afU1moPbs6WD1t9iUwFQRgLbARvEKpBPk/qiTNEqARgCK12/Z7u+nK4LRpq +YfE/PVdhkZ8X+lFKL4JJb18cSQL3la56GGS4TiS1bCl6L7oUKZoNt3AgrTJyzu/ /jCCU5a+7x7AKKjKGGcR0D2gCcP88G/WeJzya8VOlSmFk3UWsNh/4pDsPaQUYsw4 xkrg2sGcmZ8/S/wfiOUQrQn90C3B7kpFgEwXZD/iuILIL+C7yMjIr4XsPQdbmRSW cUfx1Lu3uWHCatPXwmMnPKzVnkq2mpFd28aWa9ydl5vSokCNPf4o5sF2U0gJ7NFw H6n7ew== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d34k4hwjy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 20:13:32 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-829ba0e63e8so2746913b3a.2 for ; Mon, 23 Mar 2026 13:13:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774296811; x=1774901611; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i/EFVjmIq4o0XB7IqAunb20T4qbIQzoB4f8t5D0bKME=; b=YeBRDlFHw1/nYv+yV2qZRi3QuDeA8sP7XW6xrCtSmNhsCZ44U92MnKz/HP2Vhq+62v qFq/pQrzpK6siPRoWwaHbUGC89a5aFRUUfWwlmfg7RExJSZQkzxKRpUrHQklhZ3I95XO mZPipuMdKWHZ5Xw6kP4e8feq9mkODUn9yBDjaSqYvMbFW9F5INGXfyy9dT2ECTnIr4gx FhdiEQyFi6GXD3+RhGRQm90g3rIuXNptaH/LY4zZz1YH9VP9HuQwIszQxv1a5nn4UGvG gwRAxLnB0CJkOJYP16J2JYCdiNFuwzDhsIo5PptCiCmvni1jXYiCQ8BlZg29M06i9X+k 2Q4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774296811; x=1774901611; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=i/EFVjmIq4o0XB7IqAunb20T4qbIQzoB4f8t5D0bKME=; b=VjBHAUamiF5SOsxUQXPptgRP/nM8nGv78qYhCWa4qV2kZcoAusU/VB2YdLs0hoQ8RQ GZSGjTnCfX0By5HI6YZsO9U6EKZeHtXALeCkbx52qXpZjcj9XZa3zD8G0lfOGLzUs6eZ R9t30J4HhJYBQdbdEay3Pi/eepk6vV+orMPh16AocXojOE2pC6uUaCvnVcJJJTeXSpEN F1FQbkm4Rq/ERI/hY6R+8dGBnpbuG8QSbKPnWui8jW93io7RwU0SSKYiDnwLVCvHopgz P2lez5uwV+SlzUMZ+zWBRVZkMz0U+V993GwAO57N2GtN7Oh27kSpUa+v26xNaboPSY/m 1xPQ== X-Forwarded-Encrypted: i=1; AJvYcCVI3cPhuiyi+/x77beHROaCBVvmtllp727mZIrbG9tLMkQCbJh3vkPaHfOm4k9L5+Ur6Rrdrbx3IbWQ+g0=@vger.kernel.org X-Gm-Message-State: AOJu0YwQC60sQoUoohip6mfp6QIKLkKKudEpj5dz8aq4NizH1oMdyLVz DXE06wuRMZ8pWBrhle2+V473atFCJbuB26DHh5I7eggu9OiyaeviqBmNaMM7rbl4FLHvaYDGsjH oBhXdUEsJ0LBMv+wWVp5MGeHsMqoJU2MXpu0y/N4dKx0pxkqsXH2bMoptCFGIYIEpF18= X-Gm-Gg: ATEYQzwdcIbv6lD87DtEe2L6ITPxwijXH32hLRQeUKEwlSnmOQ0BkG1IGvY2sqtTgdv PqtD+7B2rlHC/ZwaaOqFnDQvS/sZGo212LvWJK+LJwt/LjorAEdqLHgv0EVbdiw/f3ZMRAOJsJu NNtuYXB3lyFEHEd5N4U/BQmdU9ZJ4o4672xEFIVP519JjbHw/divTCntTvEaWoFXEyhugYrYqm9 TaLot8sCjLMET856ZJSvgklfNeXTRSc+ya6LOm4FSgk5kt39t6MpLS21aXUO3S+3NzF91Wdkx5c H6eFB7l6tI+5RYTdY0pVModWHDTDfKQBwndxtuHvZZhiDEHyjbaLgFgYLAG5AOodDumx6ide0i7 2ffR9vP+KY1XFjAZ15ZpmD/DLQYCTz3IDyhtwLZbV1Jv1Qw== X-Received: by 2002:a05:6a00:1707:b0:82a:8163:4bfe with SMTP id d2e1a72fcca58-82a8c38da93mr10575919b3a.60.1774296811121; Mon, 23 Mar 2026 13:13:31 -0700 (PDT) X-Received: by 2002:a05:6a00:1707:b0:82a:8163:4bfe with SMTP id d2e1a72fcca58-82a8c38da93mr10575852b3a.60.1774296809650; Mon, 23 Mar 2026 13:13:29 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409d148sm9510738b3a.29.2026.03.23.13.13.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 13:13:29 -0700 (PDT) From: Akhil P Oommen Date: Tue, 24 Mar 2026 01:42:21 +0530 Subject: [PATCH 09/16] drm/msm/adreno: Implement gx_is_on() for A8x Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-a8xx-gpu-batch2-v1-9-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> In-Reply-To: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774296753; l=6497; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=2QHtgMqo3TglD7zXCiFywppEZUI75kRalKuvSCgmedA=; b=hquaopb4yfbmflNYOXExPzWdFx7cZL5F60eeWJy+fD6AopfspxA3QntDU/q/URSv5NPSWGMeF unE3v63PjiyDlPBks60CG219KYKk5i9OBmXmHMwdsjkpfZ3BiPXeHgD X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: 4XV8wOcDzKPBV3SfGMy41b1GcC4CIZlJ X-Proofpoint-ORIG-GUID: 4XV8wOcDzKPBV3SfGMy41b1GcC4CIZlJ X-Authority-Analysis: v=2.4 cv=c+imgB9l c=1 sm=1 tr=0 ts=69c19eec cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=wYauUFJWvglRPmXws0gA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE0OSBTYWx0ZWRfX5D0gr4WGZ+R6 u9/NO/goehzifQKPd/TeY+26A7r5XJJBdHePrvEbg8uNFe5irD/mZsXTC0zhkRuVJsSV2IOwB0x m5Tre2Y601UpsCyvohC6Ms5bZ2vHkJLlR/t72JFu+zmdJv59oayOY1f2trDw9qv0GN5D7Grd26W e7dTXbGV77BNOw9H51qHg5K9ncekpUg7WibCkzSgGttrSUthXLLuBGVpTz2biU9umkf5f1wRp1E 01Sd40I6rhCa3lxHEmyVWfpBJ4DuY+iLrTOUvaH54be6OWfNY7HRheBO1DZuT9lyVuBJGb0AY+z lw87ujlWmHZ/+eUZ7K4UCVo9YMC2TGYYxvBQWDryCRnY7se1O/FnPuPPxSuLjrL9b6V51P4IFFL 3Mv4XXlBVPwb22wfyO0X1Er2zSGUG46u5Qmfc9qb5sV6OgpfUZEExYY2NLEGRwR13jSBMiwX6AT 0wnrJWF5422KR4enfWw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_05,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230149 A8x has a diverged enough for a separate implementation of gx_is_on() check. Add that and move them to the adreno func table. Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support") Signed-off-by: Akhil P Oommen Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 25 +++++++++++++++++++++---- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 4 +++- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +++++- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 4 ++-- drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + 5 files changed, 32 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 6d511dc54e43..cd6609bb66fe 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -91,10 +91,10 @@ bool a6xx_gmu_sptprac_is_on(struct a6xx_gmu *gmu) } =20 /* Check to see if the GX rail is still powered */ -bool a6xx_gmu_gx_is_on(struct a6xx_gmu *gmu) +bool a6xx_gmu_gx_is_on(struct adreno_gpu *adreno_gpu) { - struct a6xx_gpu *a6xx_gpu =3D container_of(gmu, struct a6xx_gpu, gmu); - struct adreno_gpu *adreno_gpu =3D &a6xx_gpu->base; + struct a6xx_gpu *a6xx_gpu =3D to_a6xx_gpu(adreno_gpu); + struct a6xx_gmu *gmu =3D &a6xx_gpu->gmu; u32 val; =20 /* This can be called from gpu state code so make sure GMU is valid */ @@ -117,6 +117,23 @@ bool a6xx_gmu_gx_is_on(struct a6xx_gmu *gmu) A6XX_GMU_SPTPRAC_PWR_CLK_STATUS_GX_HM_CLK_OFF)); } =20 +bool a8xx_gmu_gx_is_on(struct adreno_gpu *adreno_gpu) +{ + struct a6xx_gpu *a6xx_gpu =3D to_a6xx_gpu(adreno_gpu); + struct a6xx_gmu *gmu =3D &a6xx_gpu->gmu; + u32 val; + + /* This can be called from gpu state code so make sure GMU is valid */ + if (!gmu->initialized) + return false; + + val =3D gmu_read(gmu, REG_A8XX_GMU_PWR_CLK_STATUS); + + return !(val & + (A8XX_GMU_PWR_CLK_STATUS_GX_HM_GDSC_POWER_OFF | + A8XX_GMU_PWR_CLK_STATUS_GX_HM_CLK_OFF)); +} + void a6xx_gmu_set_freq(struct msm_gpu *gpu, struct dev_pm_opp *opp, bool suspended) { @@ -240,7 +257,7 @@ static bool a6xx_gmu_check_idle_level(struct a6xx_gmu *= gmu) =20 if (val =3D=3D local) { if (gmu->idle_level !=3D GMU_IDLE_STATE_IFPC || - !a6xx_gmu_gx_is_on(gmu)) + !adreno_gpu->funcs->gx_is_on(adreno_gpu)) return true; } =20 diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.h index dd0614b19aac..9a5464fa6a07 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h @@ -10,6 +10,7 @@ #include #include #include "msm_drv.h" +#include "adreno_gpu.h" #include "a6xx_hfi.h" =20 struct a6xx_gmu_bo { @@ -231,7 +232,8 @@ void a6xx_hfi_stop(struct a6xx_gmu *gmu); int a6xx_hfi_send_prep_slumber(struct a6xx_gmu *gmu); int a6xx_hfi_set_freq(struct a6xx_gmu *gmu, u32 perf_index, u32 bw_index); =20 -bool a6xx_gmu_gx_is_on(struct a6xx_gmu *gmu); +bool a6xx_gmu_gx_is_on(struct adreno_gpu *adreno_gpu); +bool a8xx_gmu_gx_is_on(struct adreno_gpu *adreno_gpu); bool a6xx_gmu_sptprac_is_on(struct a6xx_gmu *gmu); void a6xx_sptprac_disable(struct a6xx_gmu *gmu); int a6xx_sptprac_enable(struct a6xx_gmu *gmu); diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 897522778fd4..cdecd91094c6 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -1641,7 +1641,7 @@ static void a6xx_recover(struct msm_gpu *gpu) =20 adreno_dump_info(gpu); =20 - if (a6xx_gmu_gx_is_on(&a6xx_gpu->gmu)) { + if (adreno_gpu->funcs->gx_is_on(adreno_gpu)) { /* Sometimes crashstate capture is skipped, so SQE should be halted here= again */ gpu_write(gpu, REG_A6XX_CP_SQE_CNTL, 3); =20 @@ -2768,6 +2768,7 @@ const struct adreno_gpu_funcs a6xx_gpu_funcs =3D { .get_timestamp =3D a6xx_gmu_get_timestamp, .bus_halt =3D a6xx_bus_clear_pending_transactions, .mmu_fault_handler =3D a6xx_fault_handler, + .gx_is_on =3D a6xx_gmu_gx_is_on, }; =20 const struct adreno_gpu_funcs a6xx_gmuwrapper_funcs =3D { @@ -2800,6 +2801,7 @@ const struct adreno_gpu_funcs a6xx_gmuwrapper_funcs = =3D { .get_timestamp =3D a6xx_get_timestamp, .bus_halt =3D a6xx_bus_clear_pending_transactions, .mmu_fault_handler =3D a6xx_fault_handler, + .gx_is_on =3D a6xx_gmu_gx_is_on, }; =20 const struct adreno_gpu_funcs a7xx_gpu_funcs =3D { @@ -2834,6 +2836,7 @@ const struct adreno_gpu_funcs a7xx_gpu_funcs =3D { .get_timestamp =3D a6xx_gmu_get_timestamp, .bus_halt =3D a6xx_bus_clear_pending_transactions, .mmu_fault_handler =3D a6xx_fault_handler, + .gx_is_on =3D a6xx_gmu_gx_is_on, }; =20 const struct adreno_gpu_funcs a8xx_gpu_funcs =3D { @@ -2861,4 +2864,5 @@ const struct adreno_gpu_funcs a8xx_gpu_funcs =3D { .get_timestamp =3D a8xx_gmu_get_timestamp, .bus_halt =3D a8xx_bus_clear_pending_transactions, .mmu_fault_handler =3D a8xx_fault_handler, + .gx_is_on =3D a8xx_gmu_gx_is_on, }; diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index 018c164ad980..c0b9661131e8 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -1251,7 +1251,7 @@ static void a6xx_get_gmu_registers(struct msm_gpu *gp= u, _a6xx_get_gmu_registers(gpu, a6xx_state, &a6xx_gpucc_reg, &a6xx_state->gmu_registers[2], false); =20 - if (!a6xx_gmu_gx_is_on(&a6xx_gpu->gmu)) + if (!adreno_gpu->funcs->gx_is_on(adreno_gpu)) return; =20 /* Set the fence to ALLOW mode so we can access the registers */ @@ -1608,7 +1608,7 @@ struct msm_gpu_state *a6xx_gpu_state_get(struct msm_g= pu *gpu) } =20 /* If GX isn't on the rest of the data isn't going to be accessible */ - if (!a6xx_gmu_gx_is_on(&a6xx_gpu->gmu)) + if (!adreno_gpu->funcs->gx_is_on(adreno_gpu)) return &a6xx_state->base; =20 /* Halt SQE first */ diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/= adreno/adreno_gpu.h index c08725ed54c4..29097e6b4253 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h @@ -82,6 +82,7 @@ struct adreno_gpu_funcs { u64 (*get_timestamp)(struct msm_gpu *gpu); void (*bus_halt)(struct adreno_gpu *adreno_gpu, bool gx_off); int (*mmu_fault_handler)(void *arg, unsigned long iova, int flags, void *= data); + bool (*gx_is_on)(struct adreno_gpu *adreno_gpu); }; =20 struct adreno_reglist { --=20 2.51.0