From nobody Sun Apr 5 18:22:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EED23DFC7C for ; Mon, 23 Mar 2026 20:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296802; cv=none; b=UNo/eccpiJDjIK75SDg748OvmxAkC05P4kvwsKbbu/WkQZruEOcHlaZX+nYF/APQB8odBpCOGWuq/QidZ3ijv9ZHB+g3zxCUVPHFCR0dDD9VSVdqz9ibKrWW/z7xt2vjSZf0+iz2u5F2PqAOQ1PG/KZOWW5r36YqCltE9m6nsx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296802; c=relaxed/simple; bh=nnupNIOeLrMXfkuUyA2tcvNb3mffh+T80cPwHVdQi3c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XEsde/bAOHJS2JWG9ide8Stjk0qjhMBXGBXL5/np2pvd4B2O1eFht9Pa3a05/ZUEQRIPsBFEgXnPpdDLOnoz0kNrS4ltE+A4klxn5ja8uTLuQ0TBZDm7IAOm9GXb/pdukV/80npiT4O1JkhGJiUdhhzhxS1iD7QuJhDqVYt8HJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GWO6czEO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XaYtVc2Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GWO6czEO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XaYtVc2Z" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHrhC2620409 for ; Mon, 23 Mar 2026 20:13:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s55BbPd47G4U0MWootUpuQFOjqvge2EChb3luzG9YmY=; b=GWO6czEOxZHUTfuP izJhaXgEvot5as2nB1ugMTX7VRUAaZ0xW15h4Q1YgYjKdPr5SDmz99OD6XY7fR+L XaSmUX9gynnYxEWCKh6q0O8DdgW2BwAi5hBRbYEeyv9VveKBpvK1slDOIqqra14m GkqqDDATh8nFpUOI9Ioz5qBZrVZFiSE/IIs9OLpVYcIzDCaFUY29XxxHudg7EkJs GE6z4xnk+cAE2VIf1eD5f7V/L6rhsimeqyeVr2GBnpRAqzzso+41Tfd/S9axdsLH 67RWgW/paAgsjl2P+4RZ+jy4WW5v/kInVwQxEkD4bBSaavnxOuoXYW7+Kl6JUsam j4vbBA== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jgjkg2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 20:13:19 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82a820305c1so392293b3a.0 for ; Mon, 23 Mar 2026 13:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774296799; x=1774901599; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=s55BbPd47G4U0MWootUpuQFOjqvge2EChb3luzG9YmY=; b=XaYtVc2ZN+xeLloSG4Zsbj+4e8S0HwS5+xCKeWhgSyvAmWQ+zZAHq+YHhpXrMYrtxD fFkCN/jGxRB+/HiMtKRCnREKaSzOMApSKpExyAOYtEuJvZxfx6kDdV7pGoa/GEQ5LHMQ MMZunu+H1e5J83NeigZizDWf2Zm4pf/xpIGjeqrBuuvafUubpG/0Ekvewb3sAWSE8nM/ UCqussxmxtU80fQU5KXnYkC/6zOVh87WeCiy3W6kOmApsdt7GavngBsnFs5X0zFJYxYP dpT11Munyvw8waqwhYzYV6mFdwSd4ck0lx2n2GWEpbpyn/DfROBocWiywQWrLC5UBvep Fc4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774296799; x=1774901599; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=s55BbPd47G4U0MWootUpuQFOjqvge2EChb3luzG9YmY=; b=FNuxtZsQQZ61ZBGHux3sqqLmJ8QNQX7Mouy3tKqZlZ/WKJrU8U/mM+eec6i7QmVA+/ rPOqMXIKAHeZ+7e3jbDMkmFhbQh3786Gr+LC6Zje/1murd/ZghBdmUJBWheskXcCl8vV 4+wANsqtxkAfXGqdGJM+apvEE21HVkKX02UZEvDbN44xiDBHd3t0/TKsDLmR+wdYGqhK gMsybdi8rsxYyHCtoRy01ZhxQN2XYObRxaHjnIrIESOycKL9nmVwvVUBAX1hMYdF6rLq pw1wZn49l1DvnrxkJNGo1KYonVfsj4kX0xJchxPVFF7TFtSY6P2IKr9BrE1JNSOwg0SO mKSw== X-Forwarded-Encrypted: i=1; AJvYcCVlarQT1WKTrekZkE7b6Y+8Ys3CSaUi5mGSER8IqVGWwx2kBLAVUkmlcei7ljFEKRok+HUS7p3IWfl22WY=@vger.kernel.org X-Gm-Message-State: AOJu0YycIM6kptMNFmA8VTVur32J9JqZXYtw/XkS7iPAr7B6bnSXGU/+ S9GQ/mbo34HGI5gH+44ANscZiQl2uV7DvYCVwuEN1NLTSzPPlSKblSy/Fm812aeUrVCQv3MQNy3 3xGNqxzsxJqXHIFN82WzQC3wptIJ9UNCludV2iGqF7W6S5p6hkcfq/+fMAAfxtWNd9nk= X-Gm-Gg: ATEYQzyTlslbhrCYN+s7CUGl5dXYqKBvVaRz6iOLXu6RGfL5riCtKxhVt0taeX4Falv VXR3y1XWlVyc0IEeSMqGoNxsjOKt//UNBhRNGYthE6JWg0V6OFnQJEVqeYVe/yt+HBObCM+szod xS0M8ENd9UljZynaAYv1bVrOJWF2hysZQcscWgqv3NB7Ok4I7SAXRmHyYzedRZ54DWjHW2fRjrB bBxXb88rKud9RwPF7Z17cmXWyComxBHF1tpKxTIQgx8HWIwYYpaf5fHJ4keprDO/HS8sZcveIl/ lmMoboY9X/oQcyq7QCzM+Z3ankn1IMvwTjTa49Gq+vpchz3YktC1s7uNckkTY1Pz3pdjX5/yFb9 7NXgm3RU8CQIeYisPexR3JAjHNRZnWP++4NtkjlVdRnfkhQ== X-Received: by 2002:a05:6a00:1707:b0:82a:6461:6d1e with SMTP id d2e1a72fcca58-82a8c392393mr11129958b3a.46.1774296798790; Mon, 23 Mar 2026 13:13:18 -0700 (PDT) X-Received: by 2002:a05:6a00:1707:b0:82a:6461:6d1e with SMTP id d2e1a72fcca58-82a8c392393mr11129922b3a.46.1774296798223; Mon, 23 Mar 2026 13:13:18 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409d148sm9510738b3a.29.2026.03.23.13.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 13:13:17 -0700 (PDT) From: Akhil P Oommen Date: Tue, 24 Mar 2026 01:42:19 +0530 Subject: [PATCH 07/16] drm/msm/a6xx: Use packed structs for HFI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-a8xx-gpu-batch2-v1-7-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> In-Reply-To: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774296753; l=3900; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=nnupNIOeLrMXfkuUyA2tcvNb3mffh+T80cPwHVdQi3c=; b=wYEXOm/R6Vsxc4rBfrfyT9WUhx8CW/T2BOGGO+xofnEJDCbPmC1wyW81635C1kRzkWrzKXy7u JYNCqh7a/gdBW5mk2jJTJvHPIghQWautFCviH27ZFJuilb3Nhxx5u75 X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: uws0PhzIny0itPlDnKTu-_MVTH-Y_XPH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE0OSBTYWx0ZWRfXxaeUENSekAlE r2uSyZ6SwtL6SaUG7vBxJEfJsvAmRdgTuJYYKAzWzBhHa24A6W5onnFqiyTxd+XRXOOYoN3Kkgw VuBS/46E+xkNTJiP6sxB4njtWBkD0SgUijAL9Euhb3/hfsiYsezfs2lqt/NIVtRr/35i80FnYV8 z/VmJEwdgNf+HiA5vOIEqPfTeQ8Z0qZ+jQr8xr1BK3MEjS6iOml6ttn40yQlAjUeuybvQQhj1mb lzo7K5LJrNZu3DttlmH8RXdKrjumeuYK8zqRvGxrmtqClL/Dxqu5b+3yxqoA9qpoCeHjLlxpmbd xAtuSbewvA8AP+cpZrWe8WtZwIp6zC5ZFMG4EK3LOn8BQLrqjjKDhELV8Y+Y+YZogxG20vgywqD bYijjdISPr8zWiJvaAoTB4R9bEQOb9B1LYU1tIm8UfMGjBWp8R1/fPs1gvg4Naq8vyox6mm+7qB blR1CXkdtaiND3wpf9A== X-Authority-Analysis: v=2.4 cv=CMInnBrD c=1 sm=1 tr=0 ts=69c19edf cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=ArFqxpKCfli7nxZMP-sA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: uws0PhzIny0itPlDnKTu-_MVTH-Y_XPH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_05,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230149 HFI related structs define the ABI between the KMD and the GMU firmware. So, use packed structures to avoid unintended compiler inserted padding. Signed-off-by: Akhil P Oommen Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_hfi.h | 40 +++++++++++++++++--------------= ---- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.h b/drivers/gpu/drm/msm/ad= reno/a6xx_hfi.h index 19f6eca2c8c9..217708b03f6f 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.h @@ -13,7 +13,7 @@ struct a6xx_hfi_queue_table_header { u32 qhdr_size; /* Size of the queue headers */ u32 num_queues; /* Number of total queues */ u32 active_queues; /* Number of active queues */ -}; +} __packed; =20 struct a6xx_hfi_queue_header { u32 status; @@ -28,7 +28,7 @@ struct a6xx_hfi_queue_header { u32 tx_request; u32 read_index; u32 write_index; -}; +} __packed; =20 struct a6xx_hfi_queue { struct a6xx_hfi_queue_header *header; @@ -74,7 +74,7 @@ struct a6xx_hfi_msg_response { u32 ret_header; u32 error; u32 payload[HFI_RESPONSE_PAYLOAD_SIZE]; -}; +} __packed; =20 #define HFI_F2H_MSG_ERROR 100 =20 @@ -82,7 +82,7 @@ struct a6xx_hfi_msg_error { u32 header; u32 code; u32 payload[2]; -}; +} __packed; =20 #define HFI_H2F_MSG_INIT 0 =20 @@ -92,27 +92,27 @@ struct a6xx_hfi_msg_gmu_init_cmd { u32 dbg_buffer_addr; u32 dbg_buffer_size; u32 boot_state; -}; +} __packed; =20 #define HFI_H2F_MSG_FW_VERSION 1 =20 struct a6xx_hfi_msg_fw_version { u32 header; u32 supported_version; -}; +} __packed; =20 #define HFI_H2F_MSG_PERF_TABLE 4 =20 struct perf_level { u32 vote; u32 freq; -}; +} __packed; =20 struct perf_gx_level { u32 vote; u32 acd; u32 freq; -}; +} __packed; =20 struct a6xx_hfi_msg_perf_table_v1 { u32 header; @@ -121,7 +121,7 @@ struct a6xx_hfi_msg_perf_table_v1 { =20 struct perf_level gx_votes[16]; struct perf_level cx_votes[4]; -}; +} __packed; =20 struct a6xx_hfi_msg_perf_table { u32 header; @@ -130,7 +130,7 @@ struct a6xx_hfi_msg_perf_table { =20 struct perf_gx_level gx_votes[16]; struct perf_level cx_votes[4]; -}; +} __packed; =20 #define HFI_H2F_MSG_BW_TABLE 3 =20 @@ -145,13 +145,13 @@ struct a6xx_hfi_msg_bw_table { u32 cnoc_cmds_data[2][6]; u32 ddr_cmds_addrs[8]; u32 ddr_cmds_data[16][8]; -}; +} __packed; =20 #define HFI_H2F_MSG_TEST 5 =20 struct a6xx_hfi_msg_test { u32 header; -}; +} __packed; =20 #define HFI_H2F_MSG_ACD 7 #define MAX_ACD_STRIDE 2 @@ -163,13 +163,13 @@ struct a6xx_hfi_acd_table { u32 stride; u32 num_levels; u32 data[16 * MAX_ACD_STRIDE]; -}; +} __packed; =20 #define HFI_H2F_MSG_START 10 =20 struct a6xx_hfi_msg_start { u32 header; -}; +} __packed; =20 #define HFI_H2F_FEATURE_CTRL 11 =20 @@ -178,14 +178,14 @@ struct a6xx_hfi_msg_feature_ctrl { u32 feature; u32 enable; u32 data; -}; +} __packed; =20 #define HFI_H2F_MSG_CORE_FW_START 14 =20 struct a6xx_hfi_msg_core_fw_start { u32 header; u32 handle; -}; +} __packed; =20 #define HFI_H2F_MSG_TABLE 15 =20 @@ -193,7 +193,7 @@ struct a6xx_hfi_table_entry { u32 count; u32 stride; u32 data[]; -}; +} __packed; =20 struct a6xx_hfi_table { u32 header; @@ -202,7 +202,7 @@ struct a6xx_hfi_table { #define HFI_TABLE_BW_VOTE 0 #define HFI_TABLE_GPU_PERF 1 struct a6xx_hfi_table_entry entry[]; -}; +} __packed; =20 #define HFI_H2F_MSG_GX_BW_PERF_VOTE 30 =20 @@ -211,7 +211,7 @@ struct a6xx_hfi_gx_bw_perf_vote_cmd { u32 ack_type; u32 freq; u32 bw; -}; +} __packed; =20 #define AB_VOTE_MASK GENMASK(31, 16) #define MAX_AB_VOTE (FIELD_MAX(AB_VOTE_MASK) - 1) @@ -224,6 +224,6 @@ struct a6xx_hfi_prep_slumber_cmd { u32 header; u32 bw; u32 freq; -}; +} __packed; =20 #endif --=20 2.51.0