From nobody Sun Apr 5 18:22:01 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 670573BF682 for ; Mon, 23 Mar 2026 20:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296796; cv=none; b=n40iAKf/8NSVYeHvpl++Lxcx6eqbnCbFUH+zJBQhseCYbOV2Seg3L1uhdJ1Kdzp7saVJZJCe1bWd+ZmDoQluCVgyoflWdjz1/MkUA3KYUsxKL+7SYRpdoPn4pm9eY95VMxYxHOHFFbBpHKJ0kRBnrhqAqdR+wT0KyRYaOOCut1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296796; c=relaxed/simple; bh=1ajLVoslkBTv41Sp8G4luxsz7Te6eYrrZtKsz0zxR/0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hlMqS70zlhE1QS380R0xHCMhYfl7jttpZo1KIMlC/+TPCkDF3UaH+kS4m/cfzXaRSGmy9PnLLzRV7FxR1lBAAgaItrsQy/Yd3yERC2wnXo6XbikRsJnNyseFNl9NwC+VvMtT3tFZDOm4Us+Td/Y0HI7AWSNASob1h6oNqznuf/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aOXMgnna; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dWOebm+M; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aOXMgnna"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dWOebm+M" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHqYPW3170682 for ; Mon, 23 Mar 2026 20:13:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iFi8aoHCvHDcD5YBbZdBFmik9S7MrX8p/en9vgMxupI=; b=aOXMgnnaMW2rfqSm wf62voJmAEkx/vKDnitU4Jh6I+Jx9zjys+3vRU5b6OOGPsOe+N7aF15Klx1HQe0j VgFTzhqWfc1X3Cq/hARFhbp5MkrRthSJ1ksvZD6XHyJIqFXbFtRfXgpNIEny9zUy C6ik7xWFs8OomYncVeiUK1WIyzYiIXaR6fdC0yE2VqAQyZBm4W1VGouUFsnBeuVH wI+RAIicJKiwElL+y07nTDqRJMqgNruncASULMUkJyWmOLgw3zdGPG1RYC4Zp0yw zK0Zqo2xSSoO2V6GDjufxkp7rfU6R6Ka0gAbnebsXOybe9KfLJIy5YwXdzWwTZMe Fe9KIQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d35r21jxc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 20:13:14 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b62da7602a0so2376281a12.2 for ; Mon, 23 Mar 2026 13:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774296793; x=1774901593; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iFi8aoHCvHDcD5YBbZdBFmik9S7MrX8p/en9vgMxupI=; b=dWOebm+MY4mYFHddn0uBWhIwa9tJCm0yJLasqUwncgYgEfWfvMKzLImWfYzei416WX P7yexKuGyO061Pdzc7dN0ilNtAkVbJEaRu9Couwe0AM8UFzIQPBccHygMNDf8ZHxG30R lcuKukjqEWAPf/I9aanc+VAYTe8H+9uKgW73npSLF+f+gxBONSUXGrSLgFW8FRpGM0B0 RAg86G5EH9JQmFpOyFvz9ehRC2aRfMpoewEBUN4D0OHOJAnc9z+Em73nfQ4Du8CqVHhM eodyzVVbfvZvvfBZB9ZuIIR80pehV7GCv+scvhJ9cAbBGfVbQX4VFBco00LlMHWBhec1 9NZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774296793; x=1774901593; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iFi8aoHCvHDcD5YBbZdBFmik9S7MrX8p/en9vgMxupI=; b=JKy9szoaEGyTNUojb5YRuU+hL19ysDnt7Nx4rEhmH0vTEdBOiErFVesuuh8nA6Uij1 SKPXBryFwSpt+MWrOSij3MoTLIcxkqLl/BIbJBpCfFJDvCPO9KJG8edGsZfQsPC7CVSU VprYbby2FcfJX5z5IXkUU5L2a9gAN4KOYDqryZ0J4zChbBts3GfTXiAteDkHWQMaRYme G+zPEXCjCKzkdokLTYjDibszlGNKuMIF1JE1fmyy3DxXEyQbbxVTkuxbOD23f8XwTiNM aGTx1lG32dDZ9x/DFGLWPZqf4n9/SUDi17dP6ITojQ/FY1OnGj3yPrsFi4wpagypyUDO SbcQ== X-Forwarded-Encrypted: i=1; AJvYcCWfIb95Zn1/Yfz1crCJzgxse4k6NiA3QVHS1RDRcBpTEuieVb5fdkuqNtNRdPYrAR1W9FU8SYtG70iKH9o=@vger.kernel.org X-Gm-Message-State: AOJu0YxhmH+qpkOh7QRoGI53Y2WPB2IJjLMuqgOjkvRwvLHOt2ihep+p IUt/pRaLVdbMRHTG8KQnzf6BVf2QcHFBrUcsjbD/Is1i7pckA176N/vq0ISGJEZNK8zUyW1EvHd lsepxfFg14NN4I/gTwn1lJVWLuYduBVMUlHC+NBDxi5ML5DV/8IWZZ+1/y3v0irwOHqw= X-Gm-Gg: ATEYQzzCPMkkxsOFRJ6kqkkYLdNjb3eGCH2v0d9ymuNUfLBSBWtz1PlHMmOXmLnvNV0 RBj0GrtMn/CKZ6gENymUYC9KS5iBzlXPe7ZaFXEqURCjpiSYMbtxX+Ryp4/IE+Ujm5E4TVloLZg T0IgQ81D+rBYtK69LZLds/tQQF2OF+KvNCrrcIByB6itoM9NwkFryeqZxFMr34FM7yMp3OePRqa ZwujJIqyDShqFYY5lqCOgcQOetWmUZUiCSJfm44jw5es71Kt+801W0Rz0HeUgW7FSlIILqIt1p9 bR1qJsF5yrTFqbDFnOT4m5JYPwenxLRD6M9KTxc1n0/MEQe+ulS9olOnnR2vPnakFYxgpldVLq0 tQQbFUNfHyrnsW7ySyoMGXyXw99jiw+Lx9t674dWRVr35yg== X-Received: by 2002:aa7:8ed2:0:b0:82a:1529:2b4f with SMTP id d2e1a72fcca58-82a8c35758cmr8866478b3a.44.1774296793137; Mon, 23 Mar 2026 13:13:13 -0700 (PDT) X-Received: by 2002:aa7:8ed2:0:b0:82a:1529:2b4f with SMTP id d2e1a72fcca58-82a8c35758cmr8866464b3a.44.1774296792639; Mon, 23 Mar 2026 13:13:12 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409d148sm9510738b3a.29.2026.03.23.13.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 13:13:12 -0700 (PDT) From: Akhil P Oommen Date: Tue, 24 Mar 2026 01:42:18 +0530 Subject: [PATCH 06/16] drm/msm/a6xx: Use barriers while updating HFI Q headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-a8xx-gpu-batch2-v1-6-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> In-Reply-To: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774296753; l=1974; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=1ajLVoslkBTv41Sp8G4luxsz7Te6eYrrZtKsz0zxR/0=; b=fMD8o5dT8SsxOVs4k4rWFPgLkKIR8YU77uqDQ0DMUTmim9gm/FgM8cMODWImekNXWofrA88+w e0f5Cwsu1g7BsVGQC1TXcmqh/guEntf0zGyTwt2ln78P0OQd5K3Jkww X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Authority-Analysis: v=2.4 cv=VvUuwu2n c=1 sm=1 tr=0 ts=69c19eda cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=h6CQE6Wve-Y6OpkwRbYA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: RVp4BiFDe48uJwZkr9TLiXGBrqfmcNfq X-Proofpoint-ORIG-GUID: RVp4BiFDe48uJwZkr9TLiXGBrqfmcNfq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE0OSBTYWx0ZWRfXyxYAaEk3U9ci 2by6MaT07xsI1AaRlXEZwIbUA76I80UU7mpkUf7jdPExshxpValW+8TRqsZ7MljolclP7YVbHAr 6BXVKcylaFvgkfDrT/mlfewRLZHStwn/UAQXkJiE3cpMA1x7Y99xX3yuQ/XXJUfvHZvplQWv/AI 7lVE2k7Zn2X6qBpiLM1GE8QkyGlj/Ku2Nq5rcGfkx4+lj3kOx0arh/UqoRmbLrwif/05XzMgFI/ 8MJgZoADSZj2GnAq7wQUhpD57K9s/zAfJHN0oXnBmQl/h5upG0l+nsyk/LdWqTSFMUlARCy6wX7 60BhEHXPx83V4uG8LImvrkzYYp/kUA3tyYCJI0H4ZoBZ7rLOc0uxRsQZ+taKappBMj/fuYaeBa2 xDoAr/V8iw7RfbuyVdLp3FPW80/b8rU3/BxbVfd/v7Z5qmysSDnOhIwDVdOBX6ZxsLsVTQumrXG 93fJ8LNLDUNhplGdw9w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_05,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230149 To avoid harmful compiler optimizations and IO reordering in the HW, use barriers and READ/WRITE_ONCE helpers as necessary while accessing the HFI queue index variables. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/ad= reno/a6xx_hfi.c index 2daaa340366d..aef00c2dd137 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c @@ -34,7 +34,7 @@ static int a6xx_hfi_queue_read(struct a6xx_gmu *gmu, struct a6xx_hfi_queue_header *header =3D queue->header; u32 i, hdr, index =3D header->read_index; =20 - if (header->read_index =3D=3D header->write_index) { + if (header->read_index =3D=3D READ_ONCE(header->write_index)) { header->rx_request =3D 1; return 0; } @@ -62,7 +62,10 @@ static int a6xx_hfi_queue_read(struct a6xx_gmu *gmu, if (!gmu->legacy) index =3D ALIGN(index, 4) % header->size; =20 - header->read_index =3D index; + /* Ensure all memory operations are complete before updating the read in= dex */ + dma_mb(); + + WRITE_ONCE(header->read_index, index); return HFI_HEADER_SIZE(hdr); } =20 @@ -74,7 +77,7 @@ static int a6xx_hfi_queue_write(struct a6xx_gmu *gmu, =20 spin_lock(&queue->lock); =20 - space =3D CIRC_SPACE(header->write_index, header->read_index, + space =3D CIRC_SPACE(header->write_index, READ_ONCE(header->read_index), header->size); if (space < dwords) { header->dropped++; @@ -95,7 +98,10 @@ static int a6xx_hfi_queue_write(struct a6xx_gmu *gmu, queue->data[index] =3D 0xfafafafa; } =20 - header->write_index =3D index; + /* Ensure all memory operations are complete before updating the write i= ndex */ + dma_mb(); + + WRITE_ONCE(header->write_index, index); spin_unlock(&queue->lock); =20 gmu_write(gmu, REG_A6XX_GMU_HOST2GMU_INTR_SET, 0x01); --=20 2.51.0