From nobody Sun Apr 5 18:22:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FADA364E95 for ; Mon, 23 Mar 2026 20:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296790; cv=none; b=G2FCQ9GAOYvB0wlqo04frTBP8K8lyZbwdy/TvP73U0MmMDg6wSxWCFsVI2R1hPQzcD4d6sGH3InkwhwVcibOw44rzsprpupGX3fwMNWID7WhaA7CxtzBTx+bBgOnkZRCFZXeDTpd0z5H7C4CXqypJXauKIxcx+ga4GVl6oUjR5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296790; c=relaxed/simple; bh=Y47hfhEP77VPPLQuO6M98YMW2oPSMLiiSh5WGqdD588=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DUxbGU9TNRlOv6AjdV6Q+Mfp3AT+lHMY22HyHLitZzs0OVm0f4oZTg2/putLpK5+C9c3pKxfY81pJdTCxxezaXn0oYXcLOlVN2Z4DKAZS4Yw0H9G2wayNEEU+STOaoBmJ/mStpVNoDfO7WOJXLeRQlDVwbEJ9E6QkRom2e+IdaY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Of4Rq/g0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jzQ+k9nF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Of4Rq/g0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jzQ+k9nF" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NIYlgJ1908895 for ; Mon, 23 Mar 2026 20:13:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9gnUn4vlm4hYrJYBjxx32v/u7fbwTJqrSqNxW05+/Zk=; b=Of4Rq/g0bVYsAXN4 7FyNacw+Ksh0aBGZFUtPhXJPVvFJa9IT7+MO0154eM+3SQxlZHO7TtpwUXAjEhZ1 gC+7w9P1VGZTTMbnEHNagPc7rS4xSVSeVg7/MOorRE+17EM6BUnfUQhy7DIu8pir MCD3gB4HXOy49CvwSD4zugOLd8hPJVNlNdWHLj16qQdL5qfngvBAe9wNV1VLHQUO SegZETfwgnJVDg+98fb2/Lt+sxmZJZ+CxxJ2fEMoSzkPV3ME3q9LrQOxKfBUm1Fu 5/i9U0oUivGqUfDV4B2FzgtqQmKMpJrjYfEnTFZau3E/FZuGHtfhGgKD8qP1E9wH 1u1/mA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d3awyr9sk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 20:13:08 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82a820305c1so392205b3a.0 for ; Mon, 23 Mar 2026 13:13:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774296787; x=1774901587; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9gnUn4vlm4hYrJYBjxx32v/u7fbwTJqrSqNxW05+/Zk=; b=jzQ+k9nF0sidrCQ6eXjfE8+G81rFyEy9Jd0l/I1RKpkggXcXY3x7muf0YXX2kViS8h 4Vhy+5eQAABC7ss0ZfNIY83V4oez2jjHk8ryIe/uFfWMqVBDAqxEuxPTfPIBwIZ3FoZh 4CReM7xAMnJ2uzKdPXfV2cJKAbl/nL92shyVpHbtJCbe9zs64G4TkkCrHp6JaoCuGzIV xmXZm+WG1r97IjDwcusSKUGRB+w1aBMgv2TlS+7RF9aaIou/RSuLSMhjv5JxCbRRUgaX tkGrRIsB1L82aAlSxJyntlz9PyBavJvI3jt/BJzk8dwWgYofA/YqBMPSGDo4gi4f5XY0 J4Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774296787; x=1774901587; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9gnUn4vlm4hYrJYBjxx32v/u7fbwTJqrSqNxW05+/Zk=; b=ebbP9Wb3scPNXLYvKPIbwCfFF4J9LRcjLe4OZsRowcewV9nUDEAYobDkmClL7TVmEn Qm+v6a3OyYe6NNFvgoNGCmwtP2jLYWGpnsN1iO8BZgzbmzRfuJBf+JwClM9Oxw8vRmSV RqRzw+gSoP86hx4L5Sioj/QPtnHrWNWzoYRGFS5e7NzozbGywJ24wEIsU7rGY3V8h+70 25u1Ih5MJWXI3Wf8U2V+DMB7mIR+2z6s5onJFzgtgElKlyaMHyUprCR7MoRbf3AHXYN7 JVEB/asN4oZqyhGuXUX+eH8xqj7brbNnRn8M+aN5EeavCPQbRHkDYNRBlTWC9n3tvJvn ylCA== X-Forwarded-Encrypted: i=1; AJvYcCVnrs6psLC1kiEzELwrWZtnzohXf3wyBgj27TK6xrPsFeJqFSBG1+aeHfP+bVZxRUQfa2jiTKo4TuvkUKE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5FieZ4rUDxt59eeMd/b1CH9t2KPJU44M2dALROLUT9uH01BYM HvZ6ChzJsIt94FjSlowlIOY4Rj9EbpMtSNObi7+N9/5oiXjT7j/bZ7lx1iz+ZN6TPBy9/n4YG9V RcZUyEXhnSD83w+3jwKg4O9ND/iHIAOqvyl+Y3CB4U2q5SAwldLOqmwp5mu13rDF9xjs= X-Gm-Gg: ATEYQzxj8ZRkkEsyRspcZykS0EWQWH6v+j2VKvJZrSbfxnQAaipIFGa1/W6ZSfloi8P 590VPD8CWyAiVZ/b2QeiyBWUaiPSRRqjZ8gBmuH3VgRydorqOd4kSOOZ11+SOl63ll29IcPRVuf B90Va7xi5+bm/nLj3swtbFISPja2qpKV2DPSPLgSCzw4CrWQ0+6yLIS4UGWDs8zDZlc4RBHoO6b H47/b7xGqaEqhs1KMFle/0tqkLMrra63ikaQhtTIo7+zwIW44qfTXqbnR4/J7RUZRNpmdRzNNWQ hyFVdQT7j/84DAWpDVaMHqvI7L2nwYRfLTG4rHJftkOhupfzGyBd6IgkwtlL4U9jojd6bu0xUs2 qtRkn0BmIneg+AZ9UPwSlsfZPVnNqs7gAosiaaq4sQQyhRg== X-Received: by 2002:a05:6a00:13a6:b0:81e:4476:f67c with SMTP id d2e1a72fcca58-82a8c22de4dmr11789588b3a.3.1774296787437; Mon, 23 Mar 2026 13:13:07 -0700 (PDT) X-Received: by 2002:a05:6a00:13a6:b0:81e:4476:f67c with SMTP id d2e1a72fcca58-82a8c22de4dmr11789558b3a.3.1774296786933; Mon, 23 Mar 2026 13:13:06 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409d148sm9510738b3a.29.2026.03.23.13.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 13:13:06 -0700 (PDT) From: Akhil P Oommen Date: Tue, 24 Mar 2026 01:42:17 +0530 Subject: [PATCH 05/16] drm/msm/adreno: Coredump on GPU/GMU init failures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-a8xx-gpu-batch2-v1-5-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> In-Reply-To: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774296753; l=4487; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=Y47hfhEP77VPPLQuO6M98YMW2oPSMLiiSh5WGqdD588=; b=uNx5nipFybpSsxCpeoPj8dQ+2Szp58MCMSQh230ApmII8VwqLiThw0TG2UiEPDhMGLF4u6Hsv Cnqrk16U9iaCYLw/aJmPZTNSksnZB5JVRYhyIW0xPFVKxUOlY62uvYC X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE0OSBTYWx0ZWRfX7YET2Od+5Iw5 o9V9C0Rp8EUfBP7csJXo0dhnT14y1hciVGAHFLdjc0EsSztpUNsj4ZC1GxLqkOSnnI+WuON3w6l 5BJsZP90qCvwWpmLNDVZkMlvJ02KYtvj72uXEZ5aMwgz1PY5FyvlIIwLV6c16aKvvUKfz6V1Dw+ occRIJch2TKxuiu3SQ3GXgFD9faeU2AuwxQqCLUsv6OnEU6E3jMKqyH+L+60JuEUuMQB5HqXjEP b4MkiqmKwtUNw/D6QHEToSfQuXABLclB2f52WdxqdHm+RJKXX0nfla6LIOt3qHwChYcuyOiGws0 xmmgMbcmCMdzLq8jpZENobcXynbhUCFw73gs8gTTOgVWs5FBBS90d9gV9y0K/QxCFKVSExbmRdq 0WDL8NapBYoVGOASfUz1ktfFO9gi6F/hCidyMuX1lXRfuA3fhwqj2WaDGq9UpOC+Q9r40DQfRxn TLxh+Il6XMFgrm/zYNw== X-Proofpoint-ORIG-GUID: lGCyFD5336_etbSFWvBdrV4VLWx9-2iq X-Authority-Analysis: v=2.4 cv=KuhAGGWN c=1 sm=1 tr=0 ts=69c19ed4 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=Uv9L2OBOgJoomgqfufwA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: lGCyFD5336_etbSFWvBdrV4VLWx9-2iq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_05,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 phishscore=0 priorityscore=1501 impostorscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230149 Capture coredump on GPU or GMU errors during initialization to help in debugging the issues. To be consistent with the locks while calling msm_gpu_crashstate_capture(), call pm_runtime_get(gpu) always with msm_gpu->lock. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + drivers/gpu/drm/msm/adreno/adreno_device.c | 7 +++++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 ++ drivers/gpu/drm/msm/msm_gpu.c | 5 +++-- drivers/gpu/drm/msm/msm_gpu.h | 2 ++ 5 files changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 690d3e53e273..6d511dc54e43 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1240,6 +1240,7 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu) /* On failure, shut down the GMU to leave it in a good state */ if (ret) { disable_irq(gmu->gmu_irq); + msm_gpu_crashstate_capture(gpu, NULL, NULL, NULL, NULL); a6xx_rpmh_stop(gmu); pm_runtime_put(gmu->gxpd); pm_runtime_put(gmu->dev); diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 4edfe80c5be7..85b3e1f0e4fa 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -105,6 +105,7 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) */ pm_runtime_enable(&pdev->dev); =20 + mutex_lock(&gpu->lock); ret =3D pm_runtime_get_sync(&pdev->dev); if (ret < 0) { pm_runtime_put_noidle(&pdev->dev); @@ -112,15 +113,15 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *de= v) goto err_disable_rpm; } =20 - mutex_lock(&gpu->lock); ret =3D msm_gpu_hw_init(gpu); - mutex_unlock(&gpu->lock); if (ret) { + msm_gpu_crashstate_capture(gpu, NULL, NULL, NULL, NULL); DRM_DEV_ERROR(dev->dev, "gpu hw init failed: %d\n", ret); goto err_put_rpm; } =20 pm_runtime_put_autosuspend(&pdev->dev); + mutex_unlock(&gpu->lock); =20 #ifdef CONFIG_DEBUG_FS if (gpu->funcs->debugfs_init) { @@ -136,6 +137,8 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) err_disable_rpm: pm_runtime_disable(&pdev->dev); =20 + mutex_unlock(&gpu->lock); + return NULL; } =20 diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 1bc0e570bd12..10d9e5f40640 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -391,9 +391,11 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_c= ontext *ctx, return 0; case MSM_PARAM_TIMESTAMP: if (adreno_gpu->funcs->get_timestamp) { + mutex_lock(&gpu->lock); pm_runtime_get_sync(&gpu->pdev->dev); *value =3D (uint64_t) adreno_gpu->funcs->get_timestamp(gpu); pm_runtime_put_autosuspend(&gpu->pdev->dev); + mutex_unlock(&gpu->lock); =20 return 0; } diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 995549d0bbbc..472db2c916f9 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -361,7 +361,7 @@ static void crashstate_get_vm_logs(struct msm_gpu_state= *state, struct msm_gem_v mutex_unlock(&vm->mmu_lock); } =20 -static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, +void msm_gpu_crashstate_capture(struct msm_gpu *gpu, struct msm_gem_submit *submit, struct msm_gpu_fault_info *fault_info, char *comm, char *cmd) { @@ -886,7 +886,8 @@ void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem= _submit *submit) =20 pm_runtime_get_sync(&gpu->pdev->dev); =20 - msm_gpu_hw_init(gpu); + if (msm_gpu_hw_init(gpu)) + msm_gpu_crashstate_capture(gpu, NULL, NULL, NULL, NULL); =20 submit->seqno =3D submit->hw_fence->seqno; =20 diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index 666cf499b7ec..eb5b3a7b81f9 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -747,6 +747,8 @@ static inline void msm_gpu_crashstate_put(struct msm_gp= u *gpu) } =20 void msm_gpu_fault_crashstate_capture(struct msm_gpu *gpu, struct msm_gpu_= fault_info *fault_info); +void msm_gpu_crashstate_capture(struct msm_gpu *gpu, struct msm_gem_submit= *submit, + struct msm_gpu_fault_info *fault_info, char *comm, char *cmd); =20 /* * Simple macro to semi-cleanly add the MAP_PRIV flag for targets that can --=20 2.51.0