From nobody Sun Apr 5 18:22:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93B793E0253 for ; Mon, 23 Mar 2026 20:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296783; cv=none; b=FAXCOKDYSZDK9UJ/+vgNVK1jJ2EVxVbPpFHMG2DV5em5KY1T1wYtdMoEEWDBoSUyEe4lN0Ee+LXxwxp11Rba0bRMGSzph9MVXVJgBLNRxMz/JwOejf6i65uoImii/YnldANsEqMzbwthJVhjpCn3248gpX7i4FdhulbJFYTxuD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774296783; c=relaxed/simple; bh=XU6DfLSnpNWPI66IC/TzgoZVKRNGuruB43NJyqi08Jc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cJMn+GKuVYio+6gxBJ9ovt6rwD3PJ81yZgiTomb2FQSjcU1AKaA3c2ba2MwPAktUltxYuh1eTesi8bv0XDRRQOB6ZzIYe3/QHlGrcwU4+1FagXbCqWDqE8lkjy8KmcsgYTOH0E8VY7QCIjHED/TEdRhDEK5dIioP8jR7iwzdJSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dqloMYI1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DRjKffqL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dqloMYI1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DRjKffqL" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHquhh618693 for ; Mon, 23 Mar 2026 20:12:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S55qtoUgugfr63dVcnC+GLJkI8uxi0KX+Hru5AmHH7Y=; b=dqloMYI11CXMm/0S keI+hcXWw6XO5qsNaLbzc2snqk79Ajsz1CFDNCPAheowchArt6sr25ayJhV+iAV+ LZjC52g802mjn+iLMROT9Yd2mCPbQE+XqPDBHpZwdChmqXNUwIzGSwGH0Z8VeNGk G5O7Tyr5ry5el3TH9+b1/gtOKjxpSNb6P9/eRPm4JsT1ElSALZc+QBkXIiJg8oTg WP8VtX16wCtAlsnYPYs+Pc3giSy97oMKDLkMLRqpgzWdHKycN0HiiWCehktVCUme /XzEVVa0lMlpv1UsfHLfXTefIoJHviuQxWcMEBt51jZh5Y1VgyFmsPDUwfXD2otE yYqyHw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jgjkey-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 20:12:56 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c7422397574so15127743a12.0 for ; Mon, 23 Mar 2026 13:12:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774296776; x=1774901576; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S55qtoUgugfr63dVcnC+GLJkI8uxi0KX+Hru5AmHH7Y=; b=DRjKffqLRyRoaw5xaQiYMt9yobhcuEcXj4O0I7XGpv5+r7RsKQwITHwi3o5/MoOkpp N53VeO0zLasDuRGjAiW02RDYoVKuBaerbTtn+ri8fYl8h0c2uOoNhm5TlaEWZw74nCt/ g7E4QZO1JbR0LsvtdsBZJncJGP9aA6B+WpQL180sBDXZHQbQIlKiElaYD8iqZLnoxNHx 04XBSID1wqN5+aAHKkcpTiYqWi4IW45JVoTiSUM9pfDCaUSLIYnQDOhmghPKrCRQkHAJ dVQzqOQDDr+1SYATsZ1vGaEwif8HI75R7tTcYRD8Wk4ZllyjAFT7oZTlCE0tjIwzfOYT GbNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774296776; x=1774901576; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=S55qtoUgugfr63dVcnC+GLJkI8uxi0KX+Hru5AmHH7Y=; b=Hzo/IbDeJ+2Tdc4HQxenBWPuBszpk5yEk0jb9eU+bVL7uDW1G7NzVb/MyUk5BUMwW/ ZfFZCesrcdkOgsentqrbN2qorb6kSHEmyYWwHWuiYRt9E1pZ6bxgpTSD9ijEoxolVodN lyIfnbnRm0nn4hk3zQDR8bcDw74eTQ1EKBArtE/Jtzc4sXPy9NaNTlYpc1Jplr6nAnlT IAPk7Pnx0TGQrYX4YHRrs1fbK5bRKIjPWIWzJlvmeYpQTp2HdAhm8C+BhAUyPUeY+Azx PQ9DJbiwshufu0PsXt2CCUfL2sPdoy+giDgbYsZrUBou4Y9mgrQV1JX5VwHxRgwBGFJw OAnA== X-Forwarded-Encrypted: i=1; AJvYcCV5QtttzMQz5Y50hdbc9nCQaPr3SqzlpWnNoVM6tg53FdOqh0R9p2ip7VmHfyPJ/qXVTDY9XkuoZLUgwVk=@vger.kernel.org X-Gm-Message-State: AOJu0YwjkwnSlHmDkTFYal+D7kzdQjnstgiri2xS9AXlYeDVIPltIwk4 HWhjQicN7aSiNeg2Di/0xR/+zO8gDs6AtpjAbwCZvvgOx0Dwh8w6KS+2ejXSVfLB4v3/UubnXFo oB5/wVovYLTQdUGxEiAI6FtqBytkyJhsJjKkFTm8L85G7nsAukBSaCDFXFA7fB5r94OI= X-Gm-Gg: ATEYQzy0OL99zyd9vgQKNFwDh1Os8SiX8IqPDEKo55JqRD1ExGLSJpmOw4GeCi+8KJj xbjORopJZnfzuMUzP2Q1Fm1XTRAJ+5azjL4pa9EgOz2jwXUl4juFBPGeOgLaZNG8AjIO64SkU5S qkVuEgeHfcQaFOqXFsatH72gyRR7rKSS/TZOrZ5SdkERasOauyYgug5HVwY4cePsolGgomE2m7O BpyCs7bNp2rbJ3JDCbjbHy4kGGv8pL59JKImwTclzkXpTgoVUi4ZnwguG0pY3kG5HodbNAr6eBZ udcBMpMp/t+qLiDhVtK7fkpsBwdBhsWRUXZMBIec7yqXZP69mCC+cNGSld83X0aN1dzrTb3gmP1 4ViSOaK60nAEqOo7VubCd3i8/dUoWRzwEaNzbutInuqsONw== X-Received: by 2002:a05:6a00:2d29:b0:82c:28de:fa26 with SMTP id d2e1a72fcca58-82c28defcd5mr8681509b3a.36.1774296776024; Mon, 23 Mar 2026 13:12:56 -0700 (PDT) X-Received: by 2002:a05:6a00:2d29:b0:82c:28de:fa26 with SMTP id d2e1a72fcca58-82c28defcd5mr8681498b3a.36.1774296775570; Mon, 23 Mar 2026 13:12:55 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409d148sm9510738b3a.29.2026.03.23.13.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 13:12:55 -0700 (PDT) From: Akhil P Oommen Date: Tue, 24 Mar 2026 01:42:15 +0530 Subject: [PATCH 03/16] drm/msm/a6xx: Correct OOB usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260324-a8xx-gpu-batch2-v1-3-fc95b8d9c017@oss.qualcomm.com> References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> In-Reply-To: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774296753; l=2386; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=XU6DfLSnpNWPI66IC/TzgoZVKRNGuruB43NJyqi08Jc=; b=0yD/TiCNdFIRXTp7VQT0deosP8kmu4wjice+6AJyGdMDp+3xpyU04YHALqF5QI8cnEA1H0j2C hsAba0mO96sD8vFFQv6elOzXlZTlcraC0mQZMsFn00dq6NPbflBufv8 X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: fesu5orlrZr8D4dzaUN4nbz49ht8W1h0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE0OSBTYWx0ZWRfXwW4aV5XH+tXd AXvT/CKa/PxlJPEtBfjKo2ROWqT3rIc0a6vr3CWj8lctu8MVbV7dkR+7KJw9cdhDJc5MqVYR3UT uscBqtJ8mAlilQZPHst+BDXknfnGC81L/m/3HjJ6YHqseV9/72dYyYd+GULtaG3IB/TqKLJLIzv cUdxkk2puFTTIe/wpfnnFjpgQqNNK2wML/6giAGNJlLBSPJgnR1siKfkfMBYfPVaGArnJonffwg HTbcHS3/rAI0iyNBVLSuaX57OqF3912suCcE4c1nYy2pqN2n2VdS73gQgs5H+bqRiuA6G2VHe6V /MMmrVtvRVanPnjqLEiELmEZkjyhf+JcV/COwSHgt38eYWBnlRyQwGV3JRJaLpONXTwzACAlgE5 /qvcIW+tpCqKiNzjTOE+80T/banY/aDgJtpNNYaYFxUbHhI12WigW6MetL6oYubdRVvnq8d0+nC qrnUY9sd3CjN07LmsJA== X-Authority-Analysis: v=2.4 cv=CMInnBrD c=1 sm=1 tr=0 ts=69c19ec8 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=pGJFX0Yo-_9-baE-uFMA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: fesu5orlrZr8D4dzaUN4nbz49ht8W1h0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_05,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230149 During the GMU resume sequence, using another OOB other than OOB_GPU may confuse the internal state of GMU firmware. To align more strictly with the downstream sequence, move the sysprof related OOB setup after the OOB_GPU is cleared. Fixes: 62cd0fa6990b ("drm/msm/adreno: Disable IFPC when sysprof is active") Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 ----- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 ++++++ drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 6 ++++++ 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 9662201cd2e9..690d3e53e273 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1236,11 +1236,6 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu) /* Set the GPU to the current freq */ a6xx_gmu_set_initial_freq(gpu, gmu); =20 - if (refcount_read(&gpu->sysprof_active) > 1) { - ret =3D a6xx_gmu_set_oob(gmu, GMU_OOB_PERFCOUNTER_SET); - if (!ret) - set_bit(GMU_STATUS_OOB_PERF_SET, &gmu->status); - } out: /* On failure, shut down the GMU to leave it in a good state */ if (ret) { diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 93bf2c40bfb9..897522778fd4 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -1603,6 +1603,12 @@ static int hw_init(struct msm_gpu *gpu) a6xx_gmu_clear_oob(&a6xx_gpu->gmu, GMU_OOB_BOOT_SLUMBER); } =20 + if (!ret && (refcount_read(&gpu->sysprof_active) > 1)) { + ret =3D a6xx_gmu_set_oob(gmu, GMU_OOB_PERFCOUNTER_SET); + if (!ret) + set_bit(GMU_STATUS_OOB_PERF_SET, &gmu->status); + } + return ret; } =20 diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 987c99097d40..d414f24ddbd9 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -711,6 +711,12 @@ static int hw_init(struct msm_gpu *gpu) */ a6xx_gmu_clear_oob(&a6xx_gpu->gmu, GMU_OOB_GPU_SET); =20 + if (!ret && (refcount_read(&gpu->sysprof_active) > 1)) { + ret =3D a6xx_gmu_set_oob(gmu, GMU_OOB_PERFCOUNTER_SET); + if (!ret) + set_bit(GMU_STATUS_OOB_PERF_SET, &gmu->status); + } + return ret; } =20 --=20 2.51.0