From nobody Sun Apr 5 16:29:46 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED01231194C for ; Mon, 23 Mar 2026 23:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774309716; cv=none; b=dTDvJqZ7Iyx7CRMdizrbeXIZ210G2JSQO9RTw9PUozJPM6PcW8Y/ZIbrDW+kqfkLG7g5EXeyny8L6EFXroTMQOZhDPaAjD5h38bQILuBRdJAQDk+yb1yOiHdlytwU/EiaFF1UaFDyw6MLUBgRcmhiTKjcVby6izvYFP6D/7Rf/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774309716; c=relaxed/simple; bh=tH5DpAhEq37bg4pM1Dzw14/Yus49u6Ap/2euxNLrFXE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NUKEuAxbFhyMOU9sLIdLIRwEvNEkT6uc68C0ElNIAA+Fhxbq4X4jfSN5keH2FXxjgHooPJqtyxBEUihXVyYSMpSoiNyMKyCembJJFwWNQnazHIgM/QoRGvrv3AA0Lbvk9m2SqLB5Xfma7Gd2w0hJNU4xIr69exuIbma2S5U1+zM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CQCPdZ1G; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CQCPdZ1G" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2b0565d77a6so10126515ad.2 for ; Mon, 23 Mar 2026 16:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774309714; x=1774914514; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mCWqRJjoVJuaNpuRmiteVkOsirbUvugIgwz/r3CNIZ8=; b=CQCPdZ1GUbjiGZZMainGb2i98Ue+g6OVkNno8Glh59r0FyQHjsz9KhsuhSC1PaIaj/ yT4FeABIud3SLlGgpXxhmJjTy7owJRIWljL4fFHJOVjtf0uhBcoXlzspEQfcJ4m3hRkx 95tpDvK6Nv61OkAwTVl1cf3cJ9fAc5CVF3D6TBcryY11JLrWFSF9oNxAVEBpiAl+fRDY nin76kPX4scQ/v/MlanfgyPHwcwZBV5RIKgpDkrDZuAiyHt08P/e7IL3evO8vsdDwtTA XJw12WXAVdbEyh2G52n0zeeKxj1TS4mb9IXdSiSslyN3MwedMVQytrpizMtb7rf8JZCn 1m7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774309714; x=1774914514; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mCWqRJjoVJuaNpuRmiteVkOsirbUvugIgwz/r3CNIZ8=; b=lwWBqy8FCErgiKJd2FC4ROfSloE8v9/JzsiAw183U7sncmPNE+XJsJCu0wy4dMBTJj aKShZh67FZYF2KJLSDieAJZYaWg6RgC65xrxL9X03jDtdSHQkCILo5t19hCz44eAcPUb tjldD4lJndEgf8KR78cfUQx2vAn0+A/aQ3sFIUVLOx3IWV7RRgu0SnprhucEnpfYp1pQ 9aS1sVBzIe0UqZ5dySY8ZHyAzkJ7zKVr8BE/i3KblV/LYUl8msR82LnSuhsri0C8p0+T Z5rqnaRum4OTTvJbOT1cPFIqbnmJUDQBrBI31tVsALNMMCGVpQLBFIOKHuxsIuq0iqQD p0Pg== X-Forwarded-Encrypted: i=1; AJvYcCXQbh3GL7YoVi8IcOJsgnOpxXGsOVkhtYDnSxEnCbzyNOJJm5JVnjgNO8XqcASOK1suMGqeP1NxGKQgJTY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzyv4yKKxHFHJe+d0rX9W9lb4//5L0Jq2B+nvut6PI92D+K/Km/ TonvF6fxeBSRxP9ueJjfRxuF5m7J54ZWf6igl2VxbG6Dzl3cYkFKClguC2yaooUNW/DN84rflBY qLSPYXOuUc3r7X8TejWc+RuILOg== X-Received: from plbv22.prod.google.com ([2002:a17:903:44d6:b0:2ae:4ac1:400f]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d488:b0:2b0:4f82:74b4 with SMTP id d9443c01a7336-2b0827ca214mr131130345ad.47.1774309714070; Mon, 23 Mar 2026 16:48:34 -0700 (PDT) Date: Mon, 23 Mar 2026 23:48:27 +0000 In-Reply-To: <20260323234829.3185051-1-hramamurthy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260323234829.3185051-1-hramamurthy@google.com> X-Mailer: git-send-email 2.53.0.983.g0bb29b3bc5-goog Message-ID: <20260323234829.3185051-2-hramamurthy@google.com> Subject: [PATCH net-next 1/3] gve: skip error logging for retryable AdminQ commands From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, willemb@google.com, nktgrg@google.com, jfraker@google.com, ziweixiao@google.com, maolson@google.com, thostet@google.com, jordanrhee@google.com, jefrogers@google.com, alok.a.tiwari@oracle.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jordan Rhee AdminQ commands may return -EAGAIN under certain transient conditions. These commands are intended to be retried by the driver, so logging a formal error to the system log is misleading and creates unnecessary noise. Modify the logging logic to skip the error message when the result is -EAGAIN. Reviewed-by: Joshua Washington Signed-off-by: Jordan Rhee Signed-off-by: Harshitha Ramamurthy --- drivers/net/ethernet/google/gve/gve_adminq.c | 26 +++++++++++++++----- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/eth= ernet/google/gve/gve_adminq.c index 08587bf40ed4..c7834614c5f0 100644 --- a/drivers/net/ethernet/google/gve/gve_adminq.c +++ b/drivers/net/ethernet/google/gve/gve_adminq.c @@ -416,11 +416,6 @@ static bool gve_adminq_wait_for_cmd(struct gve_priv *p= riv, u32 prod_cnt) =20 static int gve_adminq_parse_err(struct gve_priv *priv, u32 status) { - if (status !=3D GVE_ADMINQ_COMMAND_PASSED && - status !=3D GVE_ADMINQ_COMMAND_UNSET) { - dev_err(&priv->pdev->dev, "AQ command failed with status %d\n", status); - priv->adminq_cmd_fail++; - } switch (status) { case GVE_ADMINQ_COMMAND_PASSED: return 0; @@ -455,6 +450,16 @@ static int gve_adminq_parse_err(struct gve_priv *priv,= u32 status) } } =20 +static bool gve_adminq_is_retryable(enum gve_adminq_opcodes opcode) +{ + switch (opcode) { + case GVE_ADMINQ_REPORT_NIC_TIMESTAMP: + return true; + default: + return false; + } +} + /* Flushes all AQ commands currently queued and waits for them to complete. * If there are failures, it will return the first error. */ @@ -482,9 +487,18 @@ static int gve_adminq_kick_and_wait(struct gve_priv *p= riv) cmd =3D &priv->adminq[i & priv->adminq_mask]; status =3D be32_to_cpu(READ_ONCE(cmd->status)); err =3D gve_adminq_parse_err(priv, status); - if (err) + if (err) { + enum gve_adminq_opcodes opcode =3D + be32_to_cpu(READ_ONCE(cmd->opcode)); + priv->adminq_cmd_fail++; + if (!gve_adminq_is_retryable(opcode) || err !=3D -EAGAIN) + dev_err_ratelimited(&priv->pdev->dev, + "AQ command %d failed with status %d\n", + opcode, status); + // Return the first error if we failed. return err; + } } =20 return 0; --=20 2.53.0.851.ga537e3e6e9-goog From nobody Sun Apr 5 16:29:46 2026 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D08A37105D for ; Mon, 23 Mar 2026 23:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774309717; cv=none; b=PF4JDIIGmdsk8vrq372c+/YjhSrBkD63d9l9GdlEbZ3E5j/tgxeC4RCg5xwKVRRXc8s4gtNfPR2bRLW907iGCqy+drYrVXtmCXiHDIILZMzU5aPToTZzUxUK+cboutt4Ezte92tj7d5TXIvX2L7ReftFfqLJTt9TUggPnxlzM4U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774309717; c=relaxed/simple; bh=7/XClCIKuqaz4B/y9XGkHL4iLFN4AY0RrT6DNg4CO08=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Jf8lMf8Q3v+bW2A6l2/sZ0+bsAVdzRVVwnf29wlUENia/h5RYn4EmU8odkGz4UCgZlhn/PJrxcxCgERLroyyugnOv2T0ly2PCNvyq4E6Oudv11c1F4GLCxeuBaAGb/i+M3uAR9fjwMNImSlTOO7IuiqCR/8ABO2drYthCxkRqVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jg+97qji; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jg+97qji" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c70ea91bfe1so456515a12.1 for ; Mon, 23 Mar 2026 16:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774309715; x=1774914515; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=T1dqDyNUHXc6mREjK3mFIuS408AytwQMk1N/EEfOEG8=; b=jg+97qjiGnTM36SwrjeNYqjFb/EnXLrvbpJp8PPkW2HHUrLlxp1BefErKMuV3WUHsg X9iIn6DlIqPci/2+W0evkgk70C2zSuQLsxc25jqkll4VXVNmG3+YELg0+X1k2o9FW/8y azGiCNfnup8OhZEcoRKjHDUTrliWIWSHaHJTOb7nG+NK+iWNzvogvTeYs4ot0sTEFljh XDKjCgCvtq6FZDnW9E2bIJBROBEn6v58KzvKquG1XL7t/J1259irLZFURAyO8xSiFYeF rNj7KrkMcKeyClmyBI9E/x2lMEp/9N+ckVNS9tZ+duUwb3F1QU8COgj0+asI/GrwM59F uR9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774309715; x=1774914515; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T1dqDyNUHXc6mREjK3mFIuS408AytwQMk1N/EEfOEG8=; b=XMOIiot47xClZgav6opouJbloQ1HwBLpTWd71LjjxiPvYG7WF2bcmnOUWIScQKht6W jstkDGnFDQvfZFv8amfqOBVzyzckwoxufX9lzDPQa/OUXi6tCdZVRX4eJzS/bVBOW6oO 5JtlCMpjZYt3ooRbfhTyo521qMOlYnuGcCeiA0rBqwl7MsW61TwWt3K9AXW7MNptH0Ce PULy4sEuY2sZ+CRQDNpSdOnC56TUFWqxaDh/vDDCRbS+QSPBnix9EyN3gnRnYfViGz9D fVV6DzP1Sn2NAycWZiQtCeyPblhluPeszSR7SSgszqy+sz2BNVBKdWkn9NER1t0fUlnJ lHuw== X-Forwarded-Encrypted: i=1; AJvYcCWsI46S6izO/ZnY7tOBdGfz9Pp/cKkF5rqysb8TsQsEJOA9+CW9NgodCpM7tgKUxIYIgPsS9amH8ObmCIE=@vger.kernel.org X-Gm-Message-State: AOJu0YyRHHuXOR1O7yK0d8uAoReBsI51w+RIdxO/5UutqkT4J+ONL7+P ZJLIRpOc2e6p1ymtO803zeZ9lBqRqWGj2KlT4GrMyXm1UXrpNU06luXkMByMMNczDAx8UV2IwnC KC6E+Emz9WiZkj8npTn0HZnCz4Q== X-Received: from pgbda10.prod.google.com ([2002:a05:6a02:238a:b0:c6e:21b7:bfd0]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:a514:b0:398:9301:b9ae with SMTP id adf61e73a8af0-39bcec7ee66mr9257986637.52.1774309715434; Mon, 23 Mar 2026 16:48:35 -0700 (PDT) Date: Mon, 23 Mar 2026 23:48:28 +0000 In-Reply-To: <20260323234829.3185051-1-hramamurthy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260323234829.3185051-1-hramamurthy@google.com> X-Mailer: git-send-email 2.53.0.983.g0bb29b3bc5-goog Message-ID: <20260323234829.3185051-3-hramamurthy@google.com> Subject: [PATCH net-next 2/3] gve: make nic clock reads thread safe From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, willemb@google.com, nktgrg@google.com, jfraker@google.com, ziweixiao@google.com, maolson@google.com, thostet@google.com, jordanrhee@google.com, jefrogers@google.com, alok.a.tiwari@oracle.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ankit Garg Add a mutex to protect the shared DMA buffer that receives NIC timestamp reports. The NIC timestamp will be read from two different threads: the periodic worker and upcoming `gettimex64`. Reviewed-by: Joshua Washington Signed-off-by: Ankit Garg Signed-off-by: Jordan Rhee Signed-off-by: Harshitha Ramamurthy --- drivers/net/ethernet/google/gve/gve.h | 6 +---- drivers/net/ethernet/google/gve/gve_ptp.c | 32 +++++++++++++++-------- 2 files changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/g= oogle/gve/gve.h index 1d66d3834f7e..7b8f78bd1968 100644 --- a/drivers/net/ethernet/google/gve/gve.h +++ b/drivers/net/ethernet/google/gve/gve.h @@ -923,6 +923,7 @@ struct gve_priv { bool nic_timestamp_supported; struct gve_ptp *ptp; struct kernel_hwtstamp_config ts_config; + struct mutex nic_ts_read_lock; /* Protects nic_ts_report */ struct gve_nic_ts_report *nic_ts_report; dma_addr_t nic_ts_report_bus; u64 last_sync_nic_counter; /* Clock counter from last NIC TS report */ @@ -1321,14 +1322,9 @@ int gve_flow_rules_reset(struct gve_priv *priv); int gve_init_rss_config(struct gve_priv *priv, u16 num_queues); /* PTP and timestamping */ #if IS_ENABLED(CONFIG_PTP_1588_CLOCK) -int gve_clock_nic_ts_read(struct gve_priv *priv); int gve_init_clock(struct gve_priv *priv); void gve_teardown_clock(struct gve_priv *priv); #else /* CONFIG_PTP_1588_CLOCK */ -static inline int gve_clock_nic_ts_read(struct gve_priv *priv) -{ - return -EOPNOTSUPP; -} =20 static inline int gve_init_clock(struct gve_priv *priv) { diff --git a/drivers/net/ethernet/google/gve/gve_ptp.c b/drivers/net/ethern= et/google/gve/gve_ptp.c index 06b1cf4a5efc..140b8fbce4f4 100644 --- a/drivers/net/ethernet/google/gve/gve_ptp.c +++ b/drivers/net/ethernet/google/gve/gve_ptp.c @@ -11,19 +11,20 @@ #define GVE_NIC_TS_SYNC_INTERVAL_MS 250 =20 /* Read the nic timestamp from hardware via the admin queue. */ -int gve_clock_nic_ts_read(struct gve_priv *priv) +static int gve_clock_nic_ts_read(struct gve_priv *priv, u64 *nic_raw) { - u64 nic_raw; int err; =20 + mutex_lock(&priv->nic_ts_read_lock); err =3D gve_adminq_report_nic_ts(priv, priv->nic_ts_report_bus); if (err) - return err; + goto out; =20 - nic_raw =3D be64_to_cpu(priv->nic_ts_report->nic_timestamp); - WRITE_ONCE(priv->last_sync_nic_counter, nic_raw); + *nic_raw =3D be64_to_cpu(priv->nic_ts_report->nic_timestamp); =20 - return 0; +out: + mutex_unlock(&priv->nic_ts_read_lock); + return err; } =20 static int gve_ptp_gettimex64(struct ptp_clock_info *info, @@ -43,15 +44,19 @@ static long gve_ptp_do_aux_work(struct ptp_clock_info *= info) { const struct gve_ptp *ptp =3D container_of(info, struct gve_ptp, info); struct gve_priv *priv =3D ptp->priv; + u64 nic_raw; int err; =20 if (gve_get_reset_in_progress(priv) || !gve_get_admin_queue_ok(priv)) goto out; =20 - err =3D gve_clock_nic_ts_read(priv); - if (err && net_ratelimit()) - dev_err(&priv->pdev->dev, - "%s read err %d\n", __func__, err); + err =3D gve_clock_nic_ts_read(priv, &nic_raw); + if (err) { + dev_err_ratelimited(&priv->pdev->dev, "%s read err %d\n", + __func__, err); + goto out; + } + WRITE_ONCE(priv->last_sync_nic_counter, nic_raw); =20 out: return msecs_to_jiffies(GVE_NIC_TS_SYNC_INTERVAL_MS); @@ -109,6 +114,7 @@ static void gve_ptp_release(struct gve_priv *priv) =20 int gve_init_clock(struct gve_priv *priv) { + u64 nic_raw; int err; =20 err =3D gve_ptp_init(priv); @@ -125,17 +131,20 @@ int gve_init_clock(struct gve_priv *priv) err =3D -ENOMEM; goto release_ptp; } - err =3D gve_clock_nic_ts_read(priv); + mutex_init(&priv->nic_ts_read_lock); + err =3D gve_clock_nic_ts_read(priv, &nic_raw); if (err) { dev_err(&priv->pdev->dev, "failed to read NIC clock %d\n", err); goto release_nic_ts_report; } + WRITE_ONCE(priv->last_sync_nic_counter, nic_raw); ptp_schedule_worker(priv->ptp->clock, msecs_to_jiffies(GVE_NIC_TS_SYNC_INTERVAL_MS)); =20 return 0; =20 release_nic_ts_report: + mutex_destroy(&priv->nic_ts_read_lock); dma_free_coherent(&priv->pdev->dev, sizeof(struct gve_nic_ts_report), priv->nic_ts_report, priv->nic_ts_report_bus); @@ -150,6 +159,7 @@ void gve_teardown_clock(struct gve_priv *priv) gve_ptp_release(priv); =20 if (priv->nic_ts_report) { + mutex_destroy(&priv->nic_ts_read_lock); dma_free_coherent(&priv->pdev->dev, sizeof(struct gve_nic_ts_report), priv->nic_ts_report, priv->nic_ts_report_bus); --=20 2.53.0.851.ga537e3e6e9-goog From nobody Sun Apr 5 16:29:46 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AA3A385514 for ; Mon, 23 Mar 2026 23:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774309719; cv=none; b=NLwUsCBC/PE4s5ZkS65QAFFKhGVXXf+BKrpQ4+hLDqapDYomgn6rtt+r3KY5ZaSzVbdcATQmStJItIZqROq/II49vmaCMu2P9zP1jfyzJjVzlo6u2lxAQ/9RT5mfDJ9WJO0LRGcaWDv/uiXj/jxpeHDo3X8CdPkGM32LtROJ7As= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774309719; c=relaxed/simple; bh=ipi/hmuzw0I0dIR12Hqh883My688JUPKmeeIE1N+G0c=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Rik3eVQ265L0HxMzLkCeKHbdoI00FY+n+sNT7SSumhS34Uif9UkTIg6s06WswIMPiADcuEGk5HwNw9yNzn7PEea7qsw7zHq7GrB5DBH4H6EJJG4ptp/WhoG332AhOhZriCk2unhVMKgKMfdUDROwJlm5Oqs6pzO55FTG7LkEeDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r4kxlH6d; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r4kxlH6d" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2b051befbb8so41583645ad.2 for ; Mon, 23 Mar 2026 16:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774309717; x=1774914517; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Jw/WcolBOl5E4xg9/GOqX1azVpZAcATB1CeYqZdKYX0=; b=r4kxlH6dQ8gNcXqiXUYBvhU2MzB0cmwNJcJpokv7gZI7EuPl8FUR/W8Z32aNNUiSd5 fSN8ioWCVYNZjqU2K0ahT2hsyfjf/LfoT9zU4z/HbIPmqOkPNhZurfdXOtJqr2/TeY80 uLbZoYAyMLH5nTD/3LSxZ7v4MxLz/M2BC2+q3+U2r9YrzpP5y/Eym3RVrx5DdcHRBnT6 VCf2RAygh1kzvtuUjpfkYTYevzhInCjEsgiDXYNOCF717jLKATANV0Ux8VWvrZ79DIUY cHljJmEMKCFqHH/7Rf7s88U2EY2c8YZuOTaQcIujfgVPn7YBR/vx/z9sIMxJokJxEsav 0gWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774309717; x=1774914517; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jw/WcolBOl5E4xg9/GOqX1azVpZAcATB1CeYqZdKYX0=; b=UDW2ARmAGyj5Nej+327gNNV6xNz+/ZMwCvOeggeS4RQMI85tO08QyMb6MtMpxzxs7F yZ1FLhfDiWqw+OeAL+tNCH+eddv0LbLPWx8upCNozusVQcNiQ2S1oZjUsUMdNKQjne/R NFv59lQJTKPbwGHE1l/csqnTwRwB9a6nji8Lj/6NbTO1qP6ccwTWkhM3JoLMsqTeyI9e WQegaXeLTp1gSUCojgMkZe9WWlHh0VCt5jVWvMT0ZGLSXhUk8W8q/y694bszix6CSCTs rT2LjCMk/12EUg9PzblSv4r8Zx9urJlWz4hT7VRzyUl7eolA0vxJihaIodXBaeEKoe5y 9UzQ== X-Forwarded-Encrypted: i=1; AJvYcCWblyQQ9uyWIb5fEdCmJtI1uOOVIm+maFMpPjXprb6TCmajkiExT9uSrQIlereTkvcsChkAIF40xKfPk24=@vger.kernel.org X-Gm-Message-State: AOJu0YwTLcvcndUTtEPNEOSLFdiLNt6jPW2I4K8/mdOb6B/pnBgyih0y /iqBXva9i+M+U1j1t4DNCopeXyJT1c6RrYYTYbcJP8J6ZqxjFt75NzYDY4M4LIZoEgSXxBcXs5u eZg/wTTQcTaJp23BfaeE+0LNbNQ== X-Received: from plgc17.prod.google.com ([2002:a17:902:d491:b0:2ae:cd48:3a6f]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:dac7:b0:2b0:7224:a4f3 with SMTP id d9443c01a7336-2b0827eefc7mr135145895ad.48.1774309716791; Mon, 23 Mar 2026 16:48:36 -0700 (PDT) Date: Mon, 23 Mar 2026 23:48:29 +0000 In-Reply-To: <20260323234829.3185051-1-hramamurthy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260323234829.3185051-1-hramamurthy@google.com> X-Mailer: git-send-email 2.53.0.983.g0bb29b3bc5-goog Message-ID: <20260323234829.3185051-4-hramamurthy@google.com> Subject: [PATCH net-next 3/3] gve: implement PTP gettimex64 From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, willemb@google.com, nktgrg@google.com, jfraker@google.com, ziweixiao@google.com, maolson@google.com, thostet@google.com, jordanrhee@google.com, jefrogers@google.com, alok.a.tiwari@oracle.com, linux-kernel@vger.kernel.org, Kevin Yang , Naman Gulati Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jordan Rhee Enable chrony and phc2sys to synchronize system clock to NIC clock. The system cycle counters are sampled by the device to minimize the uncertainty window. If the system times are sampled in the host, the delta between pre and post readings is 100us or more due to AQ command latency. The system times returned by the device have a delta of ~1us, which enables significantly more accurate clock synchronization. Reviewed-by: Willem de Bruijn Reviewed-by: Kevin Yang Reviewed-by: Naman Gulati Signed-off-by: Jordan Rhee Signed-off-by: Harshitha Ramamurthy --- drivers/net/ethernet/google/gve/gve_adminq.h | 4 +- drivers/net/ethernet/google/gve/gve_ptp.c | 189 ++++++++++++++++++- 2 files changed, 184 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_adminq.h b/drivers/net/eth= ernet/google/gve/gve_adminq.h index 22a74b6aa17e..e6dcf6da9091 100644 --- a/drivers/net/ethernet/google/gve/gve_adminq.h +++ b/drivers/net/ethernet/google/gve/gve_adminq.h @@ -411,8 +411,8 @@ static_assert(sizeof(struct gve_adminq_report_nic_ts) = =3D=3D 16); =20 struct gve_nic_ts_report { __be64 nic_timestamp; /* NIC clock in nanoseconds */ - __be64 reserved1; - __be64 reserved2; + __be64 pre_cycles; /* System cycle counter before NIC clock read */ + __be64 post_cycles; /* System cycle counter after NIC clock read */ __be64 reserved3; __be64 reserved4; }; diff --git a/drivers/net/ethernet/google/gve/gve_ptp.c b/drivers/net/ethern= et/google/gve/gve_ptp.c index 140b8fbce4f4..889f0120e1dd 100644 --- a/drivers/net/ethernet/google/gve/gve_ptp.c +++ b/drivers/net/ethernet/google/gve/gve_ptp.c @@ -10,28 +10,203 @@ /* Interval to schedule a nic timestamp calibration, 250ms. */ #define GVE_NIC_TS_SYNC_INTERVAL_MS 250 =20 +/* + * Stores cycle counter samples in get_cycles() units from a + * sandwiched NIC clock read + */ +struct gve_sysclock_sample { + /* Cycle counter from NIC before clock read */ + u64 nic_pre_cycles; + /* Cycle counter from NIC after clock read */ + u64 nic_post_cycles; + /* Cycle counter from host before issuing AQ command */ + cycles_t host_pre_cycles; + /* Cycle counter from host after AQ command returns */ + cycles_t host_post_cycles; +}; + +/* + * Read NIC clock by issuing the AQ command. The command is subject to + * rate limiting and may need to be retried. Requires nic_ts_read_lock + * to be held. + */ +static int gve_adminq_read_timestamp(struct gve_priv *priv, + cycles_t *pre_cycles, + cycles_t *post_cycles) +{ + unsigned long delay_us =3D 1000; + int retry_count =3D 0; + int err; + + lockdep_assert_held(&priv->nic_ts_read_lock); + + do { + *pre_cycles =3D get_cycles(); + err =3D gve_adminq_report_nic_ts(priv, priv->nic_ts_report_bus); + + /* Ensure cycle counter is sampled after AdminQ cmd returns */ + rmb(); + *post_cycles =3D get_cycles(); + if (likely(err !=3D -EAGAIN)) + return err; + + fsleep(delay_us); + + /* Exponential backoff */ + delay_us *=3D 2; + retry_count++; + } while (retry_count < 5); + + return -ETIMEDOUT; +} + /* Read the nic timestamp from hardware via the admin queue. */ -static int gve_clock_nic_ts_read(struct gve_priv *priv, u64 *nic_raw) +static int gve_clock_nic_ts_read(struct gve_priv *priv, u64 *nic_raw, + struct gve_sysclock_sample *sysclock) { + cycles_t host_pre_cycles, host_post_cycles; + struct gve_nic_ts_report *ts_report; int err; =20 mutex_lock(&priv->nic_ts_read_lock); - err =3D gve_adminq_report_nic_ts(priv, priv->nic_ts_report_bus); - if (err) + err =3D gve_adminq_read_timestamp(priv, &host_pre_cycles, + &host_post_cycles); + if (err) { + dev_err_ratelimited(&priv->pdev->dev, + "AdminQ timestamp read failed: %d\n", err); goto out; + } =20 - *nic_raw =3D be64_to_cpu(priv->nic_ts_report->nic_timestamp); + ts_report =3D priv->nic_ts_report; + *nic_raw =3D be64_to_cpu(ts_report->nic_timestamp); + + if (sysclock) { + sysclock->nic_pre_cycles =3D be64_to_cpu(ts_report->pre_cycles); + sysclock->nic_post_cycles =3D be64_to_cpu(ts_report->post_cycles); + sysclock->host_pre_cycles =3D host_pre_cycles; + sysclock->host_post_cycles =3D host_post_cycles; + } =20 out: mutex_unlock(&priv->nic_ts_read_lock); return err; } =20 +struct gve_cycles_to_clock_callback_ctx { + u64 cycles; +}; + +static int gve_cycles_to_clock_fn(ktime_t *device_time, + struct system_counterval_t *system_counterval, + void *ctx) +{ + struct gve_cycles_to_clock_callback_ctx *context =3D ctx; + + *device_time =3D 0; + + system_counterval->cycles =3D context->cycles; + system_counterval->use_nsecs =3D false; + + if (IS_ENABLED(CONFIG_X86)) + system_counterval->cs_id =3D CSID_X86_TSC; + else if (IS_ENABLED(CONFIG_ARM64)) + system_counterval->cs_id =3D CSID_ARM_ARCH_COUNTER; + else + return -EOPNOTSUPP; + + return 0; +} + +/* + * Convert a raw cycle count (e.g. from get_cycles()) to the system clock + * type specified by clockid. The system_time_snapshot must be taken before + * the cycle counter is sampled. + */ +static int gve_cycles_to_timespec64(struct gve_priv *priv, clockid_t clock= id, + struct system_time_snapshot *snap, + u64 cycles, struct timespec64 *ts) +{ + struct gve_cycles_to_clock_callback_ctx ctx =3D {0}; + struct system_device_crosststamp xtstamp; + int err; + + ctx.cycles =3D cycles; + err =3D get_device_system_crosststamp(gve_cycles_to_clock_fn, &ctx, snap, + &xtstamp); + if (err) { + dev_err_ratelimited(&priv->pdev->dev, + "get_device_system_crosststamp() failed to convert %lld cycles to = system time: %d\n", + cycles, + err); + return err; + } + + switch (clockid) { + case CLOCK_REALTIME: + *ts =3D ktime_to_timespec64(xtstamp.sys_realtime); + break; + case CLOCK_MONOTONIC_RAW: + *ts =3D ktime_to_timespec64(xtstamp.sys_monoraw); + break; + default: + dev_err_ratelimited(&priv->pdev->dev, + "Cycle count conversion to clockid %d not supported\n", + clockid); + return -EOPNOTSUPP; + } + + return 0; +} + static int gve_ptp_gettimex64(struct ptp_clock_info *info, struct timespec64 *ts, struct ptp_system_timestamp *sts) { - return -EOPNOTSUPP; + struct gve_ptp *ptp =3D container_of(info, struct gve_ptp, info); + struct gve_sysclock_sample sysclock =3D {0}; + struct gve_priv *priv =3D ptp->priv; + struct system_time_snapshot snap; + u64 nic_ts; + int err; + + /* Take system clock snapshot before sampling cycle counters */ + if (sts) + ktime_get_snapshot(&snap); + + err =3D gve_clock_nic_ts_read(priv, &nic_ts, &sysclock); + if (err) + return err; + + if (sts) { + /* Reject samples with out of order system clock values */ + if (!(sysclock.host_pre_cycles <=3D sysclock.nic_pre_cycles && + sysclock.nic_pre_cycles <=3D sysclock.nic_post_cycles && + sysclock.nic_post_cycles <=3D sysclock.host_post_cycles)) { + dev_err_ratelimited(&priv->pdev->dev, + "AdminQ system clock cycle counts out of order. Expecting %llu <= =3D %llu <=3D %llu <=3D %llu\n", + sysclock.host_pre_cycles, + sysclock.nic_pre_cycles, + sysclock.nic_post_cycles, + sysclock.host_post_cycles); + return -EBADMSG; + } + + err =3D gve_cycles_to_timespec64(priv, sts->clockid, &snap, + sysclock.nic_pre_cycles, + &sts->pre_ts); + if (err) + return err; + + err =3D gve_cycles_to_timespec64(priv, sts->clockid, &snap, + sysclock.nic_post_cycles, + &sts->post_ts); + if (err) + return err; + } + + *ts =3D ns_to_timespec64(nic_ts); + + return 0; } =20 static int gve_ptp_settime64(struct ptp_clock_info *info, @@ -50,7 +225,7 @@ static long gve_ptp_do_aux_work(struct ptp_clock_info *i= nfo) if (gve_get_reset_in_progress(priv) || !gve_get_admin_queue_ok(priv)) goto out; =20 - err =3D gve_clock_nic_ts_read(priv, &nic_raw); + err =3D gve_clock_nic_ts_read(priv, &nic_raw, NULL); if (err) { dev_err_ratelimited(&priv->pdev->dev, "%s read err %d\n", __func__, err); @@ -132,7 +307,7 @@ int gve_init_clock(struct gve_priv *priv) goto release_ptp; } mutex_init(&priv->nic_ts_read_lock); - err =3D gve_clock_nic_ts_read(priv, &nic_raw); + err =3D gve_clock_nic_ts_read(priv, &nic_raw, NULL); if (err) { dev_err(&priv->pdev->dev, "failed to read NIC clock %d\n", err); goto release_nic_ts_report; --=20 2.53.0.851.ga537e3e6e9-goog