From nobody Sun Apr 5 16:28:29 2026 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 442D5326930 for ; Mon, 23 Mar 2026 23:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774308802; cv=none; b=bIaq/iTttDR3PkTLuxka+KHYRiqsAjtjHnz1csLYo3vIlW2DPkWATFtJKu90mh/mrSEatFdhK2xJ9SLqIfmIPRqOS4PMm7eVYSmlbUjC7xzDhkJ8m8MyAG0SFHBh1V9C1nTPrf7QWbrmWGtv5E1a94vDTZPqgVt0D6oA8/H0cnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774308802; c=relaxed/simple; bh=O5MFjb+Ao1hDoNz0FnKc5jNPOHTRIFVWCiUjBQz0MQg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RjM77TbdsdJ/Zlh6zaDWw0hac5oeCiPH3de/L93uCPaxBL9yDw+EC5AGtlLoB6fALk2Ef6YLARR/JrVpXx+zUiSnrQYWnVghdv5h5NVIEroCsPnp9PnIWO9Kl9HBmD74N1tzdRiRYmN5p1y6k84/JxpB6giIhFQSQySbj67LSwA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cpo9wSZB; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cpo9wSZB" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-8cd8c6e365eso315473085a.0 for ; Mon, 23 Mar 2026 16:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774308800; x=1774913600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=p/v5iJ2MRi/6fZNrjwCSXmIsYUmpQSRYVVF7Dj+y1co=; b=Cpo9wSZB9l9hq/e3zCHlNp/rpAq/Ax5RYgeNgNoJ3NWc1WRo5HI8Rz/mDVtapAVopZ k7l93ibFaVSC8Fhk8fiEc8one9zyCOTB8xpP8m7Mr10bxyursep3oOjf3QmjduVcTP1G A7d3zkUHFoTAyWmRyR5TbKjY/gAAy/tgr1KXAU2yz7w9MJ5Jm4NqBIUTEL0dFVlLTTe5 uvvxH1kMrALqZeUVOact58HdGL4PsS62JhJ6lLWF1XTLXRHrvPMOapq+3YIMUO+tHUFG u9+9An3+KZKddWtksm6gFYpUD0rYA3RIMWa9joS8K81J9wfGXg+FueQnbfao9535F4Ft 05Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774308800; x=1774913600; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p/v5iJ2MRi/6fZNrjwCSXmIsYUmpQSRYVVF7Dj+y1co=; b=pSErkPO81L/+BW1VUMM4Q/QCGASvVu2COUcjkLoUM5QnZ0KeUbKsUklap8NgwR/qDL C5qEJRt8m9PjDZtwPeOlgdjOps+PffeqSO05LaGpUErLaSrkfXdXrTT9Avm0g/iL0Ez1 IbAZ79MlwzrcD9ZH+wEsCt7CPBuo94lNVsSoZ0J/2LuahdJO+X2vMZmylLJ3NTCr2a+a LarUfWQU6z7eMYTZ1DWRVK200CPCSt2bVc8CIdSBY2r4AX8fGmVPgt2NDkvTOkAHkKny zbisS6h4Xbq+sX7P4nive/ew9wI8bpHADDEZSIYFc8TfdabpCqYNiXWtWDWYikH9atz0 LhAA== X-Forwarded-Encrypted: i=1; AJvYcCUbdXcuUP8oiCxMkOg19Mbi1etfNjN5jz0k60KCGZflSmUaexw45CpNgJFvwrV9SuGsMM7pMnMITrjRbXc=@vger.kernel.org X-Gm-Message-State: AOJu0YwIjQPz+JfXFMAtjB0Pqj24/Gz71HUSG28oyE3OJb/+qlPkW4nn 7Sc3jnNx/FbprYpfDB/w6VDYgk5eV0k9x0L/lntPWMtk6+JFPIgAYXL8SaRTz85W X-Gm-Gg: ATEYQzyXx+veD0nhbQOiXp2oPQJng7HnxfbM1X73b0NNk53kbIpdxkkMa/Kq9Gg7rgJ gX9TD9O5sHxJzf4cD36eqhn8cWKuEu8qoCfqgaXV4ZdHJR63lrnbnOP1betWkQbpoDliQG0dliV kFetjFy4ASSrkvG+W2+sKhvImsdst+b1iZpfcsUWjsH4ppmL9IqLL/M94nXUZtcgZHs1FKrVbeE YLL5qi6shdJX/cvN0d/DzQKURGBV0FQ4R0qaG31qAwYBKtxUoZKLK00IVJDMipuVeW3Bc8b8OQJ eLQgfGsNi5QnVKX/eWhRulXgEIJk0DAAwtIMSchnRkQTBD7W9opfEYLBio+7WAZ2eHDX+oNc4WZ rV3wRq/BIRlZml6DjE8bgOQE9IdJPDadQzJXJAIVmv1dbKTi7JGSt7U6ImrAaWFdXJ7rG+U8zMo 6JWsdqbtQcON9YBRheScKtw41gNHRR4F4qgZBxcMrKmA== X-Received: by 2002:a05:620a:4050:b0:8cf:c08e:5f43 with SMTP id af79cd13be357-8cfc8097225mr2098170285a.63.1774308800011; Mon, 23 Mar 2026 16:33:20 -0700 (PDT) Received: from localhost.localdomain ([50.21.71.60]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cfd47c9226sm896593985a.23.2026.03.23.16.33.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 23 Mar 2026 16:33:19 -0700 (PDT) From: Neel Bullywon To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Neel Bullywon Subject: [PATCH v3] iio: frequency: adf4350: replace TODO with NOTE in adf4350_set_freq() Date: Mon, 23 Mar 2026 19:33:16 -0400 Message-ID: <20260323233316.40047-1-neelb2403@gmail.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the TODO comment in adf4350_set_freq() with a NOTE explaining that a constant-time approach using fls_long() was attempted but deemed more complex without meaningful benefit for initialization code. Signed-off-by: Neel Bullywon Reviewed-by: Andy Shevchenko --- Changes in v3: - Drop fls_long() replacement, keep original while loop (Andy Shevchenko, David Laight, Jonathan Cameron) - Simply replace TODO with NOTE explaining the prior attempt Changes in v2: - Use fls_long() instead of order_base_2(DIV_ROUND_UP_ULL()) to avoid unnecessary 64-bit division (Andy Shevchenko) Link: https://lore.kernel.org/linux-iio/20260314172006.69744-1-neelb2403@gm= ail.com/ drivers/iio/frequency/adf4350.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/frequency/adf4350.c b/drivers/iio/frequency/adf435= 0.c index 3883b63dcc3c..6bbb6a8dd9d0 100644 --- a/drivers/iio/frequency/adf4350.c +++ b/drivers/iio/frequency/adf4350.c @@ -152,10 +152,10 @@ static int adf4350_set_freq(struct adf4350_state *st,= unsigned long long freq) st->r4_rf_div_sel =3D 0; =20 /* - * !\TODO: The below computation is making sure we get a power of 2 - * shift (st->r4_rf_div_sel) so that freq becomes higher or equal to - * ADF4350_MIN_VCO_FREQ. This might be simplified with fls()/fls_long() - * and friends. + * NOTE: This iteratively shifts freq by a power of 2 + * (st->r4_rf_div_sel) to meet or exceed ADF4350_MIN_VCO_FREQ. + * A constant-time approach using fls_long() was attempted but + * deemed more complex without meaningful benefit for init code. */ while (freq < ADF4350_MIN_VCO_FREQ) { freq <<=3D 1; --=20 2.44.0