From nobody Fri Apr 3 17:33:20 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A087258CE5 for ; Mon, 23 Mar 2026 23:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774308335; cv=none; b=LFJxDjVNNEUZ8N/Iv3nO9otZQ26rAOeH0kFlCADiN3aBHTyaq711kghJLlP0OV69qw3u3NWKOnFYX/gfeznM1HyZiVlhfout/nGE7/T93QUHZ+Vn4XgX4knKSpvqwlSaMFLIabw7kD4uMTrG3tG4Yop0syTlyn8QFKZj/pngY3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774308335; c=relaxed/simple; bh=eITXHaozo6vADCkc8O2OVwzYvtVluDBEmszcR4mumsA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XeuTcwaivU/q1sS4RWg7GHA8bGYULmBrZRfa+pU9/kMQHEZ3m43JbYsta7csFaNfFKfBJ9NgcMLKxVpJ9ED8MyYer3YvBr8dxBeImgi7YMk7OopekcqWMw1AWaK2/rSlzUThxqNat3PnsuuXVOS+69niziwbxcKDYBTJB/aSxDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nmbhzyJB; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nmbhzyJB" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-439b9b1900bso2329819f8f.1 for ; Mon, 23 Mar 2026 16:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774308333; x=1774913133; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=so2pmTc1fzbBN2ER2ICEfia2r85CFvfiwopJL0bNT2M=; b=nmbhzyJBkOuF3thQg/6pQE0msrTI/AWU2J6DfMbdbvNxby8BRo1a1lYJjGvX+LyjZC 6vw0PpbxyhTEFxpicQodMiiKsUWl3ucueGHAoGCF4T8Zx0vp0ze2zzYujYrTEuWfzETX QU5QGPRSClBM0134n0hq9uWruh7oBlgCOD1rPQCas316BuaPkb3UJxHX9WVq9ROYVNAd BCttJoXUR7XAC8UzvJIXaddqEryRH4O+gj/l5qtolXHugfjtjo6Q8Liyw/gnkOmMAW3G 2hcxIyK+yTUw5mAD33Yc+RZQsASA4sNrSuYKcVTFdHDKkRvJlLE08StJNow7kf2nyCH0 G/6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774308333; x=1774913133; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=so2pmTc1fzbBN2ER2ICEfia2r85CFvfiwopJL0bNT2M=; b=G+mHT3gI/PGFCSYAkXkJeyRXTd5PIxBdhv75BDd7oW5jKH4SeQ+Pil1Ifgz0KJwhfR RvUR1MrasVNhghBwB/EGT9gbQ0VNgRc3GWbyBY2U8iGE2OTeoeLt5hvFMH5l7pmnAU5i j/332ZuoWNTao5U/LCagQOBURH4ejqwueTN3IkdzWyIVUIf+rSkksrMJXkmfUXAzog5R Sn9f3JUhrm32AsCggxe5xUbFv08TQab+3tzATuil/w0hMjZ7z1/w2npN4R7XBD/PIp4W xf/cyr2hIbPZSumvY2a+ESQgBy/xBPVYuwwI1pKitBso5oe8haH+N4IANW7B37CHYXOW KG4A== X-Forwarded-Encrypted: i=1; AJvYcCWvakiCPOhcUEeHT9OMsp1KRgGLCmG9Iu9bfciO0Se960PSU07aT6bJqmwWS6STu/cepYfpGTJ/XdqPDNY=@vger.kernel.org X-Gm-Message-State: AOJu0YxCnB1Sz8l6nL+5KTDXaLdDgnbJvbCYqvvvjfs4ZMjMKoQGfoTu Zm3rI5xNV8I2tjuk/NiR9BnCMJ3ac1l1Ea8QX9IVZU1fLa9Prk8hf1rP72fiRYCN X-Gm-Gg: ATEYQzxYzQzz0tITTcW2vBfNbrQe+VwFh67v+mf9kMVAvfnyvO+cK+6FFD3/JLzMs6j 32ZRO5VehnvOVTuwTItOedjY+ODn6srzHH6i5MlV0bAqo0AIfjvxxaF2yz+6LLlI56l4M0WXOew CFAnsFc1ElOGEuK6Es6D2jRZbL027lI2kfGrCyCmyJ8edwmXkLse0FR60uHfJKWix9kZ5bAjoc3 7oP/RW3z4CUBfa9FrzBLfWnAHIZPZMyIteZxf+LSDhdKFmTU9Y9zfp9dwKY7Hjxj8BMXIxOFuh/ Q66qpbR3NTCBRgDEuqapfbTYDD/m8g9xvdois+uyrQUgp5A5em28mqqrH0EtdpG0a/sDVQL3F/1 tn9FIg39Vf32RirnT1HtpEbokE/0sCsV5Fs2e+JU2UDJ/Ula/5UQ+axFLo1AtO+uvHIr0PeSfhN 3btZjZwNkTuyo/lOA+xDPV2q0= X-Received: by 2002:a05:6000:4203:b0:439:af25:e4ea with SMTP id ffacd0b85a97d-43b64277131mr20611736f8f.25.1774308332464; Mon, 23 Mar 2026 16:25:32 -0700 (PDT) Received: from potato ([31.176.182.174]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470b1f7sm32890664f8f.25.2026.03.23.16.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 16:25:31 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH] staging: rtl8723bs: fix error handling in sdio_dvobj_init and it's callees Date: Tue, 24 Mar 2026 00:25:26 +0100 Message-ID: <20260323232526.25288-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return proper errno values instead of vendor-defined non-descriptive _SUCCESS/_FAIL macros Callers only check for non-zero return values, so this does not change behaviour while improving correctness. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 7 ++++--- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 19 +++++++++++-------- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..80ff3154f6e7 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1136,9 +1136,10 @@ static int rtw_resume_process_normal(struct adapter = *padapter) pmlmepriv =3D &padapter->mlmepriv; /* interface init */ /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; + if (padapter->intf_init) { + ret =3D padapter->intf_init(adapter_to_dvobj(padapter)); + if (ret) + goto exit; } rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..0d6475bfbaba 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -131,9 +131,7 @@ static u32 sdio_init(struct dvobj_priv *dvobj) release: sdio_release_host(func); =20 - if (err) - return _FAIL; - return _SUCCESS; + return err; } =20 static void sdio_deinit(struct dvobj_priv *dvobj) @@ -159,16 +157,19 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio= _func *func) struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; =20 - dvobj =3D devobj_init(); - if (!dvobj) + dvobj =3D devobj_init(); + if (!dvobj) { + dvobj =3D ERR_PTR(-ENOMEM); goto exit; + } =20 sdio_set_drvdata(func, dvobj); =20 psdio =3D &dvobj->intf_data; psdio->func =3D func; =20 - if (sdio_init(dvobj) !=3D _SUCCESS) + status =3D sdio_init(dvobj); + if (status) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); @@ -180,7 +181,7 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_f= unc *func) =20 devobj_deinit(dvobj); =20 - dvobj =3D NULL; + dvobj =3D ERR_PTR(status); } exit: return dvobj; @@ -350,8 +351,10 @@ static int rtw_drv_init( struct dvobj_priv *dvobj; =20 dvobj =3D sdio_dvobj_init(func); - if (!dvobj) + if (IS_ERR(dvobj)) { + status =3D PTR_ERR(dvobj); goto exit; + } =20 if1 =3D rtw_sdio_if1_init(dvobj, id); if (!if1) --=20 2.51.0