From nobody Sun Apr 5 18:21:02 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3647E384233 for ; Mon, 23 Mar 2026 22:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774305546; cv=none; b=HletsMTOsy9jRUaMKwpzcoQ8z5UNyYeSrflNNHgjBr5oFTKvVDNmHCy2HSe1FVU3uxybGpMhcyS1Mqk3xLJgcLL0XZYgWd1+rq+PExS8EEVLynas8DQNImQqwcQ8gOs08BuaAT0+8t8AjFUkl1l6L0R2Mvb82Ynkx0lK+KrtqXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774305546; c=relaxed/simple; bh=uSbPbbEF96iO4/jDf1d3kH2TPon+s7DHfw5HFTuRwdk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ovwGTvRWIH9kjMc7q2GhwfchBlB8eCCug5iu9gQHaTollC2d0vmR0FHToq8SeQJNfhCUieVAwiHauHmfxW1HUUAdyOGRNutHBDSNGjAyg77Wq/ANZRtPlf8pwrgPiL+TResISGnQVqk6OtGyXkKaJse7nb8tAyUa7C/eLC/WW4g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UXFPfg4P; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BEcDTOH0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UXFPfg4P"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BEcDTOH0" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHqYsJ2971814 for ; Mon, 23 Mar 2026 22:39:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=/jKQw8dGxLC 6/wkqCmrBcQV0wz2LZBd3Fby8QVjVQNY=; b=UXFPfg4Pc+yf2grujnyk+iEix6P EGl0Ezy9IKDWfnTcxfEvfXpvaAJFq3lHhyjbh1jzAZQGY3JYxrksAaCIj7p/pgZE hfMNe1sd+/7jkyqC58m32NZMcXODN0demDCsiK8ZELr/k1er/+R+WMIZhN+/GTte FcUfTV/TEqls7IDe5JLBacuUYH1InGq1t1lqX2JVbM/EUafhNTnQs1+7ZZ2INz1J w7cSpJLpbyq7wl4cbGBt4x1FaZZ1mB+iEHMkiaXvt0fuBG1oBTX1IcLpHR3/pBZh 9Y9Qbstm4o0EtvMhrI33AwKNTU3OAv6Ir0mqyBfdf3+zNI5gxdF1/hZ7mQg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc309j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 22:39:04 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-509219f94b0so61547151cf.3 for ; Mon, 23 Mar 2026 15:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774305544; x=1774910344; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/jKQw8dGxLC6/wkqCmrBcQV0wz2LZBd3Fby8QVjVQNY=; b=BEcDTOH0KlM6asJ6wnjVNKvGXIuXK3CTdxPmHy+FQO7Qf+LoayBeqMpW2xMwoB4AZj E3dmeSUelNXffw+oTXQAx28xlIoaanZ1k3w7LICnb2tEz43DNQspMDqR3g/5Hi7mpMkC 1C810/nO+dCc9x+q/aydtWdIBOsvn/hFKPnlgf3aq0uJ7mEFWfOv2D5OBRm9a4AX2QZP BhYJPboIZliifUk0bnC5WV/nOnMu9AOkdsvDYe+FCqsA08ObqPQj7tU5NRZQvjJ3QDfo jAOjfXeTFfvKzbyTw4kgwto1vpn/xkEO4cNptVgE+kxy8K/zhhuIuw7dno8RyaHtA8J/ 0T0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774305544; x=1774910344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/jKQw8dGxLC6/wkqCmrBcQV0wz2LZBd3Fby8QVjVQNY=; b=Re2Q9obj7va99BhRyDubbqgp+WdFYx5Adt6vCUoTBkPF0P8QmeMQIL/sPBi4gaD3+9 dEqnyNFmuOPDmamu5xxMokk6qOAk69uIHeFR75zuMpZd57kmOkj3oLWL/v0JePScT0Sc jx/YiNDvbga4gU4rvb39mZ5SsuLRKuvko1BcPLCcnq5E3nRzu4AeaC5s+mmGLPWIiuCB ofVOXrgcOPCJrs/Sn8MhWIQ6zfkW66O4tbnf2yKZsx2XkiZ59bqctam/Z/I+vcYRe4hn +32Pf3ZdyZj8VYTqSLWctrsF82kOGac0wslhgm+XAWeOvVdaLqsa68G3JjEnQlS0J+kK UWxA== X-Forwarded-Encrypted: i=1; AJvYcCV6ETgyFPM1sVO4A7RWnFrR30OeTf32K1Gj6HYYpdDOpexH8s03hUQ/JiQPS1EpBfKK9lTKIEpofSoOFB0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6eob7bbcwhmM90t5OXi/oWYyzkYEaGAWZx2tKQwarEn8ebl/9 SNYiVtcSVATschcwSUsbqzv4NpJdZstmyly9WHwrXhwsAtEunz8LDomVo1DEhSkH4mLNz9B5Fxv wGaOBYGRwnm5odzjxAP1UcBUD6UAb4xqiTTu/1eVxpE5fAKthEEpyr6sRFWfBHpaGtnE= X-Gm-Gg: ATEYQzx8NmSO+wsXcjTm4sW8v5Wus2V80UwGEvhYFfO6h9F06GhQ1lyWA0Uye/++p4a VtDTLx6Cl47yudEJNqCiEl6YjX+vOar2QqNWwfe59kCyManVIWsq3zut9Py4nREJI50SCbu9pbf j+Lxu6RHdETC1V8cFc7BQFi05wsKBUYfA6scYbWRPaPh4BoZXhPOsgKC5PeyNVX+c/D8846T0B8 q4yJuDGyX/f/ARK4KJzDJuVoaScWQnwhkn4hncZds9yt01P4g2400iO7Z+6Rha+8S4YBuWRQA0h O+G4k+p9ffCYDwJlZjTidIjtkfICkTQbfXVHnV037/XNG3xR+s5kmTdwvK+0dQo24S/XOQ5IIYc 3PmTG6nVZoertiWdlBN/zG2mRsjIyHXGSAwt35q4zbUi4CTtbUyqgDX8= X-Received: by 2002:a05:622a:154:b0:50b:6fb2:fe1a with SMTP id d75a77b69052e-50b6fb30404mr14837221cf.42.1774305543679; Mon, 23 Mar 2026 15:39:03 -0700 (PDT) X-Received: by 2002:a05:622a:154:b0:50b:6fb2:fe1a with SMTP id d75a77b69052e-50b6fb30404mr14837011cf.42.1774305543137; Mon, 23 Mar 2026 15:39:03 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64715539sm33320351f8f.33.2026.03.23.15.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 15:39:02 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v7 05/13] ASoC: qcom: q6apm-dai: reset queue ptr on trigger stop Date: Mon, 23 Mar 2026 22:38:37 +0000 Message-ID: <20260323223845.2126142-6-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260323223845.2126142-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260323223845.2126142-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c1c108 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=w9bA4Yi6UXS1dLCTJJEA:9 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: 19ggoeukccoNC6L13hzESstmgldIeGfG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE2NyBTYWx0ZWRfX7PEkdXQCLf0n oLJWECsA4qugl/5gnK68BzmnmS9U3ahyD/Z3QDmCqDajKp3QqQBbhPoR0uiZbLdOdmJdrii56r6 txZRCMaJhcvIjCMZScQ7cMUUQ/wygc/jLtwkLzRYuLrT6AdDjA0z2qsqSrWrpS8x4Hqg4LhC9ze 2jHnNr502v10XeIQEDY2SI8KkGpzK11CDqmUgMBcaGBivTaFJ2CI5B7bs0ISJ1wBGkWamwXQ/3x y57CojUmE89w6yptMRayNhPPW8HSqjLTpXmwV4RA4/q52P7Ctdou3/8xSK58hUc9JHN0uh8WeSN zRS2KgHXirXYzMTWopfXVCqKTLQvlzgGJ8DAsqKxk3EpCSF1XRekXWLlbLLUbZXhK4eGukfj5DE dFYZGIQTo5UcjF4jmsvnRva9oea5fabs0qYuNnA/hQNFBUKHggNlN45rqdeeLzsBtcB8vM4cebf rLXJmpv8LUx9N9XEX/w== X-Proofpoint-ORIG-GUID: 19ggoeukccoNC6L13hzESstmgldIeGfG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_06,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230167 Content-Type: text/plain; charset="utf-8" Reset queue pointer on SNDRV_PCM_TRIGGER_STOP event to be inline with resetting appl_ptr. Without this we will end up with a queue_ptr out of sync and driver could try to send data that is not ready yet. Fix this by resetting the queue_ptr. Fixes: 3d4a4411aa8bb ("ASoC: q6apm-dai: schedule all available frames to av= oid dsp under-runs") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-dai.c | 1 + sound/soc/qcom/qdsp6/q6apm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-= dai.c index 306e928e7b49..292be457764f 100644 --- a/sound/soc/qcom/qdsp6/q6apm-dai.c +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c @@ -317,6 +317,7 @@ static int q6apm_dai_trigger(struct snd_soc_component *= component, case SNDRV_PCM_TRIGGER_STOP: /* TODO support be handled via SoftPause Module */ prtd->state =3D Q6APM_STREAM_STOPPED; + prtd->queue_ptr =3D 0; break; case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 1fbcbbf3123d..9d4cbe29cf94 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -215,6 +215,8 @@ int q6apm_map_memory_regions(struct q6apm_graph *graph,= unsigned int dir, phys_a =20 mutex_lock(&graph->lock); =20 + data->dsp_buf =3D 0; + if (data->buf) { mutex_unlock(&graph->lock); return 0; --=20 2.47.3