From nobody Sun Apr 5 18:21:03 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61A1383C60 for ; Mon, 23 Mar 2026 22:39:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774305543; cv=none; b=moOG+tDU0Hv1uiOpv8CS5oRFHILnpu8EAYYPBiBcarzv0paaQKYcJXXoJM8byGQnyFsD/MIotq90LRY5a6vKiYnZvCis8tI/NmQ1yWfv91xjUNWlVdZdLxbe31bd+IW8lYbRRJTRxfSfzXC3LOz63hyAncW43PLE971+wGZJ8R4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774305543; c=relaxed/simple; bh=6jShP5otc7Z/xglFZY5mqaUqDhEckaI1JOm+jwe6kcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LXR9voeYXj0rl3SQMPEaEyHuulX8cED5RkWiOYaVVS6pphQhDHfE0AdU9BASqpD7l9Yj4SIIKz/GxXsAWoWTe2jkh2X1aqvwLPPyGSoWTXpZDgFlZGpMN4yvIK5e+5eknZdJzQv5p/BuGXf/j6t//oCWmPS4FmtUbpTNUi+T7UQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FPNH7VQ4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hap2eZjr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FPNH7VQ4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hap2eZjr" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NHquhj2832908 for ; Mon, 23 Mar 2026 22:39:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xKWL+GAYqNp +tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=FPNH7VQ4erEtxC/8Mwb9Y3Nnj8l i1ArmT01rOSlVdzYTbM5M6OWLFeaFg8Ggw5QfvHa8l1H6EkePTMuRKoBhs7H0wwH G4PxmzgO6RLe4n/LTDf2B6cz7nLfUOXsy3rOZOcwihssgxCXJAjRHaeBSLFWLRtI zW1zDsJdcMo+x7nORRXlFhS3yDUjYzjrk0HBOKASRppW4A3xI6nXGRLqCmxgu6C8 D+gktW00VUTxY3rcY0B0xFQaorr5gbsTTFaDoH/xXICbExT+lxLzkpSYODVj9rL7 UlqAPY9Mj42OpfptyXXLiVQ5Ghy7Dr4hb50iBtSai+01SF17L8Yvm5ZVU7Q== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d364jsvfu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 22:39:01 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b469e5543so7322541cf.1 for ; Mon, 23 Mar 2026 15:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774305540; x=1774910340; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=Hap2eZjr9fptovNS3B6uIFH2F/ZQOv2pdHfMf4JAmXGxJU1o59kHLCG5M9Aqt5H7hV Ie8o3BeExlozARIuAdCA5zf8+XFvmQs1/Au09JnXJEpXxxDCsUef5U3sRYLnvO3K5D6X BSID7eKUMoFBXYV5zfe24ik+FyDzvToJXcCBSzVmmdjyQGMjBlIQpUf7ZUA+oFYY6w2L Gq7d+yB9e+jBricWlakCvzzPcl3plKhBrWIZ2Z47i0uCdHPhzWUez/NG3AhsIzulL/ed NFt94wUfuPtUojJPPQqxRxr5qPcDBN/aaVhSHxUpoHkjH6pQ4iBzLHnvoEqp5ceNN7fd cRsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774305540; x=1774910340; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=EtNdVsn6E+Ml7+f87xte0QeAMaPODAVPPxlxcV5M8vyhkrKFvnaWF9ccqDKbulXCPM cZRt38hgoKCM40fFrS7NH7m8zI9h39JTpxXAzleZT4lZc+UsTrafu3rjk8MnBcwwhtOg uHljt3B3Wm+iqV5/NJ4N76irIXbSBFD7ODGx+WFX8WLW4tpggOJIRwUHZ/SsnkgrnfxU uVJ1MfLVWygB+iGwG2HZiY/Z3/XK+Ehh7cvPAnionKr+LAY9so/yPQWZ/ms+mzgJbeEr u1xqRQy9y8fEht52gjqjTE0ci6t0skCdAj0HeLNfoqzWJhEl0TyA8aB+eduDWJMkbYUE 4Mzg== X-Forwarded-Encrypted: i=1; AJvYcCXBXuQwA5Hg84A98HIa5LGnrkKh5tcJwSdA+A41UvK295TGNcGUUFZB9VcI1MHF8fOqWGgDjqHWWmzUzto=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk/xw+zh/pJZSuqZlAveBWCBth/xO6LisCySNormmvz1tTLec4 8JpOwDj+2d56S98D4hh8nrou/+mhMi1c5DcyX0grH+Ot7DoIV0CgwBRsV10eScoXJGticcaN/M7 hjVA5MQQ7b9xpwxov0UoqGCV+otlQSL41AhiAC6IwIxnDuUKdaoxq9Z8vWLKoqm+X5v0= X-Gm-Gg: ATEYQzzUNuw62Cq3H/kjq8xNjJPqO2IP0QOnO89oQ1OTGxfktVP8HO/wzE9Fw/Pw301 +i5HFsJweYXW/FgZNhkjyLzWa17ZhWyKcOnoNxmSJz9jubp9WLp/uyRkZdQLZ4btYAI8bDNNec+ 9Gi3pfpvUvwgH7TTwxawDRltRuFFyFqvZzeyHs1/ZBjrO+AnfSPSFxuV2NFb8avt6wMMnckPxc3 9UIn3GbckW8Xvr/bcZQkpVcVOy3aCnGSWmDLHYHJDG9cSSeX/q+xpc2lmxKqNR0HgqUG3yXdPDx Zq3SddqXNtkyGgJ2XLl9HONpHVBXElQviiPtwOPJDdkTsnqP/uzMYCjzyiWi10MxVDZ+JmSdp/v u4VD9nVRN7iYaUisiyd7jA9pMK3zyyCuSkj78Ab0p5jyzXvXzh0OizF4= X-Received: by 2002:a05:622a:6116:b0:4f1:ba0b:90 with SMTP id d75a77b69052e-50b373d08b8mr192255141cf.8.1774305540067; Mon, 23 Mar 2026 15:39:00 -0700 (PDT) X-Received: by 2002:a05:622a:6116:b0:4f1:ba0b:90 with SMTP id d75a77b69052e-50b373d08b8mr192254861cf.8.1774305539641; Mon, 23 Mar 2026 15:38:59 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64715539sm33320351f8f.33.2026.03.23.15.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 15:38:57 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH v7 03/13] ASoC: qcom: qdsp6: topology: check widget type before accessing data Date: Mon, 23 Mar 2026 22:38:35 +0000 Message-ID: <20260323223845.2126142-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260323223845.2126142-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260323223845.2126142-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: zxXMNC69OVMNnAl8qdfDhwQ9N6C8MQsl X-Proofpoint-ORIG-GUID: zxXMNC69OVMNnAl8qdfDhwQ9N6C8MQsl X-Authority-Analysis: v=2.4 cv=JcaxbEKV c=1 sm=1 tr=0 ts=69c1c105 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=5HTw2GpdgXbBP0wXRk4A:9 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDE2NyBTYWx0ZWRfX3U0FoLncOT80 9GV6b6fXyJhf+5mAgN0KMk0M6dxYQBtuNDnvmab3GV+I5/NYacBO3PBr1RrHBmuA2sUicgHWHlc yPsY5/bG4/4CJ8TVNECc//wH09B5q/s6WNerjAbxdyrkOTvraW3U7moIlFQVlfaQTBm6k3+TShu JiRPIrI9fVOhkb+r4PCDseXlCBvJ7wh3TLlf96JJCDPXZ5s+dZjZKOiotw5jCyxj45Hs4b2EBBK Yu3lOMuRgqsPPmvFdqR7lfX86AG91R33yKbGvLazuFfHYehFqCZ3yzLi0RxCBVRE2ruYZKHd/UT t7KCkbv0Ucjg6/ofzAN19PLPn2h/Wa0mwG8ZQdVi5iQN0dRVGKiY23lIG/jzM3bLDV5ro0rIP0s gIbQSCk+UiGYRHyvRBnNdbqPmdRHYxzvEM8JDJMSBvtNnVXpxbvcN3tBLhHly0KeVLZ/bnXCgWN Ovku+tyqG9lrxyU2afg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_06,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230167 Content-Type: text/plain; charset="utf-8" Check widget type before accessing the private data, as this could a virtual widget which is no associated with a dsp graph, container and module. Accessing witout check could lead to incorrect memory access. Fixes: 36ad9bf1d93d ("ASoC: qdsp6: audioreach: add topology support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/topology.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index e732fac9b8ca..1f69fba6de26 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -952,9 +952,6 @@ static int audioreach_widget_unload(struct snd_soc_comp= onent *scomp, struct audioreach_container *cont; struct audioreach_module *mod; =20 - mod =3D dobj->private; - cont =3D mod->container; - if (w->id =3D=3D snd_soc_dapm_mixer) { /* virtual widget */ struct snd_ar_control *scontrol =3D dobj->private; @@ -963,6 +960,11 @@ static int audioreach_widget_unload(struct snd_soc_com= ponent *scomp, kfree(scontrol); return 0; } + mod =3D dobj->private; + if (!mod) + return 0; + + cont =3D mod->container; =20 mutex_lock(&apm->lock); idr_remove(&apm->modules_idr, mod->instance_id); --=20 2.47.3