From nobody Sun Apr 5 16:29:47 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D10E37FF64 for ; Mon, 23 Mar 2026 21:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774302103; cv=none; b=Z1vfKEOYxZ/8mH+xnY7/i8HBOl185kwdr++ChDx8HiM4jfzw5o+10rrwl2qVyjB9YPdkK1Veyk3Qi34bRuQH8PcGDxOdH3YPVVEbmwhbuXwzvAabOqE5RKnY9JpOyVxkLaYtYV4D4KaPQTSjYW0VXPyYLSrnrRi7XqvMIU/TdVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774302103; c=relaxed/simple; bh=g3w3qCfqaYM2NTYd4HvcuyAVB8DkqVlChLlirD9AIkg=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=GjCyOExOB6koNkrxZ30Qyg8Zqw7/ZN2+0dAMx79KDO4tmRBPvVr3oc3RqUvHlGwmX6rWJX1rZHXDKDD4EeGXyacueFxmqX472wRp3tBcS/FyDGctuHAFYxjxwLIdcg/GPFf/jXBlUAwWX8lpN0tulzxOgdGRxImlnY+logF7f4w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HNe7M9EC; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HNe7M9EC" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so4153375e9.0 for ; Mon, 23 Mar 2026 14:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774302100; x=1774906900; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=n2BcmGWUlKjDNBV7X1EsbJrCzz3GciSU72UqjC/sO0s=; b=HNe7M9ECzDf2uaUYkg6UI7a+ZsP1hkwXovKFD8PJVrCKIx/z0up/trhBh/8gfKySTx ZkqvDz0awSc+SO1WuI+Ct1k1SD5IzMbBGoZFsHVusV/uFbvHanzU3GDp7Ayf8XKHM0tI K3Q85zNbKHsAkgu4/7oYp+6SqLpNeWdPWmx3zh3O3eAJd4JcrebZPqy9lTBtq2d5E0h9 9nYQ+x8RNdzue9qbxFOC5AHJy3kDNfXHuPg1qoaEPZoVgB3j25peTk2lx+SjWCWa8kv2 N0lRJoUxZFUxyIsgomAX2raZchZVAOOoA/UttBjNydoH+TiOmWNUgQdpmQf87hxAvcts 7ArQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774302100; x=1774906900; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n2BcmGWUlKjDNBV7X1EsbJrCzz3GciSU72UqjC/sO0s=; b=ERP3dM0eX2XSqCnJi7VkgULd5LgTPsYHDhKxopHTorF+ibC/oQIDaWowyjV+kAYQ9P /As5lVmh1PPBC35hmUiQiYi/FXOfoexJP0kROfegkqUDMDsx+nrTpvgfu6V9/1F+S4zY hUPxz3LPnCWxPY6Lxpzak7X0vTEjjGuROYl4NSTqKcL+h85popJBCmSc3Vxdd6zdUJyh xnwEU2lOlfsp5lv7IepciEuuYxhx1iR1cbmZSBvCmW2YFff+RHA7MrftaBI3UBdkYNnw HOU8ttpwnTJGnLmiLzOwFUNRPIUslUgxYv88YzC5swOnvHap/bjK1t2cTwyer/HbRCE4 9SOQ== X-Forwarded-Encrypted: i=1; AJvYcCWwU6XNFfxNURbLG9LjRNrBuKx3lk4CIjGXxuVXYPzdhm4cANk07iCYC/evDRcgBxkC8gRruDKRS/DCzDI=@vger.kernel.org X-Gm-Message-State: AOJu0YwpqHlYlQlEZR0iZiB+oADXdW80aBZ5AXHUEy2RRFf/qyE62yMz S/Y2dMOUxXs7lJTdFUaEP01Nie1dTF7B2+t1LeeQONBwlbuvnqA8tXLo X-Gm-Gg: ATEYQzyyy/6Hm+0qFYfhNb5OkjO8REoULnk+JcUAXd90fiZKM7VK0x3jimVazrCIQOP WEhvg2wgyfSk1+CYFyxYTiv57z+nEb6lDv1R0sxNky9ynhlGlKZNrIDJTUPVeWjIktzCTyUvA0m YEnYVIFQQp6ofR9/zWJo56t3dj9BwFq49DgeS7GGt9Q/DSXs5VxlOxPhx8LKHyGs3YfT4aZ24qu lg+HEuQAEqOwGlBPNfRl+VImPlgGIQxavFO/f9VnZbVh/6c9osihvYfJvA+uCvJu4udpWfJrBVJ iewnuRThcLqrvxd7Ol/nJAcA5usA5+GmFCp7eXyYOfRMaYJ0TPIrMbTmSoOZkws5vs4Om7YdEv6 eSDVlNMEuV3CJqZGxoV4i5+0QK6VQaGn1N1GQVUIZ42qP/mlq/9Gfw60pjHpUZZKo8EwJ8+0ftb GKhCiUimwKoPlKSTN0yVQZ6fC5Y0hSzyBwahoE6rxU/+hsttrg066nlujHqeg= X-Received: by 2002:a05:600c:608c:b0:487:1114:d42f with SMTP id 5b1f17b1804b1-4871114d526mr2635115e9.1.1774302100481; Mon, 23 Mar 2026 14:41:40 -0700 (PDT) Received: from osama.. ([156.223.38.150]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4871105c799sm2133935e9.20.2026.03.23.14.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 14:41:39 -0700 (PDT) From: Osama Abdelkader To: Catalin Marinas , Will Deacon , Kees Cook , Osama Abdelkader , Andrew Morton , "Liam R. Howlett" , Jeff Xu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: vdso: fix AArch32 compat init allocation leaks Date: Mon, 23 Mar 2026 22:41:16 +0100 Message-ID: <20260323214117.241216-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" aarch32_alloc_vdso_pages() allocates the AA32 vdso pagelist, the compat sigpage, then the kuser vectors page. If aarch32_alloc_sigpage() or aarch32_alloc_kuser_vdso_page() fails, earlier allocations were not freed. Unwind in reverse order: drop the sigpage when kuser setup fails, and kfree the vdso pagelist when either later step fails (only when CONFIG_COMPAT_VDSO allocated it). Signed-off-by: Osama Abdelkader --- arch/arm64/kernel/vdso.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c index 592dd8668de4..9903bfdfd45e 100644 --- a/arch/arm64/kernel/vdso.c +++ b/arch/arm64/kernel/vdso.c @@ -236,9 +236,27 @@ static int __init aarch32_alloc_vdso_pages(void) =20 ret =3D aarch32_alloc_sigpage(); if (ret) - return ret; + goto free_vdso; + + ret =3D aarch32_alloc_kuser_vdso_page(); + if (ret) + goto free_sig; + + return 0; =20 - return aarch32_alloc_kuser_vdso_page(); +free_sig: + if (aarch32_sig_page) { + __free_page(aarch32_sig_page); + aarch32_sig_page =3D NULL; + } +free_vdso: +#ifdef CONFIG_COMPAT_VDSO + if (vdso_info[VDSO_ABI_AA32].cm && vdso_info[VDSO_ABI_AA32].cm->pages) { + kfree(vdso_info[VDSO_ABI_AA32].cm->pages); + vdso_info[VDSO_ABI_AA32].cm->pages =3D NULL; + } +#endif + return ret; } arch_initcall(aarch32_alloc_vdso_pages); =20 --=20 2.43.0