From nobody Fri Apr 3 19:05:54 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBF830596F for ; Mon, 23 Mar 2026 18:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774291150; cv=none; b=FTnq+/icgnOdion+a2+bXIG8vSG+BW+tMcnTQk1LeS4gDfFbN78LyjNBz59wbf2jRaXjwJFO+G3HuOmdCVrdzZ5glNweqAgQN1bobRNdYfhNQN+0JXUAiTtleRDxsfvDTcIHAhVtQqlfn/wDpR79MzJwmZHt4pOlZZ9kdurSKzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774291150; c=relaxed/simple; bh=uT8Gdsj4WmnDwk5F7IYjxDPdX4MIIvH80+iQjYGrqHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=axQRVMmWdDLe3tHR6TsuL7N+ntNhU+bdLLu9VTwXmFMQCEz1MBa1tmpfbApirxm1brgNH0vVlQGJrxYN2RSbsLhYEq/kVL86wf0/djlOjmwNoL0k9mjM2oNYWimj+1PGzk3BOrEzf6HtRSTpd9pl8H++Nk3sGqTqIAJD2jobrAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=df6apRLH; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="df6apRLH" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c741db5d610so1282981a12.3 for ; Mon, 23 Mar 2026 11:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774291147; x=1774895947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sy+CDHxlIyZx/+MrAYIXPwoNBrNq+e5Vy6JCRCEF8Rg=; b=df6apRLHEBRXZZaR9NhK7lfCfWPDKkvfPYsH1TdK4iULr7YVYKtK9v4fqKQlSUd38C mRJXXA3I0gLLykgwcn5FJOmK9X22SgHiCgyIPjt9smUQrhpqau167Sw/24ZyMsHUVR+v LOwrIjqNrF6JXxCpagyzRz6X+ToRZyrf45O7AN1JzZfuSRf8jloJr73ZKEDF+MMTBbA2 4E55WG+m6MU0Mh0vr+SbJv1dCSoJ0Ja0VRiP+7zgZuxbHK2jSPirYfR1c+QQJUe10raH cywDk1R0HxaVFVR3Sxmw7vkYVU+ImFBEqqnAaxpvtBgLSUENoT8COK1r5HmfldIv227b eEEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774291147; x=1774895947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sy+CDHxlIyZx/+MrAYIXPwoNBrNq+e5Vy6JCRCEF8Rg=; b=hrMONRL105K2O/KFGG5WTq5GvDnnJuFosKdKZqhyA/RCJ7NfxVvjiywj7gjn6nYJnz QccLCS263XSsP5YHIAVISQIQTcge7OsPsVmZ8mLzcFFetKhbSVtYp01tciKoOvcmMwBl RNxuNs3eFd4egOxCvAxjxyMTP2fwKti0Fq76bpQJnYl9xIdcNBRPRmSrU7WhYR/6PHxR JNKcd/9IYUz0x0+RfvGlZyNC50LN/ypPwWgA5JpnB+/QrmAnE+nR9EgqznRb3Ue1mq9k 3T5csuPlxjqWxrdNlvZxzV6yIpG16uLxNOyMUKGDzvAtbaTds+wS+nORGe9/8klUOOTx +qjA== X-Forwarded-Encrypted: i=1; AJvYcCWM2jS2vg8c7ZwBkcOyBILVkGKAr/eJmkU5aehYEdgZDVza9ppXGvtTpPzKCfmjeC4GEE0Q7TfO3g6PYwY=@vger.kernel.org X-Gm-Message-State: AOJu0YyN/rl1ZVNyMdokE1wx7Ax4E5u8bLnnwfc0+KoF//scAsgw6FOu ZtaqucsYwD+1Tye9JWm476BZoohD3FdRJASTVuNhs28LxfCLzUPnmMCPAF4n1V8nA4Y= X-Gm-Gg: ATEYQzy9K5k7Ayqw96jCEnVu2+uYdENuFMDTU+Va3aITF8iYHrZF335Wv6wQml8hdBp aP8YTXf7LUyRLxvlzKq8dEcAL9r6I5Ol0fLCpdNFg1krVN/1lXbFaIXppxBfCZcLPk3GlQtsF3Y zp4qv/eY2U5wlbvP4GRlCvof4S44oWsAIfICvFiklZM1o2BX9nxa/RPsGl6TYnG2XfbfaiyjpEq BDBd6VG1RyLt81f1+HcaZ7ApKd2X+ZHgwm1VD0DuVYK47equMF1b1dIvsNzo6WCPIXMmh40F7I6 EHu/CdG1hOyihF0ijJipsoeNEDFcXPJ5oL3T9z/wQKZB+7fI71LguHkeRxYLpi4yTpwjqVVqDIL IvArVkiRpGNbHJ3eFZDvnpPqU977792TgqKtDBFkVEpqhQznkm+dP4lbf1pfh3iYBw0mxwEmH33 SfFNWplNA/hEA= X-Received: by 2002:a17:903:15c7:b0:2b0:73d2:219e with SMTP id d9443c01a7336-2b08280025bmr116139915ad.47.1774291146948; Mon, 23 Mar 2026 11:39:06 -0700 (PDT) Received: from localhost ([2a03:2880:2ff::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08366c443sm151792235ad.56.2026.03.23.11.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 11:39:06 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v5 04/12] net: bnxt: Add a helper for tx_bd_ext Date: Mon, 23 Mar 2026 11:38:29 -0700 Message-ID: <20260323183844.3146982-5-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260323183844.3146982-1-joe@dama.to> References: <20260323183844.3146982-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v4: - Added Pavan's Reviewed-by tag. No functional changes. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index 7793ba59bcfc..4d4e7643f7dd 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -663,10 +663,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -693,7 +692,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -706,9 +704,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index d82b0899b33d..a6b04652600e 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2834,6 +2834,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0