From nobody Fri Apr 3 19:09:26 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 454533CD8D5; Mon, 23 Mar 2026 17:41:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287680; cv=none; b=GaEde0UyPR1s0jfmT+XdtrrUroNSiXIYT0lE53hRiIu21+phPcogY8XK7DTbNhl9yymYmQ5wtoTffyWQsroowN596H/iKqIDTfxQ1YlyplnrYaYgBCIC0hW6qZGcYP9lBEJwubS0pgHjLLLlP6Ay3ahQn7ns3irbvNZoTE7qBv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287680; c=relaxed/simple; bh=zoAHSQ3Fdv6Ow07hipkMqufNHcDnPzZ2Z7NU20uPMxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oJDNHWNMCU0EXgHAC0wdzrXMhah/gd+BZ+T9Jot92KwZ/Ec3fLK59qh2qpHTZ9VAvl/FRrjrIdwoolq6bIwm3tLle47BbOCpPdm+f4spyNnBtWkwJgsiOKmaPNCN4zecMAos0RbWDhSCWhR0afxsij1+9q8fqEmMWDB/Sreu6KA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Nx85Oefl; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Nx85Oefl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774287678; x=1805823678; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zoAHSQ3Fdv6Ow07hipkMqufNHcDnPzZ2Z7NU20uPMxw=; b=Nx85OeflCi6WrYQJSOizL52MIREP9cS8aucjAgfb7Ii7nQit+RTgw3iu 5kw0IfoTLVUbfdC/hLfMCRajPUTWBvU7OMlWp9B/0hihYjY98C2ax9Qaq lssmIOSwoO2ra1vS4h0y2EGzHcOem3SslUMCSe/6pBDu56oYNJ6QhwVT1 fSbRjTbdAAjrp8O2OKEa/Xmv4dp4A+TPwEtxr+ZzDgApiKQpkU/fHQk+e JtnvSKnfAB1dTm9mPm5U7OSNvhfTLoxaTomZv23ScAYB0cdGhA1k432+5 ai86BgiKwMm5+Z6N7e3AyVtD5RWzO3HnsFmbFeA0ppORRE55QgZuwb+4Y A==; X-CSE-ConnectionGUID: 0eKDIA1cQE2561Z2FWvniw== X-CSE-MsgGUID: Kb2BALGTTxSqMPnNdOBpmg== X-IronPort-AV: E=McAfee;i="6800,10657,11738"; a="75484714" X-IronPort-AV: E=Sophos;i="6.23,137,1770624000"; d="scan'208";a="75484714" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2026 10:41:17 -0700 X-CSE-ConnectionGUID: x7yAurUtQP+wriMS32Poww== X-CSE-MsgGUID: EixFYHn5RCWMbcw+VpGI2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,137,1770624000"; d="scan'208";a="228576825" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orviesa004.jf.intel.com with ESMTP; 23 Mar 2026 10:41:12 -0700 Received: from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146]) by irvmail002.ir.intel.com (Postfix) with ESMTP id 5F97C32C91; Mon, 23 Mar 2026 17:41:10 +0000 (GMT) From: Larysa Zaremba To: intel-wired-lan@lists.osuosl.org, Tony Nguyen Cc: aleksander.lobakin@intel.com, sridhar.samudrala@intel.com, "Singhai, Anjali" , Michal Swiatkowski , Larysa Zaremba , "Fijalkowski, Maciej" , Emil Tantilov , Madhu Chittim , Josh Hay , "Keller, Jacob E" , jayaprakash.shanmugam@intel.com, Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Richard Cochran , Przemek Kitszel , Andrew Lunn , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH iwl-next v6 10/14] idpf: print a debug message and bail in case of non-event ctlq message Date: Mon, 23 Mar 2026 18:40:41 +0100 Message-ID: <20260323174052.5355-11-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20260323174052.5355-1-larysa.zaremba@intel.com> References: <20260323174052.5355-1-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unlike previous internal idpf ctlq implementation, idpf calls the default message handler for all received messages that do not have a matching xn transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error messages printing garbage, because the parsing expected a valid event message, but got e.g. a delayed response for a timed-out transaction. The information about timed-out transactions and otherwise unhandleable messages can still be valuable for developers, so print the information with dynamic debug and exit the function, so the following functions can parse valid events in peace. Reviewed-by: Aleksandr Loktionov Reviewed-by: Michal Kubiak Signed-off-by: Larysa Zaremba Tested-by: Samuel Salin Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/= ethernet/intel/idpf/idpf_virtchnl.c index 38d119147ab6..d9f93c88e938 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -84,6 +84,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx, u32 event; =20 adapter =3D container_of(ctx, struct idpf_adapter, ctlq_ctx); + if (ctlq_msg->chnl_opcode !=3D VIRTCHNL2_OP_EVENT) { + dev_dbg(&adapter->pdev->dev, + "Unhandled message with opcode %u from CP\n", + ctlq_msg->chnl_opcode); + goto free_rx_buf; + } + if (payload_size < sizeof(*v2e)) { dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive valid payloa= d for event msg (op %d len %d)\n", ctlq_msg->chnl_opcode, --=20 2.47.0