From nobody Fri Apr 3 16:03:02 2026 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E753AA4ED; Mon, 23 Mar 2026 16:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.147.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283699; cv=fail; b=n8lASIDGl9cn+r227RbDKEvb37lugmqZG/c86keT6uikm+jcP3Lf8pVilF/fdbfu1PbWMotV6CxOczbb3nXeghqOhLqz3IQZ8GdggmIrZJEU8HdB/52Fev1lFMyv/5EtpKdOdaFNGAZkUfTQB4MggIC3hszafS0IZYYTkF1CyjM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283699; c=relaxed/simple; bh=YAentU53EDdARwPr8RNSuQqwawHIQOLUZl1vxxH9JNw=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=iEPifLF+QSEdptR3ODQ7+/JbCrMgD9SVRer8cgzphbpTW92KjRob7U4SyBe4ElK+Rq0bFX8vt1k77ncYWVzyterN5sILHy9yM6XO4ImCL5qaCPvP5ApxXbGl+r9dD/xtJ4blpSwARu27SWSn3MTUxCzMRfixvj+e+9+A4xx2SME= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=fEquCwhd; arc=fail smtp.client-ip=148.163.147.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="fEquCwhd" Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NEd2fj3152836; Mon, 23 Mar 2026 16:34:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=Fz 7URvk5GFT0yaTorSbqF7LpByxzXGhl4ZyXxy8rW6U=; b=fEquCwhdQkN0TM9jBB yNKrZVLlE7j5TgDHveqDRXet5G0yRoafmeZ57Yy4GUZz1QYkJT0OGiWgdaRvUrEi qwzASKOVyVas7/9L8yL6Y1JB8XvnnWOzr5kpKC0kQW+Pnjsyl+o7lgXKSNAJdlmJ t7wkTGYZbRWY3UDBdHidDGZFQkOWe9UeH769ZMqKEVxH86sTxMrV0kAlxDJxwrOb nuAJ88uqK//NTLHPJbC9Gah+BvTjjjJSCifrDXXnOz1n3EJivbjC8W8sLYn1pOw4 0fsOC3NzcCXDRdf11ifvfOHlOpK0Q+QHuB2EV+UPL1tCZ2akF5GhQwWpRSnK6Vgr rHSg== Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d37f6hf0y-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 16:34:39 +0000 (GMT) Received: from p1wg14923.americas.hpqcorp.net (unknown [10.119.18.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id DA95BD26E; Mon, 23 Mar 2026 16:34:38 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:34:38 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Mon, 23 Mar 2026 04:34:38 -1200 Received: from BL0PR07CU001.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:34:37 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x55FaFAFCZiTFDqpv1CDcGFER1Zgiwwrz5ZGyr+uGBhFfEZb9wwfuslg1l8lZtP3lozgu+O0Rje+wOROAgBH1h3fxPr2j6r/hGgBn1qfMOn36MHRULZj/HekbCpnq8phu3fKQrjAslLL+aqXeLyb2BymLYNXt33NZ5Mu54sPuQ6XFuHLn8/92CqM3fmRymoBBqulH5yaZanOIfdCcyA+mtM8jWm28oQMwj2lfH4S4bMZzVhESkhz+OoeIcRJXl9Ex84NdiVRvj2h0TQeFbycY+/qsbSW4CAEeGh8afhM9LmUyz6r0z63MyM0/s2lJp1IMkK/+KPr0iGZvAa7DClLvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fz7URvk5GFT0yaTorSbqF7LpByxzXGhl4ZyXxy8rW6U=; b=lmRMlbmPW6re1SW6VXS7QVCN5y2dSE3L2zNYQ9/FhHOsqhBm9nteYq4yL+3qGWxVM58g6K7wv/PIk97JqNF2/SusiJX0joci6rZqkni+kThYLk5/A35hCqtCiWkQaAdEoJN/iYHF4JsjTWsua2GCzxHYAonrGmSK/4r8XSj+ZuBluxrqjInn+IeMQUPC+txRwPNjsL8dhQerQ8z46JPGE5np9KKiXwBu0iWssR86xlAIgU5j2wI1a+2zHHJ4h9UXABf88mpGthMj0BssPp/Jaz/ynf+ce062NDhAkELEUJyTvuH/Q+Wr2q0kdCx/ACZ079LZn7MKjq16wtRH0iwu2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by MW4PR84MB1899.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1b2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 16:34:35 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9723.030; Mon, 23 Mar 2026 16:34:35 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "wenswang@yeah.net" , "chou.cosmo@gmail.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 1/5] hwmon: (pmbus) Use -ENODATA for unhandled registers in MPS drivers Thread-Topic: [PATCH 1/5] hwmon: (pmbus) Use -ENODATA for unhandled registers in MPS drivers Thread-Index: AQHcuuLvNpBjS1uimUWr/HcfQZ3cyQ== Date: Mon, 23 Mar 2026 16:34:34 +0000 Message-ID: <20260323163343.183186-2-sanman.pradhan@hpe.com> References: <20260323163343.183186-1-sanman.pradhan@hpe.com> In-Reply-To: <20260323163343.183186-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|MW4PR84MB1899:EE_ x-ms-office365-filtering-correlation-id: f7eb0094-0578-4980-6ce5-08de88fa1183 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: DitywImhFi0PqxhpaXvlx6lmmyEeFRQgSSk+P953t0bvcs0N+wsWIV/zzHJ0D0wSMiaIKrBv7mVj+nHfJPG9QsxDcX7OGXSn1P7+tJxJMJTjRN4TLwPU7FdyT01O4U1yHQzg8m5meZzv61zbFjEy0audv+AHeHlAIhK5Kqra/XRRyHBmJIEX6/xH+9YLMpc9SUzYLE4DLjgsWCzaa5FXR5vgSypp95eYYcjmhU5vy6we/lpfv2Lcc1eBEBdpCeEFynGcXBaHQ7HVPJYSP8b+OMo0sPfORa4B6/bIbjghIbILgieTnb6HatjqfpGqXAIECB//u77ARgy6HkMseGeheJQRYyWJgjUwJQcnQe5bNyKrtEthpI7kSfyL522Q+TYbWYvoG1ZiXxH2Be+CccXcHV8SlAL12jU9JBtlkelWUJH6B/zrWrQLTtK3RJ+t/ZKnG2duolw9FI2Rw91bRT8a3EXRTOFsfq6wVM1CGhVCXB1neXTG5WHFhk+UJ2wM4xMmd/15dDzyCFJBpmGPp+8QURbfgFMQyKvGfj6a+Md4ZwE9IpjdJ/aefCoubmw3OIEmo/ift3R4i/WLDo22Xxxrd94mwVWKvY6fvuSgPYSMGtQrC1962f+DqVG2ko9A7FYDlOIhE3n1pIxtfm8jQN6VqsNMMX9BljdEYRiHBuYUHF446uy5KcWdmLKRZ/CXrzvypfRCQ2vGpzvXEnz+rda0YrHDjNd27UBO2B+uCJYWkbtWbgp/Y+A8hAc+jJfSiU+ANYos2fROAnc4yKsK9V+Y5VW++bNImH07DkrB9fNqLJk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(38070700021)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?5bXOc+WHNhSAmL8SyB/ztnKjenSOOUJIU7vCuTR+dAc/aPJSlcjNbktrW8?= =?iso-8859-1?Q?jHGgR63mmT4JAk/iaxmHIf0dTH1eweAFHUR4cOD+lNPcyR7O5uHaQFcWkW?= =?iso-8859-1?Q?j832Ju4sAMdzOSMEgUhVkuRto/6zsqXzrm0ipu1TCxDB+2L+Q72JZlCZAo?= =?iso-8859-1?Q?zODQDWPQTEMZCbLq2+LmNp28KwKIul2Z/uHHZghNigxX6aPB9A5GR99fui?= =?iso-8859-1?Q?esIY0JybK97v4h2DFT5iM9wkloTny13J4o3wIYPTQGghbLF5q+SVPIryFL?= =?iso-8859-1?Q?oSMWK9ElUACdY8tgx0qWcJi42SC+ZMXOaCp+1NdXHW4TZBXKnaicK5k6lk?= =?iso-8859-1?Q?5iRzdekcFiM1dp9xsYlks/ohlx0Ah+LUJchwI0GbEYGPLN4BX7DqNVm/MH?= =?iso-8859-1?Q?Nx+IvW/qWajUq7LP5zD/wPWPlaXE9SYnqK3pApO0SQ97ZAEzhpukoD+p16?= =?iso-8859-1?Q?J+YwGFx0fmxnpGnskhK/v8joTW/6hSS1Bwuk7hUvHMYzabMfM1PVSBb/QY?= =?iso-8859-1?Q?IXMnZZdNI4JE0qblZEDcZIAbFqEfC5AE019n1tBdcQt/l87c0JbqXrqjzR?= =?iso-8859-1?Q?MPG+3s4fS7mqKpfkDaZy3DwmVWxQ8U08cBIRZSntw3/kR854LA2bYFQt9y?= =?iso-8859-1?Q?4Gvc74si/P1AyZ52C7uNmQCJwawNIu5stBJnR5FIvOJZaKqDCG2CW6T4vU?= =?iso-8859-1?Q?3ZTKFFvJgyACillgov/R+0MgHgp8gBPydHwVBZXAB2u0u3ByxZpgdkVnEE?= =?iso-8859-1?Q?nhZmRR/3RLC6z4tnkV7iVG6s5KBpDROtui39QfFAwPmN2mTPd2sII8bwzC?= =?iso-8859-1?Q?jyLH6Zj2v7Yuge+mnlcbhMgQTvdmFbimkhur1HyYah1wZWwssfZ251Z0PK?= =?iso-8859-1?Q?/23msZYTtOFmGdJuovvyG+oxQzB4F57JSvS2uxj3OAFc4t/U3qWR8apuDc?= =?iso-8859-1?Q?YkGLrDF9M1ZSwvHm3v5K6y1/AZORPahS1rp97Eu7SqMNkF4VumxO8pR1YM?= =?iso-8859-1?Q?OQfefy6gUUw6HvpM/aoSQgUp5mHvKMiGMqXAPYsEWYuDwKgie8WP9U7Ifo?= =?iso-8859-1?Q?yUJ0PnHhu864iwu4LIzu4q7o/M+okLYjH2rnvugjktyvKdK7Sti7rCnqBq?= =?iso-8859-1?Q?qkf8e7c0wCTfeGyFs7lDr8nEgl1eBaCa2l43CmQKQeBvIRTU+ekVDdKowR?= =?iso-8859-1?Q?18Fuhd/wvvZhIPdtpQBsjTnwEIg2n1idqizZWONWDEgIHYFa36Pm9XdWtn?= =?iso-8859-1?Q?2Al9JFcDvm7mXroLL23/zZLSP0m7u8Ye+3GOhq6uVTimuLKagechvNjxC8?= =?iso-8859-1?Q?2lYLUXGojSLBVnriEBf4wfYGNYldNiNl73+OUpIpuPiSfphKPoUuClvWSX?= =?iso-8859-1?Q?8QDWNJUTxpFgf+3N1Xr+fQMMsUoHkpmuLbL3sKiH0sGNj6AZNd8c2egTkk?= =?iso-8859-1?Q?snOWiv7fpiXUXxc4KIxCC8VPQaoauEics9c1yeI+xWx6UZSgTejXCX8clU?= =?iso-8859-1?Q?erYxS0EbT4edg41OKhb6m4LR77FNBb0IffTV5QOrSlLtUl9is+5jWI+TzB?= =?iso-8859-1?Q?H5SUMvcFDLcAqSu+roKn9iVcQqzNrG9vDPYAkcXgpe29+7/HwCupLkFfxu?= =?iso-8859-1?Q?cEZgNKDWrucSLGHfwTTaSqKoPSIYoWH//wlXa21lW1QtY//rj7e39s9ggU?= =?iso-8859-1?Q?lxPZxjE43Z1XqizlYfZN/bnWDmSWWT9cj9kkfuxtqKYZHZnQ6kH7JGraTz?= =?iso-8859-1?Q?swBcheN3zFoX1pKzriPnCdKgx2kRHWsDaaUq27ybmKG4qI?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: qberfeIYOAMC1Qj/dqSQGW2+Yh/dZgdYJ9UVg3kQ8BWWjCXrSnuKNpNRM6IHwJ5XHCdMNRzzVOd34M76JMiGBTPLgvRNLdiLjsfPU5clGELQxX/b6L9Fo+E9y5RLfebcuZXUpFVdYjQdLjukEZu0RsGI4GO/b55Gyur6Dc8HR6qUp/tUtXkG1cH2eGr1nRw4qwEn2A1RgevXiHVymab6Cafqs5oYOljEEd+qXoi3fNVRpexrmFwjHtm5fIi5+SotJdR1Mt0p/6fClBYiCFKZQBAvlFE6FZ/GlnM53aFfw3z9W10QC4a+oA7yUxVXUIlzJsLcJG2hoAtcVrjHWYV6Fg== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f7eb0094-0578-4980-6ce5-08de88fa1183 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2026 16:34:34.9921 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ustuz8m61yrFnJqrmCIi6Pmfde7A2rZV56o01C2A5POuJgUBDMyKGnJhHMTNIdn95s8mWXVD1mk1jKgDLVIUXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB1899 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: QtO8L5E_EaYjktVp13ofY44oQyRg_a8y X-Authority-Analysis: v=2.4 cv=d8P4CBjE c=1 sm=1 tr=0 ts=69c16b9f cx=c_pps a=5jkVtQsCUlC8zk5UhkBgHg==:117 a=5jkVtQsCUlC8zk5UhkBgHg==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=ay80y3fxfMS_JZZz1qJy:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=mbBNgdjj5DS2MrdysacA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNCBTYWx0ZWRfXwjKiKDbvOLNB n8r7a1n0snTdLXl9Yuab5TY/wvBEQmFaPIRb/PCrDMC/e2QVat0pS84EWsSwEuhmyBmrO2aIKSl nOFabmBtUNSPEs4Wjw7GWGWwb2vLUiatWWpZXeNNhqFT82QtpB+vn9/fgnboy0St/1wRZ8BRoT6 +p1cR3ql+jnThstxSCc8mGCKdfuYUZdeISDAoM0J4CzZpfqMs63e54GejjYZDveNDe8ueGcEuKZ Lkpv0G+7mt6uXDLC5LdBjJp0YYZilEC/KnvUxkEMmXg/benXnzTU0Y8a+am3tpBMEvOkGIaVWjp 0xSnmKMGMVP5ibz/EcudB9zPOqi7fz7bl5fDunqNpHRGUm5ckM5N7RPZL//bolu1+Aw45E1i1k9 gdoSFSCsv/14kirfAqbEEtP3bPC9p329Phjblb7kWBTdVOIXQzefnjic1oxVaqoHqrCcPoDdbVY psmMNdyyPcCn/wUUx7Q== X-Proofpoint-ORIG-GUID: QtO8L5E_EaYjktVp13ofY44oQyRg_a8y X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1011 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230124 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan The read_word_data and write_word_data callbacks in mp2869, mp29502, and mp2925 return -EINVAL for unhandled register addresses. In the PMBus core, -ENODATA has a special meaning: it tells the core to fall through to the standard PMBus register read/write path. Any other negative value (such as -EINVAL) tells the core the register does not exist, causing valid PMBus standard registers to be silently hidden. Replace -EINVAL with -ENODATA in the default case of all affected read_word_data and write_word_data callbacks so that standard PMBus registers not handled by the driver are properly served by the core. Fixes: a3a2923aaf7f ("hwmon: add MP2869,MP29608,MP29612 and MP29816 series = driver") Fixes: 90bad684e9ac ("hwmon: add MP29502 driver") Fixes: a79472e30be4 ("hwmon: Add MP2925 and MP2929 driver") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/mp2869.c | 4 ++-- drivers/hwmon/pmbus/mp2925.c | 4 ++-- drivers/hwmon/pmbus/mp29502.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hwmon/pmbus/mp2869.c b/drivers/hwmon/pmbus/mp2869.c index cc69a1e91dfe..4f8543801298 100644 --- a/drivers/hwmon/pmbus/mp2869.c +++ b/drivers/hwmon/pmbus/mp2869.c @@ -391,7 +391,7 @@ static int mp2869_read_word_data(struct i2c_client *cli= ent, int page, int phase, ret =3D (ret & GENMASK(7, 0)) * MP2869_POUT_OP_GAIN; break; default: - ret =3D -EINVAL; + ret =3D -ENODATA; break; } =20 @@ -536,7 +536,7 @@ static int mp2869_write_word_data(struct i2c_client *cl= ient, int page, int reg, MP2869_POUT_OP_GAIN))); break; default: - ret =3D -EINVAL; + ret =3D -ENODATA; break; } =20 diff --git a/drivers/hwmon/pmbus/mp2925.c b/drivers/hwmon/pmbus/mp2925.c index ad094842cf2d..a62f6c644bb5 100644 --- a/drivers/hwmon/pmbus/mp2925.c +++ b/drivers/hwmon/pmbus/mp2925.c @@ -132,7 +132,7 @@ static int mp2925_read_word_data(struct i2c_client *cli= ent, int page, int phase, ret =3D -ENODATA; break; default: - ret =3D -EINVAL; + ret =3D -ENODATA; break; } =20 @@ -203,7 +203,7 @@ static int mp2925_write_word_data(struct i2c_client *cl= ient, int page, int reg, ret))); break; default: - ret =3D -EINVAL; + ret =3D -ENODATA; break; } =20 diff --git a/drivers/hwmon/pmbus/mp29502.c b/drivers/hwmon/pmbus/mp29502.c index 7241373f1557..4556bc8350ae 100644 --- a/drivers/hwmon/pmbus/mp29502.c +++ b/drivers/hwmon/pmbus/mp29502.c @@ -456,7 +456,7 @@ static int mp29502_read_word_data(struct i2c_client *cl= ient, int page, ret =3D (ret & GENMASK(7, 0)) - MP29502_TEMP_LIMIT_OFFSET; break; default: - ret =3D -EINVAL; + ret =3D -ENODATA; break; } =20 @@ -555,7 +555,7 @@ static int mp29502_write_word_data(struct i2c_client *c= lient, int page, int reg, word + MP29502_TEMP_LIMIT_OFFSET)); break; default: - ret =3D -EINVAL; + ret =3D -ENODATA; break; } =20 --=20 2.34.1 From nobody Fri Apr 3 16:03:02 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF0E53AF650; Mon, 23 Mar 2026 16:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283708; cv=fail; b=clH2ZERF12hb4DeT+SiKIsMUZUtLSg4P3l1EgFfVDC1jpiTE+NTdRhNKzUNZaxrEk7Ga2wkZjKpBcnPaCW4asGqRY7Zcxw0MYJRUtNFXvzyXR6xTf0vegzeP0afWrIVaF9Le6+oPLD+O+Fd/SZDYd+FjziUM+5l4rTUnShff76c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283708; c=relaxed/simple; bh=xAICgJ8ScQU12oX/dXgj3mjfqHr4DsG2WrGuJMN/H6c=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=GVDfbHyXkWqE1R3znRxHBXZhSKKVgbBifDmYpTtif0JqXyD4Fji6E1ZLXN9r4uO6LNtgZZgu6UfcT9GI3tTV62vKEcmAJNLqpvIx1FrMlFtUSiRzDl1TLWJyTlwmi5bfqsynstDJ0HNRRxCABkLFJhNkoSV1OFpRFeiRRPgpjYI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=F7vGSkeN; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="F7vGSkeN" Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NEqrtD2097874; Mon, 23 Mar 2026 16:34:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=g+ 8Nav8lHF9jBYyAeCPc2OVUxgxjm2Uo00o9oFilux4=; b=F7vGSkeN9I17fMdMna 1VQq3Ja8L0tAxIXf5gQwZVWQHvxE4c1g72e6qvFg+hBcOmIpR+hFOYhgBXG/CEoU 5eimb2+PzpTRn/bzyDYztfFHtsuNm0qRxhqH4Kun05I7CbSisRRcaW8u//lw3pMN DTPVLS37429pzMybnEUBdGLhSUlOWSyozZnho+ztxgff40sajvqHRD8q94T7K1qX IupRZpKxuziq7SMPr3VrxGjNa9KCNMKcaBR8X81GhjtLS7dME2Fn2U2BZl+UqoZE AiOBFK0hUvWm4v4ncu8E1QLUwuRZZGGQJxyNkczLAv5/KKnu3QPbRY9VJFgR303R P8hw== Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d37nth9ve-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 16:34:49 +0000 (GMT) Received: from p1wg14926.americas.hpqcorp.net (unknown [10.119.18.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id AA8E8D270; Mon, 23 Mar 2026 16:34:48 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:34:48 -1200 Received: from p1wg14924.americas.hpqcorp.net (10.119.18.113) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:34:47 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Mon, 23 Mar 2026 04:34:47 -1200 Received: from BN1PR07CU003.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:34:47 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nNCOhWCHD+QbQx1cYE0f4B6Y1Jnh/xMXiyd+u8xr5qQoq0lvqar2lagxIQXujjJeBDSpRNJk6qIMNCcHWsMcbdU/lgXBJtTlaEp9Pf/pGpc3jKrKbRjqmeX7dFlj0N6cT7RUWcE8tb9A6wXntwCghr+NXjQobd1wkyOu7l1NKI84AM9GfwdneUXl+07xC4Y9vX4w8EDeOALjoGo93iNFXiEE7FJpscQJQAvCH6DeR2zqDTLFyZEGqDiZz7rnVtZLo3mRhAY/lfeuK0IJH03XWxeLu/538gu1OhdvYrsINxYrm39JoSesfD/rFHXe0qjfpH5lqwx2ijJpYxYsw7Pv+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g+8Nav8lHF9jBYyAeCPc2OVUxgxjm2Uo00o9oFilux4=; b=RQkYyOLZ4DGxtK/BxS5GeyeM9z3n2RGNDykFEnmroGzUKKwJwX5Ge1+CzfzG6LN8VZT1N3Z+eshUTPNugSh3zE56LiN6LIHXdZajMP+Qj982J6UdYZeQWedDIzKVK9rvX80wnpanGvDfD54xz5Nl1Y24mmfRDwXOhIpBcrLbPdNWfFGj4hhnkWtyTwr2oEPcJIVhaHfdfxq8gwJYuS+QzPx4fnHUrVDX96st7dlcGnh8hFPCE1JDuR0wgAHvbt7jUkXLRylYAJF5diGfvZ26Dp9tWfY0Ir0AkrCbiGWswqj5ISd9NkmKgzobslnk6llPjFlkpPlelz3JwuGVCRQfyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by LV3PR84MB3819.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:1db::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 16:34:45 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9723.030; Mon, 23 Mar 2026 16:34:45 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "wenswang@yeah.net" , "chou.cosmo@gmail.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 2/5] hwmon: (pmbus) Fix return type truncation in MPS reg2data_linear11() Thread-Topic: [PATCH 2/5] hwmon: (pmbus) Fix return type truncation in MPS reg2data_linear11() Thread-Index: AQHcuuL1lqWIQ+/K0kWiUQgF7nHDqA== Date: Mon, 23 Mar 2026 16:34:45 +0000 Message-ID: <20260323163343.183186-3-sanman.pradhan@hpe.com> References: <20260323163343.183186-1-sanman.pradhan@hpe.com> In-Reply-To: <20260323163343.183186-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|LV3PR84MB3819:EE_ x-ms-office365-filtering-correlation-id: 0a4f5428-bb8e-4015-149b-08de88fa17ae x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: pzdBEnAoep8dhyiLiAeV1AQV65T47ZWUi2RzgwwWhWUZ8f47fU8G4JEByPshNh/pkBZZhVXgEEMcvRWHjgLzsLUqA7aLGJGY+sGQRFH/RvlNeQor0vt1ACi8fGDZ4xcveYYojxFto2hxt3Bf1C9Rc6R3jmmkbb2yiLXvQM639cMANjoGFRK9edFByAAPfwT6RE55xh2iTJbQNWtaK/DNE/EsWOObPNZ9yJc3RGluPcxkDSWCf9qZEMyemOJbAFPPIemVMA326jegXhTvGi5JVGV60WbEQQEz0xhSmPPD9g/8rBKxwq1fZQ4UloYk0YSq0EXvMT92OubIaFiaK0ib1+1U674QRILSzmz7qQOboPBk/IeBsQSkcql18+qDPgoPjsVFZTWT5TqY82zpmmOWXH8veMp8Gnvz3a/xijcGFY9qYcHtwliVFzpNS/dywn6UmJTR1RYU72Pp80ElEP23Vto19Z5In8KZNroC5ftUTvGTFmJoqUVO2nfU4YixQxmWSBwLc3dPISZRjx2LHqjPr5BTEnoMbRuI+iTokEXNF5Ufc0Ovh+NdIsemtuC9B9+DHG4tD7/ZkM1ONrJAdRfIeq9mhRLZZJSTPjYhkQgT+7wCVS7QAMJXQ+wvt9RgPCRTGFlFWQ8PDN2yYEZXRu+CvI6qzBBCWGo15jZH9i9J6pTqX76bQlM2IaWPtKoM/KQdBcBRqYzdcFQGQiJwkt5sIeibUlvLa18LFxiZLNlf3gKK7G6ZEGd+LGjY8OmyVJzQDkYTHvjI0MRjFx9qAb8BLPbO/a1qnLi4S6duxylh4w4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?+8UzE0x4cG8856wBzPDhyz00gtPChZj5Npt473dByExx/g5MyhKv27M69g?= =?iso-8859-1?Q?rafZSXIU05Dil+PAqD0FrOIVmLBYHuNGHHiitaSoCSS+mJhrGQqGeIilsH?= =?iso-8859-1?Q?NXmfIgyulwFEDvJTjWVtcNrkL4yo9EtO5SO9FJ6hhh5vqG9o1oSD0xzb1V?= =?iso-8859-1?Q?GjQOjdcutw3w6k7N7suFC6nU+ereZKOW7IWz3Aj0CSE90yTThHeljqglz/?= =?iso-8859-1?Q?2fzkHMQvqe5rDNUnxUQUFj2/zmS2QHIue8pizmPvljXlvwEfeq90inBw8f?= =?iso-8859-1?Q?q5noe5GSKVPKJSRW7Ue9i/nGg7Lhj9WOA3GUcSuLOQdRwUJPOL/k1rHcEB?= =?iso-8859-1?Q?Ilv3k4vpTyImvGI1DyRbtf1V9UZ2sF6lZFmD1YX24yqEsM50xdxfCc/jrC?= =?iso-8859-1?Q?5jlVNKdP53ZfMTcBg0mbFgsSCNFwRXODE4KmcxbKmkrS/5DOdoB/jSt3fE?= =?iso-8859-1?Q?Rm7V/nCMkYE5GIKdHX6Vf3MVMCcowJLF7b1yU/+pbPcsXQrfVTA6p4HZ+X?= =?iso-8859-1?Q?yE4eXn2/ESsHhvzvegi8OYZF9KKZAJdXZ+gLuMrQm7sv25zdVvC2AmBuc+?= =?iso-8859-1?Q?JXCjJiwZiIstUmIxUEO1a0p/+OysVXt4Tpgs/rat6hh00w8oaUSa6e0thw?= =?iso-8859-1?Q?r0wVjCHdG95LHPZjJDMTE8Ofpl3cakNZs3hI0adDvuC5RKEzmF30XeqyrN?= =?iso-8859-1?Q?/uqpsUR3q0c67FWxGrWAUjDLIFlDGCc4RUdLEDVaixads7sCw3sHjz74sA?= =?iso-8859-1?Q?kVzNECWnWw6BuC509S3R7qqybWLFCgr9VEV6PLy9zqtvEy5ZTkzlI0Oa5/?= =?iso-8859-1?Q?uIkk7aDIbiXvHR1RE3ISQYQ55Lv6ixjjcSFhd4Epwv/4RLoiBzF/HZj/9T?= =?iso-8859-1?Q?aCgTMpM5ef1vJLaPHKjf62XvMEn4dSoG1Gd5h+0i4i/RojFuYTkSKcKQlq?= =?iso-8859-1?Q?ylUngBtVjvq5XlUSTNrndP4BeZdDjIwrAiUMlxjNLJwm3ZymDfcIfDdmab?= =?iso-8859-1?Q?4aXxlSq0F+/60A0QE8fVw/TjfNxhytOrI46Eg8+xOaoLDI8cv0v5oM1N1v?= =?iso-8859-1?Q?T/gJ0I7Ir7MG/oqOuEUUSbbvwRFaBBPTqmd+7aFhOmzZUswkGgprvzNtR5?= =?iso-8859-1?Q?RnBqgUzVfM+L9iF7BL9Rz9PeSTgFY4LJY719jVIhzGRXvqS4TigWq1MHao?= =?iso-8859-1?Q?KqvXXUDZDSsF/CyCoHSygICqqMIl5XOdqNvhhqd9YunCP7KQPTJao2332H?= =?iso-8859-1?Q?XzwG7LKpLvbdTQoqqmiAaRFj6qA8+pZKpQYopP9t+/zUmpw/Vr5CAg1IWl?= =?iso-8859-1?Q?RYq1giiNfDu3q3YN559LfbcELuiBuJb+7ufAC8snL5nfbSKaZOjrYjZA4Y?= =?iso-8859-1?Q?3rtc7UDzHFkTN4Z6cyQQVKFYsDlVHqzroNTse4tEgf8hBe8DULmCY16kiI?= =?iso-8859-1?Q?7ois2PhM8n+OQBBSDwAmqVROwA3SmsUuxXfRppB0P1XFOqlPER8NwRQ2eO?= =?iso-8859-1?Q?0TOLXD6bC3cUhY6q95oX9ZXVC7fjVPWgfKAnenGswG1+F8sTfVOgFjZ+y9?= =?iso-8859-1?Q?tMpIhPJpiCf3hTzFF4SI+UXpw3R/l5COVIFAQcKWFPqUf5NrBw0FRkO1lZ?= =?iso-8859-1?Q?etUniyESSY+8INmr2OJu2qKffzs2FfqkO2X2JgKPQR9Rjl8aiW4oNUcIAv?= =?iso-8859-1?Q?bkZclwyFP44yDSIEsnkBOtQkEszVjxMqlNH2KBfSnef8M641l+mkpxWo+1?= =?iso-8859-1?Q?JutZlJDMhh8DaHhZ8ostyeAHB4DJ63kj1Ves4BrHVzlEdL?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: qPowWYOTTbR9I6xrIjU6DeCZpsLLKDQU9+jHmjDT2BoXLL8K69PSZYru7qj47LithsFGKR0bNbdzPqpILtnfGfqaqmZNgMN1Ra1/htGCn5urE3Xo+DlqFgdqkJIocxpFylxouZJNUgE5mVdNtqMRVkkgfWjswkuNSv9q1KMN/Ly3z0BxTa5L0dXyuhe6mcHgoS0vn5q7w3N55aDVN3XqpOgcL+icpDIIIa6BEkDWX+ts+Y0/hbbzXSO7qW+2G3oknDghA4lNaW1jpbxVg1KoeHtjnqL0cJUQiYaqdt4LJF4b7BC+6IN4voqPEnhYEWAZ1NrIXDL4zpNw6sKgmRVtxg== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 0a4f5428-bb8e-4015-149b-08de88fa17ae X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2026 16:34:45.3442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DwKFdVPgkebXfF1IYaQngwK/vQgrN+CulssanUCQd9KQiND6SAhxO/EhYPhK4BmgpQ07zyBQX6vCaGsbJZrXpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3819 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: l6bVSnSOp_HxX0J2I4dRN2kCHm_IFKFe X-Proofpoint-ORIG-GUID: l6bVSnSOp_HxX0J2I4dRN2kCHm_IFKFe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNCBTYWx0ZWRfX+xEM2gIyxTj4 FsDUgeP06wfvxENn9mZPOnZLfVD2oiMUUDG3yzPj+wEo5LByjtCqwMh4zbj8q6xz3P/SH55Dxez 6Gd3GEB/jvWqkAy/bZES8Nj+OmlidbkzJmhxckaKlACpemLqD4JvWcRw6c0zvpPyO1c7bZXLPVg GqNAW1ihU0lr16jpVlMerto7s8pS5W56CdBBOok2jGhJe/DQpdGDRwzA7svHXVf3XGg5jJZyz9o Rhpis/wERA//43KJOO1YeUn9jAx03TjTRuumul38R8IPWK70HbNBEA0Bm+wSA1Myzyr583pHOzZ 4whANVj56ji4OwuAJhfdz7DjDIry2s+LBTGpMwsYczMtIm98UkM54BWBdwBJ+VYSV/UgzusCEXb bmXbOeIxdnB/bbEMUx3Fg4L0udX2DG5Hx4QkZY68cXsanRz8KevjTuWqQrEJWIn/f+eDCHtY8/Z DdApBHBQpTJBaJfc7zg== X-Authority-Analysis: v=2.4 cv=ddKNHHXe c=1 sm=1 tr=0 ts=69c16ba9 cx=c_pps a=5jkVtQsCUlC8zk5UhkBgHg==:117 a=5jkVtQsCUlC8zk5UhkBgHg==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=3haJ9R1Aw3gUfsUHDaCR:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=Knx6zecuWxaYfDB9Tz0A:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 suspectscore=0 malwarescore=0 bulkscore=0 clxscore=1011 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230124 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan mp2869_reg2data_linear11() and mp29502_reg2data_linear11() decode a Linear11 PMBus value using signed intermediates but return u16. This silently truncates negative or oversized results. Those helpers feed values later returned through the driver read_word_data() callback path. In that path, negative integers are reserved for errors, so successful decoded values must remain in a non-negative bounded range. Change the helper return type to int and clamp the result to [0, 0xffff]. This makes the saturation explicit instead of relying on implicit truncation to u16, and keeps the conversion semantics local to the helper for all callers. Fixes: a3a2923aaf7f ("hwmon: add MP2869,MP29608,MP29612 and MP29816 series = driver") Fixes: 90bad684e9ac ("hwmon: add MP29502 driver") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/mp2869.c | 4 ++-- drivers/hwmon/pmbus/mp29502.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/pmbus/mp2869.c b/drivers/hwmon/pmbus/mp2869.c index 4f8543801298..fc4ce854c9c3 100644 --- a/drivers/hwmon/pmbus/mp2869.c +++ b/drivers/hwmon/pmbus/mp2869.c @@ -65,7 +65,7 @@ static const int mp2869_iout_sacle[8] =3D {32, 1, 2, 4, 8= , 16, 32, 64}; =20 #define to_mp2869_data(x) container_of(x, struct mp2869_data, info) =20 -static u16 mp2869_reg2data_linear11(u16 word) +static int mp2869_reg2data_linear11(u16 word) { s16 exponent; s32 mantissa; @@ -80,7 +80,7 @@ static u16 mp2869_reg2data_linear11(u16 word) else val >>=3D -exponent; =20 - return val; + return clamp_val(val, 0, 0xffff); } =20 static int diff --git a/drivers/hwmon/pmbus/mp29502.c b/drivers/hwmon/pmbus/mp29502.c index 4556bc8350ae..1457809aa7e4 100644 --- a/drivers/hwmon/pmbus/mp29502.c +++ b/drivers/hwmon/pmbus/mp29502.c @@ -52,7 +52,7 @@ struct mp29502_data { =20 #define to_mp29502_data(x) container_of(x, struct mp29502_data, info) =20 -static u16 mp29502_reg2data_linear11(u16 word) +static int mp29502_reg2data_linear11(u16 word) { s16 exponent; s32 mantissa; @@ -67,7 +67,7 @@ static u16 mp29502_reg2data_linear11(u16 word) else val >>=3D -exponent; =20 - return val; + return clamp_val(val, 0, 0xffff); } =20 static int --=20 2.34.1 From nobody Fri Apr 3 16:03:02 2026 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 731FC823DD; Mon, 23 Mar 2026 16:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.147.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283730; cv=fail; b=Wx0pxFHcBZG/zajrNE75SdpoDaGm1w7aLiUF7qBJ6NjL34m6s+Lv+a1CZ6XEsxRgTQuYnuv2XFJq96Y0JA82aDc5go6NRDxtaW2THRKAHsfeRro9NCxfvlbN5IKEuVtxMXGVRaNQ1ROIK0OedOhmLqvrQBI7UUMKjgykHOm2A+8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283730; c=relaxed/simple; bh=/yFvt/prDiE5erpnNLaZuHeQLex/jwSI48mqmtetPZ4=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=ZWo7MG/nDZSkbiWo+he6DNVmj3IyHMnCynBYWCCDo+YcewcpMbQRP+BwgurByiA3ni1kUCIVJ84Znyic9SHZB0UnIWjcZQCofRot+5HxCZuDOP5ERPw40jVylau0+yXrbfpQH8w6F7hFDG01ut4CCJeuLdKzEVjg/2N2ISGsoCU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=dOnkGGOx; arc=fail smtp.client-ip=148.163.147.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="dOnkGGOx" Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NCBAAQ2636062; Mon, 23 Mar 2026 16:35:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=SX +a5PW0yIkoRZTx68V97PWA5Zl7rPbUq2LyZzrymQ0=; b=dOnkGGOxUhxgUfHvrO KJddZXvQUtq2yN8M4wAQut8hG7K/4x26Fk2l1CM6GKtMfdvWRf2rFYJLIS7Aer3l i2wBDnFJJl2vcXfv6VmLz/uFc8m4GN2AGd9ycacJp2mAKbcQEiLteQBCS0wZl4fd Jn9urdxVX//4GpsyslISZX7YhAwZ/n7y+PD2BoofK3Mut9V58Q/5PN6+pCj9pZRF y+mY0ftWvo8AQCevSl3OlmtViBcl9H4H17lpr8CQrKvxV/jde9wl+ZXrjTJqBNVG 2gaEcUx/v3xKuOlwzokprDZ2DvtLMuJ4m/27DtthvudOnwy12mzHlhUcKP5L/Db9 pR0g== Received: from p1lg14878.it.hpe.com (p1lg14878.it.hpe.com [16.230.97.204]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d35a6b4pd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 16:35:11 +0000 (GMT) Received: from p1wg14926.americas.hpqcorp.net (unknown [10.119.18.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14878.it.hpe.com (Postfix) with ESMTPS id D711B295F0; Mon, 23 Mar 2026 16:35:10 +0000 (UTC) Received: from p1wg14927.americas.hpqcorp.net (10.119.18.117) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:35:10 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14927.americas.hpqcorp.net (10.119.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Mon, 23 Mar 2026 04:35:10 -1200 Received: from BN1PR07CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:35:05 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T8JC9yUk+WjKbMo7RHTf0bmWYRpRIFv8Pav6e52ugErV28fwjJg41MVdAnKgIgQYpZ/W7lmslV81xpNsy9NBT6gPrchtUMi07LSH1rQOVH12aL9FMG5BKoJFCas2ke6git/v0Hb76ARZK3V+l6uh816QUx3Uku/hd/bX+617AjrsijFDFVqAphWi4Hlh3AGRIfZW3K5CnwTyXE+2HnvFCiE6JzZ8V4fnZuhGuQ2PadYpEcpmwwjHwyJ44fIkOdwUsRtI3K6EqUzErhzB2Lzny8WtM20s+KDpHxy93JKPx+VRwWdHjP39344cMDvurn9vJz55owqa4ZVIz4NRD/kMOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SX+a5PW0yIkoRZTx68V97PWA5Zl7rPbUq2LyZzrymQ0=; b=TGyWcxvtAmSyPXm3U4F/HhB1FGtcoblmkn4sEbjW8b+Qzn44vl/rFltdNeKShTrxdL9fkDvR6VRF8ZtNOniHAzLj5BcP64130e5xqRDrKTwulPwybhqtIf089uR+uX5ChUTduWpPnqfoiFHMjGOtNAzBx/FxYrHPGIhrWmPXI/3gVTm1fnVCxTgHy2ZTttczQ0t3IHlLB6Kt7gIX/nSLxYyZk2+NvhncLku6RMG6arEUtNhTA1YSsTpbvty0yUAyLtC5SKN4bYRxAw7YzrY2jPyRu3ADufDMKk25wQ275WVGncBf+skPWeg9e0CN7wJnMf6Tma7hAWG8gnnSgtdecA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by LV3PR84MB3819.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:1db::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 16:35:03 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9723.030; Mon, 23 Mar 2026 16:35:02 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "wenswang@yeah.net" , "chou.cosmo@gmail.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 3/5] hwmon: (pmbus/mp9945) Replace raw I2C calls with PMBus core API Thread-Topic: [PATCH 3/5] hwmon: (pmbus/mp9945) Replace raw I2C calls with PMBus core API Thread-Index: AQHcuuL/+J1oRpHH5U2ocLyUH3BPlQ== Date: Mon, 23 Mar 2026 16:35:02 +0000 Message-ID: <20260323163343.183186-4-sanman.pradhan@hpe.com> References: <20260323163343.183186-1-sanman.pradhan@hpe.com> In-Reply-To: <20260323163343.183186-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|LV3PR84MB3819:EE_ x-ms-office365-filtering-correlation-id: 4704ea71-99eb-4596-8e9a-08de88fa2227 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: NzYDjd4rTDh3oeWeRLtjMuvUs9O/6xCF1bU+9q/jEhN9Mh+aYpVRsCmd87lJqXFkeMOseWL/rZfv76WTPAiQXRzxnUaRjZv9VGMnh80b0Yd7b/TrXewxbJN35bovuP53DSOicPNH+hN07GjAA+sDdFPjcUj7Wx92wWYtMHjvB/irmAT1HrDo+TW/ZZtR1D5YW+QKyJrLAE2s6tJEEkqaypKwtZbF1L/kVvAHZuj4d9otu7BtIeXBJBPSYstT/kSVp/t4eQXUDA5fZbhwMauia9+8Gz6a74UJqogrfRTqbbzkixgzNT/8ITI/FTAljEzKla/plXDFG+4plCZyM+/vz+mBXNWAZUFfOAUlTidAcHe14Vyuny4ZHBvY22S8fsx19sFD1Vl0TgqE/eRJUriu4q0NxBJvNQ+kemYCIjL+fNDGblBjMpUXnyyuBch1upafDDcnvIsAFvF8IM8D/eJibVhFJ8/YUdFqpLhfAPJ2xeQeG5NTpR5vtfVbLjcgHLsCUGnCyuWddrMuVC83FWeWvp6XkAN/21KtVNlxQ6nSr8qWr0WQZDR3x/Oz2KxhTSV6226lq9/Xxnw+ER0xY/62go7jKhVxQExodn6tzuyr6UAMXV0QYOw1qGb5dgLQJM+Ok0vjdqBtqFoz3Tvp5slx2kSPTVe6gMPwE60t+GSWz5u0Tyfi2RL8gnf+U8BIFYVmZNhEN7q49F5g4VlYVs1su+fCloMi/WPuBruo1ZzqNyT00tp21lp1xaI8BXi/Yu9e2LbOHetTdNbpWGYIGolUfpKyeaUg6gjokj2Sa0vrVhw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?qryCzRGpMRaBD+gPy/gPcMyzRclPgAtJVUFPIXzjeMQ/GtUUMWCRBkEDRo?= =?iso-8859-1?Q?ryQNNfKKZsiFX9AJeszfgmMs5AENb+PZAkCj4urkf5KzJTn3YeSODIv79G?= =?iso-8859-1?Q?0cGHyaan8aOA/FdK6W/jBhrLTWmm7myDGup3iZsJWzdju9TY1mKiwYZkVT?= =?iso-8859-1?Q?iD6BFMWEKD/3xd93d9BH25iEZsFsjGgxSZOHh4GWAk3duZtHy1M0D4Rsjj?= =?iso-8859-1?Q?FyEQoqbLfgtCtuN24uGJXv+n+6ZtnSrjZsTiu8TlMkCOilPoGiMrw4Bybw?= =?iso-8859-1?Q?7fFnjGind+B++wjPu0343BnT3KtwTDt9vOJ0bsmtEVzGyYm5oFB6tyjPQq?= =?iso-8859-1?Q?kWhwNFMgv7EYF/Y2ng8qNBNi1a9X9xKg5iDqOmEnRmu+qIUq+a+Zg/sVUU?= =?iso-8859-1?Q?3c5BJMvtXn0o5OKUsRSdGt8vibcl5ifzCy7qpxqbyHMBqORz7kmzxQwRN5?= =?iso-8859-1?Q?WGQemWbZ1duAsSGK0oTt42breMSDfVD2dGqZOsC2ojItqIi8hxnWys4gOj?= =?iso-8859-1?Q?UEsIPKYiVDkfjDZWXsYcq+xEo0ffWIgxVR6kr7pQuq5vIQszKs6/84PUYh?= =?iso-8859-1?Q?9dCUKek5EmbLK8TVFDh4ZKRJmRZh7lCxhSaaU+s7hIUNLx3qbD9Oauf/+3?= =?iso-8859-1?Q?Q1sEXZ1LBIaxKNrwPw4/gsH+5DIaA4yQanOReXT8tRP84UVGkJ45Qag/d6?= =?iso-8859-1?Q?EzMklM59wxAtdpsqleS7PwE3RlLtDozVl1OJH8eeSGCybV7kqqbAoqmFmQ?= =?iso-8859-1?Q?UGxN8SyJJQSKpv7HoxVImgl057M+byicbwvoj97MOOqNSjcWwtRnACzdUv?= =?iso-8859-1?Q?4d0aTb8y/qj6H/o9/2+LuBsImXcgIM92usFn/FQQTE6b7mVdCRWDCcFs8L?= =?iso-8859-1?Q?XUbM+Huj+w4VKPU437uN11o6vi7wZtH02LAYS997tDiSESilS7hLfZPm5O?= =?iso-8859-1?Q?USxs/5weGMiUJdoK46YoPGLxXl5eps3wI0YaZIuaK78G+jpe5eDLwi/ONx?= =?iso-8859-1?Q?SrnWcv6Nkfnlnu2Mq6XNHL2Hud/rRdBekitKlkASyQKhhh8VTGDHIsiKNr?= =?iso-8859-1?Q?7m1O6lgPNNPH3xXSgSet46TRMPKl4ymLWDrDzQccddnpGXlGce6O99AbMq?= =?iso-8859-1?Q?6RHKk2/vUFyBA3QSvvKrMlOa++Z3G+w8CQXj4kyksVDYyfXQ4HNmjmX0l+?= =?iso-8859-1?Q?qCPHHwsNC5BZQRukEEc27C/XcSqr/7gU8ydJYnDrka1FO/4lRjDLfN1GlD?= =?iso-8859-1?Q?ZsStoAHdtu+hr2VDW4nVxvoHF3p8s9/zgWdssqs7HkGKyFXFFgk3RnroUw?= =?iso-8859-1?Q?oXLfqLws04gPiOeVjgNEpRm5Iglb0TGNqHcqpDqcSRWqtsU0a8rRwPtdMj?= =?iso-8859-1?Q?FHISDwu/3ocFbZnRVFSOvKpkkLIzcTE1xmwAjPFNXwH9ZOQ4dvwZSQBVky?= =?iso-8859-1?Q?yBaPk4+K2CxkxPwnbJaX40wBvCGTL79NCqZ9+VNmhCe1du47o5sF6wtFqO?= =?iso-8859-1?Q?D0u/FDz9VeJxp71ceiCQ0aiYviaff3JdLFqVN9mK7o/FvBcdc2+7fhzIzT?= =?iso-8859-1?Q?bvh+KUyY9Ce8b1+zWKY2jrT6ki78DWiUZkw1y//RErux8cRGuDk6gLfIFe?= =?iso-8859-1?Q?nHrsibIrsapYpqOi5CA7y9Kjz3DVoEz8mm0lRJCVzdfdgyVoBJScYMi2Qd?= =?iso-8859-1?Q?vJwyseQEk0rarPdUWHcZi6rx5efNyXvaBgYFyk6/0iFNZiy8K9QgWKqlWA?= =?iso-8859-1?Q?jGIz0ZfOeE9w9XrLzpDQAwK6tgXt5j93sZNBlqJBd/69KT?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: fkLnj46Z0mrJCTkxOpSYda7O+dd9O5buAnZPLICWz2a6ud4KAQBWoFRTSpX1RF5rDhMluyYDoTEdMPnUbVtLHxyoy+OkLQpPJMcSUhsHmqplk5d9KL7IEC88yqcwfk4jBYONyZZZPIWgqBHE/3Q1dBOkK6hzKXXuEccFZ/OlZYApwcrDUQx8SpIGdXyAWec16QBnpYDFgOgWEpSwdQDiLhEQYGxNKMCnigoGmkg33IT46ESNyLwlbAk50mf/U9gorqVZIwW0uR9R3OqTZ15DsxibS55Owk2uxfCzOPS9YS0TCK2nF3G+rdP+UK1HwYqJA3OJ6iSXPwKUoHBNXCw2gA== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 4704ea71-99eb-4596-8e9a-08de88fa2227 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2026 16:35:02.8843 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SpQWoT0lY61S7+Hd+J5JnWCJYPZUyfxLozy8gy2TOW+0zDKReqzqUbSmFReG9C8ZywAJ4qYh6ii8BCtxfrJijA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3819 X-OriginatorOrg: hpe.com X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNCBTYWx0ZWRfX45tfSZAvZq8/ 5OESe8cpW1uBluvtOCZ2Yfx782JgOUKyEPpWEGEp5ScoaoWBVXjRMAIuHqBUyinHgrc5Eyg7iSY p9x+mLWzF67eVQkLasJMvGnzsuDLSP0GKPZsRttUgYU9n05u5aQr5SclUZZPzQnZv0oTmyJW3C1 ztnkgiHoGcmIiZ72maGBlk0eaqXwl/Z+BA2xP2M4lIQJx6KvmCw+Son6RNn1leezcqce3QUYImF jZVkbxraU+95y5cgu3yP07uWOtvZMagWZMxOG2cLkDiWqy4f6DIgU3oP/H+3idr9jylP1IuTMZu yqpx8jEKjjrw9LQ1Whq0iuMI1qmHVFCSjQE3uVHoXk/2Uw9ji49s+AeZhydKnebIwYP/H4Spatz 9oKrtRmfKZjI0fz8baeUXPXK/fHrPkKKVwTV36qdQiLVGA4lsnCYFDy7aGujUk3P6iPffNXcxJt pY1ifuurtqfzKHuAyLw== X-Authority-Analysis: v=2.4 cv=eaAwvrEH c=1 sm=1 tr=0 ts=69c16bbf cx=c_pps a=UObrlqRbTUrrdMEdGJ+KZA==:117 a=UObrlqRbTUrrdMEdGJ+KZA==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=RtSn8ETxjE2H05FtM2s8:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=whyYXC9HAFXPZnEe4DQA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-GUID: bzpMAFpRZdHsKoj_rUW8i_FjKhZgLmrO X-Proofpoint-ORIG-GUID: bzpMAFpRZdHsKoj_rUW8i_FjKhZgLmrO X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 malwarescore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230124 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan The mp9945 read_byte_data, read_word_data, and mp9945_read_vout callbacks use raw i2c_smbus_write_byte_data() to set PMBUS_PAGE and raw i2c_smbus_read_word_data() to read registers. These raw page writes desynchronize the PMBus core's internal page cache: after a raw write to PMBUS_PAGE, the core still believes the previous page is selected and may skip the page-select on the next pmbus_read_word_data() call, causing reads from the wrong page. As a secondary benefit, switching to the core helpers also routes all post-probe accesses through the update_lock mutex, closing a potential race with concurrent sysfs reads. Replace the raw I2C calls with pmbus_read_word_data(), which handles page selection, page cache coherency, and locking internally. Remove the now-unnecessary manual PMBUS_PAGE writes from read_byte_data and read_word_data. The identify() function retains raw I2C because it runs during probe before pmbus_do_probe() registers the device. Fixes: 6923e2827d58 ("hwmon: (pmbus) add driver for MPS MP9945") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/mp9945.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/hwmon/pmbus/mp9945.c b/drivers/hwmon/pmbus/mp9945.c index 34822e0de812..1723ef84eb0c 100644 --- a/drivers/hwmon/pmbus/mp9945.c +++ b/drivers/hwmon/pmbus/mp9945.c @@ -43,11 +43,12 @@ struct mp9945_data { =20 #define to_mp9945_data(x) container_of(x, struct mp9945_data, info) =20 -static int mp9945_read_vout(struct i2c_client *client, struct mp9945_data = *data) +static int mp9945_read_vout(struct i2c_client *client, struct mp9945_data = *data, + int page, int phase) { int ret; =20 - ret =3D i2c_smbus_read_word_data(client, PMBUS_READ_VOUT); + ret =3D pmbus_read_word_data(client, page, phase, PMBUS_READ_VOUT); if (ret < 0) return ret; =20 @@ -73,12 +74,6 @@ static int mp9945_read_vout(struct i2c_client *client, s= truct mp9945_data *data) =20 static int mp9945_read_byte_data(struct i2c_client *client, int page, int = reg) { - int ret; - - ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); - if (ret < 0) - return ret; - switch (reg) { case PMBUS_VOUT_MODE: /* @@ -98,17 +93,13 @@ static int mp9945_read_word_data(struct i2c_client *cli= ent, int page, int phase, struct mp9945_data *data =3D to_mp9945_data(info); int ret; =20 - ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); - if (ret < 0) - return ret; - switch (reg) { case PMBUS_READ_VOUT: - ret =3D mp9945_read_vout(client, data); + ret =3D mp9945_read_vout(client, data, page, phase); break; case PMBUS_VOUT_OV_FAULT_LIMIT: case PMBUS_VOUT_UV_FAULT_LIMIT: - ret =3D i2c_smbus_read_word_data(client, reg); + ret =3D pmbus_read_word_data(client, page, phase, reg); if (ret < 0) return ret; =20 @@ -116,7 +107,7 @@ static int mp9945_read_word_data(struct i2c_client *cli= ent, int page, int phase, ret =3D DIV_ROUND_CLOSEST((ret & GENMASK(11, 0)) * 39, 20); break; case PMBUS_VOUT_UV_WARN_LIMIT: - ret =3D i2c_smbus_read_word_data(client, reg); + ret =3D pmbus_read_word_data(client, page, phase, reg); if (ret < 0) return ret; =20 --=20 2.34.1 From nobody Fri Apr 3 16:03:02 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFC483BED40; Mon, 23 Mar 2026 16:36:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283766; cv=fail; b=IO+b9w3tKu2CaiHQ/ph6Wvd9wSnyCv7+OGsB0krdsooQsVcADaVmKv03ICPiSHPjLlgaefrXDQ/TIOwEAq6d8AFHnTTfbW+tCNEYTkdBx4ObdkNSeE+CcA9H3meHziX3JGUaYvXR9xyaGJkDSMc+z0PrKGFXdpXEqNKu9j2EOI8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283766; c=relaxed/simple; bh=OrB4ExPVkLJcoBa2CX5ktTf6ib7+kHjZiZFjEkFgtdg=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=ARVHogzbn4n+86rhTB8eczPNkrn0Wxr3VHOlw2G4z0ENCKvxJCryOkHsJ7bGI9nFyXjWjRIiv1lLcRnRI05a3N2NVA2fuRbgH397bOm2+0Iw7bsl6xFvAJWxavRMwuZk0qfqw2II4Y3wDnnwf05YVIV2u1QkD0WmBJ/l8IBlrPs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=ciJY14T6; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="ciJY14T6" Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NDu4bv1613260; Mon, 23 Mar 2026 16:35:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=5z Ain0sLZhMun8yp1zh+o/N0LPF0qMWLcSmB/l6MztI=; b=ciJY14T63mFxVUGnR8 +2jTLTyc33f2cNuiKdSnaCCyQqsyEF1G7/1ciK5ojowXwaxhvuxkFXOwRlnoXiS3 IXjoznP0YPQYieo09mPpv2mY9D4l3q6dWphfhawENtmm+VO1KCxz9goQTAyAAkqE zhATgPr62kApmBEunOIDlLfkokKc0r3/ArB567ulsJuySquz/h6Q52q6SyUdCpuJ URoonUWVfCS8D7iVaBOlzfwoKrFQAhYRxpSTJULfwAB2xTpXki+q9c11fIywB5pr zwrNJmQ7VoU0Lx4OvjgSDT86js36WUkBti/OGVW1I0IhwmRmhMspLzfw3b6H/jk+ 9HPA== Received: from p1lg14878.it.hpe.com (p1lg14878.it.hpe.com [16.230.97.204]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d36uca2jh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 16:35:50 +0000 (GMT) Received: from p1wg14923.americas.hpqcorp.net (unknown [10.119.18.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14878.it.hpe.com (Postfix) with ESMTPS id 781AB295D8; Mon, 23 Mar 2026 16:35:49 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:35:29 -1200 Received: from p1wg14921.americas.hpqcorp.net (16.230.19.124) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Mon, 23 Mar 2026 04:35:29 -1200 Received: from BN1PR07CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:35:28 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hrfYZCSN+VrEmsqS1bnRDjDwgVmK7AXMlYdWb0s2ExM8YZv5LV3RlcZ3lFreN64ogvVMd+27mh2wulCHrOYAk538GrneKNKNfx4Hmsdu9YXbNW4pqwD8XMJIsjQWWiVGadwXI3Jlml9mXTAn5WhcrFfBtifFBgje/BgSVuWqdvD/KrHLGcEOggKH4OXmV5N3QgIXgkwLHzYiqQ4/sDbhxRTIkdSFoXaxTNwLJ0qs1dSD6xcG5VZsjDl2IFuT4m4lzeTMfgIddIkBONjC5z+H1I/NFtlHVaDbvWly4x553QFrhx5tlwPrv7nxEFzgSV0DeAUNm4xKY+x1nbrDOc2ohA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5zAin0sLZhMun8yp1zh+o/N0LPF0qMWLcSmB/l6MztI=; b=b3qd4u1MP1syQcm/pCJrQDmhwOOp77JO2sciGLQ+MShP0avjkDgM3hSnPZ0IJHDRyOgF+Sq8jGWqeS0f5Wp+x9pDCLxww3i1RA1moPBPwF+/HFqL8+ddsaJFfSfGH9n2NZSlecdSnKyBIz/IsgAHJ64qBvLBrW0uP0v+vmMlXA2aEFXqbiM6BhIzkKiiNEvVycMrVrCxUErznwz6f6aB8CHLAq1BLEM93v3VvkSF5Gjon98fn4FPkTwChmNKzMspkou3URQkVi4ZkMiJCHWTsRS6tRDmnxNbTCtvZREqJcoeIKOyjD/wSfr0DrjGRuRJqRjgeBJdIKQy+zVFl/MVjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by LV3PR84MB3819.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:1db::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 16:35:24 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9723.030; Mon, 23 Mar 2026 16:35:24 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "wenswang@yeah.net" , "chou.cosmo@gmail.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 4/5] hwmon: (pmbus/mp29502) Replace raw I2C calls with PMBus core API Thread-Topic: [PATCH 4/5] hwmon: (pmbus/mp29502) Replace raw I2C calls with PMBus core API Thread-Index: AQHcuuMMbjq6Jwugnk2MmLLWEpoV+g== Date: Mon, 23 Mar 2026 16:35:24 +0000 Message-ID: <20260323163343.183186-5-sanman.pradhan@hpe.com> References: <20260323163343.183186-1-sanman.pradhan@hpe.com> In-Reply-To: <20260323163343.183186-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|LV3PR84MB3819:EE_ x-ms-office365-filtering-correlation-id: 0abfc746-a78b-42df-4181-08de88fa2ef4 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: 0mVI5ISujf5DIAp3HHgtIRt+vLPcp6r8AXTiC+WoJN9f9xMraboJ2YOZvsds1fGuorsPgz1cqpyI5MKWzh6O+b9WEDSkd4FN95iZblyWJGjQ23ozcq5KQjpWkCY+mEmZ5H8uJOUSYBllcTr2Vaxhy2fJb8M3FAiWlfnhF0I1f8IKWaFDVDgF2b67rOLiZxGSzTTf5ArDHPjDgzdwPPiMrGTHd7f36lAw2eojJA1q9dZyN9VZQFSSwURlfNtPYAXEorez4i+FhkuNaq5h1YTsMwyT9B+5y0JWR4YRYsmlGhxfq3jpbeRBuBJykSIUjF80GgrvAHLWEviGebW3w+mKsVl5vbFEJvCr4JkttaRojYgNXJ5khQNvzRQr0zNn7Kv+id1HMyVg6qzZb7HN5lq9PmJkTi+TvGlWR/Lx9T9TJtLTq8CCmdaCFsDZc4Wwyj8kBO/4mwwu0f8vPlQVGHvzmI3wUeppv/fNqsIz3X5+AFOGabPNbfQlhsjd2ZJLJgca+rC5Gfp6oOaU2N7Ajzl8cqfidlOqk1ACkv/eKh053oNqpmZyFqdNiHyzraighPIMr2Fm8qZ0Sj0U6B2XybbP9TIwulrokCR2+wwk62n8EmwlntZBDBpYiEEY9vMDAPcBHyC4lJ2GtF9onxIB5oKC6m6DQ4cM5ATgV3Bk/Fq5Rat3W5a++tE3EKtajqIDOu031a5k1YoPEM29EsOMjj1dEt5WQHhrmkSPp5q/onSv0ZUl9+dXxQO6T+EL7SaoPpceMdhZTXT+jTiDKOnj4GMgFOREZtKjEMYZQTyeI0h+WPk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?E4e+ktxPfHk8YWoud9oXdTHdktvRhkDW6hsWxbS+93i8xXxt38abUgBjKu?= =?iso-8859-1?Q?m3z/mno+iY7j6BWEPuqOc576GNoqvg//EjVkcUwXVzC+EhIvIqJU/1rF/8?= =?iso-8859-1?Q?hr+reWDhV4MIvZWv00lqFxBWTJu3r18hDgeAWtDyQIXw3EBaWFm461JP4J?= =?iso-8859-1?Q?nKsnmp9yO1jrBiGAFFPYuEVsjOZGhr2qkH+pZvEskeMVHIihrY3OYM/g/e?= =?iso-8859-1?Q?HyPdBFRbaXfwDMCwqHMPZcYbr2u+M1VRflEf873QNGWCH/f9qEZCSOoJyQ?= =?iso-8859-1?Q?DQJgXM/8OA6GATZTjWtYUWRoo3LgtFCbeK3NOc075BTSdvcPzRX2i9zlx5?= =?iso-8859-1?Q?HBIHuUkbrC3WzdiLmhrnenqoY40HDYwTYKu8NJltVIa40iXnOJQUwD3rQo?= =?iso-8859-1?Q?7G2loMzqN3z9dL0/unwb2cWGCt04Nbk8bzFDt4Zx6k15wiPSnQ8Khyk9cC?= =?iso-8859-1?Q?X/RbxDfQwMbn1EpcZL7uqWVZwDsxixloWv5yJz6eGbfbHrXU8Y86zpwHRM?= =?iso-8859-1?Q?rVP0DnLP30OXNMOk+WVQxI3sPKXAY5GDo2n7nAClkFIoNVzVOFstHYST97?= =?iso-8859-1?Q?kPOojd22epz/UGJGCuJtqw+KPR5r/L5T6018yySsACHveOxjFI4RfUg209?= =?iso-8859-1?Q?ln7HwP6doBcAVDv0E098YA90+1jbVXjxkdpeK2SavdVzpHfTTnr+aZj9Hh?= =?iso-8859-1?Q?j6Bjt3blhPm2PDak+afoYSBBKd7kDgpZbyaw8/bI1c3jhrbVp5D29uWFbe?= =?iso-8859-1?Q?YdobivTQbVYhhLr7sfRYZHXyfuNb0khb9pLBGhQT3+j6itQwBqkqTCe0fM?= =?iso-8859-1?Q?m999gHaF35ykTVun+JXNkg48GfS62YoYpaXuu1OOONn3sSa07rvvSlPq1g?= =?iso-8859-1?Q?wl804zQzi/3GLAAsYRSg+aoOiTJ+SGYltiTLA3iVa1KIKTKa+u1EzH6PRk?= =?iso-8859-1?Q?rOuGAKOnYHxuK4iNiZuPTgPik2Z8Lzg6eY3l9dIGFQW7dpValiOjrDdXyC?= =?iso-8859-1?Q?48jXGJHaPylG4nF8pdLUVh22+ArRKrgUruZW3QoyA9W6GjD/F2lFg35yuC?= =?iso-8859-1?Q?oii7Ixsc558wdCoh+XgBKt4lnSBLqMWSFEbA8HSaOS047iqBszLua0HBcg?= =?iso-8859-1?Q?vzXf9/CcTlGERhyGPK4rRtTMu7jl6IY6RNLLCTu1LJR/D6AGdMwBGKDI6w?= =?iso-8859-1?Q?y/1+xOklqwhOv9a3gT4W/h5Gw3iSDzbpgy5/OsBVXvdBk+IoSTbjuAT/VT?= =?iso-8859-1?Q?6rDEAdr9SqUtGMcPeTAjxZkumdk8BilrNTTL7u0495mp/FLSxBh5+XEfR7?= =?iso-8859-1?Q?2OzDZRDKyzbjTMXAdbr7LYFV0Mil6Vjr8Y51jcBORwyHxrAJca6dbt/pXF?= =?iso-8859-1?Q?3R5x4BaUNMbjfTTBEeCOdgRyeVptUu/lBw5G3JRqNk1iyODOT3lcsIQTfS?= =?iso-8859-1?Q?Fb1X4lYEjQUzQ7+71OU0/UqYdZgLr5zbbhbTcM3fUbjGZ6Pv8FxhU3aKM0?= =?iso-8859-1?Q?vab6lbDHYp31Mb8xNdG/0tsVKxPioamPFC1FD2QpY/On7XN+pxHPHqELsP?= =?iso-8859-1?Q?yzCsNU4ykUE6CU8vbHv1o75m0DscHiZbNd+vA294bdV8mXx4iyMR41a/g5?= =?iso-8859-1?Q?t/S39+Rm40JNMb/hL9zUNI8YcI7fMWfQnkZV0L3UPVogPpk3NwAUBDtEdJ?= =?iso-8859-1?Q?mFBpximZmj4+3FvDwzdu/Y4FroEBb4bqbArmoixx7fxzbuU8HLN+I94PNc?= =?iso-8859-1?Q?2K4OArx5rgHSySIl/JQL/YwwiJPjQxKh6oj1Yw0Q0EokFY?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: hiyPit2swqXxsqLdpYxgNllTMowJOGb/ZnhMMAm/AD82Q8AAPXduRmiGiAuT+W1cD3Lj4VRdYxTtJmrsw9y/Jn/9rbP7viFnW73ss7nUYtWKwcqgzrMLBLQ16Us7YPH4Z5w9wt99YQHKqkgWTsEKBzBJDlC7XSdEZknx5PsQ35ZxPgrYJB7YmwUpjioFolga+QWKYxcQfB+20TY1oIbFH4ATraHiT8fjrSURZYkAMXu7U8Yl4IoQXyT/ZZUtLgM0RXOU8y8fQz3tmVvzfKy/d5OCX1g1K/qXcUbXojLsGmO5BOF7O7BPA5xe4npL9VUOT23T3t6nAIHPcwfLyhhYgA== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 0abfc746-a78b-42df-4181-08de88fa2ef4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2026 16:35:24.3671 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ysZLO1HcBvw0TJ86w4xaTSFNHXENDw5MJhBMShZqEJTMiDcRGz0DbOrT1B3YJSA76LoAu7f4e6OcmWOICDnj8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3819 X-OriginatorOrg: hpe.com X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNCBTYWx0ZWRfX2RIzxcGPnNqd 29+WyPpnBd8164kpZ+1t3wpMaDOGS1xkIzDc7Gzwi6qkKA01KqfPek5WvlQvxVeY3SIWLsi9iZT I0XYsyYhlXpYpoBBUvHtVztRD9x0ML/tp7uD6BVF6R0Dbq1z2bBD/TDc3WwFtGl5t1QgI3stdyl ZgomcAkdC8sjp9Mg/ep7x/6HS7Nx4zbgdB9BE3xG2PgzdHFlBs0crq9ZTVvSHwKpSoz1lxh1AQ1 ZjW4wVQP53H/cpWvnxabHMswLgRckd4ig/VtA5hmQbQJy6pyjch52JVn1B6HgtrZlqkr7J5bgIP b1vjNW3f1OVpKyBWJWTHf9xUlIqF9wCPdDj0Myi6PtXrCC7X7nMK5wtnC1e9EEG2rbM1nvWSQdL KfbFFSsXafq++suGRewk/yY6P8DNpR72KyjEdHBaEKPy1lf/RL4Sz7DziQGiXpuQA/0rrsGDt8O 2cph2gZnfyFOjwx46Vg== X-Proofpoint-ORIG-GUID: 8VOyk9GucQqWQGClqcGAbn5ghZ3SVWrk X-Proofpoint-GUID: 8VOyk9GucQqWQGClqcGAbn5ghZ3SVWrk X-Authority-Analysis: v=2.4 cv=KpdAGGWN c=1 sm=1 tr=0 ts=69c16be6 cx=c_pps a=UObrlqRbTUrrdMEdGJ+KZA==:117 a=UObrlqRbTUrrdMEdGJ+KZA==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=ZSrvDirOKP4VPF05hnFf:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=0ch_ZG7wXMlDUe8ALHQA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 clxscore=1015 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230124 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan The mp29502 read_byte_data, read_vout_ov_limit, write_vout_ov_limit, and write_word_data callbacks use raw i2c_smbus_write_byte_data() to set PMBUS_PAGE and raw i2c_smbus_read/write_word_data() for register access. These raw page writes desynchronize the PMBus core's internal page cache: after a raw write to PMBUS_PAGE, the core still believes the previous page is selected and may skip the page-select on the next pmbus_read_word_data() call, reading from the wrong page. As a secondary benefit, switching to the core helpers also routes all post-probe accesses through the update_lock mutex, closing a potential race with concurrent sysfs reads. Replace the raw I2C calls in read_vout_ov_limit and write_vout_ov_limit with pmbus_read_word_data(client, 1, 0xff, reg) and pmbus_write_word_data(client, 1, reg, word), which handle page selection, page cache coherency, and locking internally. Page 1 is selected explicitly as the OV limit registers reside on page 1 per the datasheet; the phase argument 0xff indicates phase is not applicable. Remove the manual PMBUS_PAGE writes from read_byte_data and write_word_data, and simplify read_byte_data to use direct returns. Fixes: 90bad684e9ac ("hwmon: add MP29502 driver") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/mp29502.c | 68 +++++++++-------------------------- 1 file changed, 17 insertions(+), 51 deletions(-) diff --git a/drivers/hwmon/pmbus/mp29502.c b/drivers/hwmon/pmbus/mp29502.c index 1457809aa7e4..aef9d957bdf1 100644 --- a/drivers/hwmon/pmbus/mp29502.c +++ b/drivers/hwmon/pmbus/mp29502.c @@ -210,31 +210,18 @@ mp29502_identify_iout_scale(struct i2c_client *client= , struct pmbus_driver_info static int mp29502_read_vout_ov_limit(struct i2c_client *client, struct mp= 29502_data *data) { int ret; - int ov_value; =20 /* - * This is because the vout ov fault limit value comes from - * page1 MFR_TSNS_FLT_SET reg, and other telemetry and limit - * value comes from page0 reg. So the page should be set to - * 0 after the reading of vout ov limit. + * The vout ov fault limit value comes from page 1 + * MFR_TSNS_FLT_SET register. */ - ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 1); + ret =3D pmbus_read_word_data(client, 1, 0xff, MFR_TSNS_FLT_SET); if (ret < 0) return ret; =20 - ret =3D i2c_smbus_read_word_data(client, MFR_TSNS_FLT_SET); - if (ret < 0) - return ret; - - ov_value =3D DIV_ROUND_CLOSEST(FIELD_GET(GENMASK(12, 7), ret) * - MP28502_VOUT_OV_GAIN * MP28502_VOUT_OV_SCALE, - data->ovp_div); - - ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); - if (ret < 0) - return ret; - - return ov_value; + return DIV_ROUND_CLOSEST(FIELD_GET(GENMASK(12, 7), ret) * + MP28502_VOUT_OV_GAIN * MP28502_VOUT_OV_SCALE, + data->ovp_div); } =20 static int mp29502_write_vout_ov_limit(struct i2c_client *client, u16 word, @@ -243,46 +230,29 @@ static int mp29502_write_vout_ov_limit(struct i2c_cli= ent *client, u16 word, int ret; =20 /* - * This is because the vout ov fault limit value comes from - * page1 MFR_TSNS_FLT_SET reg, and other telemetry and limit - * value comes from page0 reg. So the page should be set to - * 0 after the writing of vout ov limit. + * The vout ov fault limit value is in page 1 + * MFR_TSNS_FLT_SET register. */ - ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 1); - if (ret < 0) - return ret; - - ret =3D i2c_smbus_read_word_data(client, MFR_TSNS_FLT_SET); + ret =3D pmbus_read_word_data(client, 1, 0xff, MFR_TSNS_FLT_SET); if (ret < 0) return ret; =20 - ret =3D i2c_smbus_write_word_data(client, MFR_TSNS_FLT_SET, - (ret & ~GENMASK(12, 7)) | - FIELD_PREP(GENMASK(12, 7), - DIV_ROUND_CLOSEST(word * data->ovp_div, - MP28502_VOUT_OV_GAIN * MP28502_VOUT_OV_SCALE))); - - return i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); + return pmbus_write_word_data(client, 1, MFR_TSNS_FLT_SET, + (ret & ~GENMASK(12, 7)) | + FIELD_PREP(GENMASK(12, 7), + DIV_ROUND_CLOSEST(word * data->ovp_div, + MP28502_VOUT_OV_GAIN * + MP28502_VOUT_OV_SCALE))); } =20 static int mp29502_read_byte_data(struct i2c_client *client, int page, int= reg) { - int ret; - - ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); - if (ret < 0) - return ret; - switch (reg) { case PMBUS_VOUT_MODE: - ret =3D PB_VOUT_MODE_DIRECT; - break; + return PB_VOUT_MODE_DIRECT; default: - ret =3D -ENODATA; - break; + return -ENODATA; } - - return ret; } =20 static int mp29502_read_word_data(struct i2c_client *client, int page, @@ -470,10 +440,6 @@ static int mp29502_write_word_data(struct i2c_client *= client, int page, int reg, struct mp29502_data *data =3D to_mp29502_data(info); int ret; =20 - ret =3D i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0); - if (ret < 0) - return ret; - switch (reg) { case PMBUS_VIN_OV_FAULT_LIMIT: /* --=20 2.34.1 From nobody Fri Apr 3 16:03:02 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A57C3B9DA5; Mon, 23 Mar 2026 16:36:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283768; cv=fail; b=Cs8/zg74GoPYAb7jc4+/+bUmQNiJ6r7mL2yMF76u/sTUvBEuz/+D9OeR4jCNLAzWtpvvCKC7e5k8vmxGp+8Vr7UGYvVqpSL5DIE2ntLdOHu9Nd1E9nffquDpAHROcxn6LPOVifXHFt39Y8yNSsyb27A7BJQOf5WDPfzOUhc3po8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283768; c=relaxed/simple; bh=ueq744gXwBAlEmfr2g6Sfwduq9vaD8rICAI6HHx2HSo=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=G1QYRuKLRa5jrZK/WpzTxSHRz70yE672GVlpE+RzlcKCuMhmCS4ViF699CQF+yWsBhqh59ILqybnuDx+XCSWcU87WTgH/uaDKphFfL/PKP6WyOonMFLz8u1bCtLjHAxTge75PNQKFiWk9TskvYWcKubfl1TftOwa/q4aF5Sze2o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=lFZ0LcK0; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="lFZ0LcK0" Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NGX9pL2896540; Mon, 23 Mar 2026 16:35:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=tK QpusM7YEjdVOQ6Wp+tE1ffBnIbM0UdY/ZbgKwY8FY=; b=lFZ0LcK0GomGl/iBcH 0XuyyAaH9y8GTdx9E6wWVBZeTIJG0wfyC2uA6l2xDYSFaL7+N4zPQQwUSp7OhqkY RjnRF/y8dQHPUT1/QLbgdriDmxE5uWvV85VsWeiwHBgIH+GEkXJ+CbsmZGIjJDMM 0aJ8MsN9tCkynLjbB8wqhwAacqzobE0UNxIXBPPFasJ/fBlCVykFqPf6GpXAutjs kgOkEW+f6RmmGgco4POx0nCPNAKIBy8eQu2bEMpfZ6aQI6EjuA8hUU7M2uRED/oE gCPcEL54uc68mNdjZ/AJ9EYj3KJt7IclcEna00INRXCXSfoNG2tPSsiil3h5l0hj Wb/w== Received: from p1lg14878.it.hpe.com (p1lg14878.it.hpe.com [16.230.97.204]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d31arxh3a-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 16:35:51 +0000 (GMT) Received: from p1wg14923.americas.hpqcorp.net (unknown [10.119.18.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14878.it.hpe.com (Postfix) with ESMTPS id 3A775295F9; Mon, 23 Mar 2026 16:35:50 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:35:42 -1200 Received: from p1wg14924.americas.hpqcorp.net (10.119.18.113) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:35:41 -1200 Received: from p1wg14920.americas.hpqcorp.net (16.230.19.123) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Mon, 23 Mar 2026 04:35:41 -1200 Received: from BN1PR07CU003.outbound.protection.outlook.com (192.58.206.38) by edge.it.hpe.com (16.230.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 23 Mar 2026 04:35:35 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hrZfkHFD1KVYpBqB4QdHTOjfy7k1fcRpRwYUHmMs+EQ3JaYuakJW9qmnlCxjYNUC7u8Mn81ioeu2irhskfSjWSh7zDtcYpRiiit3fllnT1bbrH7RQS4Gso5yB9y+V00IcefnD7lL6NgL2xVLMH44VbJQ7kCgv6ZEEHeI2WdTck8lrC2YF/nMbSFG6rZfGWUOXsySMH5n7oU8nXxCOnG80/qqAckPs0LwIBnGlT8x1yazRIdQuvQ6k+F/YIEF/Jq+I1hZt1ns1Cfc+XPTbcq6t2/FLbhZOnMT7mEh32/WMYhERV9qNEfb+u9lxHN940KhtvDTcnyM0jSkVZHTpTrJrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tKQpusM7YEjdVOQ6Wp+tE1ffBnIbM0UdY/ZbgKwY8FY=; b=QML39krw48hCMzVTWJxbVKeATsmeKeD700uRyQmpNpsmrZr0WAmY2CP9XiK4vPmnSbcuTk2dVnYsR3l1x9ORhvqYE/IZvirPRm4jvUK9XZ5D3abr3gp5eEjyW7SR0BKXgP5pEkVjfZxubnIv78IlC98FPVGbJyj0Qx8bK5j8U/65oHcMkgDgFJIXm9eK562zE4M887RK01zb7o5qyBLzxs0JXYSpY+GhfH+jCcOWiwAvf5B7jdS/QTpxQEaOqN0DdO6KpJQIFHTpJoj3KuYMNpKoXwhbrVKul99iPwTpyelBZfa81qJZ5YeoXgvlXAj+ICY0ljLdYkMbSNvxgWJOhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by LV3PR84MB3819.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:408:1db::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 16:35:33 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9723.030; Mon, 23 Mar 2026 16:35:33 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "wenswang@yeah.net" , "chou.cosmo@gmail.com" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 5/5] hwmon: (pmbus/mp29502) Prevent division by zero from hardware register Thread-Topic: [PATCH 5/5] hwmon: (pmbus/mp29502) Prevent division by zero from hardware register Thread-Index: AQHcuuMRWhDKDR0640+5hvolKJhuMA== Date: Mon, 23 Mar 2026 16:35:33 +0000 Message-ID: <20260323163343.183186-6-sanman.pradhan@hpe.com> References: <20260323163343.183186-1-sanman.pradhan@hpe.com> In-Reply-To: <20260323163343.183186-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|LV3PR84MB3819:EE_ x-ms-office365-filtering-correlation-id: e9174a3f-0e75-4149-1a7a-08de88fa3450 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700021|22082099003|56012099003|18002099003; x-microsoft-antispam-message-info: UtjrBEKNUFMrL7pziQUdPP/K/h5zrIIk7jckyExSZjxgKWWBLOBJQZNwZ4/qkrpidyGP9fgZL/xun3lrFmpVJRwaKEODkGcEPbcnbVBVbatsD7PeY/KX9+RskEOz2Dk5SOs4/DUD2JeATw055qvBeFi1pYcxDJEdubp7rNU2s/BDCpLpnvY4HJ902WJm9fsMQrv21RegIRVM5h1EvFr3Xb9p+SjTpvy5n9W54VN4lnRDiJh5Dy0m91xdQj/DfqQpjuBRSBlgzDhouyZY+PJJvbSm0nX7aOze8DdjCOTFQtXxYfjAosjCDSPVtqn6NxgaGSwOL56whcWcl5+tgho3DjgMQXHya5BiFFav6q7TfDR93Yg5vpLh1rCdaYGtbo1+4+DYxn5R2vpNSIRYkLWVZkAbs4S1/Ioa/ZYCqy4mktCHqE7eVKsd1qVSW9TvrIkutiD4sUA01o5DG2RiJ/Q9V9Z6chDnOz6LNASSwAobm/bZ45A3lKZJynU04eX32qQJiFgiler2CZB8XrlKcfy0TzYzs+8eAq+0iCA4S3O5Xxry9BcjVecFJaQE+5AAhuquED4r8YMaEWrWef3kJMR9O8RkfN5eWs3MnbK1ZfWq01UZHNvz3lGmmUgBxDBpDPjQ+f57jcjDKPNEq3/KDtLZGK/KEElwcaW0xkR0j4lFnqd4D9MxuZ7KGjEQ9QrVERi5JNWT4a54Cp0H9lG2Oolq9hG26oeoABkkV6z/BcpMQRe2cCqc+OWCE49iIp9gYIO/KMZHBSOawi1cFC3R+k3Bhr9ZritYWx2zXk3j50RjCrw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700021)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Ms5UVrwqh12o5zN/8dt0TA8EtGhk8b+LHtzIcehxWddmHqhWA3WeS941Yy?= =?iso-8859-1?Q?tiTS12/df4DpeeMgv+LYB1BbetbNo+umr190oF7c5wupcZDvTp9iegolPm?= =?iso-8859-1?Q?MuSpJ7HbI5PIkU8GNaunav4bcRSAcO+j80mBX9c3rjgGF7BLTTnNoEugqF?= =?iso-8859-1?Q?P+HiKcffTDGXB0aPKHZwTG23EOXGi3ueSUOpSNdCj6auJtMPBzsZZwAlcA?= =?iso-8859-1?Q?A1Ejc4WBLdrIfHXFwevLrVi5qPwb6ESx4iS/6nnljQP0she/1P87aHDIdk?= =?iso-8859-1?Q?FlxMbLRvilO8JH9UzKugS/wnqntTt13m5NGQwV4GDlKaVzr2gEmgI8djUQ?= =?iso-8859-1?Q?6tYOoRD6/UBQrdaChuqUhL5HNVB16bt7lFV5X/fEkgGGcubWrwko5HHIrQ?= =?iso-8859-1?Q?37WXpkIy33v5DOJwOM3CjH39dePqZsH6WFXerpfxnXDHIt7O3RuCnbvGlB?= =?iso-8859-1?Q?Ue43KCtGMcoDwSDiNNbaXxjOljwdY3NVoSsvRrUaVYffHvSVyB+l2RIpUa?= =?iso-8859-1?Q?v2MsBDnA33zwA9KzWW2BLMIouw9YnAt/W/3aZX76qLeNvfHINNp+7n83n8?= =?iso-8859-1?Q?QsmCGvyQSZxcZRKvzlx5vW6JYgqE3sVDu/oPa+T7b0oZ09MZOsQmT9MnOI?= =?iso-8859-1?Q?pE6OuFOT4ns89fUwwQv//bzsgkfMkDmOFX8Qm8DsCW2NSoZz+g2tYy1D/H?= =?iso-8859-1?Q?VSzoIhvYw1Jyg4h9DawLySXP+ZDqqJ8Z7341d+zriDtSlJMNriyj75Bk0j?= =?iso-8859-1?Q?oAvuJeqnj3b4U3jHzEADkb6CzHydd5IUHXBYMj6dZKIeHJQgfuxHU/rIag?= =?iso-8859-1?Q?74DMP7M+RQHEi7K5eBqckBvhJX+VarmXRMUmXM1HVMvNjZyE5wh2Zn3fHx?= =?iso-8859-1?Q?HHqnxXkVxQ72uZGCe2StmT5/efV15Gk4hZPQnPLgULPHqsJJr1q+/3A7xf?= =?iso-8859-1?Q?A1OiKyhp7Ng2/2Z30MI07WezAiaKv7U3KKmf0aWMvJDfCDlqVVl0y7ZIAY?= =?iso-8859-1?Q?1JlpFv1E3iBjhYcJd67gkUH36zwHjk7WSVAfyNqlIwVV/+dTZ9bBkHxNyb?= =?iso-8859-1?Q?jefs2njbg6FiIO35zueqlUNPT5GAXP/g1AkqOP6kUzMduJHWoW37NHHwJ2?= =?iso-8859-1?Q?/33GmCfGlrD2/1StJAcLbQdQrmx3qNbnLeOSLXp6LZT1U8macDDxMF1UFM?= =?iso-8859-1?Q?DqGPinQlDRq+Arfc+YEMsdev2r5fU9ttl/DyzShAX2UiBld15ehD5NIap7?= =?iso-8859-1?Q?Bc2viVE1xmF0AyFvfLk7nAL5NFCtvaz9GApZkiycBnNFEzC048tb8z8qNI?= =?iso-8859-1?Q?oKgUH8bpqtcqurBVPwc+RoFSUlY34tatcr8WqurqvbZMxlfn2Z8stP7E5P?= =?iso-8859-1?Q?4rFrhSUuCXq7QGPdg4FUjwRXU6OzTnv1r1bWmoXchXaJBdJSk89rDeWjh/?= =?iso-8859-1?Q?cYrNPcdK8wVY9AGp+JWRQkulqkOBDyY/KkGj7lhxjOW+tWyHI43IF4nYYY?= =?iso-8859-1?Q?RZBdD49V6VkU30eI7zFBFZKqA+UyYtemVtbp4fBS553SilGDHXl2kbgPgW?= =?iso-8859-1?Q?NZ4lcBsvyatdv5mWTAZ2lShDbDTsS0RNQ16PEY8BI0emQSOloDBLtW6o7N?= =?iso-8859-1?Q?e4yxEDUyHWERR9lEJyuZEAUJzxsGwSktHCKOfbOmhYwkPL0XFim/XCigx6?= =?iso-8859-1?Q?Tub0B7bcyDOONpqnzOHj+UfEXsdvNyM0SAHyL2IMvLXQ2fPhdq/g+nczZG?= =?iso-8859-1?Q?ILy4Iros3H9/qFEpNSfMrqKAHvj9OhMACNvyG92hDVmfeP?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: t+jsNGXP0JCNzhazOhqxEXpSe+BbMYOzJJ6G+PyoMjahxu1XvZyRXj43TOAW66IgczYEqNZcTiRvBE7Rr8tLKfPNDxYz6lI9Fi84g/cvFoieaiy8Ib6LVrsXBaMxAttQPVEqPNtTuzrIYUAQfOOpkgKDinAJAMyyq4KhIg+GiorTkFmAZRnSirS0qYNyLFi1g+7LplflWDH31Po/hrw240XBFJcR1Cz+UHDR9Jlc9NdU3W91fGatrXiPwSlpl/OfHg2P8Yz0ci6njve+gg1BmWcIRyaRTNNniTDDr+CWBA+fHFhdzc2V1q+gLZ+3FstJNcq9sKMURrG76wt3L8x1sg== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: e9174a3f-0e75-4149-1a7a-08de88fa3450 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2026 16:35:33.3637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4+4OsPqdE2utz55ApkhmdnxzAbGw/MN8Xlaa6mmvfxgeyBMNdIvpFKNMmTxUlJhXcQOm0NjWWNc5gY8e5yFyeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR84MB3819 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: uJpN1u3-Lo7Id9R0jNH1SksZlz8vFq2d X-Authority-Analysis: v=2.4 cv=IcyKmGqa c=1 sm=1 tr=0 ts=69c16be7 cx=c_pps a=UObrlqRbTUrrdMEdGJ+KZA==:117 a=UObrlqRbTUrrdMEdGJ+KZA==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=6XKncaru_qjgLvANlS_8:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=oWjv0WD8qUs_733JoPwA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNCBTYWx0ZWRfX3s+1NgsQp6x4 kARb77MSKOV9ZN632u+4hjzQGncEy2KzAakyN5xuT3yG+XgrHImhwd5YRxOVKnA8QWQ4Cq+7Yra +pe6nuctTO0mE/2AWrkWJXvJLPPNgJhPeqPh644wMy/+fUDsdCxSt5Rwq54b8gd7nv/+Tt6bTFW cyJL0n/mza5hmmiupHvSY4lRk+FRuVit6KHHlIK0wxWmjyQnSDUsdBQhyG5GnrWSoYoRj12VkIf 8NR5znFXBlQjZsyXbDAdpyXjHK07LdZipDeg8zUbIW5XohJxB3+GdxpeU4K2cEQS9uX9y1WOpWd wbX3tUKTQt+7VSeoTMJwkDniN16DsTtFc6rxQWGlRZE32zOCgOkvVHZM/4Adk0ltUAEQYlghYXZ Qvre12xecREfAJpfHOgAsHgigAq7jAyUgzMpmWHGv4j2IqccVDh7/4MjoWImMscRVXXgiVE8mCk 235NGqJIex71XCVPjfA== X-Proofpoint-GUID: uJpN1u3-Lo7Id9R0jNH1SksZlz8vFq2d X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230124 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan mp29502_identify_vout_divider() and mp29502_identify_ovp_divider() read divider values from hardware registers (MFR_VOUT_PROT1 bits [11:0] and MFR_SLOPE_CNT_SET bits [9:0]) into data->vout_bottom_div and data->ovp_div respectively. These divisors are used in DIV_ROUND_CLOSEST() calculations across multiple read and write paths: vout_bottom_div feeds the PMBUS_READ_VOUT, PMBUS_READ_POUT, and PMBUS_VOUT_UV_FAULT_LIMIT handlers in addition to the OV-limit helpers, while ovp_div is used in mp29502_read_vout_ov_limit() and mp29502_write_vout_ov_limit(). If the hardware returns zero for either field, a division-by-zero exception occurs at runtime. Add zero-value guards that return -EINVAL when a divisor is zero, indicating the hardware returned an invalid configuration. This causes probe to fail gracefully rather than crashing with a divide exception. Fixes: 90bad684e9ac ("hwmon: add MP29502 driver") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/pmbus/mp29502.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hwmon/pmbus/mp29502.c b/drivers/hwmon/pmbus/mp29502.c index aef9d957bdf1..bbcf018e5d05 100644 --- a/drivers/hwmon/pmbus/mp29502.c +++ b/drivers/hwmon/pmbus/mp29502.c @@ -134,6 +134,8 @@ mp29502_identify_vout_divider(struct i2c_client *client= , struct pmbus_driver_inf return ret; =20 data->vout_bottom_div =3D FIELD_GET(GENMASK(11, 0), ret); + if (!data->vout_bottom_div) + return -EINVAL; =20 ret =3D i2c_smbus_read_word_data(client, MFR_VOUT_PROT2); if (ret < 0) @@ -160,6 +162,8 @@ mp29502_identify_ovp_divider(struct i2c_client *client,= struct pmbus_driver_info return ret; =20 data->ovp_div =3D FIELD_GET(GENMASK(9, 0), ret); + if (!data->ovp_div) + return -EINVAL; =20 return 0; } --=20 2.34.1