From nobody Fri Apr 3 16:01:27 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE8993BE634 for ; Mon, 23 Mar 2026 16:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283364; cv=none; b=E5LzlHdwibQ0+OZ2w7QfNVpQMD0nEAKaQPEKMfny4sJnBfZ3aIIiYzeG7e8NnVOZAcFFR+n51frqAD+oX7G4qj4A/vBCkZMMzBsYQlJ0szoGjwCI2KBtiTvRlFIt77e33YacNhsufV9ZzpvBEiGI4uE90wOJrLbUbBqXvzrAkcs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774283364; c=relaxed/simple; bh=34e+LQKJEw7JRxljLgIJ0WsY3yL1y0iL2JAVsmCdc6k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=VSSQTzo70+dALh3QobMMTZS90z40JPSResuRJIHcE6kP/gCKEhHjVfmoYJU9ha0Oulz8hJr9hjt3tOHOiLNH9PhgvnZdkz9rXVBdyW/cZVzja4EWsQ6spT5yT8CcYMixnh4iQAKMkK3x0b0CaGcIXKwQs7AX9SJC3/179P30QjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zn42NBjU; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zn42NBjU" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82c20f1e890so2161086b3a.3 for ; Mon, 23 Mar 2026 09:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774283361; x=1774888161; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DEzBe1NN78BfdAo1/VcgiKXD8axm/NYlT83UKa0Ybh8=; b=Zn42NBjUekrqBzShdw/ppi4CmFCowNsRxBm8nW7yZy76Dh0hxu0Tz/S+wLl0Eev9fg gDHODo7L7Rl8e8MtdQghiOAwBfGw+Zd5d0x9MH5/lMw2nTlf6KbCK4xYvjfsSudK1zfN cv+0qskvtt1B7+gkb5itZVK7gKebcShJKJO3Jl1HLE2aebkdabrdTfDcnZzc281ddWPe 1j4ShcfbPMLURiaihhc/MO6V5Uynz7dXuhO+K6XBt0OWKcSyOBjNaeHZTKfZS01/CVow l/fw3ZD0GwDKIuOa74F6PD+WastVjd1hWpmqIcPU2dKZXYUv/DyTSqeFyKMa2L8HcwvO 9FAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774283361; x=1774888161; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DEzBe1NN78BfdAo1/VcgiKXD8axm/NYlT83UKa0Ybh8=; b=ICyOxFxGDxjkeIlu+ngLEDTcglz+VoI4YXyi9sBH+foPkMHQaQ0WXKJDuagKvZ/Q4X B/5c50S2+UL6MYwMGEPr+yfwhN2mw8sccQzfYO8a3IwKKV05DEahxmUNz8XU0wW06Gty 3c19/6pjQB8gHNQjKuGcgjb+6VEEjolyi9LIbRxJzrJmWWMsqViVeq+jEJyd9lL7ucqW re9C8EdiEgzwQK7Qa9Nmvbs8dEfsbC0vKe2KAgErlDViv9WOgPARR8buRvUmpAqfjW+P diHfCdyJZu0c9zEeM1nqx5KRhJDmptGHCLFkVk8FR+NHW2oG+ujxkUTv3mLWuWdeEQch vDvA== X-Forwarded-Encrypted: i=1; AJvYcCWAQ2tqJ7YLcAfEcExolsdRZndY1ikfSwOkrtHvB4D4LeX/buEKlEvR6MzGuqh/xAZ+pUAf9BNdzENP3bs=@vger.kernel.org X-Gm-Message-State: AOJu0YxnMNppExVWpXeDFYIXnPpEwO7gtyUHpo5lvG8is+ZlN6bG5OtB EdLpnTU46TcGsAQrwkZpb7gj9KJxKeG+/A99Y5JTaHguH6buTGmYWb2L X-Gm-Gg: ATEYQzywTItgSopcQ1ctISIoyl9l5OsE59Y//PXUD9K+b94iGNSMzVHrRNZUr1NYD8K RzjAfo5O1xtZ2ZBgcx7METDQiekpUSWdc7i1N4NQmHgadTkSBnsvkHENoeOt4CT6UMmSL6KgsLh 9ZfgO5rESvaC07bCrWJT+YWSqSIStTVwmx33wdAK77hZwOGO2XxxugmgwB82jlDa5A0L61o/O0f 8eHLIlQvSE3LLTSs3rY1SJgY8cjvZIQFHfAZFfPfDKStgszT3Q7Svwi4zak5dkTi8TmRsnuXtvX I+Yppt2dI6+BrUsfpNL2etmLGGGE+LRigSVLy9ul828IuhpxeMFXgIfYLPE2tcSP3D83YMmH1af FsYG8NAerN/IhGOlK4loAOWD67FTCIZ4ajlok3RiHdmhSarxs2vz6IFGTcbCF/fnvKL9BcNgXr+ FzllywEhrvxiC84m09idG6GEs7x6NIDFThLDd8jAos X-Received: by 2002:a05:6a00:2d29:b0:82c:28de:fa26 with SMTP id d2e1a72fcca58-82c28defcd5mr8120561b3a.36.1774283360922; Mon, 23 Mar 2026 09:29:20 -0700 (PDT) Received: from localhost.localdomain ([111.125.240.152]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b03bc66b3sm10560369b3a.21.2026.03.23.09.29.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:29:20 -0700 (PDT) From: Prithvi Tambewagh To: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, straube.linux@gmail.com, b9788213@gmail.com, ethantidmore06@gmail.com, dan.carpenter@linaro.org, andriy.shevchenko@linux.intel.com, weibu@redadmin.org, knavaneeth786@gmail.com, ignacio.pena87@gmail.com, dharanitharan725@gmail.com, lukagejak5@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Prithvi Tambewagh Subject: [PATCH v2] staging: rtl8723bs: fix constant on left side of test checkpatch warnings Date: Mon, 23 Mar 2026 21:59:01 +0530 Message-Id: <20260323162901.121947-1-activprithvi@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In all types of comparison/test (using =3D=3D, !=3D, >=3D, <=3D, >, < operators) ensure that the constant lies to the right side of the test, thus fixing checkpatch warnings : comparisons should place the constant on the right side of the test, throughout the rtl8723bs driver. Signed-off-by: Prithvi Tambewagh --- v1 link: https://lore.kernel.org/linux-staging/20260323145214.ubhshy2gwp52j= 5zh@inspiron/T/#mc3b693b37c49fbdde89171b7f1bf61b7ba8eb964 .../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 5 +---- drivers/staging/rtl8723bs/hal/hal_com.c | 8 +++----- drivers/staging/rtl8723bs/hal/hal_com_phycfg.c | 8 ++++---- drivers/staging/rtl8723bs/hal/odm.c | 4 ++-- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 3 +-- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 18 +++++++++--------- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- drivers/staging/rtl8723bs/include/wifi.h | 2 +- 10 files changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c b/drivers/stag= ing/rtl8723bs/hal/HalBtc8723b2Ant.c index d32dbf94858f..58f6cf063498 100644 --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c @@ -2211,7 +2211,7 @@ static void halbtc8723b2ant_RunCoexistMechanism(struc= t btc_coexist *pBtCoexist) } =20 algorithm =3D halbtc8723b2ant_ActionAlgorithm(pBtCoexist); - if (pCoexSta->bC2hBtInquiryPage && (BT_8723B_2ANT_COEX_ALGO_PANHS !=3D al= gorithm)) { + if (pCoexSta->bC2hBtInquiryPage && (algorithm !=3D BT_8723B_2ANT_COEX_ALG= O_PANHS)) { halbtc8723b2ant_ActionBtInquiry(pBtCoexist); return; } else { @@ -2490,7 +2490,7 @@ void EXhalbtc8723b2ant_BtInfoNotify( return; } =20 - if (BT_INFO_SRC_8723B_2ANT_WIFI_FW !=3D rspSource) { + if (rspSource !=3D BT_INFO_SRC_8723B_2ANT_WIFI_FW) { pCoexSta->btRetryCnt =3D pCoexSta->btInfoC2h[rspSource][2] & 0xf; /* [3:= 0] */ =20 pCoexSta->btRssi =3D pCoexSta->btInfoC2h[rspSource][3] * 2 + 10; diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index 9df3274c1048..61b35173aa4f 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -313,7 +313,7 @@ static void GetDeltaSwingTable_8723B( u16 rate =3D *(pDM_Odm->pForcedDataRate); u8 channel =3D pHalData->CurrentChannel; =20 - if (1 <=3D channel && channel <=3D 14) { + if (channel >=3D 1 && channel <=3D 14) { if (IS_CCK_RATE(rate)) { *TemperatureUP_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_P; *TemperatureDOWN_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_N; @@ -1425,9 +1425,6 @@ static void phy_IQCalibrate_8723B( } } =20 - if (0x00 =3D=3D PathAOK) { - } - /* path B IQK */ if (is2T) { =20 diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 31b3e880ae6a..00fa5c386d63 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -107,7 +107,7 @@ u8 hal_com_config_channel_plan( pHalData->bDisableSWChannelPlan =3D false; chnlPlan =3D def_channel_plan; =20 - if (0xFF =3D=3D hw_channel_plan) + if (hw_channel_plan =3D=3D 0xFF) AutoLoadFail =3D true; =20 if (!AutoLoadFail) { @@ -122,10 +122,8 @@ u8 hal_com_config_channel_plan( } } =20 - if ( - (false =3D=3D pHalData->bDisableSWChannelPlan) && - rtw_is_channel_plan_valid(sw_channel_plan) - ) + if (!pHalData->bDisableSWChannelPlan && + rtw_is_channel_plan_valid(sw_channel_plan)) chnlPlan =3D sw_channel_plan; =20 return chnlPlan; diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/stagi= ng/rtl8723bs/hal/hal_com_phycfg.c index dc2da49e6738..28ec996cd411 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c +++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c @@ -462,18 +462,18 @@ u8 PHY_GetTxPowerIndexBase( =20 if (IS_CCK_RATE(Rate)) txPower =3D pHalData->Index24G_CCK_Base[RFPath][chnlIdx]; - else if (MGN_6M <=3D Rate) + else if (Rate >=3D MGN_6M) txPower =3D pHalData->Index24G_BW40_Base[RFPath][chnlIdx]; =20 /* OFDM-1T */ - if ((MGN_6M <=3D Rate && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) + if ((Rate >=3D MGN_6M && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) txPower +=3D pHalData->OFDM_24G_Diff[RFPath][TX_1S]; =20 if (BandWidth =3D=3D CHANNEL_WIDTH_20) { /* BW20-1S, BW20-2S */ - if (MGN_MCS0 <=3D Rate && Rate <=3D MGN_MCS7) + if (Rate >=3D MGN_MCS0 && Rate <=3D MGN_MCS7) txPower +=3D pHalData->BW20_24G_Diff[RFPath][TX_1S]; } else if (BandWidth =3D=3D CHANNEL_WIDTH_40) { /* BW40-1S, BW40-2S */ - if (MGN_MCS0 <=3D Rate && Rate <=3D MGN_MCS7) + if (Rate >=3D MGN_MCS0 && Rate <=3D MGN_MCS7) txPower +=3D pHalData->BW40_24G_Diff[RFPath][TX_1S]; } =20 diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 639b6da2302b..bbe05211f4ed 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -343,9 +343,9 @@ bool ODM_RAStateCheck( } =20 /* Decide RATRState by RSSI. */ - if (RSSI > HighRSSIThreshForRA) + if (HighRSSIThreshForRA < RSSI) RATRState =3D DM_RATR_STA_HIGH; - else if (RSSI > LowRSSIThreshForRA) + else if (LowRSSIThreshForRA < RSSI) RATRState =3D DM_RATR_STA_MIDDLE; else RATRState =3D DM_RATR_STA_LOW; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index af6cdda8238d..25bc11ac874c 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -25,9 +25,8 @@ static u8 _is_fw_read_cmd_down(struct adapter *padapter, = u8 msgbox_num) =20 do { valid =3D rtw_read8(padapter, REG_HMETFR) & BIT(msgbox_num); - if (0 =3D=3D valid) { + if (!valid) read_down =3D true; - } } while ((!read_down) && (retry_cnts--)); =20 return read_down; diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 8d259820f103..02c3f4229e74 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -405,11 +405,11 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapte= r, bool bUsedWoWLANFw) break; } _FWDownloadEnable(padapter, false); - if (_SUCCESS !=3D rtStatus) + if (rtStatus !=3D _SUCCESS) goto fwdl_stat; =20 rtStatus =3D _FWFreeToGo(padapter, 10, 200); - if (_SUCCESS !=3D rtStatus) + if (rtStatus !=3D _SUCCESS) goto fwdl_stat; =20 fwdl_stat: @@ -1165,15 +1165,15 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapter) =20 static void hal_get_chnl_group_8723b(u8 channel, u8 *group) { - if (1 <=3D channel && channel <=3D 2) + if (channel >=3D 1 && channel <=3D 2) *group =3D 0; - else if (3 <=3D channel && channel <=3D 5) + else if (channel >=3D 3 && channel <=3D 5) *group =3D 1; - else if (6 <=3D channel && channel <=3D 8) + else if (channel >=3D 6 && channel <=3D 8) *group =3D 2; - else if (9 <=3D channel && channel <=3D 11) + else if (channel >=3D 9 && channel <=3D 11) *group =3D 3; - else if (12 <=3D channel && channel <=3D 14) + else if (channel >=3D 12 && channel <=3D 14) *group =3D 4; } =20 @@ -1221,7 +1221,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( =20 memset(pwrInfo24G, 0, sizeof(struct TxPowerInfo24G)); =20 - if (0xFF =3D=3D PROMContent[eeAddr+1]) + if (PROMContent[eeAddr+1] =3D=3D 0xFF) AutoLoadFail =3D true; =20 if (AutoLoadFail) { @@ -2035,7 +2035,7 @@ static void hw_var_set_bcn_func(struct adapter *padap= ter, u8 variable, u8 *val) val8 &=3D ~(EN_BCN_FUNCTION | EN_TXBCN_RPT); =20 /* Always enable port0 beacon function for PSTDMA */ - if (REG_BCN_CTRL =3D=3D bcn_ctrl_reg) + if (bcn_ctrl_reg =3D=3D REG_BCN_CTRL) val8 |=3D EN_BCN_FUNCTION; =20 rtw_write8(padapter, bcn_ctrl_reg, val8); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index a1f2cbf2cf55..9f6503ac2234 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -413,7 +413,7 @@ int rtl8723bs_xmit_thread(void *context) if (signal_pending(current)) { flush_signals(current); } - } while (_SUCCESS =3D=3D ret); + } while (ret =3D=3D _SUCCESS); =20 complete(&pxmitpriv->SdioXmitTerminate); =20 diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/stagin= g/rtl8723bs/include/ieee80211.h index 0f28c904a714..0f378830462f 100644 --- a/drivers/staging/rtl8723bs/include/ieee80211.h +++ b/drivers/staging/rtl8723bs/include/ieee80211.h @@ -395,8 +395,8 @@ enum { }; =20 #define IS_HT_RATE(_rate) (_rate >=3D MGN_MCS0 && _rate <=3D MGN_MCS31) -#define IS_CCK_RATE(_rate) (MGN_1M =3D=3D _rate || _rate =3D=3D MGN_2M = || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) -#define IS_OFDM_RATE(_rate) (MGN_6M <=3D _rate && _rate <=3D MGN_54M &= & _rate !=3D MGN_11M) +#define IS_CCK_RATE(_rate) (_rate =3D=3D MGN_1M || _rate =3D=3D MGN_2M = || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) +#define IS_OFDM_RATE(_rate) (_rate >=3D MGN_6M && _rate <=3D MGN_54M &= & _rate !=3D MGN_11M) =20 =20 /* NOTE: This data is for statistical purposes; not all hardware provides = this diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl= 8723bs/include/wifi.h index 230b2c4ffd3b..31eaf40a3425 100644 --- a/drivers/staging/rtl8723bs/include/wifi.h +++ b/drivers/staging/rtl8723bs/include/wifi.h @@ -275,7 +275,7 @@ static inline unsigned char *get_hdr_bssid(unsigned cha= r *pframe) =20 static inline int IsFrameTypeCtrl(unsigned char *pframe) { - if (WIFI_CTRL_TYPE =3D=3D GetFrameType(pframe)) + if (GetFrameType(pframe) =3D=3D WIFI_CTRL_TYPE) return true; else return false; base-commit: c369299895a591d96745d6492d4888259b004a9e --=20 2.34.1