From nobody Fri Apr 3 17:31:53 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34EBD3BF662 for ; Mon, 23 Mar 2026 16:16:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282599; cv=none; b=AX8WAu6xHrJj2ONCxA047gO8J4xnJfZeNuPPvWDkm2KIHpeUlNwh4u62sqPXbpAuPaLxW7CHWJEXeomo1SeFA5AWmh5jMDgbzcZ67UQhlkIuzIL08Tkzeo9tDM3z+ljke/AsaZywzSNom3bvi5kgVmiBgNqh/R9gpq7nfNc3oos= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282599; c=relaxed/simple; bh=g8+Hj0Vb1Y/88a17yOow0ZjQc6l0noTQuUGZxhIscS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e8+k4MixeAfGvRfsVr05tqA+jzj+SIm+BxeudHuk9dYeoWU7sIqoSYEaVk78DMTM0M4eyCdLD+dC4Q1ki3/LXfRdXCiQcq+fXlK/v8BBLRmDDloHVA5vf5im14UfjndGGrBAT2yitddybhYfxPSIKN7CAJsPL0nW4XP2rJLm8LQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DfL7ZP4L; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DfL7ZP4L" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4870206f73bso17110115e9.3 for ; Mon, 23 Mar 2026 09:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774282594; x=1774887394; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8e14EFbUgBOZGsLZ9xhCm0kYrey9UscJoVzYYnSs0h4=; b=DfL7ZP4Llr92HekVW2kyP2b4s9Qyu1vsgQfyaskD9FbZ4dPGD3IdrcpP8MRCRMo8a7 +SmkE5IcF9Kdn06p/ka3nvaVpTn/Gn3E7vMR007RubPNkbHB9BHEiCLL1mBBmqdOHQe4 d9K8k+2jQykdskGS3n7+IIh6en0YoP1Ga932SCTkuwiMBwxvssLNxB9wK5qmpn7wfTf7 gkdv1nlOvMxZDXi69+SPOv6nEQdJE5LVYvvpgtNh7752gDNBR6jerpk7y/mIdgjUzrE0 pIKwOYxI1wimzzfOPyTY6ybPyOySpxcZVKcH0r+NI+Sn/f4sy4bJtgwFU+WTB4e50x1Z vjbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774282594; x=1774887394; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8e14EFbUgBOZGsLZ9xhCm0kYrey9UscJoVzYYnSs0h4=; b=BGOvCtKNQrZilN9KmGaX2x1XFaxalxHPpC6d7yYQKbvxeKdL39Gh5Hgg7Bdl/kxqn8 ovMFB0GSRquC7RUE3XFCicGQkwEYltxzrZeRR0EadJha/hnnLx922sf6EiU4KSMLCchj McowNxuqFSeX9QbSmnSrUjcIWnbhFFaAlGtasAzvncaMolOuZD/yq7F2jisAAUg7GTzI Dnpp+uv+D7RhNNHE+9BY6UtEWj9vP7HuSPEAadNA0Ae+0yMWAEuQ8K55plEPmw8iElrQ H8HzWwLF60/N+iIa5EIfTd+WHUDnmnui/qErTy5lyhsjVJ06AtdOiFLeHGqOjHVoJyOx bQVg== X-Forwarded-Encrypted: i=1; AJvYcCU8FYZLD/E87XGDpt+X+ALSp1qYLWF81BM0TaeYrtLIIPYSTuiKd+t1Qf0QaEn7Wv6r3QkSlpl4d0Y+0gI=@vger.kernel.org X-Gm-Message-State: AOJu0YxBxDPA1ogcM8ldj9CgV62J6fzocUxWXGJaxXuU2Hn2NFdRtv9S 4apQCoJHrFK5XQvgGCTBBthZHCoPM6AIxFC/DsR/KKzUZ8JebgzaOTY= X-Gm-Gg: ATEYQzwFmgNjN4CPHfxt2wZh8FJcdlcY05gK0UJTRa2L8w9gTh9o9vKvWgztuoI9ae2 AG0oewSg5u4SwOyu5k301VumlkZZBPhM2RmE/3WgL4NkqgqJ3GKhcQwKRTVoxzCRYcIqrObh4+0 SauvTyNkkmAyn7ccAHXvfDvk4W51iagda9M8ITIv8X2WWB9PKWqQeNisPAoAm+uC7uZPb0gZ99u MkCRbtIl6nK0jeZJBgpmDlKn77UL5fdTIZ4zcWVc4PC2t9MwIWEnhOgsCvkHgy26ex8bjdQ65B6 N6fWuyGY1Omb7jkQUsHToa9umshjDvggK54l5vJI9ZQeiI4GQVvhYskhLnJ1ux981RoGUQRLHTE b16bp6HeUAduGSPEZ4sgnNUAC5GxRC87oGXe/1CL+OO+qEy7xa4Iqyb/aVt9jcGKWS4xmC13xnK wBUDUZRwA37e0FAvY5ve/vCuIHaoiaU44DFImuOeV5Spcci4+CAwJz X-Received: by 2002:a05:600c:a59b:b0:486:ffa3:593 with SMTP id 5b1f17b1804b1-486ffa30b26mr96817745e9.28.1774282594063; Mon, 23 Mar 2026 09:16:34 -0700 (PDT) Received: from localhost.localdomain ([78.240.51.139]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8aacc73sm331863395e9.0.2026.03.23.09.16.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:16:29 -0700 (PDT) From: Jihed Chaibi To: paul@crapouillou.net, linux-mips@vger.kernel.org Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, jihed.chaibi.dev@gmail.com Subject: [PATCH 1/3] ASoC: jz4725b: Convert to devm_clk_get_enabled() Date: Mon, 23 Mar 2026 17:15:49 +0100 Message-ID: <20260323161551.47181-2-jihed.chaibi.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> References: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clock is obtained with devm_clk_get() in the platform probe, then manually enabled in the component probe and disabled in the component remove without checking the return value of clk_prepare_enable(). Use devm_clk_get_enabled() instead, which combines the get, prepare and enable operations into one call whose lifetime is tied to the device. This removes the need for explicit enable/disable in the component probe/remove callbacks, and ensures that clock enable failures are propagated as errors rather than silently ignored. Remove the now-unused struct clk pointer from struct jz_icdc and drop the empty component remove callback. Signed-off-by: Jihed Chaibi --- sound/soc/codecs/jz4725b.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/sound/soc/codecs/jz4725b.c b/sound/soc/codecs/jz4725b.c index 39cebaa167be..8a7d26a08c03 100644 --- a/sound/soc/codecs/jz4725b.c +++ b/sound/soc/codecs/jz4725b.c @@ -160,7 +160,6 @@ enum { struct jz_icdc { struct regmap *regmap; void __iomem *base; - struct clk *clk; }; =20 static const SNDRV_CTL_TLVD_DECLARE_DB_SCALE(jz4725b_adc_tlv, 0, 150, = 0); @@ -405,8 +404,6 @@ static int jz4725b_codec_dev_probe(struct snd_soc_compo= nent *component) struct jz_icdc *icdc =3D snd_soc_component_get_drvdata(component); struct regmap *map =3D icdc->regmap; =20 - clk_prepare_enable(icdc->clk); - /* Write CONFIGn (n=3D1 to 8) bits. * The value 0x0f is specified in the datasheet as a requirement. */ @@ -418,16 +415,8 @@ static int jz4725b_codec_dev_probe(struct snd_soc_comp= onent *component) return 0; } =20 -static void jz4725b_codec_dev_remove(struct snd_soc_component *component) -{ - struct jz_icdc *icdc =3D snd_soc_component_get_drvdata(component); - - clk_disable_unprepare(icdc->clk); -} - static const struct snd_soc_component_driver jz4725b_codec =3D { .probe =3D jz4725b_codec_dev_probe, - .remove =3D jz4725b_codec_dev_remove, .set_bias_level =3D jz4725b_codec_set_bias_level, .controls =3D jz4725b_codec_controls, .num_controls =3D ARRAY_SIZE(jz4725b_codec_controls), @@ -618,6 +607,7 @@ static int jz4725b_codec_probe(struct platform_device *= pdev) { struct device *dev =3D &pdev->dev; struct jz_icdc *icdc; + struct clk *clk; int ret; =20 icdc =3D devm_kzalloc(dev, sizeof(*icdc), GFP_KERNEL); @@ -633,9 +623,9 @@ static int jz4725b_codec_probe(struct platform_device *= pdev) if (IS_ERR(icdc->regmap)) return PTR_ERR(icdc->regmap); =20 - icdc->clk =3D devm_clk_get(&pdev->dev, "aic"); - if (IS_ERR(icdc->clk)) - return PTR_ERR(icdc->clk); + clk =3D devm_clk_get_enabled(dev, "aic"); + if (IS_ERR(clk)) + return PTR_ERR(clk); =20 platform_set_drvdata(pdev, icdc); =20 --=20 2.47.3 From nobody Fri Apr 3 17:31:53 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A829D3BF67E for ; Mon, 23 Mar 2026 16:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282603; cv=none; b=OA3INH5wsWjes/xw97pF0EHwSCyzsplAKQcy739a3oJwdXCl1XeHlxQytVtNvgF2rbEFxS+4q8I5iKj8Y0+GJfkB0v+B54JAf8l62YXyiF1/JiRShPC93+QsUfTdZxgRW4e0p52hZRM8okdKjcaY8JzjzakFc3Z4rNE9mjq484Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282603; c=relaxed/simple; bh=SFCFFwHLQsmCdrpuqlJCrhc5Ygf2e1G8qXrq4SXv7os=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MwXHJFnfLtQQdF0TlaNTwZEva47IIItsgfDTfGT3gZ7MPFqP2r8orLTSXe2v1JKuI9a/MkFwS3US6B9IrbTEIOrGVorbjTNZP6Kn76cDUvTVyZ77UzBF/6e+t4Gn7f2+sgFAschsdlNyz58ShDx02PrreN3mUMINyaPi7oeyp7Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N6u4mQ7H; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N6u4mQ7H" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486ff201041so24431595e9.1 for ; Mon, 23 Mar 2026 09:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774282597; x=1774887397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UO+SkoI9eVt74xNLLkIIUZ5Y4CPfHlVSwCp47CpWJR8=; b=N6u4mQ7Hgb1gF1cZcBRTyezt7fM5d6Rhg7pd62rSDv/WsDjxbRj9+gw8cc69RJKzlj 2380kYSzDtecDcXwIvBFN1L5z3YoRuuTY343iT6FXD1x8wIHQPaFwp+L+2Hwt+hYUWYN 05NaxWuk0ICApC5gBNHRaWNCsylhz+pleLfzybAVuJG984qFY+m4543mglQ5WNgQkTrZ OKgAVivPM/4y+H9WSuH5zlEXyK60QiWq7nEnnFpKY7P9S6uzEXJS5twZOu5mAqi+8u3m osob5aSGmi28qfAFneB+tzc1uC5frFwi2FakbLjn2YaEHVWA4LyXMilVDf9cahb9RMDz Sepg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774282597; x=1774887397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UO+SkoI9eVt74xNLLkIIUZ5Y4CPfHlVSwCp47CpWJR8=; b=tFHBiYVbc7AxCfZqMMh20XmzzG+OLQD3TPcNvKw/AQ/MxvZTBZbtbb8yOYTT9Q7AdY 1z6WW+SPbT5kMaYnDFmj4MaqREeXzCQJiAkqob33PD0HZBfGmwUI00xahVVeQ/Db0txf tUYkLy872LJPub6W17niWwCnjW7HhnfkWUALoVz/X0RHQLanGBzu7+kVQD/8hvO5kqbW P0AUoHMXzvffGN8lBoLPKtkWObPg/5uahdHBPGV1IktuGldGcGkTuzuphn+MTg6kOa3F UGNKzWXGfXfFT8uilB8cNuY0Zs4zok5Wuemt6aZrmE0fS6ONFw3BeGTg94ne8pVjA7uH sA1A== X-Forwarded-Encrypted: i=1; AJvYcCWgbJ8AMARK4BAK/xowdsQ5MWwqJdrVzo2iiMVM2pR3japwPzZ1B9o1IqTCgpme3C4jphCs3Khbdg75klo=@vger.kernel.org X-Gm-Message-State: AOJu0YzmorDsfowkhox5BDk8dIV2CJ3KxeDotoCT4lMDUTmx+RMNAFIL ujk8B7vjRs8Mp1D4yghV1FQd5QpogOlBHVTgjU/+JXWfl0bZs4cOF+s= X-Gm-Gg: ATEYQzwWUF1G22uq74KJVdiMM2h/sHSJTHHF3c3iFEJTIG3rwYtIrPMjwVx9C9bwIUB Qv8hTZSTtonCTpQc3U6tBLrxz3ScMcwm8aQMiEUTr4jmFhBtLeFsF4UtwSYhlB5sGL/rRSnDG1S uvgvXF/dvv50p/SWD3tRJm8AX9CQnmPqhGBAwqs1Aq+jJDYFB328yZVD2GdQHHmo2evrMpz8zly Erfk2lKA51lGqe4eHHVfvCE7gCdVn5b61h24OePLmGmVJ/YQ91M0IrtZ84KEsg4cPZK8inTzSrU s1o+QwQCs6oO/W6aatazp2QVMdETTCMJTEEOXIjTLz7awVnikQyip3fZaVUkK01cuYlgxOJawH+ ndCEGch75yaxIfNh7sPK1HrLudB3bGg8FJqBBzvhtBDgghgh4rxXuEivCi88i2Zgrp0RdTXxJEC 5LgRoh4isVKPFSoOTb/YCq8WYx3ND+vh+Us1envf29Yg== X-Received: by 2002:a05:600c:4705:b0:485:3f17:425 with SMTP id 5b1f17b1804b1-486fee04a53mr175550015e9.21.1774282596969; Mon, 23 Mar 2026 09:16:36 -0700 (PDT) Received: from localhost.localdomain ([78.240.51.139]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8aacc73sm331863395e9.0.2026.03.23.09.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:16:34 -0700 (PDT) From: Jihed Chaibi To: paul@crapouillou.net, linux-mips@vger.kernel.org Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, jihed.chaibi.dev@gmail.com Subject: [PATCH 2/3] ASoC: jz4760: Convert to devm_clk_get_enabled() Date: Mon, 23 Mar 2026 17:15:50 +0100 Message-ID: <20260323161551.47181-3-jihed.chaibi.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> References: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clock is obtained with devm_clk_get() in the platform probe, then manually enabled in the component probe and disabled in the component remove without checking the return value of clk_prepare_enable(). Use devm_clk_get_enabled() instead, which combines the get, prepare and enable operations into one call whose lifetime is tied to the device. This removes the need for explicit enable/disable in the component probe/remove callbacks, and ensures that clock enable failures are propagated as errors rather than silently ignored. Remove the now-unused struct clk pointer from struct jz_codec and drop the empty component remove callback. Signed-off-by: Jihed Chaibi --- sound/soc/codecs/jz4760.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c index 344c251be397..6846ace06415 100644 --- a/sound/soc/codecs/jz4760.c +++ b/sound/soc/codecs/jz4760.c @@ -163,7 +163,6 @@ struct jz_codec { struct device *dev; struct regmap *regmap; void __iomem *base; - struct clk *clk; }; =20 static int jz4760_codec_set_bias_level(struct snd_soc_component *codec, @@ -602,25 +601,13 @@ static void jz4760_codec_codec_init_regs(struct snd_s= oc_component *codec) =20 static int jz4760_codec_codec_probe(struct snd_soc_component *codec) { - struct jz_codec *jz_codec =3D snd_soc_component_get_drvdata(codec); - - clk_prepare_enable(jz_codec->clk); - jz4760_codec_codec_init_regs(codec); =20 return 0; } =20 -static void jz4760_codec_codec_remove(struct snd_soc_component *codec) -{ - struct jz_codec *jz_codec =3D snd_soc_component_get_drvdata(codec); - - clk_disable_unprepare(jz_codec->clk); -} - static const struct snd_soc_component_driver jz4760_codec_soc_codec_dev = =3D { .probe =3D jz4760_codec_codec_probe, - .remove =3D jz4760_codec_codec_remove, .set_bias_level =3D jz4760_codec_set_bias_level, .controls =3D jz4760_codec_snd_controls, .num_controls =3D ARRAY_SIZE(jz4760_codec_snd_controls), @@ -818,6 +805,7 @@ static int jz4760_codec_probe(struct platform_device *p= dev) { struct device *dev =3D &pdev->dev; struct jz_codec *codec; + struct clk *clk; int ret; =20 codec =3D devm_kzalloc(dev, sizeof(*codec), GFP_KERNEL); @@ -835,9 +823,9 @@ static int jz4760_codec_probe(struct platform_device *p= dev) if (IS_ERR(codec->regmap)) return PTR_ERR(codec->regmap); =20 - codec->clk =3D devm_clk_get(dev, "aic"); - if (IS_ERR(codec->clk)) - return PTR_ERR(codec->clk); + clk =3D devm_clk_get_enabled(dev, "aic"); + if (IS_ERR(clk)) + return PTR_ERR(clk); =20 platform_set_drvdata(pdev, codec); =20 --=20 2.47.3 From nobody Fri Apr 3 17:31:53 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 044EF3BFE31 for ; Mon, 23 Mar 2026 16:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282607; cv=none; b=jA+ZmmtIxJ1dgTL/SsF6xp4YbIVGS+iB8mcwb0tQR9BBnjmIrpA6I2xsXSNpclpM5yQLaBI0F33wyL4Xn7R2iNfYl0/748ptfaVSVSMBxPDLt8HsfNp+ED4oXtq/zhZnNKBkf862ji/v5fwNkp2VMHMuC5f4m9snUtXudJJrcq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774282607; c=relaxed/simple; bh=iXK6wvRyFqYcb2f+HT0HHDjAo809KzTB5lgU9a6PXM0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nPciZt2RGerEcXvq5Z0G8es0no8TB7s6bRyRbI6Z1RZsJ/SpLOMi1UxlRxahiDvaCIFYDXXSWbab86KFy/9RC3pD2tJN2Dgg9NBm3xZs5CrUggJsVSbhUP3VUL5GD+z8WryueZx4xSlT5mOC4qQ5W9LU2svMkuScv3DhEPo5h94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+iniI/e; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+iniI/e" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso27159675e9.3 for ; Mon, 23 Mar 2026 09:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774282602; x=1774887402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gp4YODN/4k6phpMRYg5cRzJL2UKo8bXWoJWQxfk4Kow=; b=g+iniI/eDfcqqVVXzyBwiQCEzvWJoKmPSQu+Y4AWEyUguzdmeGYjes9ZALdXzAMeSa O/qhQMWUeP+M/vQVQlSVwvJJN2/NLs8Gv+77TbQVtFFlJvEc/5HiTMVU5aA/cfXhyp58 SMSDd05RBa9EK2IlpU57kUMMNMsQcXmwOntGfIcylkzITigeoSUmlMd1cDy4VdcDgKC9 i0LbYA6BDqMz9sI0vMC3HmG5SzPItuCzl3xTk9DFemgkoGm2FtenWDXzJEevcYE1I6dt Gwi+6wp7xOfecuUd0eDi7FxyJiLrdPNsuCGQHgX6Hi9ide/fxXCnmEcyAGP9pPjx9hox gCTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774282602; x=1774887402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gp4YODN/4k6phpMRYg5cRzJL2UKo8bXWoJWQxfk4Kow=; b=F/+kF/EHv9ue9Euv+uUY/xM+hLdBj4wDeEXUQnqJSAvIIOh5ZeRzRMOt/NJIL4Aeul Pxujl8QZCwe98hGVmgWxypOFvI9huWaAkVYoxjvSvueFO5aH6IJg0tWDvPrRRnly9mc8 gsjRrrIJOxZJTM0aMQfwcoI9RcqBo+cb+K/Z+9/VvJjfiizhhdzXjRN5CIUTchbIjh82 zCm16su73XdkkPsozgPSlLgPAjaZF2jh0raH25fKnZ3GZW1zCT9qjFOD66wMRDS/kHqD zo8gJ23+RvD08Qg86xMtsLdCEzFcp4uRmikjwgfItppRZdAIznJk/U0f2digMrBNG2VK Xcmg== X-Forwarded-Encrypted: i=1; AJvYcCWbaO9cm84qwXoly6DjipjP0by7hrj2FIqzrvXkHSNOL6AMo0xXRuB90wHcDydTs8UepI71kxtO+M2sVtw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy12zu02GaY6MCEQo7271rF7EsKl6s4wnFpk/ofYw9pKGs5h+PW j6BQa1tTu9Pche+fxRFUQrWqnfrFQpNJfM4I/slZA/nQgRUErFlSfm2jFF2H X-Gm-Gg: ATEYQzzLjBAIEFMs2P0OC/MChWR8iLJ840+WLLL439kT7AEXGkC1rLbuyo7j1NXokWb /3N9aV2SH74W9JJJW68AfASEjZ+GvKpcgbHKjtoThCH6N2PFZA3CzvrDUwq7U4ie8eYhfAZoRuX dInxu8bAshAsaV/JFzuwe9sk6k8pRFghWNDqzOhvRYJdUwK60PHZlWATt3UP/pS3rsH5iSMlLHK qBBQ64e5KFW8qmm/PL35XaS3RbST2r0ReLKHaUFtZQR4FbkfoKz6Rn9OTIZV403irqB/jGI5jcx zPENDXTZ0i79q/fIiLcTngftA08bjZLI/Rq3pMWqmi3EQh9Y7VotTnSzQ/B5AKHe24Ku0Y1hZ3b v3IolaB7C3ZtAeof5D9kL0ssbkYItAjGx3s5gYTnwGmSY/CObkVgOWcXK6uxvkO7vBHDwUFXtM7 89VgIxpbAQSH0M3jXr2fLeEvzkvRo5oUHKSJCcrbuITA== X-Received: by 2002:a05:600c:3546:b0:486:fbdb:b718 with SMTP id 5b1f17b1804b1-486fee29536mr181005205e9.25.1774282601876; Mon, 23 Mar 2026 09:16:41 -0700 (PDT) Received: from localhost.localdomain ([78.240.51.139]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8aacc73sm331863395e9.0.2026.03.23.09.16.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:16:37 -0700 (PDT) From: Jihed Chaibi To: paul@crapouillou.net, linux-mips@vger.kernel.org Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, jihed.chaibi.dev@gmail.com Subject: [PATCH 3/3] ASoC: jz4770: Convert to devm_clk_get_enabled() Date: Mon, 23 Mar 2026 17:15:51 +0100 Message-ID: <20260323161551.47181-4-jihed.chaibi.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> References: <20260323161551.47181-1-jihed.chaibi.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The clock is obtained with devm_clk_get() in the platform probe, then manually enabled in the component probe and disabled in the component remove without checking the return value of clk_prepare_enable(). Use devm_clk_get_enabled() instead, which combines the get, prepare and enable operations into one call whose lifetime is tied to the device. This removes the need for explicit enable/disable in the component probe/remove callbacks, and ensures that clock enable failures are propagated as errors rather than silently ignored. Remove the now-unused struct clk pointer from struct jz_codec and drop the empty component remove callback. Signed-off-by: Jihed Chaibi --- sound/soc/codecs/jz4770.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs/jz4770.c index 6b86d47028d7..be1ecdcc737b 100644 --- a/sound/soc/codecs/jz4770.c +++ b/sound/soc/codecs/jz4770.c @@ -179,7 +179,6 @@ struct jz_codec { struct device *dev; struct regmap *regmap; void __iomem *base; - struct clk *clk; }; =20 static int jz4770_codec_set_bias_level(struct snd_soc_component *codec, @@ -634,25 +633,13 @@ static void jz4770_codec_codec_init_regs(struct snd_s= oc_component *codec) =20 static int jz4770_codec_codec_probe(struct snd_soc_component *codec) { - struct jz_codec *jz_codec =3D snd_soc_component_get_drvdata(codec); - - clk_prepare_enable(jz_codec->clk); - jz4770_codec_codec_init_regs(codec); =20 return 0; } =20 -static void jz4770_codec_codec_remove(struct snd_soc_component *codec) -{ - struct jz_codec *jz_codec =3D snd_soc_component_get_drvdata(codec); - - clk_disable_unprepare(jz_codec->clk); -} - static const struct snd_soc_component_driver jz4770_codec_soc_codec_dev = =3D { .probe =3D jz4770_codec_codec_probe, - .remove =3D jz4770_codec_codec_remove, .set_bias_level =3D jz4770_codec_set_bias_level, .controls =3D jz4770_codec_snd_controls, .num_controls =3D ARRAY_SIZE(jz4770_codec_snd_controls), @@ -865,6 +852,7 @@ static int jz4770_codec_probe(struct platform_device *p= dev) { struct device *dev =3D &pdev->dev; struct jz_codec *codec; + struct clk *clk; int ret; =20 codec =3D devm_kzalloc(dev, sizeof(*codec), GFP_KERNEL); @@ -882,9 +870,9 @@ static int jz4770_codec_probe(struct platform_device *p= dev) if (IS_ERR(codec->regmap)) return PTR_ERR(codec->regmap); =20 - codec->clk =3D devm_clk_get(dev, "aic"); - if (IS_ERR(codec->clk)) - return PTR_ERR(codec->clk); + clk =3D devm_clk_get_enabled(dev, "aic"); + if (IS_ERR(clk)) + return PTR_ERR(clk); =20 platform_set_drvdata(pdev, codec); =20 --=20 2.47.3