From nobody Mon Mar 23 21:23:31 2026 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51AC53C0621 for ; Mon, 23 Mar 2026 16:01:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774281703; cv=none; b=aElhA5cLHQHbqTnG+kan885UDgVDnfotw2Ye6nxyfuOXQETw4wafQggqKjjGSE6v7+fclE03pgsNFa+MUQ91xr4/c/ksYsid+S45cYuUIPhFAuWck9IP4n53K135f3a/1iTsite/IVqv4TL/G884ub2frurZlLR1u7T2OByIzC4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774281703; c=relaxed/simple; bh=csCOKU4ZGweoZ0qVuu0CPj5KbzdHlMu0Ye2PUQfjQHM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CAZCvhqVeZnNg9Uy+ymxQ/mdBAE/PVi0l/W/9oh/s5pH3AiDLZgglOniY096yC5dd1fwpFEg0MMSlJmL2DwSdi8X5n+unVkLAvGG54lzmWtspCCkum6oS1ixM3c44Kr2H/Ui3/nl4o4xaTwNzU2iklt1j+l91F0LqEot6yQ6e1c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bitbyteword.org; spf=pass smtp.mailfrom=bitbyteword.org; dkim=pass (2048-bit key) header.d=bitbyteword.org header.i=@bitbyteword.org header.b=RjERMzQZ; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bitbyteword.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bitbyteword.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bitbyteword.org header.i=@bitbyteword.org header.b="RjERMzQZ" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-8cfc40e4158so33989685a.1 for ; Mon, 23 Mar 2026 09:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bitbyteword.org; s=google; t=1774281701; x=1774886501; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MDV783MNsejQMiPhyabnRoBjsJDu3rOHFXCd2/91B04=; b=RjERMzQZUxM59pVP+MAu45vvJEI/VSxmuYfcmKSXOxUz9P1AuXtf4ZSOsnrj+/b5cV aF8gFyy40YLWVMxWYyiBl33t85XYQ3tt6n9C08zG7DaAyZTOBz1LzSE4z+w5Pzv4cMh3 XptZOBGhDXHAZ3pXFG7hOQTsrNFm6lo6CyPYNqrNk3zcK2xssE89job+6+hKROlQNEfa d16CtdtZSQvxT3PXKE6SW88GAWJLIcxl5yEnpFdfVHiKEq6aBsfpWjsZgH95BZRzzscA HETwr8zEpwp5YMEtL1QhEYmKs2zWXonyRh82/5cmMzlfc0F6cpQqDv/rWcpbcMRKH8VZ brUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774281701; x=1774886501; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MDV783MNsejQMiPhyabnRoBjsJDu3rOHFXCd2/91B04=; b=e6fgRl5Uk5nWym8S5+zIIcbdCuhW1VO4UFbcPyOrMpkF7iW/0Rv3DInvx1QXqVlKl0 HLIcaIOdRTKPQOSsdmxo2UnSpBripfGwuetYTzARWkkHISj9g8zJlgF0JBMPU4wulPss mlfwK2gaDcRee0ZyGpM2lpTYFHYHzL5PgPQTE8wktvORwQ1IPaV2XfGp6+oiN5RSGvVr 9Df5AoiwQ8MruYi010P237g/N5JWnXPnG26eor9n6AIxXSjndQtdIfra7wJjrsKS3RWn nFuO3DwTFQip+lsNMmRFoxvFim6bYa4uDsgKiyttTt/6YERCXPv5RQnCzOnn79yLjosD n8Zg== X-Forwarded-Encrypted: i=1; AJvYcCUu2FzYG7fE/rQOcCPKy1sHeKxWRpZD9Khk667hPPec/HgAWofDrOENaU7YB8UEEUobmOkT0p0vmlR6hPQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0LWH/Yo9I4sQHpLX/+LWbWXEqUnGz5GxdKaEa/e6ZInVanH5M YqyAe+LIVF3DkKapZm3AnHsQI3zSYLCxXoOZFLB5x2Pl5lpkLa3mRugc+qsPV7wZOR8= X-Gm-Gg: ATEYQzztk6voaN0cBw6shtVHirThQ1VcF4I4E+y2nf5CvKk5Wj4+qtn2eXtD0G+FrTy ONnIuPq1e0JXnkVkIIMt88EKUTFmoqKQhTfxFrTX409NUNSik063f7Tptfe/PYTuiN7OQoVUBtq rw2WOUgelnqj60U2rXImmweznvM84kOoV0UDsFUn53EGN77V9DSx6nJGuWFUodmrHLg9sSHDG0y TWbVtelxUs62EmzvFssW62o4pZbuFjji38Oc7OGn4AJIkjaHa1N94G60MNjiKSiMtV+foGPZZrQ ex6xmCa9NhwWmDvZjcvJdrdHwnR5XXwzJ22+fvAPPlL/pffi3rNM4bFjBIj3O5Anssa/MVobcur KFWwrXu4mhpWf2NwEW2hFzwEd5pbwPmwwnjn0hhnirht8Ykxk2rBl8TKzswZr4BbBem9F0sR/8i /eYNeVc8ArkAn0OzqPbMA0K+zAt3JsMLQDWctSRAmTARZR6bzkKj2M5Yg56Ajl476T5Q== X-Received: by 2002:a05:620a:199a:b0:8cf:d804:4569 with SMTP id af79cd13be357-8cfd80447bcmr1211283185a.23.1774281701098; Mon, 23 Mar 2026 09:01:41 -0700 (PDT) Received: from vinmini.lan (c-73-143-21-186.hsd1.vt.comcast.net. [73.143.21.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cfc9088df1sm843364185a.25.2026.03.23.09.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 09:01:40 -0700 (PDT) From: "Vineeth Pillai (Google)" To: Cc: "Vineeth Pillai (Google)" , Steven Rostedt , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Sean Christopherson , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH v2 19/19] x86: msr: Use trace_call__##name() at guarded tracepoint call sites Date: Mon, 23 Mar 2026 12:00:38 -0400 Message-ID: <20260323160052.17528-20-vineeth@bitbyteword.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260323160052.17528-1-vineeth@bitbyteword.org> References: <20260323160052.17528-1-vineeth@bitbyteword.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The do_trace_write_msr(), do_trace_read_msr(), and do_trace_rdpmc() wrappers exist to break the header dependency from asm/msr.h which cannot include trace headers directly. Their callers in asm/msr.h already guard calls with tracepoint_enabled() checks, so the trace_foo() calls inside these wrappers perform a redundant static_branch_unlikely() re-evaluation. Replace trace_write_msr(), trace_read_msr(), and trace_rdpmc() with their trace_call__##name() variants to call the tracepoint callbacks directly without the redundant static branch check. Suggested-by: Steven Rostedt Suggested-by: Peter Zijlstra Signed-off-by: Vineeth Pillai (Google) --- arch/x86/lib/msr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/lib/msr.c b/arch/x86/lib/msr.c index dfdd1da89f366..14785fe5e07b5 100644 --- a/arch/x86/lib/msr.c +++ b/arch/x86/lib/msr.c @@ -125,21 +125,21 @@ EXPORT_SYMBOL_FOR_KVM(msr_clear_bit); #ifdef CONFIG_TRACEPOINTS void do_trace_write_msr(u32 msr, u64 val, int failed) { - trace_write_msr(msr, val, failed); + trace_call__write_msr(msr, val, failed); } EXPORT_SYMBOL(do_trace_write_msr); EXPORT_TRACEPOINT_SYMBOL(write_msr); =20 void do_trace_read_msr(u32 msr, u64 val, int failed) { - trace_read_msr(msr, val, failed); + trace_call__read_msr(msr, val, failed); } EXPORT_SYMBOL(do_trace_read_msr); EXPORT_TRACEPOINT_SYMBOL(read_msr); =20 void do_trace_rdpmc(u32 msr, u64 val, int failed) { - trace_rdpmc(msr, val, failed); + trace_call__rdpmc(msr, val, failed); } EXPORT_SYMBOL(do_trace_rdpmc); EXPORT_TRACEPOINT_SYMBOL(rdpmc); --=20 2.53.0