From nobody Mon Mar 23 19:52:00 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06BD12343D2 for ; Mon, 23 Mar 2026 14:15:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774275334; cv=none; b=sLsCc6d3dAFyw3yVcUyU+L9M6rPmw0kHwgFOq3ymOuMtmf7RYr2GqqQa2zTGmQzX6ogSlH0aMzd4XejMDXWkzLVgorCRPLYHJjxDBdUsC25KQbxTSihLOADMPawL8vB62cIRvft24j2WkH0RFunlGgJ1IcNYKz+gvtARWtJw504= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774275334; c=relaxed/simple; bh=sDpjc/e4FzUUBFg9P69pd8WSJ7bqYYnSNlfx2c4cl74=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BIevSsLeybqRjgcNOjJiVlJRgkoJywG0QCp+g3WyfqqgxjI3FyEbT1dFfBQdfLqous4BiES457+KjJXFXBNV1FRmuRWTvJNNB1nCo2M9oWCOhqlDVyGdRY9Vn52WvVoejbSZKn4UKBInj81SCIKULgMxQPxkawmJPvW+xR44vcw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IkqMRe+0; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IkqMRe+0" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3567e2b4159so189360a91.0 for ; Mon, 23 Mar 2026 07:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774275332; x=1774880132; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b8yMxbo6eXfzrbt6N95ePZ3H8AA4JuIBdUqubCR3X58=; b=IkqMRe+0CgwUbwgZxecBeYMd0tf0unRv7sW2+KZSnW5EoxwOOvxjxVekQ1AcjCqxaG Wz7o3U/iSfGYwzVUdu9+JHYoPjb16rjWpVkvqGuw+aVlO3i4M0PFOikwQfB1U9RBInuJ wcSNVX9lXpoy97aqxAdDoHXKJNDGrzBwhfs/IrQpa52fhrbw3X/MrDo6voCW53N9Msad UQL9nMWUtLK6Qt8WthPQOnQE0lSvb6XZCfghROSBdKRGVjKyapqOjhX3Uiwnre+ABSjc uV+OSfVzKcU9jC4COcau608smujmWrLej27FpC6huGVr4yPvtUIO+jfECyegPSlOJXES T77g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774275332; x=1774880132; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b8yMxbo6eXfzrbt6N95ePZ3H8AA4JuIBdUqubCR3X58=; b=JK8gClfRRDxS45CCJI3HxQ0bHR++DdyvmTC1M7lQHtBD4/d4QkOTxO3S/jw91muX81 2eSLcZGz7HaiQqyXNsKByQ8X7ClifOFT+KoCm76lipoVKG9V5q3UFmCEnA/nta/g0zZU jrCR9B6ZBb2KFqr6tvW9gYOnPNgr88gSD17d3QD2aMmOjfxmkVoUlyq9uj5MBsYsZrKQ h7LsaJDgQ68x3Finx3JWfrYBB2heZCMOt2jSmyJ0f4Umo74Jufxf8tMxPkOHXjqWUbXM 0qy/Lf+cUgshsLx9L8SLTPhXNPDVcEIK0NeN9kWjNWQN5UbUqeVqK4WFlVvQXt4tkZ8G jagA== X-Gm-Message-State: AOJu0YwJKK+ktNNc4/NL43lCd+FnA+hjJd9MnEYrjdkxbF2ajM4DGi1w z/XaiXEizCSrT5fnT9KsTPsKmsWTqJLn2hAY3NjiySxZMqFqMth3kRqc X-Gm-Gg: ATEYQzwI8CaFCyoTjXBiEFH4bfRxYYf6cMQ56ITljnqt/AjjaH9xlNgJVxYQmmtDg6E 0xPPmf3xfVdJteCFQhKoRktWZosDfUPj/Izrg4GFuZp1NBkMrvrntAjdQQIJT+yqJIFSFcdMfvF mxw2XTi+9n1tY5EvTh8a3X/0dTGsvDDn0NnD//MJmBumIuqRWEybO5BC26ZCx5NGzub+hiy40ib 83xL1s2C7J9o3FXsaZMb92pYszy5LmCKz42FwQ1Oo0GBNAK/M4QAkl221D1ChAtn8n6/X0iuhdi JOIOMm0953kffY020vOFJhQ+iK+SLfmnJUrWP4ts3/x36YHTX288NliJXZsisOVXnCPihK/Gl1s HrcF/l9+L+UiRrKiiQVLBd2seE+JUAuVpqy4nTdVg5RuWOM7RY/BUh5V5mgxSiv05u5zUaFpHkk 9U+EWwqfXnm8ZQBrmig+yIOFDosvvuVZnc8LDdC+F4P/uqZu02FWyadDhR6Q== X-Received: by 2002:a17:90b:28d0:b0:35b:e52a:8a37 with SMTP id 98e67ed59e1d1-35be52a91f0mr5170481a91.15.1774275332141; Mon, 23 Mar 2026 07:15:32 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.237]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd40e4bfdsm9976864a91.9.2026.03.23.07.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 07:15:31 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] timers/migration: Fix memory leak in tmigr_setup_groups() Date: Mon, 23 Mar 2026 22:15:25 +0800 Message-ID: <20260323141525.34847-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" tmigr_setup_groups() allocates 'stack' via kzalloc_objs(), but in the case where WARN_ON_ONCE(i >=3D tmigr_hierarchy_levels) triggers, the function returns -EINVAL without freeing 'stack', causing a memory leak. Fix this by redirecting the error path to the common 'out:' label so that 'stack' is properly freed. Signed-off-by: Zhan Xusheng --- kernel/time/timer_migration.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c index 155eeaea4113..92bcf876630c 100644 --- a/kernel/time/timer_migration.c +++ b/kernel/time/timer_migration.c @@ -1804,8 +1804,10 @@ static int tmigr_setup_groups(unsigned int cpu, unsi= gned int node, } =20 /* Assert single root without parent */ - if (WARN_ON_ONCE(i >=3D tmigr_hierarchy_levels)) - return -EINVAL; + if (WARN_ON_ONCE(i >=3D tmigr_hierarchy_levels)) { + err =3D -EINVAL; + goto out; + } =20 for (; i >=3D start_lvl; i--) { group =3D stack[i]; --=20 2.43.0