From nobody Mon Mar 23 19:52:09 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4B163B635B for ; Mon, 23 Mar 2026 14:02:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774274522; cv=none; b=NnSXKoqrf/kvLE7IkMhgBa3deqPHpJz2yt7DzpxfdC4TXTcqhiHy4fZVgo8lc0JwvlTcgvMsHdyar9KCJP8F7BGQSNajq8sVf+uGOSSF13XHayhNLNvn4ddSMOE6VsoV9fZ9hhk73WDvVF1sYqPjJ/yccMimtQFtZq1iavLmgd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774274522; c=relaxed/simple; bh=v5RkR4GWFbiro/iChqZK9upkZLemhscU1rQeqe+R85Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rVNFHGnAj0/MmBakUmaxEUyxnQ7MZdGWJ7RNEpVK8m8/KeEH8vebTZPcMG9OhENh7gT5XkHkwtdUoP1hBr2VqaNjfqhI73wzcJnmXZyERdMWMHP/ss+jCNeBChT1DqvtNxk4Y2Mtr1yJnebiM0zKyKmF7npNnmvfqX2gUK94wXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IUxUDVi+; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IUxUDVi+" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82985f42664so175255b3a.0 for ; Mon, 23 Mar 2026 07:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774274521; x=1774879321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x9LErbosuoksV5lU780U3bAHDdZ81QQelsqNoxIkru8=; b=IUxUDVi+mscfx4KdLWQjbDYnJkMSXgk9mcPTX9TuC6V434ce6C8aUKEKi5EW+qxkwe n0+F8SXEpOQeXdPookeTOvb1FbY7IJGHuxhiK+piYLZKXye1swP/0W5JmjsKlvzYxMC9 dTE4EH3FeHKOmo7AKjzcFtbFZIjJFw2rt5xmWEnhARV69iEbePF64kjk8e9sh1m5/qLd eb+l9iiv6GLzb+h0CJ95forUw8qaIUg/KcuYM3vqGaF0HJEdGkUC/6lwSFr52pVSOvKc ctfMiRU+Ijr0MpqBTfgDyeybMxlD9Z6AnyjzdqVU+mJefs3IAGYEKV2vWRS/WFN8GCdg uZPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774274521; x=1774879321; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x9LErbosuoksV5lU780U3bAHDdZ81QQelsqNoxIkru8=; b=TuR8DRcvgU7SuiN1iANOeL5gb5PRMrA1KTyMr4x+fxqdeiaqqzqksDQ6OnUY0BP/lt 6TdZ3yBCU5s+d6t5NewTxPDYn9vwusYYXUO/pAZxLfWnEBfZnj1TIFI5ldYXlx51mC9T tBuvrjsNoy2forUmjkCkD8u/kz3gBE0Tobtpp8hHOVNOzdTS/OiQS0+dzpt+KSiBCu2e X+02ui7bDqPE/W4QPc95OWXIvC270cWMFRY+kewSv3PmzK7B4DusYu89yWjpCImuS87F IuwvMqziwMB1w5ceXZnkVeUu0dguezAiBqSWsM7MaSToCBcBZnnQ1O7Byp2qWEhXXCjQ zNSA== X-Forwarded-Encrypted: i=1; AJvYcCVedGE8g5DCuchr8alNwLIK9fER7vTgNa1kBEdbPoskS3lfHE3noVBL8pk70e1h9AF00npwc3yG4qN70TE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5/fdo0zKOBM1O7oEg7pYhmoJy9nwvNKwhUB/X+MjIoGt5dQnC FPRoJkyQjpVqAhk7nAlt1iFWuWg6AsxpOyaOMzWz9ezBkxqno0uxGeF/ X-Gm-Gg: ATEYQzyz0kSrrDfwbKktSS5EEElIag+keA9Io1lR0FwTb+OAi5vBBHB6RAjTJF6i3ca oSLuCUxyIzL+x8X+eo5r0pKuZFSr+0jAaq/DJjNwNTY+tQ7BzS784jB72eAkThbsRI6ykAuo5p6 oKSB6TS7+I/UxaQk4z2cWlltod015Wob9lbR7aAw0FRwgOfgVsERlGxluYrxXDnckxSAHxbmzS3 aFBrBxuWYDWgP0HmOv9hIP9VRr7UOToY9HOS8lNwr74Hfq3/SyUhw1hb48oY/0zE5lZHNbaRcVo 3oStDj0JIRGpaZo2V8dSSQSP66ySsX+OazFy7oUFj7H++9xYX2LIT8UdEEUmufekkDCYfm36GkM nnsnCpOWuriTfNDuKjf0WgPc5NAI5y9y5gg6b/O7js/9KCQZZ7tlNY5eGDh2PPi2l6Hf1zL4tHe +FIbsTneQH2IH4uQ== X-Received: by 2002:a05:6a00:23d4:b0:824:9451:c1f5 with SMTP id d2e1a72fcca58-82a8c3c091bmr9909481b3a.58.1774274520721; Mon, 23 Mar 2026 07:02:00 -0700 (PDT) Received: from lgs.. ([101.32.189.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b040da3dfsm9467282b3a.45.2026.03.23.07.01.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 07:02:00 -0700 (PDT) From: Guangshuo Li To: Eddie James , Ninad Palsule , Benjamin Herrenschmidt , linux-fsi@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li , stable@vger.kernel.org Subject: [PATCH] fsi: Fix refcount leak in slave init error path Date: Mon, 23 Mar 2026 22:01:51 +0800 Message-ID: <20260323140151.926607-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After device_initialize(), the lifetime of slave is expected to be managed through the device core reference counting. In the cdev_device_add() failure path, slave and its associated resources are freed directly, rather than releasing the device reference with put_device(). This may leave the reference count of the embedded struct device unbalanced, resulting in a refcount leak and potentially leading to a use-after-free. A possible fix would be to use put_device() in the failure path and let fsi_slave_release() handle the final cleanup. Fixes: d1dcd6782576 ("fsi: Add cfam char devices") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li --- drivers/fsi/fsi-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index c6c115993ebc..f447dd53db62 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -1084,7 +1084,7 @@ static int fsi_slave_init(struct fsi_master *master, = int link, uint8_t id) rc =3D cdev_device_add(&slave->cdev, &slave->dev); if (rc) { dev_err(&slave->dev, "Error %d creating slave device\n", rc); - goto err_free_ida; + goto err_put_dev; } =20 /* Now that we have the cdev registered with the core, any fatal @@ -1110,8 +1110,9 @@ static int fsi_slave_init(struct fsi_master *master, = int link, uint8_t id) =20 return 0; =20 -err_free_ida: - fsi_free_minor(slave->dev.devt); +err_put_dev: + put_device(&slave->dev); + return rc; err_free: of_node_put(slave->dev.of_node); kfree(slave); --=20 2.43.0