From nobody Fri Apr 3 20:53:01 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F6A43A960A for ; Mon, 23 Mar 2026 12:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269346; cv=none; b=Ba8prWeYSxLO65kJV0MjQKw+UPmsh3D+FvxfDcCIOkESmC2y+Zct4QxLwSMN1HR+4DMm90wqq+yuCqxxLj9bTu56sE5aOyLWNgHySWxI2UbJ7SIcu6XJErUTXsyPzVwRnNZH3LTYjdzA1WpjOBa316jlP5g/UKetLGogNznfuAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269346; c=relaxed/simple; bh=/z1jAWc3CVaiCtuoFHewxT/g6Yg7tIbkouJ2QC1CE/Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JQblbWzTY9Jxewo0cTMc3FVhd8nsTJ/waflozgGHWjqDrIjuICnXXusB90Z3bCJAbvvzV79UBxNiFYkiK/yY2YadhdJt1SmJZgUCmmrOPZTFvTAy9MoAOiSc1iG0cVUNjL0wLJNW0loUDPydz70StEQtaIW5n5Hi9Pzbq5Dn+lI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TftC9/a3; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TftC9/a3" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48541edecf9so657375e9.1 for ; Mon, 23 Mar 2026 05:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774269341; x=1774874141; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=oWv9PdQjKwbFf/ig9F419KVNonKx4G//Z6OQwOa1arE=; b=TftC9/a3XCFAiQgBcNZzlbiJJEeew04itxzohG21BiCFevMawkdHo/3p3XrGUp2njG fo8nl7e4AEJ7hFeQ+YH2d0cM9ZGW+FItIOS9uDX02yVTkv5AnPyA3Iu/k5Tws2p7HLhY HMcwk3EfUaK+3OKmlF3eVCu4lb20voeWPz6Oqbra5fwQ8MavJTOtXwn7TzyLcE+4Qdjq HjwvFyjr2erznj4YDynJf8yVLHHXXO8uqoLVAIoBWKyVP4lv7AOzYueUnaUHcE3FVUkT GKDG1ZXv8Db/lNA5JhObYVw5UAdwe3GDMNx27OSOygw1SuEOcR/HWf3o8IdFHPQhVPVs 8Wig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774269341; x=1774874141; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oWv9PdQjKwbFf/ig9F419KVNonKx4G//Z6OQwOa1arE=; b=mimwkQBA1113W+FepK3nkiTEIjcQJemoijGXHstoMD5V4HKSyqIFEuP6pVQMGRvgJs CjmU2zBjk5ZKadq8k9lPKUVoIN9VrwlW2nsA5KYDT8fTz5PzfspfP22hM+tjZnLpJ4xv Jn/HvvqtU2GDZKVtwrN+vJI7Qw0pQMRcmlJKqrqOv/om7E3I/NkK6HmeJy+nWEgfuHnj iK3gv72B5fVjiN7dpjz8eQoQz5K4q4NyiEv22610iMU05sbSbvPoMp80q7AB/QX9OE/X lGSq8lE/fFbhxOin5CvloF69A97CHUK7yOSsWcrGo7/ZfQlDzjEbkc8NwKB++k5nQ3QA TOjw== X-Forwarded-Encrypted: i=1; AJvYcCUuPUKob4Ns8nY8M7ZpMiQUXVkFCNhaUbieWESvTsjrehUzgD9ke2r2P4RC5vPedvtVbQVpCgcA8BtTvhA=@vger.kernel.org X-Gm-Message-State: AOJu0YwxDklTlORVba4WmBC08RDVw+S9ddohYRXn41s4YUVmjxSRiiSg qKzAN+Vj4q8pM4w8Tii4ZfZZ3Th8IV4+BwGFc+i9CmaTXqLJkAK+eiaO X-Gm-Gg: ATEYQzw6moJQrOTDlQL5Iv5ujsPnqNOIgAxFgSoXYfPm3/gapMEaqFmP2iRBh0HOPq/ 4Sa7JeXvPs9qfYo9scTJF7/AqnrVvbwG6+i25OPM9msoiv37S0xLCKXGWibcdl4XRRVjLMa53qk acPAtHyiS1KH8jFyedeVCfz5WwaCXidZ3A1n1XMSrolQN2ibgHv3MMj0Qo5DlrBqY2bXtQtfx+W QL1nOGhX1mMQeM0MLN3iFVVJclmo4atn9CThypyYf+dM7SM9wd6p9sl8XvCWLgMCJa1p89GLgQu 3ShdkksY2H5plH8MgrJRu85M91lJtXcTfJ5O3OeT+4PRZdp5U4++ZFjfzeZgNWkZ2fiKFRyNg2U lEVNFozwfCym1LacbrYoKHm7nJ1m1euUCUdL6bPU6ipIGCp3/hlhodV8WqFaO6LJuXkUNrgfpXi uB2wqCUR0PyG38bdWuoHThmI1t5rkMjMX7rjYu X-Received: by 2002:a05:600c:8705:b0:486:fcc7:d6a with SMTP id 5b1f17b1804b1-486feddb25amr182281845e9.13.1774269340892; Mon, 23 Mar 2026 05:35:40 -0700 (PDT) Received: from nixos-office ([92.250.99.190]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486ff1db3absm77635045e9.36.2026.03.23.05.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 05:35:40 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: gor@linux.ibm.com, hca@linux.ibm.com, iii@linux.ibm.com Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] s390: fix dead defaults for S390_MODULES_SANITY_TEST and S390_UNWIND_SELFTEST Date: Mon, 23 Mar 2026 12:35:36 +0000 Message-ID: <20260323123536.1413732-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These config options currently have unconditional defaults of 'n' from the def_tristate statement, which shadow the later default of 'KUNIT_ALL_TESTS', causing it to be dead code. It looks to me like the commit 25d36a85c61b ("s390/test_unwind: convert to = KUnit") added the KUNIT_ALL_TESTS default to S390_UNWIND_SELFTEST, but mistakenly didn't remove the previous 'n' default. Then, the later commit 90c5318795ee ("s390/module: test loading modules wit= h a lot of relocations") copied the Kconfig layout from S390_UNWIND_SELFTEST when adding the S390_MODULES_SANITY_TEST config option, without noticing the existing mista= ke. This dead code was found by kconfirm, a static analysis tool for Kconfig. Fixes: 25d36a85c61b ("s390/test_unwind: convert to KUnit") Fixes: 90c5318795ee ("s390/module: test loading modules with a lot of reloc= ations") Signed-off-by: Julian Braha --- arch/s390/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig index edc927d9e85a..1b3afe89cb00 100644 --- a/arch/s390/Kconfig +++ b/arch/s390/Kconfig @@ -999,9 +999,8 @@ config S390_MODULES_SANITY_TEST_HELPERS menu "Selftests" =20 config S390_UNWIND_SELFTEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT - default KUNIT_ALL_TESTS prompt "Test unwind functions" help This option enables s390 specific stack unwinder testing kernel @@ -1023,9 +1022,8 @@ config S390_KPROBES_SANITY_TEST Say N if you are unsure. =20 config S390_MODULES_SANITY_TEST - def_tristate n + def_tristate KUNIT_ALL_TESTS depends on KUNIT - default KUNIT_ALL_TESTS prompt "Enable s390 specific modules tests" select S390_MODULES_SANITY_TEST_HELPERS help --=20 2.51.2