From nobody Fri Apr 3 20:53:04 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36E6D1DF248 for ; Mon, 23 Mar 2026 09:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774258834; cv=none; b=Qcn6dUVsuuldy4yzMh4AaceIEUggizX7hFchifU6mPa+APOs3NmyW38j9mKB4mEQoJQiP+IEBTrSmCaslnWhK/tZR0EsWtgE74sWgY7u8okB2jIdZe58Cp2T5zLqHvx4QdbWqBTh0WIofoxjgFFw6ZtGH8VJi5XkmHZgUVNikZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774258834; c=relaxed/simple; bh=InFf+pZHROpxHQ0YFMA7CyIrioqbD8SqYfZclS1XbEg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eRKTymubnEG3p+FYNLh88ObX7FhdcfqAML5lydT9iD/3AlbEoFfSC4l3KdOGFu9ZmRDNjnB8GL1BarOxxKOkzThHef6O4L5ebkWom81BPjKy8DiGQi3ZcprZQUpchNpOv3NGFz//ZJ5zJupS+QyPPjo6oHcmsF5uJhthXf06LaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dv3AErnj; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dv3AErnj" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b061b6cf36so19998565ad.3 for ; Mon, 23 Mar 2026 02:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774258832; x=1774863632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ecGp/dA0Yu9oZZFz93r7/hSVGYyEetqpqN5wTpj3AUI=; b=dv3AErnj9tHQ5on9TnKeGJeRVBtIfuJk6Mh8KSq2Wav1vNJAFl/EPoviDyb++jDlp0 JVLcjEWrxwBb8EhXLUXCv12m2RlR4awUGChvJAqguQWKmB/aksCXrpnmU8u+k5z7VHe9 c1PpcZ4AWb6f8mqdI3HKvyWd/dgK/rt7wtjAVpMzfMv31cwe/9l9yU9T1w3orudS9/eD OaCZYHdGPOhvU0QLnVyLNhPKNZbvOxrWOG7awrGnSrH+0ox5qgcU/DYylhlTMjMpnDNH YHp0jGtjw/fN5+siNp386/UmPxhQzPszE+AUF+RycGiL4Vd4hUafrF9icgnA4mLHUJRb Eo2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774258832; x=1774863632; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ecGp/dA0Yu9oZZFz93r7/hSVGYyEetqpqN5wTpj3AUI=; b=PUaB29OoDEL6ayWvVKeDtJLGE+gXurSkYUMUFp4f9KZycMnsNg7LL/Xr0J2Seh9dcq QF6mlCtRfS6Jp/O3p3ox0/QfZPTxMPxpglWIiXoNx63ZZewxw0BTMqqvAfRaU5nigdhr wVsLIacMLhgpQbWtOv5We1U0jKNrxmWqAaKytbrCCDPGgXuaP/ZpcKIaZjFiTdM1pPyF w+2YdFUhO6h9ow7kWta7ghicyoT+LVl1LAxGU2Ab4rZjvBASXUx8KHiuv5nZNZYQMeVu VXwZkvEk1B0gm3kPN9iHK4nNv1aftOAvGYFtLFZ8Zza7e/wtKx6MP2XdtsaiCK6V0jvB 2UQA== X-Forwarded-Encrypted: i=1; AJvYcCUPRknJ3U1NZSKfefmVF8kvOiB6y/2STXZIrT9QmTyDFZKVmRNqJ0SwjbglOeSG6btousdLA7Qqw4PVgKA=@vger.kernel.org X-Gm-Message-State: AOJu0YwgfnGeRrQuKDear0vBcJzObsUpfKh5E0W+Iz5xfDRKDV2fArQn k/baBEim7jb3mgXdcjATSyF8jigwNNBwoKPUKehREhdQuScepZrsxXaf X-Gm-Gg: ATEYQzwad0Qjamih4Rl2apuqarC1/d7zJhlQDbGUHrJDvPTPESoeuuHLpUhNRnvZH6D ntibQuKWyZ3/x600FNdxnZ1FKw6xRMxsFv6JFAQXwwqaFtvhvcMmiYEHAhRg/d5rBHldNjpFgGf ynZkuXRkT7U3m8XviC1dzcyL+po3TluvfNANvOYQwuP8u4UWxaiWJJSH8/RHI0ucSbHXesBzkA+ L2ZxJno4J6SAywV0KV5iLu9jvX/pTzxaKVmwmnIKNIJRpwYOYikodZSaz4A5EG2e2zRCOdxXRIm KfUOnQavvFolaHfmtqRwq2pSVGe2a3Jhf++C19DjBy6jSNjypkQq1rN69Av20+C3b+7N+S+vJkl qo06NBDxplI2aNoseNU6znwvqRa1G7bW9qJ3PLQ6XlQcfl7JBNwHb/n4tsRlEcEp2zImGiP2gqk 79CFGhm+2FLUZWZyV1B8YHfaz27Q== X-Received: by 2002:a17:903:3890:b0:2b0:6638:b357 with SMTP id d9443c01a7336-2b0826c751dmr118483915ad.11.1774258832443; Mon, 23 Mar 2026 02:40:32 -0700 (PDT) Received: from ubuntu.. ([152.58.131.87]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08351675esm131984965ad.14.2026.03.23.02.40.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:40:32 -0700 (PDT) From: Anas Iqbal To: rafael@kernel.org, daniel.lezcano@kernel.org Cc: rui.zhang@intel.com, lukasz.luba@arm.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH] thermal: devfreq_cooling: avoid unnecessary kfree of freq_table Date: Mon, 23 Mar 2026 09:40:18 +0000 Message-ID: <20260323094018.2264-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dfc->freq_table is only allocated in the non-EM path via devfreq_cooling_gen_tables(). In the EM path, it remains NULL. Avoid calling kfree() unnecessarily when freq_table was never allocated. This resolves a Smatch warning: calling kfree() when 'dfc->freq_table' is always NULL. Signed-off-by: Anas Iqbal Reviewed-by: Lukasz Luba --- drivers/thermal/devfreq_cooling.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_co= oling.c index 597e86d16a4e..1c7dffc8d45f 100644 --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -472,7 +472,8 @@ of_devfreq_cooling_register_power(struct device_node *n= p, struct devfreq *df, remove_qos_req: dev_pm_qos_remove_request(&dfc->req_max_freq); free_table: - kfree(dfc->freq_table); + if (!dfc->em_pd) + kfree(dfc->freq_table); free_dfc: kfree(dfc); =20 --=20 2.43.0