From nobody Fri Apr 3 20:53:40 2026 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F422F154425 for ; Mon, 23 Mar 2026 09:07:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774256873; cv=none; b=Y2j8xMWWl6KNTtMu+sUfeDwxtHTenmpiIOc/50P6ou5CFiVV2iL/TDSWfBcjgzo8BeIW35TpAtuG9qwrl766mzhTHWWDAaLMFWHcojjMgsAgTIXnW/jsJ3GwJcRaSsf/7iLjDPVBOlHInKdaoQxRvqGiw5MM8Kv522e2+C3Z0cA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774256873; c=relaxed/simple; bh=ts+7+GHNZyvDw2h6YTerOrcY31nMTnuBJGMLJ1SeNig=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=UQCqa1sx2L8G0u/XAKhk679ucpmdhtJz3BQ3D+PqVAoy8dJM0MwulQk9Kj/0VVvvedeFwDAAj2kQ2HQjKAlHkBh/KqxatJG1E4eMCJlFKz9HzMqoyfbkbpkZ8xwP0owQj12ixgAtMLhQp5eZv8poQQHvaE7WbYDREQ0SZP4F2EE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=s90JS+ML; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="s90JS+ML" X-UUID: c0e6c852269711f1a39cd589f645bc18-20260323 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=/kKOvh8mzHk95zH5Sm/YNif6QPFXAR4KEc0obuavFZ8=; b=s90JS+MLvHuJ5N7Ps3FAj7s4QGW5hl1DbI+8W2VmcEkhCsUMoMGD7rX2uP67MRaGwfOsMcCE8id6YFttowY940S+ggs2nh5SR87QjO2u6Efv7mAX4RC2OcK4JJjvfkf4+HVeDCtik7+aKA5W87PzaSdwjoIOKDsWrVpA8qD1W+o=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:762ea9ba-d899-4467-ac59-3db32330f8ca,IP:0,U RL:0,TC:0,Content:56,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:56 X-CID-META: VersionHash:e7bac3a,CLOUDID:7ba107d5-060f-4ecc-9ee0-121eeeb4a682,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102|836|888|898,TC:-5,Content:3|15|5 0,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:-1,COL:0,OSI:0,OSA :0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: c0e6c852269711f1a39cd589f645bc18-20260323 Received: from mtkmbs09n1.mediatek.inc [(172.21.101.35)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 740399722; Mon, 23 Mar 2026 17:07:44 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by MTKMBS09N2.mediatek.inc (172.21.101.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Mon, 23 Mar 2026 17:07:42 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Mon, 23 Mar 2026 17:07:42 +0800 From: Jason-JH Lin To: Jassi Brar , Chun-Kuang Hu , AngeloGioacchino Del Regno CC: Matthias Brugger , Jason-JH Lin , Nancy Lin , Singo Chang , Paul-PL Chen , Xiandong Wang , Sirius Wang , Fei Shao , Chen-yu Tsai , , , , Subject: [PATCH] mailbox: mtk-cmdq: Fix CURR and END addr for task insert case Date: Mon, 23 Mar 2026 17:07:11 +0800 Message-ID: <20260323090742.1522607-1-jason-jh.lin@mediatek.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Content-Type: text/plain; charset="utf-8" Fix CURR and END address calculation for inserting a cmdq task into the task list by using cmdq_reg_shift_addr() for proper address converting. This ensures both CURR and END addresses are set correctly when enabling the thread. Fixes: a195c7ccfb7a ("mailbox: mtk-cmdq: Refine DMA address handling for th= e command buffer") Signed-off-by: Jason-JH Lin --- drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-= mailbox.c index d7c6b38888a3..547a10a8fad3 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -493,14 +493,14 @@ static int cmdq_mbox_send_data(struct mbox_chan *chan= , void *data) if (curr_pa =3D=3D end_pa - CMDQ_INST_SIZE || curr_pa =3D=3D end_pa) { /* set to this task directly */ - writel(task->pa_base >> cmdq->pdata->shift, - thread->base + CMDQ_THR_CURR_ADDR); + gce_addr =3D cmdq_convert_gce_addr(task->pa_base, cmdq->pdata); + writel(gce_addr, thread->base + CMDQ_THR_CURR_ADDR); } else { cmdq_task_insert_into_thread(task); smp_mb(); /* modify jump before enable thread */ } - writel((task->pa_base + pkt->cmd_buf_size) >> cmdq->pdata->shift, - thread->base + CMDQ_THR_END_ADDR); + gce_addr =3D cmdq_convert_gce_addr(task->pa_base + pkt->cmd_buf_size, cm= dq->pdata); + writel(gce_addr, thread->base + CMDQ_THR_END_ADDR); cmdq_thread_resume(thread); } list_move_tail(&task->list_entry, &thread->task_busy_list); --=20 2.43.0