From nobody Fri Apr 3 20:53:32 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886A2370D47; Mon, 23 Mar 2026 08:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774253339; cv=none; b=JUZ4XMXiTnFpSVTzjXTxiknrOSjIG3XHYpsBPfVLP5tbsWH6qOrKxSBmpwhWzwZ9GK/nAyJHdf9MI84yCZTZvo+HxCXVMtqUFg9bXPpBgHNlOJp90yoRi7Vk1TWiwVyE1E6aSIMxIh6Sjre1gYTBr3fo7qgQmecRRpoADaIP0PY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774253339; c=relaxed/simple; bh=J5pALpBg2dh7ONIB4aTvF9E3cdXjk9ivru91yK9RYzo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XxEgccRFboXAXaB5OrtaY/8cq0mk1wtU2LGC9AARQCvYMBbQf/jUvNvhIdTiuXBPzsQkamVfrOHlmzJ5R7lwdeCDY1RRyGlxDgtz4mw0eCW+n/tr+wN0AEhnO/jMQMcgq8MHGNOb6RQjRxQgqpJdJDL7p3QE+OXYM82Qzh/DyJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.197]) by APP-03 (Coremail) with SMTP id rQCowAB3ldwN9cBpPEeHCw--.12178S2; Mon, 23 Mar 2026 16:08:46 +0800 (CST) From: Pengpeng Hou To: Michael Chan , Pavan Chebbi , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Pengpeng Hou Subject: [PATCH v2] bnxt_en: validate firmware backing store types Date: Mon, 23 Mar 2026 16:08:45 +0800 Message-ID: <20260323080845.40044-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAB3ldwN9cBpPEeHCw--.12178S2 X-Coremail-Antispam: 1UD129KBjvJXoW7trW8Kw45Xr47Kr4DKFW3Jrb_yoW8ArW5pF Z8JFy3Ww18GF13tayftF48ZFn8uw4xt348Gry7CwnYvF1YvFyUXr9akF90qryDZF48Crya qF45ZFW5AFWDWwUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Y14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUGVWUXwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1x MIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCT nIWIevJa73UjIFyTuYvjfU0GYpUUUUU X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" bnxt_hwrm_func_backing_store_qcaps_v2() trusts resp->type from the firmware response and stores it in ctxm->type. That value is later used to index fixed backing-store metadata arrays such as ctx_arr[] and bnxt_bstore_to_trace[] without a local range check. Validate the returned type before storing it and abort the query when firmware reports a type outside BNXT_CTX_V2_MAX. This keeps the fix at the point where the untrusted value enters driver state. Signed-off-by: Pengpeng Hou --- v2: - add commit message context and fix rationale - no code changes drivers/net/ethernet/broadcom/bnxt/bnxt.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index 0751c0e4581a..d0446f851d66 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -8692,6 +8692,7 @@ static int bnxt_hwrm_func_backing_store_qcaps_v2(stru= ct bnxt *bp) u8 init_val, init_off, i; u32 max_entries; u16 entry_size; + u16 resp_type; __le32 *p; u32 flags; =20 @@ -8715,7 +8716,15 @@ static int bnxt_hwrm_func_backing_store_qcaps_v2(str= uct bnxt *bp) else continue; } - ctxm->type =3D le16_to_cpu(resp->type); + resp_type =3D le16_to_cpu(resp->type); + if (resp_type >=3D BNXT_CTX_V2_MAX) { + netdev_warn(bp->dev, + "invalid backing store type %u returned by firmware\n", + resp_type); + rc =3D -EINVAL; + goto ctx_done; + } + ctxm->type =3D resp_type; ctxm->entry_size =3D entry_size; ctxm->flags =3D flags; ctxm->instance_bmap =3D le32_to_cpu(resp->instance_bit_map); --=20 2.50.1 (Apple Git-155)