From nobody Fri Apr 3 22:48:59 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0453435E529 for ; Mon, 23 Mar 2026 07:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774250141; cv=none; b=M5SpuK6/0/JsXjPIyGCef1okHvGv6DLiMoT3IlXR+6DvxJQmkJo66KXuojU255NbO8odKbDOF5hFWdfRB09AvZq0CzJ3ALQAPRmGp35caPiy0uyo780VUkhVvoyE7JtctZXee430j7yFnC9PWlDpFzrOCr3GsOJ5qzSv6/mNsJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774250141; c=relaxed/simple; bh=oBZX5oNsob2YIu+H4T5mZfN/nQNZqNp8MhN/QQd4wrI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jvWqe0hfI+EnX7Ce63qIUbj9YI9EwHQBG7//+zlVhlstSCaFI4TPNAGrdZY/ZKqGQI51IUE2PfnJqhJ1UEncDbg9Htc7gM1sBXwDTGt+ayXyqCw7Gl5sY1M11NYNXaHbqk6wJTYmMq9PaDXTuwqp14YFqtHTBxbm0ZmpZXHgjTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C7w7TE1V; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C7w7TE1V" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2aae4d2d215so14634275ad.2 for ; Mon, 23 Mar 2026 00:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774250139; x=1774854939; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=G84ar5OFwPS1ZIDT1z7k87iUKtwKqphERZsWCCAaZV0=; b=C7w7TE1VLVMVEGiI00adW9Z0T/1ZHKDQAVAV6YCpLHLzLoBTVO8rsl/+pzbgat8+3v 9liZfdspubV72O4cAKli/LQLFdDEtDU3u4pIRxUBlDNbw/q8k/gQRkeVk15IKyyttcb7 XGR7xxzyGuS4iV9SCYSX9pnsZ/UG7rzEyLeuIxBjBm9v7Ffn8/IdL2LidBbguILeO3i9 GUC96V/1WdyIN/kKYLOb8OOg+MYn2Ekq+5g/GdEU7dAsmcgp9NJqJii+LhP4Z9zjDtoY gpOMwIIVXj004gz3RTVzKhIIQAf02CHWBVxcMFR+3BKYKIlHArvsiOCW2VB8Vtgd7c0g N65g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774250139; x=1774854939; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G84ar5OFwPS1ZIDT1z7k87iUKtwKqphERZsWCCAaZV0=; b=GXqZbZuMyn5uWFKtPtQJNd4nljoUpeq6ZNG7+HssiW36WQPtXOhzbJTraQHvKZAbJR PICoK7O2wNToN3NEzqdV/6nI3GLxXkPPjO6cSY0S7t5AyDy21LJr6x6MOYm8UW7KIpmh 1872IVEbXl2G7zxpOl3JfU72SCuVmcMkgYWyXtBLNwpeNXQeRqexO+G7qxQh7VokIdYg uPPvZ9njiP2m78DMAHazl8mUi4RsKh7Cd0HZPscznQKDkW7VTMtEbKvPmqB7d0s8wT0E NqjmlayM8KwYUgj7zQvzHzoW4poe/IO/w2svrtkVjA9xSnHazX+YJkYQ4LfJxFC/JqX6 mikQ== X-Forwarded-Encrypted: i=1; AJvYcCXAZmYwO5d+zn/Yc7ZVraPYiekYdRdjcnTARozDUBcEC1AtB8vTaNvSTX4jrCWSPD3TvPGWN852McSzfUs=@vger.kernel.org X-Gm-Message-State: AOJu0YySwozrDDHSIfw0nqbVpkyP5XsxUqneRckFywb7o9qF4L2TDTWA RbePr+sDJB5DBx49YwP51fEifq23cOyszMK4WRo5cTaHOz3hYr6mc2FZ X-Gm-Gg: ATEYQzxKSr7wF+KLifrAuPEuercPSUlmJh/HwQsEfT7DYo1CiGliYL9Lqhba9hgDjfR 6E3R2v0UroLbuzboV9oQTKfq6ZqL0bSSwsoo6E3Oo0PyttU+4BeVicrP0YE50CjIC7IWpyF+Nhl 8TsNHsIjgyN/ZBZbKMY+K8MMYWQNTmlyfTBNwQLnPH4nvyVOfdy3LY7mbRLKx+fg7HMq6YYhWYx zrIi9hlO3wP9+pD3oda+YkD25iJImIsgMw/8maM26on6QJ4NbefWAf6XezWpzxsHE85dGVOO7rU poo5msa9nzrIyXtxgTbJk5YZuXpoSDJyQJeKhWItl/Hu55WwNYVFTcu56ECXpdJtSNg9zNc4ClN i1NZIknlQLAS40vZZ5RSctpgqJ6knNWTosruQMm/QQbwACAuKRKFXRLFs+a0pF+GHyEMS12W8Al pM1l7Jxp8baerztJox2OdrlYieZawPQ5i+ X-Received: by 2002:a17:902:e811:b0:2b0:4f82:74c6 with SMTP id d9443c01a7336-2b0828009d2mr73276475ad.8.1774250138885; Mon, 23 Mar 2026 00:15:38 -0700 (PDT) Received: from localhost.localdomain ([189.1.242.96]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08369617dsm125119955ad.71.2026.03.23.00.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 00:15:38 -0700 (PDT) From: sunichi To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: horms@kernel.org, kuniyu@google.com, gnault@redhat.com, leitao@debian.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sunichi Subject: [PATCH] net/mpls: fix missing NULL check in mpls_valid_fib_dump_req Date: Mon, 23 Mar 2026 15:15:15 +0800 Message-Id: <20260323071515.1945612-1-sunyiqixm@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The attribute tb[RTA_OIF] is dereferenced without verifying if it is NULL. If this attribute is missing in the user netlink message, it will cause a NULL pointer dereference and kernel panic. Add the necessary check before using the pointer to prevent the crash. Signed-off-by: sunichi --- net/mpls/af_mpls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index d5417688f69e..28bbea30aae3 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c @@ -2174,6 +2174,8 @@ static int mpls_valid_fib_dump_req(struct net *net, c= onst struct nlmsghdr *nlh, int ifindex; =20 if (i =3D=3D RTA_OIF) { + if (!tb[i]) + return -EINVAL; ifindex =3D nla_get_u32(tb[i]); filter->dev =3D dev_get_by_index_rcu(net, ifindex); if (!filter->dev) --=20 2.34.1