From nobody Sat Apr 4 00:24:37 2026 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D77D2D8DA6; Mon, 23 Mar 2026 06:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=92.121.34.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774247281; cv=none; b=KYfyJen8boKG6zsHSmdBdJF6nu0ECfr7vdku4j2Mkm5wFnLwQZfOgWra+QenPHAiYzdKlV93L91aHstlhDh5zMiOBQnFQ/96SD9yYsS08Qyy7pL6dV2e3jV3AWZggotYwssDDn23RH6NeJt1NLp/dnPK5A5tkTzsm/SRTrHZ/iw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774247281; c=relaxed/simple; bh=Xa26ZYxb4Gsg0IhGiuU/gR4t9zef9EdcqTVuIo62dEY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Qo8c2tvIFZgvB0NuxjEdFci6x9QquhsQbXObV3wWwViA7oBkeBgXSClN02mGbU4cLqYN4dCWSMi8k0/v+BC8Q2OId0l61FZeLyqyj2D7atSYhOm6QUq0/tWbHXIjfWNq4LzAh1YEiVfY49hG1TzW1EyPtzb7YTdod5OhjmK2Sz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; arc=none smtp.client-ip=92.121.34.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 24B541A09F4; Mon, 23 Mar 2026 07:27:50 +0100 (CET) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id E1FA91A0A04; Mon, 23 Mar 2026 07:27:49 +0100 (CET) Received: from lsv03900.swis.in-blr01.nxp.com (lsv03900.swis.in-blr01.nxp.com [10.12.177.15]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 952DE180221C; Mon, 23 Mar 2026 14:27:48 +0800 (+08) From: Lakshay Piplani To: linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org, alexandre.belloni@bootlin.com, krzk+dt@kernel.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, broonie@kernel.org, lee@kernel.org, Frank.Li@nxp.com, lgirdwood@gmail.com Cc: vikash.bansal@nxp.com, priyanka.jain@nxp.com, aman.kumarpandey@nxp.com, lakshay.piplani@nxp.com Subject: [PATCH v8 4/7] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator Date: Mon, 23 Mar 2026 11:57:34 +0530 Message-Id: <20260323062737.886728-5-lakshay.piplani@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260323062737.886728-1-lakshay.piplani@nxp.com> References: <20260323062737.886728-1-lakshay.piplani@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP Content-Type: text/plain; charset="utf-8" From: Aman Kumar Pandey Add core MFD support for the NXP P3H2x4x (P3H2440/P3H2441/P3H2840/P3H2841) family of multiport I3C hub devices. These devices connect to a host via I3C/I2C/SMBus and expose multiple downstream target ports. Signed-off-by: Aman Kumar Pandey Signed-off-by: Vikash Bansal --- Changes in v8: - No change Changes in v7: - Use new config I3C_OR_I2C Changes in v6: - No change Changes in v5: - Corrected the ordering in the Makefile and Kconfig for MFD_P3H2X4X - Updated dev_err_probe() for regmap_init failure. - Updated module description Changes in v4: - Split the driver into three separate patches(mfd, regulator and I3C hub) - Added support for NXP P3H2x4x MFD functionality --- --- MAINTAINERS | 2 + drivers/mfd/Kconfig | 13 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/p3h2840.c | 125 ++++++++++++++++++++++++++++++++++++ include/linux/mfd/p3h2840.h | 27 ++++++++ 5 files changed, 168 insertions(+) create mode 100644 drivers/mfd/p3h2840.c create mode 100644 include/linux/mfd/p3h2840.h diff --git a/MAINTAINERS b/MAINTAINERS index c72976dbdf31..4f67fe64c833 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19101,6 +19101,8 @@ L: linux-kernel@vger.kernel.org L: linux-i3c-owner@lists.infradead.org S: Maintained F: Documentation/devicetree/bindings/i3c/nxp,p3h2840.yaml +F: drivers/mfd/p3h2840.c +F: include/linux/mfd/p3h2840.h =20 NXP PF5300/PF5301/PF5302 PMIC REGULATOR DEVICE DRIVER M: Woodrow Douglass diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 7192c9d1d268..14f4736683a1 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -617,6 +617,19 @@ config MFD_MX25_TSADC i.MX25 processors. They consist of a conversion queue for general purpose ADC and a queue for Touchscreens. =20 +config MFD_P3H2X4X + tristate "NXP P3H2X4X I3C Hub Device" + depends on I3C_OR_I2C + select MFD_CORE + select REGMAP_I3C + select REGMAP_I2C + help + Enable Support for NXP P3H244x/P3H284x I3C HUB device using I3C/I= 2C + communication interface. + + This driver provides support for I3C hub and regulator, each subd= river + can be enabled independently depending on the required functional= ity. + config MFD_PF1550 tristate "NXP PF1550 PMIC Support" depends on I2C=3Dy && OF diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index e75e8045c28a..aaadf50fedf4 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -122,6 +122,7 @@ obj-$(CONFIG_MFD_MC13XXX) +=3D mc13xxx-core.o obj-$(CONFIG_MFD_MC13XXX_SPI) +=3D mc13xxx-spi.o obj-$(CONFIG_MFD_MC13XXX_I2C) +=3D mc13xxx-i2c.o =20 +obj-$(CONFIG_MFD_P3H2X4X) +=3D p3h2840.o obj-$(CONFIG_MFD_PF1550) +=3D pf1550.o =20 obj-$(CONFIG_MFD_NCT6694) +=3D nct6694.o diff --git a/drivers/mfd/p3h2840.c b/drivers/mfd/p3h2840.c new file mode 100644 index 000000000000..65090a09f7c6 --- /dev/null +++ b/drivers/mfd/p3h2840.c @@ -0,0 +1,125 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright 2025 NXP + * P3H2x4x i3c hub and regulator device. + */ + +#include +#include +#include +#include +#include + +static const struct mfd_cell p3h2x4x_devs[] =3D { + { + .name =3D "p3h2x4x-regulator", + }, + { + .name =3D "p3h2x4x-i3c-hub", + }, +}; + +static const struct regmap_config p3h2x4x_regmap_config =3D { + .reg_bits =3D P3H2x4x_REG_BITS, + .val_bits =3D P3H2x4x_VAL_BITS, + .max_register =3D 0xFF, +}; + +static int p3h2x4x_device_probe_i3c(struct i3c_device *i3cdev) +{ + struct p3h2x4x_dev *p3h2x4x; + int ret; + + p3h2x4x =3D devm_kzalloc(&i3cdev->dev, sizeof(*p3h2x4x), GFP_KERNEL); + if (!p3h2x4x) + return -ENOMEM; + + i3cdev_set_drvdata(i3cdev, p3h2x4x); + + p3h2x4x->regmap =3D devm_regmap_init_i3c(i3cdev, &p3h2x4x_regmap_config); + if (IS_ERR(p3h2x4x->regmap)) + return dev_err_probe(&i3cdev->dev, PTR_ERR(p3h2x4x->regmap), + "Failed to register I3C HUB regmap\n"); + + p3h2x4x->is_p3h2x4x_in_i3c =3D true; + p3h2x4x->i3cdev =3D i3cdev; + + ret =3D devm_mfd_add_devices(&i3cdev->dev, PLATFORM_DEVID_NONE, + p3h2x4x_devs, ARRAY_SIZE(p3h2x4x_devs), + NULL, 0, NULL); + if (ret) + return dev_err_probe(&i3cdev->dev, ret, "Failed to add sub devices\n"); + + return 0; +} + +static int p3h2x4x_device_probe_i2c(struct i2c_client *client) +{ + struct p3h2x4x_dev *p3h2x4x; + int ret; + + p3h2x4x =3D devm_kzalloc(&client->dev, sizeof(*p3h2x4x), GFP_KERNEL); + if (!p3h2x4x) + return -ENOMEM; + + i2c_set_clientdata(client, p3h2x4x); + + p3h2x4x->regmap =3D devm_regmap_init_i2c(client, &p3h2x4x_regmap_config); + if (IS_ERR(p3h2x4x->regmap)) + return dev_err_probe(&client->dev, PTR_ERR(p3h2x4x->regmap), + "Failed to register I3C HUB regmap\n"); + + p3h2x4x->is_p3h2x4x_in_i3c =3D false; + + ret =3D devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_NONE, + p3h2x4x_devs, ARRAY_SIZE(p3h2x4x_devs), + NULL, 0, NULL); + if (ret) + return dev_err_probe(&client->dev, ret, "Failed to add sub devices\n"); + + return 0; +} + +/* p3h2x4x ids (i3c) */ +static const struct i3c_device_id p3h2x4x_i3c_ids[] =3D { + I3C_CLASS(I3C_DCR_HUB, NULL), + { /* sentinel */ }, +}; +MODULE_DEVICE_TABLE(i3c, p3h2x4x_i3c_ids); + +/* p3h2x4x ids (i2c) */ +static const struct i2c_device_id p3h2x4x_i2c_id_table[] =3D { + { "nxp-i3c-hub" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(i2c, p3h2x4x_i2c_id_table); + +static const struct of_device_id p3h2x4x_i2c_of_match[] =3D { + { .compatible =3D "nxp,p3h2840", }, + { /* sentinel */ } +}; + +MODULE_DEVICE_TABLE(of, p3h2x4x_i2c_of_match); +static struct i3c_driver p3h2x4x_i3c =3D { + .driver =3D { + .name =3D "p3h2x4x_i3c_drv", + }, + .probe =3D p3h2x4x_device_probe_i3c, + .id_table =3D p3h2x4x_i3c_ids, +}; + +static struct i2c_driver p3h2x4x_i2c =3D { + .driver =3D { + .name =3D "p3h2x4x_i2c_drv", + .of_match_table =3D p3h2x4x_i2c_of_match, + }, + .probe =3D p3h2x4x_device_probe_i2c, + .id_table =3D p3h2x4x_i2c_id_table, +}; + +module_i3c_i2c_driver(p3h2x4x_i3c, &p3h2x4x_i2c); + +MODULE_AUTHOR("Aman Kumar Pandey "); +MODULE_AUTHOR("Vikash Bansal "); +MODULE_DESCRIPTION("P3H2x4x I3C HUB multi function driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/p3h2840.h b/include/linux/mfd/p3h2840.h new file mode 100644 index 000000000000..cba6fa516d1e --- /dev/null +++ b/include/linux/mfd/p3h2840.h @@ -0,0 +1,27 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright 2025 NXP + * This header file contain private Reg address and its bit mapping etc. + */ + +#ifndef _LINUX_MFD_P3H2840_H +#define _LINUX_MFD_P3H2840_H + +#include + +/* Device Configuration Registers */ +#define P3H2x4x_DEV_REG_PROTECTION_CODE 0x10 +#define P3H2x4x_REGISTERS_LOCK_CODE 0x00 +#define P3H2x4x_REGISTERS_UNLOCK_CODE 0x69 +#define P3H2x4x_CP1_REGISTERS_UNLOCK_CODE 0x6a + +/* Reg config for Regmap */ +#define P3H2x4x_REG_BITS 8 +#define P3H2x4x_VAL_BITS 8 + +struct p3h2x4x_dev { + struct i3c_device *i3cdev; + struct regmap *regmap; + bool is_p3h2x4x_in_i3c; +}; +#endif /* _LINUX_MFD_P3H2840_H */ --=20 2.25.1