From nobody Fri Apr 3 22:33:35 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14BA02D77F7 for ; Mon, 23 Mar 2026 06:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774246298; cv=none; b=OMKnGVPQP9hlQjrYJT9PuQ7QSXP8lGMgImvuDERfWe9bt6ZUHAA0tKy/GzxOVoxS7BWKsnRkrsBeTkhzTLUbs2XTW/t6f4IGPEEaON/n/YzJBHwESr7VvLDq/xPFFuDcDl++vqfpiRAhemMSh53MM9oTJcY/VsS5ufvRhxWNoYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774246298; c=relaxed/simple; bh=zP+0mcQUDNq8fX/zlO2jHB3LKgZCRcykrpgJxEf5IHg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LraiqqL2q7ki5zMEzkBcQb794zXJdXgF/reGVPYKUoHIXFxO3zzSNIAqc159Se35KyqrHWQ/o7Eh7tX+6r3B34fJeIx9lTkk1R8Ti+fpdoW5KC+/pKMAmqr4FOGSjeJYrJngkMtr0CTJm2U0M0E7DMNn0aCGp0SpFvVaxeVl6aI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mV1HF/CT; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mV1HF/CT" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-824c9da9928so4144232b3a.3 for ; Sun, 22 Mar 2026 23:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774246296; x=1774851096; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=633WHBFbNkwK4Zij2Rd3cLNtIgcg49AlsRqIj/bkpiw=; b=mV1HF/CTx9W+qwQG1BrPVw5GiVArUanPjFztds64zIWaOUneiJ3zVq3YAnqPWKNduC 3pDhX6T+lo9o3+jHc/xQMQFvNGyDwQNSPSlSOZN/JeY2NavsYbnBYzRw7ILbl9/XgJha hfiqxp1pu9ui5HpxS875IdtnJLuDWP7MohH+swzzHqJtrP097VcFS+sh6OAk+KN4oi3F 3j77vTS+4rr7uhLWXMJ7Iga0uTXpJt9zvV/ofN4UPiF+09WaEWkOsaeJqGHTEm277U99 vRy+D3NEq0tIB2EOktofLurOvD4RVq/MXZusjrGEfVCpM2Tg87kCbkpVoAouuc5g6YUE iSLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774246296; x=1774851096; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=633WHBFbNkwK4Zij2Rd3cLNtIgcg49AlsRqIj/bkpiw=; b=mCtPjEm1tzKQM5l+1TqIxq2F/NMMiXXttfL0WJyiyjN7LYeelh6cvxHjtBSr5R5JF2 OBRMcSBxUn37DyJ4l0oazS52XE8iW35MbEicQeUj0/FA0g7jPMkOcAd00HY1sDCTJ0C+ k1a3cpk0Fb1d/HLLJMbhky4Jc8lf/FSUK9KzShDMJ+MtU/NDm/h7VQ+B+iBLnhoUrkjd twSdmuMegPDEDLKrJLwwVFBCt4SB53JSwFRt/cB5yGOYqW4OXzwZ+k1132+mZxT0jxDa z5kGPcXivZc90ZowZOdde3BaYYOV9dFC10rqY/KMrhIb9r5id/0dUHLNRLKKdcXNK/6Q aicQ== X-Gm-Message-State: AOJu0Yw0nlmsKZKIHTPQLE4K66gO7Vz3XWJQMkc2EYx3vkgdyTixRle+ QfHkWUNTduQNrkcYgLZ44APiGj5j1JwQzUDMNgPk17rnhJX0fCXoYbhj X-Gm-Gg: ATEYQzxHkBw4kzNGuumCFh7RnuTDEwEJsp4k2vjixlNntGFw9jzIJ2GmSWzDEDRH+EH 4f7pyXBzg89Mqm49DIccStnkZwv+OuGOCyL5J/NfOInqt66AMQCWweCC5Bi49F2hPh00326PAg0 s7nI6p28YMFiZZHwqWhmc+pN/QxEbbqi+R6IfWRm3PZIsW/72DHJG9oXitSagqjcmuYHhJY1O4u msjMGauNbgwHT2xfajGV4aO7Pd00JeflbG9UVkmJmXGYxSYztdOosACftXExNVDks+Hz9aJSXQk kXjYGaYpLZWaKJ8CAPPcI3Gt5Cxp2V3bxO5GrbXMl0GkQkw2K4cVgh1ak1xLzx2lERZ8w8sgsWf mQwKoDgqewXFe4oeful4qrgh6K7a3WFdi7qh9M/PyxDXXGgHgzHgvd2EMklrhmF1rvQcYT8xct8 qYrubfySmEtAEqssB4wv4DZtHrDy3iOF3CrGSZ2peWCp8rjYA= X-Received: by 2002:a05:6a00:1a89:b0:829:9fa3:5c8b with SMTP id d2e1a72fcca58-82a8c3b91fdmr9053736b3a.55.1774246296341; Sun, 22 Mar 2026 23:11:36 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.237]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b0409b448sm8034918b3a.39.2026.03.22.23.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 23:11:35 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] alarmtimer: Fix argument order in alarm_timer_forward() Date: Mon, 23 Mar 2026 14:11:30 +0800 Message-ID: <20260323061130.29991-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" alarm_timer_forward() passes arguments to alarm_forward() in the wrong order: alarm_forward(alarm, timr->it_interval, now); However, alarm_forward() is defined as: u64 alarm_forward(struct alarm *alarm, ktime_t now, ktime_t interval); and uses the second argument as the current time: delta =3D ktime_sub(now, alarm->node.expires); Passing the interval as "now" results in incorrect delta computation, which can lead to missed expirations or incorrect overrun accounting. Fix this by swapping the arguments. This issue has been present since the introduction of alarm_timer_forward(). Fixes: e7561f1633ac ("alarmtimer: Implement forward callback") Signed-off-by: Zhan Xusheng --- kernel/time/alarmtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c index 069d93bfb0c7..b64db405ba5c 100644 --- a/kernel/time/alarmtimer.c +++ b/kernel/time/alarmtimer.c @@ -540,7 +540,7 @@ static s64 alarm_timer_forward(struct k_itimer *timr, k= time_t now) { struct alarm *alarm =3D &timr->it.alarm.alarmtimer; =20 - return alarm_forward(alarm, timr->it_interval, now); + return alarm_forward(alarm, now, timr->it_interval); } =20 /** --=20 2.43.0