From nobody Fri Apr 3 22:13:21 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9EAF288505 for ; Mon, 23 Mar 2026 05:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774243316; cv=none; b=b/wCkFzfIdBYeoGN6wWqYBNr/p1RZnZIukKSjZZvMUucUhAHCgAJAEiyM4928GIM+l8Kw5OeuKeNdKP45w9MTxw2MeJ0x/Gii1ImAX/8gFoPWhLXOhEp15GE0mUE1PZP25uMpkTIKxFR7WQRDkaVnXx7QS+1pZ9RbJogoFUINjM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774243316; c=relaxed/simple; bh=nkpfooB231w08yEuMmEI3pOCLhwFDkpkvgaj5ETgiwM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dnhaoEfmJDzNJ5DqOowZafy0AD9fDA2gjJb4SRd/opunsDuqi5MEnHSg9D9Z0f8JQuaiaERCUHbxiCyxf5oVBlodHgmK1kdCbVMFoHD1poBviOobwyagpsWc1ogHpV61SI/+LSxWqW+MTo2OdF/fgiFJhJUqlv2a9tWtSDbq10I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QV05X04Z; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QV05X04Z" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35a09e0dd63so3226956a91.3 for ; Sun, 22 Mar 2026 22:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774243315; x=1774848115; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NanPiL1bkZBnaJPUdNrmZem0Ql51ml2Y45NTYmJIv+I=; b=QV05X04ZkqK6wUz1L76bKCNMwMDiKsQth1GFvF4CL9K1lUy0QNttI+G0ajpXsX2RRV MGqKXACkDBahGUKfXaBPsrVcvJd8XicM/sZkdpNY3qaBLseWxw+UNKWBAVN33GbbwYs1 2IcNWBm7gEDIiscVC+f26KX95sARmTHPU57IZ0FpJFxPWsI0PAIbqN2+ZVSl5bp89tW3 LBZp8bvon5OkGJZYLd4w0XnYykglx8rHnMdHTM/JmfOOLieTr2sglAikSV6oIMPSg/vk v67xM5Xrt96DOBh7aj5xN79diPm5ZEJBznt8D1bpetDzKDMHoO2z3yggCbOUD1EOKKtc YanQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774243315; x=1774848115; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NanPiL1bkZBnaJPUdNrmZem0Ql51ml2Y45NTYmJIv+I=; b=mtIm19z9HyFHYC8ksLwikqXcA2HCyy34RK3FjlSrP5aFPpsunBBLLWi2o1io7sq4Sy vKgkKK0NzZLzHNn3qB0Xk3y8//K9S+bWRTqUNEBS3VdjGsIMMB2YFLpKSzLZDUucobs2 NHUiAjKRoyp2nmiK49Ods5EKvWD2xopwBP1o7nIE5NdcspTw0/yEwxp/FG5hslsqdPoz Xxj/bunkkBq71puODgCP4HFPW2w0RTRvQt8PP7+MzSLNJWYEuvxA2OvBaog+uHXLjivW USEWX9RFWBPHzKmlG/AQb/v9+zPh/ORRmF5DkmnuMsHJFabDynA5uWFUDypQNZTV+crS hQaQ== X-Forwarded-Encrypted: i=1; AJvYcCWrsSCpEQxy3BN2oMmNnULFsKosdVzHKFSIsK/I6fsFHJ8kqTTWeEOu6qOg8dILAda+n0xnVVypoMIO6OQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwhR2AFcgMBWcBCmtFWRL1GMsQ+TdE/YtqezxiBYRI2DFNOGk0d AiPCnaU8PD9CPNBm7htrRgkQyp/HjuiAxlpTJGyoBhSj4/CHw0hQuBz0 X-Gm-Gg: ATEYQzw1Ab/fybrPaYXNNMacuoXlF2kfF7ffmTvjiX//7k31mugCgnNMu28oHi5kv1G 40dNA4G+bOrEpV38CKhAhk6fwGnWaNUKUVvcjdoG0X6OO2UT4aTyJcbUXuGN6QccwOeR7o43RpD 7qHL9fMD0LfTRHxEhh3/4AfU3tx1edNbd3iuwLJ69RXOAIe2ieVmuyNRxasyhr11y+tzi3j1+lX dLiGEoKQr2siVK2YEwZkJsRjFIBL4DTUjDgxHWI4VD7RABhKGP7bf3gZQblwkHn9672KCCoe3HR 8i/Xs5vvlC5t/ZaRoN5SrZCyMJDfhESXk0sF4nb3ZnFKyk0K2nw47jL8Vrb4gaOEziMFiKu88hl MXF+PyQMFZ9JTicVeJtGlReXK6Tfr643hHYZqZf2Qu4p1OnTv0FuyoJ1TlZnZnpfNlrgJrKyKA/ DKSsRTrwyBLSsLUHRFhnQbQpWwzsnutcxpdKqT6sKbPQF4IPVonJCJ7CvQlAuUQ0SYIapAmnt4Y JN1KA== X-Received: by 2002:a17:902:cf05:b0:2b0:665b:c7de with SMTP id d9443c01a7336-2b0827c1676mr102331455ad.40.1774243315196; Sun, 22 Mar 2026 22:21:55 -0700 (PDT) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:b0b:762f:8715:d6ad]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b083655b45sm127608245ad.42.2026.03.22.22.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 22:21:54 -0700 (PDT) From: Deepanshu Kartikey To: almaz.alexandrovich@paragon-software.com Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+7adcddaeeb860e5d3f2f@syzkaller.appspotmail.com, Deepanshu Kartikey Subject: [PATCH] ntfs3: fix memory leak in indx_create_allocate() Date: Mon, 23 Mar 2026 10:51:48 +0530 Message-ID: <20260323052148.1239035-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When indx_create_allocate() fails after attr_allocate_clusters() succeeds, run_deallocate() frees the disk clusters but never frees the memory allocated by run_add_entry() via kvmalloc() for the runs_tree structure. Fix this by adding run_close() at the out: label to free the run.runs memory on all error paths. The success path is unaffected as it returns 0 directly without going through out:, transferring ownership of the run memory to indx->alloc_run via memcpy(). Reported-by: syzbot+7adcddaeeb860e5d3f2f@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D7adcddaeeb860e5d3f2f Signed-off-by: Deepanshu Kartikey --- fs/ntfs3/index.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c index 97f06c26fe1a..11f59d7b9ea4 100644 --- a/fs/ntfs3/index.c +++ b/fs/ntfs3/index.c @@ -1481,6 +1481,7 @@ static int indx_create_allocate(struct ntfs_index *in= dx, struct ntfs_inode *ni, run_deallocate(sbi, &run, false); =20 out: + run_close(&run); return err; } =20 --=20 2.43.0