From nobody Fri Apr 3 22:15:09 2026 Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazon11020086.outbound.protection.outlook.com [52.101.228.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C46288505; Mon, 23 Mar 2026 03:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.228.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235765; cv=fail; b=l0og7vUFcwmrljLrEF8bA/wPne5A7H8iRr3UQToT+6JDVwS2t+fdyE21OofJZRiT8rJOdB3iSXrWtCH/U/MGZ91/Dja6dWin4WXU+c4y+B6CkRxaaCVr9ddhiRdFivarXkS6TmEWkVq7s6A1L9v10JoLT/RNYtJpXIftE6lAm0k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235765; c=relaxed/simple; bh=SR2GeG88ta4GDBACZLHUn682wci30W3Ne9jWi5PnWaU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=fwKjQU8TF5N1d7qUexWj86SNDbiuil8UUjriE2pmGAbJ9yW9O/1bmajERIEchyWU84R/zrySefWOva2cXcd57Gg7u1R/sXqcdx8aGP1P7etwqWO90lPs3wgPTSEFUWI328tr6hqSTFichIvIHG7SSSVV1XKyqwf4XSvUIkuGB4o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=M55bK3kg; arc=fail smtp.client-ip=52.101.228.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="M55bK3kg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HaLO45IOxvi03DkiKvXHCsVi6+d0PftDIjQeYfikjcHEDF9qXpfv2Mgr5YWIlY8Eps8ZBtQ9gsswCOThZNns+TWzwh/9zBPOyt72wEVrFtIv2d7LWM5tQzgFvFFKiPuZcDBwLXgjYe0zepKbZ+/4sWxkXuNf4Wm2FfM9eU8Nwl9vUnxQ+ldpmXZ/AwRNZote0KxVVhkb3ylBHi0Gm6ErRHH9LQtNoYDOjZg56rwkV8iVYmTRHY2hzO0N9eVuemkZzLmB9yBQvXqTRc22qY3IURQF7ziQrjW2QwzD0H/+coXVbEFnCTyjDDeILGhuEqySK60cq7zw/xB+1uAqqZeQBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MUlISL8egwbZyC06vqvzS2GtovVSCpr9UCZhCBpX+k4=; b=nGDKj70FQuQAniRJvRwS1sS22xxFWm0rKPFB3D6cDkFH5vm76sU0szgdb0I1dPr4THICE1jfynHf6BvBpsSTvVqtwHnjeRSdMcvh0u0tsIgfI7MbjfJJOfps20jz0hiITV1kM6CY38W7KopFQ46DDALdlieJpgppZKa2bJ1NZONomgqXzx1+wEe8NDwMvvimbMUEwWnaNY96KZLANY3MYcq1h1h/CKf6Hhv6fST44WY1SKlhbrwmkw7FCo5l7FCE33veCLHWiYK/jNKRQ09WNlrMG1cHJMMhpQ2ECPowwc2iRGaIf3/uVY+UpRjd5dTSXMkmW0Hp989oOHKC0lm0Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MUlISL8egwbZyC06vqvzS2GtovVSCpr9UCZhCBpX+k4=; b=M55bK3kg99IGiwt/9SJcwQnhTJKjD7z0QqsUJk4VOedwXjoU0D6wrhIafL3fILgNSSfYD92vYaWJQpHfFjOm69ijeU+L/5wR2J/PwAWk74TzzAzdbmt4wSvyIO2hx3Wzumizf6QdbC4oytCfIJBeu3u4gZlQRnYQDDD/mPw27u0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TY4P286MB6894.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:33f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.31; Mon, 23 Mar 2026 03:15:58 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:15:58 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 01/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset Date: Mon, 23 Mar 2026 12:15:35 +0900 Message-ID: <20260323031544.2598111-2-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0319.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::18) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TY4P286MB6894:EE_ X-MS-Office365-Filtering-Correlation-Id: 935ef30e-7b1d-4fe8-45bd-08de888a8120 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|366016|1800799024|376014|7416014|921020|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: LG+jdNIitxMe9qGjr8iOjJuFyzCkaZzbikxHY/2LAKTHE25+cqhhH99riquEEgkXQ076CgpcRmYiHE2DRXEhW8O/UJPpD57poJUV1bAnD3yNxg7OA3zWrN/unTEjX1MmW1ETp1A9X6b7k8D3hgu9kbTh5rayoN3jHqQkW4ueg8uiRDUWjqnIWnDlDC2V5ByIa4Xad01x8gMQlPaD5et/kfJgCOYNJ8zwnzc63d7S9A5JmAKkmgqA54o4yLSyHGPx7rUaSID8IUoqChsjU8PfbR6wqlvdTUxBXNlfas3CoegkXfqQrH840+tKHHGj+24PuohXjTqnNZ6v4CMj8kW7U6LGSMem3X5nBu7DSF/gnvVpc5ZZGc5QiwIfo9nf/IDizZ44tf1Ou6OVRMaO2rLUVWtqqq/l3b+QzN4YebDUIpEMxY7GFG48sxCdN7farweU9aRzGelBQuz3e36GtoinGlXjtFHW/M0Ir1YI44YjKQODl1LhmZ84V2K9H3xBMSgvsaqkvcqTj900a1oVQRtIf5eqWJYWYsLhLsHDG/ZlXt0B+qSxuAhRwwErt+fqYk2z4IM04Ct650byWdqZR5mjfjPJp8XoU5XEqRa6610LJBtvmIjMkZp3n+cajS4zEfpZD8vq0ZsPNkD6RgyLV0dU3m2/y1NPems/OXcSKLLaH4FPejMc2BI3FIxFmn3H1QJbM8Rq8iFB/7fcutzX/IywchXmNYnElsDXNtgHu0o2H5S6oERcoEGIO1p+OgCtwLNB3jMBH9IOU9leW8c1G/rIDA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(1800799024)(376014)(7416014)(921020)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XPyHFXeLCZo7NvEHHSREhV2ax1SHiEhB1emHeY2I8gXiiFcuVhzU3ComCk4V?= =?us-ascii?Q?Xqc7ey/RZxBLLyrhy6WZ5d4/oyZOWV/1zzGSS4mpFeJeTzupw9u6eJAF6xFs?= =?us-ascii?Q?pD/ECm/Ko3GEGqFpSlVe/3TEW9wEQSYE4M59aHhoBxqqrQz+FVvWSnuGG/Ij?= =?us-ascii?Q?o41msZViYu8fHJQieDbVRy6VldugyFCt0ueZCwgbDijyR4SqDCmuBmDF8PqZ?= =?us-ascii?Q?YKURngh8cLwpVfv1qt9eb8pj8vRnGFYsVF/IVkP8+8TyKLlnB25YVrf6Yfdn?= =?us-ascii?Q?v0kA5wq/ea2Jhd/RKVQgzXJuvBjSVbwR9nMRiXMtoFfYjP+HSD1ZJ1SFfXya?= =?us-ascii?Q?4o8+BSgto3It66AUvGvJiTlcrn40A5yFnF0uVAL+nMCYDDWANfwLH/lkUhSG?= =?us-ascii?Q?n7mAspHAZMmRhk8OeaHpbrJsJhO5X277/hVk15gTNttiN/Yc+qklHmhUsVDc?= =?us-ascii?Q?4Uhkc0hYwnE/AIY2ildgu1auIbtlNfIuiTRHcVUO0e3Tb3BMdIpbtmL63Kk1?= =?us-ascii?Q?JJrJ3mGF+Mysq/LFNjJtPbZPvk02C09zq6ywtlAQrB22pBL+xXhoDPAxsusD?= =?us-ascii?Q?dEavuWZdSnVxr4zka1kWRfnmnGmIakvld6mX9nZS2EwpYN0ay5xStPpw+WcI?= =?us-ascii?Q?/g/qD2XPDoX+M0+WpHiMGcOO5T2bzJctKpS1QAZdo2dM43KU6JvlVPrtgJFL?= =?us-ascii?Q?aJh71w0H0JF8Vs285LRynHwyhPseSG+ftofYRPBL0KExr+xN5UZiEr3V62pM?= =?us-ascii?Q?OGPNW2P14l69Gor4uRGZNUUAb5EyPYczAqSSrBvO+CB8NKdqTsfV7giBF2VR?= =?us-ascii?Q?/psHEK96UPFDRDqgHb1uNN8/gTiXKuzBROL89wGyrf+1cQiReErga1jkU1U6?= =?us-ascii?Q?3dB52DCS7/UiXG0eAV1gAH9RFjKIlEc29d0a21E+6dg0UpnePSdLawmCYWlr?= =?us-ascii?Q?WwStTpX0m6uA/CILzMluYMnu1DijIkKHVKW/k2jdfBfDZBPgYmR870cD73Fc?= =?us-ascii?Q?qAnMPqwEao8IvE3IxO8K48imx6yYJUCwrzE/AJOOGfbdQB+cqCP9dE1kIOeE?= =?us-ascii?Q?AIXbRMBEtNQubyRs69LQ3H5soj2x8CLE2cXMaBNNO/jU7T6DOg2CW5N1mnER?= =?us-ascii?Q?YGHjFBimlLx8bfwVqrKtK34uj/xZStG0HP4K2d+A0CWVOQ7EkoG10Mw5uMxw?= =?us-ascii?Q?m0a42uw/wa3S7/K7BFYmg/ZAt8aUYUbvGiytwnaXoNbnlhCJgNp4Chws63Rc?= =?us-ascii?Q?YAm4t7Zkj+kM/XCqAI4vXfsrYmtvtSUsDqHhuyEjPyrBLG8neH6DRL8HK4gK?= =?us-ascii?Q?OQtVor+CuqGWQzNLuhQsLQQWwN7N3Sg/VoCH2OmNd+8eKOMAus8vLWxdMnaT?= =?us-ascii?Q?02SnFH/uM8XbJKm9DL1qLSCcvZjTX4iw1k9XgvevuEgEcLW+gr3Nqmn7AvSF?= =?us-ascii?Q?rn6eJ0mFM0CiIMsMWUtMgLiZs0d/s5F7h2BDaKi//KHUYpODLULkT1DRgQpL?= =?us-ascii?Q?HxkdNnggdeIrKGQl0UaCu7IGeDz835BMSiRbNbMesGFkwq6PP6v5/hr8tqu1?= =?us-ascii?Q?VJIrZh8wOC3H1xxCD5LRPg6WiPJgE/Ol1lpZF15ZSkJ4wuqsBw8XBp/QNZdD?= =?us-ascii?Q?XCFgtvfqD9MaT3h7ytdvuryx2WMoGewZugOfM6zhQn4jKchrRrekjZWhF628?= =?us-ascii?Q?31EmFF4wTLX6XBwTcOfOoEKCgNZXs9VbluGeo5QWWUTfAl1kISK3brD90r72?= =?us-ascii?Q?07gc76ABCZjIhfBxd2rZmTBji9kNTp+C56au78ol6+6BWRZNio4Q?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 935ef30e-7b1d-4fe8-45bd-08de888a8120 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:15:58.7177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rjAEiBz84vJPpNP+Ao0Hr9bb8ynju1Pw/2dSfbqMeo0wqerYgzKagNacNikVapU/FNqBskkq0o0AQhiWUHaepA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY4P286MB6894 Content-Type: text/plain; charset="utf-8" vntb_epf_peer_db_set() raises an MSI interrupt to notify the RC side of a doorbell event. pci_epc_raise_irq(..., PCI_IRQ_MSI, interrupt_num) takes a 1-based MSI interrupt number. The ntb_hw_epf driver reserves MSI #1 for link events, so doorbells would naturally start at MSI #2 (doorbell bit 0 -> MSI #2). However, pci-epf-vntb has historically applied an extra offset and maps doorbell bit 0 to MSI #3. This matches the legacy behavior of ntb_hw_epf and has been preserved since commit e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP"). This offset has not surfaced as a functional issue because: - ntb_hw_epf typically allocates enough MSI vectors, so the off-by-one still hits a valid MSI vector, and - ntb_hw_epf does not implement .db_vector_count()/.db_vector_mask(), so client drivers such as ntb_transport effectively ignore the vector number and schedule all QPs. Correcting the MSI number would break interoperability with peers running older kernels. Document the legacy offset to avoid confusion when enabling per-db-vector handling. Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/en= dpoint/functions/pci-epf-vntb.c index 805353528967..a75f8a30f8dc 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1367,6 +1367,25 @@ static int vntb_epf_peer_db_set(struct ntb_dev *ndev= , u64 db_bits) func_no =3D ntb->epf->func_no; vfunc_no =3D ntb->epf->vfunc_no; =20 + /* + * pci_epc_raise_irq() for MSI expects a 1-based interrupt number. + * ffs() returns a 1-based index (bit 0 -> 1). interrupt_num has already + * been computed as ffs(db_bits) + 1 above. Adding one more +1 when + * calling pci_epc_raise_irq() therefore results in: + * + * doorbell bit 0 -> MSI #3 + * + * Legacy mapping (kept for compatibility): + * + * MSI #1 : link event (reserved) + * MSI #2 : unused (historical offset) + * MSI #3 : doorbell bit 0 (DB#0) + * MSI #4 : doorbell bit 1 (DB#1) + * ... + * + * Do not change this mapping to avoid breaking interoperability with + * older peers. + */ ret =3D pci_epc_raise_irq(ntb->epf->epc, func_no, vfunc_no, PCI_IRQ_MSI, interrupt_num + 1); if (ret) --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 517985C613; Mon, 23 Mar 2026 03:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235763; cv=fail; b=pTk+Dpf8kln8liTd9FIsxZsUAvsEu02rk6Mk2Pm4RrF9477AKetsfSK/w8unJlck55JsHHWpKzZWIcEVUh17RV88D9PjxHARVIn5SebgTD8xeimsHBVQauxYr7yQ02eAea0chJx8rp4fpkXl25EzvDCF8rLzUdEtC+YTqPHvLDU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235763; c=relaxed/simple; bh=lzYU2LUpbxIgnFGP3lrxvocb+cFJ3pDcy4/IpFzzrag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=h+/uuo/RMPIk+RvlEdm9krJ+VqcW6FeO2CZUAh53vYrOrM8fzz33mrPnEvXjeXJ2gGuw16hUa9DXGB3h5C7tVj1TvNy6+koAi8oVqxYARUvn4Ux87W1JbE07aPefHI3l+qwSLuqEv6PQheef+elOViUgEsXVxwGUUPHx73eYdeE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=uPevmKZw; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="uPevmKZw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gewMM2Kw163mq/4uQ0OLeeZI4DxoKsKzd+WbfDggqOKo2MWxh+sYwTOBkRdFOJq1HRYl3vsd58naeX8pz5cJIt4Y6rJIsTrUf8Yc26vykB1jYnhU+p61VNnpBUR5rYCQoIKcHBHfi2J+YreXQwFn6AV80+nPG163cGmCPdShzG4sqBJVCIu4R+KoHPysF0BYdJovoZ7E9C7a3e7JGw9zQ/F3Z/tq9u7yAR0B2NnoqD1v4f+xC1sabhXk/G1kvPFwpD2BdrlHsTfvwpgnhzbOyVpiFiQSU12zv2tdI9/sBnDmHz5bpbRmuFQwBt9gdI39oYHSf2RDCZtCWXTzYnt93Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4TVNCjNUYLdSAwIdhLlYm/OWUeYCEfEfMJS/zG4RAM=; b=oWMB5zo8AqK3B97wpXyoFVjUw86qmkyCIGDxv53RrK7ClPiX/y2Hw9kXJQAwC+iFsHgyJnUdm2m00o2ika3Y4TUYg/TCCd7dbZJKufr5UXPR3OKm95JtagzN70X9XG2KU/1ZKxTvvo4sJb9kw+I9j0tysBfaHR7vexoSdL2k7L9S87wy/85IRAzvt6fNSYcmUFTFtaWtf3/VEUNQfnrJncruJ6nyigIgJ23ddgEblLoE5YuqI/+sF4Ruc+g/uJ1H4250m9NP/EdB3fp1DhhHqmvzdhRE4gfxK27HmQKsrTAGqggI8m6mNx5vEkOdGwKiQqtHt01lzgCT6tccE+VGHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4TVNCjNUYLdSAwIdhLlYm/OWUeYCEfEfMJS/zG4RAM=; b=uPevmKZwpWewPrfKjo6JaL4mdxcl3u5scG9UZB310KILmUd2UBmeWYlOYRikmU244z0zXqn6uT3wOyq7PfvPsrWvC9h1BBe6y/p+K1s/PhkdXQmM0NcMDdycJWZ0yVlIQ5VLiYDk3Y7L0SEBF8PPOYaEGhVBaEF3KX4WshiapfQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:00 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:15:59 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 02/10] PCI: endpoint: pci-epf-vntb: Defer pci_epc_raise_irq() out of atomic context Date: Mon, 23 Mar 2026 12:15:36 +0900 Message-ID: <20260323031544.2598111-3-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0330.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::19) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: ed1c53d7-a169-493a-1275-08de888a81c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: sNG+tYYPvTcx1oENNQTfNUjvDjXhgQQfHmOxt9RXs/AUArt1CQ5ZYLFNFs++mnjh03wUZSYoibDumRHWI6EjqGLKJG5nAgKXLKRAe2btbXxkFPQlUEAFgfws39I7U1RjHF9N3UrVKOFCDr60wuaJenS8AL2Xal6vOt97M63NyEBFmB7doFkpOwIgTCcANWYP5QQS8raQPexDadE2E+e4qjMp7SsFLZXbV7lc7X19qpmTZT24PlFx0UDR60B2GS1Ki7VmZImPkovWT1o60MSHlYXOoM07BEmMl3lWTEjaMnlbu9O+1j5ZRqUNq+uo5SzZaITe3DXcJg/w/1yfnIrqx8TdPvHx4Z8fNKTfGaoTHWb2YNg17jdHh+Sl5C9s98I9gpcu+NjYEcx0iLDC+9//BWXUjzO6f5GLkNx836HwJlcgp0Az6w9ryFar/GQ1kn6R6nUvBHkXNgYgctx6D0Ltxd6qaETNMrsGLrH5RcDn3wLHBP9k010sBvtQUwL9SyBvVQ0u6jJjkstKsRLy8eKcVccLQYTMgRZhTgGyiyOjhmtCH6b0pM3Dd6d/G1J6CzSv3fhcr1rk3FkVwwPkCoJRkiAk2gY8aYIpT7Apit5yL6q4H5cCMXJMjbHe7Mmg3pcswv0ptD76g9UJF28hj3MWihSavPUYMgmg99EuK5adr7oK30a4wFexX7f5C4Zbo+aUBKA0DUTP+ZV3c5zNviAYZLkSYutmzsiagi1x5zeASYqFL5fqXY3eq/HLCiH3EKgnyjvV4b6ClInYholAgTSivQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ILKCqtlC69VkgrN3DWwUrhdre+9O5Caj4zRqzR17+7BhV/UVlaO8tSWgse2j?= =?us-ascii?Q?Mw16le9s0bharxsBxkNPn5BmnhHeslC9Qh3yUWaUWI0UkcYGBx9bjlxSqaWr?= =?us-ascii?Q?ujWdjb8JBjYGD2A+JSFIkLuqAI2RQkoEa6bGsLn9voTmT2B1yNfmbGKeMpNs?= =?us-ascii?Q?HWD2gIyoQDwde2iw3j7o6TmIftZjO+KPE3uQhAhqkNGYI61wXgjhdDP4sXPa?= =?us-ascii?Q?c62a0QL/9jqcddINolAQQulo3mU0hn+K8uj4jvLUk3D6uqdZmGuo7rwTm++/?= =?us-ascii?Q?CgWYouktIm68wNqrPH9gt7PmB2Ng7b6QhM7Ace6uzAXhfwUYWGBwXuJPM3DK?= =?us-ascii?Q?3Jr5Nl6E+J9p24yuq0ngVuZoMYF7GZMDb+aGWXLfU+9NOB0OeJavN4FmkaZ3?= =?us-ascii?Q?5fpsrM3UtqW+ipUkaD0xnO69qy13oOSkON6R3sJk1OWq54vsLGgnE89YgG3R?= =?us-ascii?Q?ZLwKs+oarDicHFEurNBB20wjDnZlJdtFCxcoHrJ/RYsOFH5KgSV6DbjUvEZz?= =?us-ascii?Q?eAXXVhCvY6/O3meTKFNKZvCE31JrqOa/oE1CB1heFF63SLb8S5w01JNYCa28?= =?us-ascii?Q?R9xWpiJ/CUgzDygfSdrow1VwPs9OooTQls5j1HW1mXmnx1+SJ8JXlx2hyosa?= =?us-ascii?Q?+/p+4+CrJEpB6yb9CaAP+1zaKF/x6tLNTbd6yll14ns9Uo5GmpN78cWItl3Y?= =?us-ascii?Q?GMIbT8EKrFErHg6KS74BhL2E0JOe3aLs8WvBVAQsIkQqDa+2yapXOpOmSFlu?= =?us-ascii?Q?21wH/zKFmOrRp3/s2sm1ViMHJasuWXRP1n8ATTRGZ81be8nmZ7VNXxy61mea?= =?us-ascii?Q?9PJ8hfoRkHicFjFQnyXW8cuYM8SASYx6nf/vsuz5cH0qMrEgOY9YGqAsqSzf?= =?us-ascii?Q?8Nl5I0+kuSPKd09wMrIY+v8JP5b+mwDyo7g9bLz2DmCN44vlQgvAFCj21OGs?= =?us-ascii?Q?TOXcqsnt+iQHrLKErMxG8uBfceVLkK8s5BVh3z/7TAVTdawnDIVLvff1Gz8p?= =?us-ascii?Q?yK1q3y2v51hA5CG94gqYj69uxP9kDSlaWcx5JeM18oK501kP4rzN+lqFOx5D?= =?us-ascii?Q?YoJGb90m5ojzG26DQ47MSENQiyCA2gkB8VjUKN6gS3tIQRuCSRqWQUtDDGNl?= =?us-ascii?Q?NQbrNBBkS4fTz0+ZkJYmX6H5mIBi1NAd/oth10iDWY0INc8zgx87L1g5vlJ+?= =?us-ascii?Q?lj3oYOIRBdAOSrC2ZD8nbvz5gsrMcm1GZoGcc1rB61V7mFBxe3qf65bxxhbk?= =?us-ascii?Q?C8HlCs3j3MrcmbWaCCk0s3RnZm7kU9QF8W7DDSyQd4GgY6z2CPmgb9+dMWl+?= =?us-ascii?Q?2KBr8xilWFhZtHoreBBEKze5flpdDVAF4cNTs1T0YGTJZOeLb5w2cHL30KxY?= =?us-ascii?Q?d62/sSul71T4K2uiHo9PU/kKz2FaxHWOxxuy6iLLNUjrMqz5ixVxuAUxUcIc?= =?us-ascii?Q?kHVcDfwHiVfpcSoUYcOQM9ofbQieT0FvgdPhicszN1M3pEOJtBrTZ2eJTJGC?= =?us-ascii?Q?8RHKHGVQZgO1gNkcDEze+/kTvaf5goMZXSOCTEQHOtDV6Rj3YexIMW3n1vBM?= =?us-ascii?Q?3+TX8v+/fpiIpShJ/BrRVcDMSjt0ccly7kI82mCRi5QiZfgO0C4mUYiOk8f2?= =?us-ascii?Q?b05pbRUawJGoWsGV4EhhxMaIxRouY1Ku+kMHoMsb3kFfNOEeQJ76HrbvOz33?= =?us-ascii?Q?dbYQxsEXPy28IDYuDfXTP9gSPpxuoa2RjyWItbCVlbZUxur+SMeYw1nOwSex?= =?us-ascii?Q?i3tUfMSBcFRPEKEq0fJT2lhRali//pdBn3IKHpFecnL779hXGPt4?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: ed1c53d7-a169-493a-1275-08de888a81c1 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:15:59.7951 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SAimh6iTd7lF47tR0gnua2MPCtnjilaIMtn3A7BBGDq9WuCS9LBzTMA3HbVzhlmQuVmj0RCXl9vHU1SQoRUEnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" The NTB .peer_db_set() callback may be invoked from atomic context. pci-epf-vntb currently calls pci_epc_raise_irq() directly, but pci_epc_raise_irq() may sleep (it takes epc->lock). Avoid sleeping in atomic context by coalescing doorbell bits into an atomic64 pending mask and raising MSIs from a work item. Limit the amount of work per run to avoid monopolizing the workqueue under a doorbell storm. Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP= ") Signed-off-by: Koichiro Den Reviewed-by: Frank Li --- Changes since v2: - Resolved a trivial context-only conflict after d799984233a5 ("PCI: endpoint: pci-epf-vntb: Stop cmd_handler work in ep= f_ntb_epc_cleanup") landed in pci/endpoint. drivers/pci/endpoint/functions/pci-epf-vntb.c | 106 +++++++++++++----- 1 file changed, 78 insertions(+), 28 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/en= dpoint/functions/pci-epf-vntb.c index a75f8a30f8dc..bc3b3df53ddb 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -69,6 +69,9 @@ static struct workqueue_struct *kpcintb_workqueue; #define MAX_DB_COUNT 32 #define MAX_MW 4 =20 +/* Limit per-work execution to avoid monopolizing kworker on doorbell stor= ms. */ +#define VNTB_PEER_DB_WORK_BUDGET 5 + enum epf_ntb_bar { BAR_CONFIG, BAR_DB, @@ -129,6 +132,8 @@ struct epf_ntb { u32 spad_count; u64 mws_size[MAX_MW]; atomic64_t db; + atomic64_t peer_db_pending; + struct work_struct peer_db_work; u32 vbus_number; u16 vntb_pid; u16 vntb_vid; @@ -920,6 +925,8 @@ static int epf_ntb_epc_init(struct epf_ntb *ntb) INIT_DELAYED_WORK(&ntb->cmd_handler, epf_ntb_cmd_handler); queue_work(kpcintb_workqueue, &ntb->cmd_handler.work); =20 + enable_work(&ntb->peer_db_work); + return 0; =20 err_write_header: @@ -943,6 +950,7 @@ static int epf_ntb_epc_init(struct epf_ntb *ntb) static void epf_ntb_epc_cleanup(struct epf_ntb *ntb) { disable_delayed_work_sync(&ntb->cmd_handler); + disable_work_sync(&ntb->peer_db_work); epf_ntb_mw_bar_clear(ntb, ntb->num_mws); epf_ntb_db_bar_clear(ntb); epf_ntb_config_sspad_bar_clear(ntb); @@ -1357,41 +1365,79 @@ static int vntb_epf_peer_spad_write(struct ntb_dev = *ndev, int pidx, int idx, u32 return 0; } =20 +static void vntb_epf_peer_db_work(struct work_struct *work) +{ + struct epf_ntb *ntb =3D container_of(work, struct epf_ntb, peer_db_work); + struct pci_epf *epf =3D ntb->epf; + unsigned int budget =3D VNTB_PEER_DB_WORK_BUDGET; + u8 func_no, vfunc_no; + u32 interrupt_num; + u64 db_bits; + int ret; + + if (!epf || !epf->epc) + return; + + func_no =3D epf->func_no; + vfunc_no =3D epf->vfunc_no; + + /* + * Drain doorbells from peer_db_pending in snapshots (atomic64_xchg()). + * Limit the number of snapshots handled per run so we don't monopolize + * the workqueue under a doorbell storm. + */ + while (budget--) { + db_bits =3D atomic64_xchg(&ntb->peer_db_pending, 0); + if (!db_bits) + return; + + while (db_bits) { + /* + * pci_epc_raise_irq() for MSI expects a 1-based + * interrupt number. ffs() returns a 1-based index (bit + * 0 -> 1). We historically add +2 to compute + * interrupt_num. + * + * Legacy mapping (kept for compatibility): + * + * MSI #1 : link event (reserved) + * MSI #2 : unused (historical offset) + * MSI #3 : doorbell bit 0 (DB#0) + * MSI #4 : doorbell bit 1 (DB#1) + * ... + * + * Do not change this mapping to avoid breaking + * interoperability with older peers. + */ + interrupt_num =3D ffs(db_bits) + 2; + db_bits &=3D db_bits - 1; + + ret =3D pci_epc_raise_irq(epf->epc, func_no, vfunc_no, + PCI_IRQ_MSI, interrupt_num); + if (ret) + dev_err(&ntb->ntb.dev, + "Failed to raise IRQ for interrupt_num %u: %d\n", + interrupt_num, ret); + } + } + + if (atomic64_read(&ntb->peer_db_pending)) + queue_work(kpcintb_workqueue, &ntb->peer_db_work); +} + static int vntb_epf_peer_db_set(struct ntb_dev *ndev, u64 db_bits) { - u32 interrupt_num =3D ffs(db_bits) + 1; struct epf_ntb *ntb =3D ntb_ndev(ndev); - u8 func_no, vfunc_no; - int ret; - - func_no =3D ntb->epf->func_no; - vfunc_no =3D ntb->epf->vfunc_no; =20 /* - * pci_epc_raise_irq() for MSI expects a 1-based interrupt number. - * ffs() returns a 1-based index (bit 0 -> 1). interrupt_num has already - * been computed as ffs(db_bits) + 1 above. Adding one more +1 when - * calling pci_epc_raise_irq() therefore results in: - * - * doorbell bit 0 -> MSI #3 - * - * Legacy mapping (kept for compatibility): - * - * MSI #1 : link event (reserved) - * MSI #2 : unused (historical offset) - * MSI #3 : doorbell bit 0 (DB#0) - * MSI #4 : doorbell bit 1 (DB#1) - * ... - * - * Do not change this mapping to avoid breaking interoperability with - * older peers. + * .peer_db_set() may be called from atomic context. pci_epc_raise_irq() + * can sleep (it takes epc->lock), so defer MSI raising to process + * context. Doorbell requests are coalesced in peer_db_pending. */ - ret =3D pci_epc_raise_irq(ntb->epf->epc, func_no, vfunc_no, - PCI_IRQ_MSI, interrupt_num + 1); - if (ret) - dev_err(&ntb->ntb.dev, "Failed to raise IRQ\n"); + atomic64_or(db_bits, &ntb->peer_db_pending); + queue_work(kpcintb_workqueue, &ntb->peer_db_work); =20 - return ret; + return 0; } =20 static u64 vntb_epf_db_read(struct ntb_dev *ndev) @@ -1629,6 +1675,10 @@ static int epf_ntb_probe(struct pci_epf *epf, ntb->epf =3D epf; ntb->vbus_number =3D 0xff; =20 + INIT_WORK(&ntb->peer_db_work, vntb_epf_peer_db_work); + disable_work(&ntb->peer_db_work); + atomic64_set(&ntb->peer_db_pending, 0); + /* Initially, no bar is assigned */ for (i =3D 0; i < VNTB_BAR_NUM; i++) ntb->epf_ntb_bar[i] =3D NO_BAR; --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19731F5821; Mon, 23 Mar 2026 03:16:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235765; cv=fail; b=n4jkJhzZzfUZGq0tOTPcacwc+SDZcEz5AoWanS9O48h13YXMMnMzauUQMBj73MfzbBricKY2+YSbj1FMEfNnlIJUL5MEMkKsCYtp8DzYgfvNPbFFrY0tU6KN5788912BYPa861yBq7RmWL30nQJxfqLcvVdpGge4YOM1tz2RWfw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235765; c=relaxed/simple; bh=Vp0jjjAjVx3kJgw5BJe5IzR2vQQ/BQvJP3R2jxxlbgs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=NmVzUkxXvdxYOGlXAMmESDDTYds2k25o1VEG/14qBpBy68fmfMvhEHzmjTdptjE9IuIv+gT/ajcz52e8BZbyTtoV/QCowt+uiSDZMhkSnTLh7oLK+YEBbx79iEVfJgsWTfLAncxfyTzVyC1Ev9sZYKj9UTeyXUv5rGvGi0e9NJw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=pGLdgjsw; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="pGLdgjsw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bg0fCtSqrBGRBykf1Ko0pUSKqDWfhnYg8LTnx9ZQnXzvyjPC5ZL4Zah60SEfsB0AewCGTrAoMvNLRwk6Un5JUkXKebtauiJLwSb3Ed/L/tyDmh6umWZIxmN8DIwuDzLuKdLZvfrK4O1dhej6swxIVfMdeFBsIBCpZT5tvVKjMJxE7R/wKVV4y3iu3l+nMxNMGfgTTEesNBQ8YLWZPJQe+2neP0dbRRf9O+cB5sdQjHTQOMHQ39wU3VhiXrEAf70wC+TVp13Gh/lPaFXJdqgLYVTdEWA3AyZhvhqHT/x8TizZNSbu/1uGeCMe4609Oo9t78r2kt+IqVLLc9AkrPQc9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bxl4+aqitJJLM9pcANb24e760tjkAxwqC55ts5Kqcno=; b=Ge62Iyh1MUb9WTmdqCelRllAmm8k5JWlU0siWO7s7nlvr4EpBC8wvd6kjoWmTiXSlWDeKVprI6Ybu94yIpsoP8KvycazmUx1ef9Ij1rP/1zNdObF5nm7tJfsg+6CN9d5mjMCUTN+FLXsLRVqK61+50D8lFuQjO/hnr/HwSrovW0zPfoFR7feN0qQ8IelI5Z1b5eZv/tUafxIRc6z+c9QuHhiPkuQ0A5QIUrDlt37aXm98WUP2WlzpxBlwfHHHz1AzH1ra79qvOSz17wF6Enr3RXKpw3IpTzp+uuCyTc6Wkb/uKCgAzuxutribo4oYYUxZd/0LQl3/URwGXTzFbzNNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bxl4+aqitJJLM9pcANb24e760tjkAxwqC55ts5Kqcno=; b=pGLdgjswQbnczFOTTOZ3ngElzd43HYZpDk7R8yPMBeWwCL47UpNjSVxp+ue2PyHMvp0S9c7Hf15f8cOH2xZf6K30QywI4GhZKjZPvLwfYV8wNGV7ktPjXxkbGrZtwxEUtupUROpDuAwo/bJA6KT00UWDWcQyjcIfydfTcwTZhbA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:00 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:00 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 03/10] PCI: endpoint: pci-epf-vntb: Report 0-based doorbell vector via ntb_db_event() Date: Mon, 23 Mar 2026 12:15:37 +0900 Message-ID: <20260323031544.2598111-4-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P286CA0055.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36e::14) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f0d40f5-47f0-460e-6cd7-08de888a8247 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: PRrSKJK5zLrDJQXa5HDljzITJNNzrdQKFayyR5EvpCzZVR6/Tc3f/msWMsTDLE4Re+aUnECyjPkwPWGUc3mZt1NGqWgSeiEMvHQ74Syf7dUdLve4g4k7LDcOj74AIkpEbBhN2fjX12AsU2GoV7rtUMTXoC2F91kdZjd8H/eXN2ganpeCmzsWjB5boOKz9Kc0EhmzwCerTzQIpvxdliS3ISyaa1zOGujqW+HDYZRCAoOERGwB6lMDAuTaHd9cEB+rZchzUpktJSMrdit4k/n0uULAgy7QAHo8xOx4syLFjfPBYqQ7FZQnjPXDNQ7di7vL4LFWa+b8PG5LPQVlcEKXLSrk0HT8ve+CL51ApOYikNjsRwTAdoNtZB6eGmTbRtt00pS+hAguFUV2iAhabUkjR8TK0AZEhGIOrzMKdQRakL6u4WzOI+TH5zHfkhaPF2AVUhbfLpvYbHiFhNbqdgZMa+h4ysVzTEaSkDzXDm/Gro0fAiYyHsYFxHs5vT9Ja2Y18y9TlT8D2NQiLMgqRdTHIOFc2ZtILioOPCY9lDEidk1A9/q3VHcuSkHOrAY4MMVlRB+y19wZNxmNehcuct381v+X1Kc8mTynmFIAJQIW9Tjxx+RzYLiHDkVrNPvoMv1vi9yjbsyQgsaxSTno/QR2ungeQZFpAJui4nn8cDr//2eJQPADTlH2uMrx5FKZmV5GDW56iE2V2CMf5CdVDZ+BVovMSPtRTlcBGJlZ7EK1BgJ0n6Zw35OfCtvHcNuNQe8MiNwBtQMgJZSP1i1pqtQu3w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kFoyv6i4Xgu0XC/BtcrHwGp60AAnvl0p4dB0xu8Xlq8Sh3PoE4rl8vtYgoWl?= =?us-ascii?Q?206guA04YYAYyN7TcNCtjxniBTYKNZpypUpscZ8mbFWToqR5hyuoKLvxUadx?= =?us-ascii?Q?IeougF/PlH8IGhIft1pow3QxOgAd0aHcHE6pLDd4JCLFwf9GAAZFVFzbWyOK?= =?us-ascii?Q?6oFzqko91rgDGYtmktJ2tPZViObUon68eeBGjWBPFwb0RxiC04Q9giJ3BwAG?= =?us-ascii?Q?3CYs2jQKadldgfHx2TzAMhmFxYTWuX2MsujtvlY+kO6kw2ycM5pzBjDH/fhj?= =?us-ascii?Q?RjSKWWtw/7FIn95WzodzSDloie5hgMCUcL/PHehQqivmmvvJPavBGcl5Xjhe?= =?us-ascii?Q?Uj6OuMwOR5YyKq/HzUnaAr1Pe+G6HOkBmr02NyR7Ow4b6FAEYb5jzhhpn3VY?= =?us-ascii?Q?7mzgdbJGV9Lnt17PdiW6xr1AQ+0xgfzU6fWIRwjM0FIycY5SL90Rp19D9gEW?= =?us-ascii?Q?meRKk+rPp44Nu2w1sjo+W5PiCSZUVFLErKC0g07vrPmoF8UyeL6/NStG6/8R?= =?us-ascii?Q?dgk9gvUb1NiZoKyHUGebWTBNQQ+qRwI5X396v3U83qEQPb7t2ahoggtS4D79?= =?us-ascii?Q?LnwGNamfa4rSj4F1S/qbVTr3NrUQNfiOsWb/NJNcRF0xICv9CTA0hAs/AaJh?= =?us-ascii?Q?M/nm+Rft98qhjEF7PKNj3z/iafWvegQFbpQzbj6CG4PKr1bnKWbkRwLzEdi0?= =?us-ascii?Q?v9U5z3+kvRtbbcaPvg20H+SHfPfyHUHPZZQyJIYkzaebgCl1K7dz61mMjtdo?= =?us-ascii?Q?4VPmE7uiBSe8iCSoKnMPTzcEScGHZ7WM3byXCcMpdAIpcsP9g4ulSNWaD+DS?= =?us-ascii?Q?+bAQxMGdn7bp/5H0smlttozlDUvxLhY1Pq+jswr6G60OHJxXI/0E4Gn1QEqH?= =?us-ascii?Q?guRgKjp64dXrik88JIJ+T0Mnt7JFxjBTV3e5Ad2e+2WGjIaZe+YY1MENMk2c?= =?us-ascii?Q?LeVfnw0n2XnHjyE38wlkLdqfIKtlLoNEkmfkXMiUiEXeZOp38cm5PwjHj1HT?= =?us-ascii?Q?/RIIykKccjkci14GPUxyT2xsJ4gnOXwOgr4fpkaOMfKdBKlq2aiXoIjgDMXR?= =?us-ascii?Q?f2yXaiKgR3jsetK8D81qSq9KBcJ026PFSZZVKiFnI7KZImEfIPTXWbDX9idp?= =?us-ascii?Q?zpH1IxPGiFqQa6c4Iq4rigGNcQRD8nG24XuGnCuB000POeNuHwebG68SlPlH?= =?us-ascii?Q?TBcB5iapDsb9YkYAXZTHmVRMEZw4IhdNY6SpLtf8yGGAQZjuO2CGPmXuRxcI?= =?us-ascii?Q?xQPVutxCPBQeDoiWAko1UU35VoiBMsOzzRIYrqDGFnsJPKADJ1hyT2bjbAYb?= =?us-ascii?Q?mZ5g0RuyXT04mW93vD8DcGDx7zMNCooCQNtUp91oc+L+rsVWBM/eutelS/1O?= =?us-ascii?Q?2mHNxEwKUEEh1egFmMd7CBvKaL+XdlpYub7e4PnlSlAr7H9dCKhXGHTnj3Gv?= =?us-ascii?Q?ZioSruytb59M/3toEaaKYp0+gwgqYNMXKP2ZHSBsor57H+wErAg25L5vUj4M?= =?us-ascii?Q?2eQOR9aXZuvrhklQQpzqfXNqmUcNg8MrmgeHeDsjg7N3DmboCVNXJFJ8giRv?= =?us-ascii?Q?e1Tk+EHPHAzbgNmP4x5QJkktQ+dJaBwoqVDxHl3Rl+xrUz1b0+lMI6jWQsCq?= =?us-ascii?Q?P3GUCcgEtfeCL81QAJQgYQeueWCSbwyPg3J59DH7UBY5ceZVkYP5JVQlSEbo?= =?us-ascii?Q?BGnMK6o3FcrgB8r0AeHBZk4VJF8Fvx2GjDebwrYxg3RNcCoPo7hzTQDH4Yvv?= =?us-ascii?Q?TksT2T6AfIEb948ykgGhxmSou/u52kdf459YgiI6MFQ9/cROP9d/?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 7f0d40f5-47f0-460e-6cd7-08de888a8247 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:00.6445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ETfNL/KwZQigNuc5gZXOmknKX12CUM8NEW6qJOvE1d33VWPHRy/Y1j3w1tiNUellvmwLCpm/cXYJ0p9WBZAakA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" ntb_db_event() expects the vector number to be relative to the first doorbell vector starting at 0. pci-epf-vntb reserves vector 0 for link events and uses higher vector indices for doorbells. By passing the raw slot index to ntb_db_event(), it effectively assumes that doorbell 0 maps to vector 1. However, because the host uses a legacy slot layout and writes doorbell 0 into the third slot, doorbell 0 ultimately appears as vector 2 from the NTB core perspective. Adjust pci-epf-vntb to: - skip the unused second slot, and - report doorbells as 0-based vectors (DB#0 -> vector 0). This change does not introduce a behavioral difference until .db_vector_count()/.db_vector_mask() are implemented, because without those callbacks NTB clients effectively ignore the vector number. Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP= ") Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/en= dpoint/functions/pci-epf-vntb.c index bc3b3df53ddb..e86dc530c08e 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -82,6 +82,12 @@ enum epf_ntb_bar { VNTB_BAR_NUM, }; =20 +enum epf_irq_slot { + EPF_IRQ_LINK =3D 0, + EPF_IRQ_RESERVED_DB, /* Historically skipped slot */ + EPF_IRQ_DB_START, +}; + /* * +--------------------------------------------------+ Base * | | @@ -266,10 +272,11 @@ static void epf_ntb_cmd_handler(struct work_struct *w= ork) =20 ntb =3D container_of(work, struct epf_ntb, cmd_handler.work); =20 - for (i =3D 1; i < ntb->db_count && !ntb->msi_doorbell; i++) { + for (i =3D EPF_IRQ_DB_START; i < ntb->db_count && !ntb->msi_doorbell; + i++) { if (ntb->epf_db[i]) { - atomic64_or(1 << (i - 1), &ntb->db); - ntb_db_event(&ntb->ntb, i); + atomic64_or(1 << (i - EPF_IRQ_DB_START), &ntb->db); + ntb_db_event(&ntb->ntb, i - EPF_IRQ_DB_START); ntb->epf_db[i] =3D 0; } } @@ -335,10 +342,10 @@ static irqreturn_t epf_ntb_doorbell_handler(int irq, = void *data) struct epf_ntb *ntb =3D data; int i; =20 - for (i =3D 1; i < ntb->db_count; i++) + for (i =3D EPF_IRQ_DB_START; i < ntb->db_count; i++) if (irq =3D=3D ntb->epf->db_msg[i].virq) { - atomic64_or(1 << (i - 1), &ntb->db); - ntb_db_event(&ntb->ntb, i); + atomic64_or(1 << (i - EPF_IRQ_DB_START), &ntb->db); + ntb_db_event(&ntb->ntb, i - EPF_IRQ_DB_START); } =20 return IRQ_HANDLED; --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 482A5299927; Mon, 23 Mar 2026 03:16:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235766; cv=fail; b=DrUvsF9xmA7ZPP5blvktsUFQHaZbV3LCMRFOFTFvNChdO3/yncBzceugD4UIM7GKXkU6xtl1tKgNKhOiIyiaBu78CO8B/sKINQ9aAN5/wRzmftdIAXEyUSaAGd8dkTrJTubyYLNUK4uCY/x+zmLq37wrHO0v/gOC5H0lRo3tcAs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235766; c=relaxed/simple; bh=U+Uur7vH6JWkGwJJyAVLL6Lc4guRl6EBUtd9DBKBh8o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Rc3RtBkVLIVA8Ch+42l8+ZmSHpPkk3/2gwYyyfSOvcc0Db1VOr82BL9xIMQRvt8Sebvaec0X31N7K8sVEhP0eBGE8wKss3J00TmULuIeV9oCuWqSBXwy/TVzaX/Xi4ohCzdRyRdhMK16yaaGlk4RJfFkQzCji9F9Gp0KrnasZ/U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=jExrFyRd; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="jExrFyRd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hIMkq+QQkLBbRcOE+xZzu/rDPwYqHllEpTEE0uJXWlhbGKzy+cKmkVYL/GNJ7FyDtAxG8F9wA/8lL8rpAdtxqqmfUwkA6TMCi2pqq6Jq/MT+1YsiXPhGJ7+MMQ/06GFeZXWVynD/I1K9cCzC3iuNB2Y7muk8O6T5JUPYzyG2npdT5OcOhA1n/dhycH/xcrWb5Hf7F2cIG0ST/uUreEOUYAean58HzllyoLbYQL4vuNwxlGnTUpzFZXsXzpNxibJPJMmrFfCgmCTTJeFGMwwdhJRI3SSwcMUCEgTUNenJeFsmuxaphzjwac6zTfCQyHqRKClWS8EthTlkHFv6QmJU6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1mKWJBoxEqm0W1XtQsaA3SdfPjnW0vSnzsUsSRAGltk=; b=gcTxusqfWazyVyHOw/Zr04dvsDGjWku1PQ3SrilkvCYIbJtvj47lJpUhPDrQcpWu9F79Zy7EpvfozZYd6Tc5wvUQNHqicszvh8n8hrXaD25fjmD+NiEzB9W3YnVHrq4xVqThehQmUfWIzGdFR/UVjtZOhvdsnkL9Ugg+8OGd/94PFCYQI1xO6jEk0d/fuxmnvqCsv0GLriDZuKjdtrcvLc3W2Xzu8FuIi6rgyK6S6w9VqBjLbYiV3+TJ+Ujtdej6Vwb5xgSXRZY0OJb60Co5gPsHxMeoJJO/z7Z1HfVzqXjbw1VYzsvaUdWpyYh4FFKiJviPnX4ofACYQ14N2PWaeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1mKWJBoxEqm0W1XtQsaA3SdfPjnW0vSnzsUsSRAGltk=; b=jExrFyRdVY1aPd+qnWdZesolKKFkKA7kww2qGK0pZZ26fEaIdyBPDcUCxNz3TFTk0cpK2/T6Q90QGBxhxgeiERmkxKBkkHfigCr3/iWR3utm8QOLfoOy+MvALujHcwy2sS3iXNFnB7hOq5qUeKj9UVPdEMzTaFe69Ee6DK0knS0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:01 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:01 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 04/10] PCI: endpoint: pci-epf-vntb: Exclude reserved slots from db_valid_mask Date: Mon, 23 Mar 2026 12:15:38 +0900 Message-ID: <20260323031544.2598111-5-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYWP286CA0021.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:262::12) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: dd9e628e-c079-489f-2ba3-08de888a82e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: lv+7ec7Vqn2Cru+U+k1YMjHzIbau8tUFND6FrnGrb9+Df0Q6YY0o5vX4YWGI1ofAK/rsrSZpKk+ta2EXiPu274Bi/o4V7S2BPDQYzAV5XgGbsLQC3Jn9t+EipnK7UD7Il1/U4BqV7PwaM5G53hPduK+ozk1ePGsfO1frMNCOk04UGc47Dvol8r9mAwunvEGbCFDNgjGxhdgeBk8Q1z0WGT6wu1wGX+0sthaBFcEVd7iSJtt2kil+Tkrhy2aua+aDbSdObGt0hm1QacmgPB8esDvGmRXRMjdMNLhR8f7ML3MQtGJ3J3SBlQJAr7mcwpzfbIHFf4svupstyoGLlIF2MDstAhLY9hZ+wrCJ2Dgvt8HAy0r74SgKdXa9PILMTZ/eMATyO2KB+OzKi/driLJzfjOl6MYiVFbOUvBxEVKziV2g8W1xmC7z0qlzECrSYYjlVla6zJs5BC1co8TRKl42EKZozNgnGb/Q31M+KP1DV2AGV9sThKgfePk7VUXodmqcZ2fg8tmRYB05zz3N0V9Db1x1Feoyl/VPeJZa4qbLvDiZCSmQ6ORnvPK0+wqughVJM9I4Ay5j7s2N2JAe6a1dIGLaeEK+jT2e1o0MD5IrTc8Mr6Ci9i07f52W08+WYkC7mdiffyOUgZn1uquEJKnp90WOYBzeBICvW3VurKH0YZtAGIgdfxIU63npoN6sErVDl6JDExlaQqnTHusqb6RfBciw0YbyPgt9P29R1MvfzuVa0/ulcRg1rxU63x9vcX7qzkSQ5kDniBaljBqBBs+fLw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YsMjvwx9l7JVK1gjk3VSWBzmddO7AsxMKdnK0A2FD2LeffkURoZT+gZPsjLj?= =?us-ascii?Q?EAFEOVrE7KrCeT6rA6qbFS+gok3p9A3wA/LfAjnLhGAlV9LFEGPFuKOjLQ0S?= =?us-ascii?Q?XZE2jQcuqtjLSH3EeKZjA4p4M/HUv3y2ebM/cjrH0lDW9LdFMYggmom7App9?= =?us-ascii?Q?QOc9oHJ6TiyedY9cIQ+hHhTC7yK+3NLAHrYm213BiDxNKTE/fMTHDqp4TcSO?= =?us-ascii?Q?AwXlpcKGuD4kWLg3Y1SmlVq54m9ApiHKjB5rJEe6pEGB1mD1KXWOSZcM2/az?= =?us-ascii?Q?PJ9LUsdDFprrRka0J0TL+heDMRSAAQlac9l8gfUfTQtoPULo/xiwVBkjSQfe?= =?us-ascii?Q?6OsNS6HFU364dZVun1goCo7pC0oX6J3E51n19IH8vwB5PUv9jys7XDNxblJ/?= =?us-ascii?Q?fQsHIvCw3EzidEhO/j5yCNuVToZGEb9Di5hMbm+kfPtTwwOsPvu5pajZfrQX?= =?us-ascii?Q?b5GxBR1IDqoMc/WjiKYa2VYg4WPsO1F0fuM/pMFeZEppiypqw9ubU5oNwgTA?= =?us-ascii?Q?bJqtK41ycP38oLwdDRr5Lt5fRnYmcsErGFV/v19Rx4h8gMQ1FR62qUpHMVb2?= =?us-ascii?Q?9gn4Ch7t9Koga4hPaM/zG1zVaRa49sJLa9FhiTfCq0pHVFycb9pHx8ns1cRW?= =?us-ascii?Q?378DqkzzRsASTjMVt/mt3PJyZiTuosQfYZnvuScKBNFgzRbJmvPcTWpTGcEH?= =?us-ascii?Q?bzFRGZ8Fbwqy1rok+V2YlacL/Ue9HLzaePL7ZF8UbgMS/vxSCOhKoJ6aJ0nG?= =?us-ascii?Q?TUg1bAf/+7NnLn48J1qevqqabIbNM/ztFGdpOAjl9/T282aqC88okgv9jlZZ?= =?us-ascii?Q?jO6mBZhYaINQUvQvmPABqP31Xqr/Jrn7WLxirElePILEG2LYWfi3qAcnnJIx?= =?us-ascii?Q?IZ3h1JJkZOtQvx8m0kAJx6qQocCafGyTaReOnyGUMlb5jWFDolSh1LTUNUvH?= =?us-ascii?Q?BtsAP0lWKlnWCjmBZNJbLzUcrv+tyGdcf9n4duazY1qLEUNwOXQrQwZ9IoBx?= =?us-ascii?Q?93E5bVWW+8RQQRcJiToQ1Mal/I9aPLiJARaPQWkrFW+MfcFMzn5uE7EBR5Kb?= =?us-ascii?Q?7juZqpZ4N+vrIlfVMU2JDSQSlcCGjv1n2In/zMxzwfxWxKkUjmn67GqK0t2R?= =?us-ascii?Q?zo4SzxweqwApB2cyYoaTtgEHloHBP6/oybz+DTkDYjewfg5gdntSvR/Kfyfe?= =?us-ascii?Q?H1DJy6k9IKZbaQr8ULradaqR4GliHIYsrdIg7neyagYh9hicLaCBNp18o9Yy?= =?us-ascii?Q?A/XIeh+487EjFEYF+iXnViT5jmPDlE7uMvn0bDY01ZajKiAxX7PVWYUrc4Nd?= =?us-ascii?Q?3/sF15kT2SE8sqGhAFob++iAD+okrLqlks4hJavVT69A8SeZBk1oDMOEGHQE?= =?us-ascii?Q?x3APaPTELmbOhcyHtRr0FmKsAWNern+kyl4w+MS3YO1aLeEVI0sLxz0bP++c?= =?us-ascii?Q?jbdEM12A+g6ytB5WDOdQlpthb4xcWvsZ46ilB59aFt47PTenYjRSght95xoD?= =?us-ascii?Q?3hrpf/vxM2GKCjF877L+Ti2DJcXRasaA63zfKXnKGRvhQBVkts+C1pU38bqy?= =?us-ascii?Q?NaD/zaTWARjSIYAjA9wN1SCeFHomDfoZA+S7IxZApYzx2lRPj3ZDvCteoKwF?= =?us-ascii?Q?aLSbqyTYEoZ+jCad89BF0ljvTnRXfpkhSJNSckPwybUsN04bnT3EapaFot0v?= =?us-ascii?Q?ru94z6+6g8Z0kvAgWLNHibZtESs7+WJjWtIspRawNsqkumrusRPRbSAi1d9I?= =?us-ascii?Q?Zu2CBY/MaBBYxHoBSiwhLjxfDFPay86rel6WQ7RtNRdB7O0VzGE4?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: dd9e628e-c079-489f-2ba3-08de888a82e4 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:01.7081 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k+lG5TMBYcleJg7qPPHikryh3k3bauM1Fpuejw1U0z+UrfVtVTnqPGDZywCW4MLqgNpiFCnKQDpySg9wgO9ZRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" In pci-epf-vntb, db_count represents the total number of doorbell slots exposed to the peer, including: - slot #0 reserved for link events, and - slot #1 historically unused (kept for compatibility). Only the remaining slots correspond to actual doorbell bits. The current db_valid_mask() exposes all slots as valid doorbells. Limit db_valid_mask() to the real doorbell bits by returning BIT_ULL(db_count - 2) - 1, and guard against db_count < 2. Fixes: e35f56bb0330 ("PCI: endpoint: Support NTB transfer between RC and EP= ") Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/en= dpoint/functions/pci-epf-vntb.c index e86dc530c08e..d91033ab8e03 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1268,7 +1268,10 @@ static int vntb_epf_peer_mw_count(struct ntb_dev *nt= b) =20 static u64 vntb_epf_db_valid_mask(struct ntb_dev *ntb) { - return BIT_ULL(ntb_ndev(ntb)->db_count) - 1; + if (ntb_ndev(ntb)->db_count < EPF_IRQ_DB_START) + return 0; + + return BIT_ULL(ntb_ndev(ntb)->db_count - EPF_IRQ_DB_START) - 1; } =20 static int vntb_epf_db_set_mask(struct ntb_dev *ntb, u64 db_bits) --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2C4729E0FD; Mon, 23 Mar 2026 03:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235769; cv=fail; b=jAfnRAeEssQnQiBdApCaUUOlBAxP/bGOsOKeSr+UZioo8HJZ1S8h/G3rgm1H7bJapX3clA5sFzUnEKLkEDHXotLnazRATmHquGsd9WoZ56uqPBYdSWCMYmRLUzMglSEPISZy0V0hzJfH7zcKe6y2ef9JFybSNGG6p4+UZlU4wfY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235769; c=relaxed/simple; bh=hMCUmGm7TvHAwG74RKci5sY4s9mrKvxC9t9NWJHl5rI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=FVmif82Qhg9BBWyfKF511P0TMySxdvH7UcfujrOe7G7eIII4ZEDsk3WAM74emF6vxTdLy2sqAksmT8LArfZDyvqzYvZCPIIdcQE3cW4WwwcrzYRYRHfs7fYc5uK0Rpdiwfo/j6KgKK038r+LDouKnQvUbCbPSlb8FjVnJ87KaAc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=GEdnELx3; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="GEdnELx3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cpu6kMVNXrPXeO+0pxC6R6rrFgkqzFwOV5cCXc2Cag7Mwji3HcqnRox8n0pdGUHnXtvowoOlKazFrp2OTFln/nhqkh8hHIGac5LZ2bG4LNGhb//8pYaUJmMpIuMiVtnts9VOC4s8P4RC3g5wWLrHGbJX1A3wYXdnfJiUhJqWDdOcnef+eSOOiuX5UWCptPERx5AX6Lq4PEgHDTY505fHWHKx+Gwz7HZeYriGr6tiTcXsNqemguKT9foDQZS37wK6oSCWzJxw7Kfe1PhnhJQK6e2D02gQmV1PmeaAeazrOPwOQe1xdzpo6PketV6GZ5F2dQzzS01+7BL4Q6zRlsysaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8OQzAPgOcT9MI38nJJGsNc+zXxs30Z6AeOqM6Q9gNdE=; b=xnOM2scqz1jqHseuAjz/fJKP02VzCm4cukK74M2wuWkOmcQegKFa4KO7YYHa0PCy0cRVCf3zo2xNyDGv0mcAn51aEomUQOpNGprluoayd8pxy7Wf16UMk24AVMsRGgZwfGAVlktl5peSuMqXfWu+RiLcs+ygUDO6qVqHa3q+5dzJPoNF0BPOGPrM5NASUgOjen1BTiFeTpvaXkCJYT579asKgbnGOmOnvK33zBbPOS4iyzTLRILlW7+6vrV8PmHmrfJl0WHC+DRYNtvjTwK/QtacJWmuSLqgw9ayX/yuCGxbQdAPxsN/NggfzNPasP3hObltUTYkCQ8dExTEP7KA2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8OQzAPgOcT9MI38nJJGsNc+zXxs30Z6AeOqM6Q9gNdE=; b=GEdnELx3iUDo0QJsDlFDrf3xl/uH+UU4BsM/XXo2uu84GTddJOueORc1q/aeJr97bKMliuF80gqGqjRfhvniEzitQirzlGxpwGQmfMsj70yzLLZVpNsuT/dzLJiWUfaCa7A8CJALaRT4HVaIqdQT/GnGwQlCmfxXoGp13udhxHk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:03 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:03 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 05/10] PCI: endpoint: pci-epf-vntb: Implement db_vector_count/mask for doorbells Date: Mon, 23 Mar 2026 12:15:39 +0900 Message-ID: <20260323031544.2598111-6-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0178.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c6::9) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: 94aeb237-3959-42f4-e36c-08de888a83fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: y4SHyNPIX5GMPfAwCUKteHOpgzLko7XKAmRKO0BNflVEuSz+rnFKSpkmA1lykomIpPUlRCQKhj6m0WaH7wkMtahvY+an7pYooWWp5ZLHXRiEO3I6b+/IOr3yVfeDMcdG/RQNDSdUhE80s4tmrCN3s9xqeCPkYt94KPdxTOhEq5Tmxr4vUYpVUFSSMpsQl6HUFU7BVx/QrkvfYrXYur/kALsNcT7D+gggB/KxUU01EzopmmMHR497O5g6ZIynqJRd3AQhuLrxE0qKE2LqaOw4/EbukKiXIkNE6bpdA8NhUY8w4HC9QnM4XGx8x0CBmq/USsi+334zuFHAlzxuR/bpzKi39VSM9bwWqHp/2ve3eZFVStGzuEazqkQMWbBB8VyvNfLbkDNOwjfPelb+UodheHpR1wOkLF4HiUmpPnECjEb50R1iHhcwsV2OrlwcQ4nhUZU4fUSyW6C6eNYGQD5jDqPJf66hkfCSK2tezwR48EzWhfH/pphTJoRPclmKKhOkVOFvp5kCVsORvr/QX0YiPj0i9hlD9UI3InRD4elZp8VFtRHvKRMOroO9MeGupEPDxu/hLagWYwuud88GkAI/ZBoGO0EAT5LwpW+k22/qZ3RgHHfAGkghJkWRQjiz2YpIyRI6heOFHSQJI7o87xXIU81FtJASzk9nKHRid0mtKuHDuP8M7LgHEzm/W14bbnbAOApdhj3X7B5wiYhBz0kvDP/0SsBLdd3bkJXHWlxAMmW4gjMESJJTo1PoilVCJEe+9lUWp/PMvCgK5fZXbAKQAg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y1q7QpxKi4jyGzOnU6QYXhWu29k1R40y+fMEOkyITaXHhj8o8X2OtCXEOKsg?= =?us-ascii?Q?Uy4i5ULI+CGK8bOYuT+OGWUO8GugvWqqYPiBCUyKbOq034J05l46cDP7pe/d?= =?us-ascii?Q?HrFeJUXGLQZhkC8O60zN4FYldMivNXk5PTNKo6TpnuZ+Iys9G/hRYRZnbLQb?= =?us-ascii?Q?v2sgIE+IlBFDr1uuhIWvyp3cUzOEo1KNfcXmbY4kZLJxCve2PWFd0eYo5Wt2?= =?us-ascii?Q?pS6U2HsnAcGWLNr+f89gQHDhZZT/wmLXteYwDOjJe+YqJ6HPhD34Uyw2xFLw?= =?us-ascii?Q?EU4h1W1nyhq5UIu0gudzrFDr131ZE5dtFalnmoNxExMnx+ec/+dQ5PZEdIk5?= =?us-ascii?Q?E57EvJ27utHcszJ9thgLnfW+gKHPjGqUVEO0hauPm6ceRHZ/KyzChquMHn53?= =?us-ascii?Q?O5CiX+Xj12EaCPRC4aG/+lY2CoYmaEi0g2Xdpeh7Hp3ToRdyPUoBu1AweaCO?= =?us-ascii?Q?OsvY5d7aEHj5CFbklkAxYDO/QCJz5WGvQc3fk36AeyXzwWmIzMnTD84lEWGM?= =?us-ascii?Q?wj+JXFfuRiWuyPvWqLWRSEGq3H1MVIqNPEx6v/TbxHULszqXgVf4y1lljKTh?= =?us-ascii?Q?VLAk7ftz1qaVmdSaxQzHdC+9SlNFNeeHt51UZtbPVP1Vet96Jq8+FVZ4K40n?= =?us-ascii?Q?6UV6fRvSSIKDVBAOya/UJh+Dzh753B+eMsaqnSM+28eC6Ot/Th8mzgS48K7v?= =?us-ascii?Q?saABuRDFr9b602FKye73wVkmTK/4b0rhL+vaztdD1/D/GJI/3DcgpHkANw6L?= =?us-ascii?Q?SV59kqob+UARsh6HdSbRJkLTL7EI0wDec1IPgMFYav3+PzF3T5mhJpi9nQ3s?= =?us-ascii?Q?vdwgEWw7v03HD5dsTjwl+8Nn0kA7En8yXz/H02vPYr/auxamSxXM3MDQKO5R?= =?us-ascii?Q?ykHFBYFTohrTOqUjBnmym2xhv+4v5DLu+WdyLzrvpreiz/THe7AV3Ke2HFJ2?= =?us-ascii?Q?bRSCbQME4xMc0VfRi9c24l6XYVbMn8k9rZ+JiN4WCippibVUdXdt5ONYfd2U?= =?us-ascii?Q?gVYVj/50W7le8oiOtAhXPmnZ8By7CN4ZvgzuQI6TlNpZtwbNPtzzbFMn/aZM?= =?us-ascii?Q?+SbEPBXp3L6vD+0V7AtlyYr11ZzEt1oi15g1Zytsp+CgwQvD3lL8sgXkNVTx?= =?us-ascii?Q?VTwEsBI556GBlCvaxqHWhLTeoAJiCXhip/xvA0wkVszAKlsB9VgRRxkJqUfu?= =?us-ascii?Q?sC0P/P11eD7NJ+aUTZtFzvEZl+BnzxUVrRwBIEEFeYw6LQJyfO52cp6X9jWQ?= =?us-ascii?Q?2IzpHN3HAI2bGiCv+2L+5Ji2PE1hBaOeXFMjZbfz73JZJnMhit45PIJG9WMX?= =?us-ascii?Q?9wHuLsez/fy8eygbAoRQyjsdMTvLMcpsVHwTN4otCWYCsZ4nVwR9hrvcOeVe?= =?us-ascii?Q?E38u/crumbaEL5UCOqp+FK/uxXtuLxATEPT4Sl/8DL1OzY5S5eZoummhrrsT?= =?us-ascii?Q?s+SLsuo1RZyaT95SjUk5Javm9As/cuBPPtbHK5U03OLv2euw0zr6Emjlqw0Q?= =?us-ascii?Q?tJZJ1W22Q7D1cNowP2UiKdmHKjbcWS7mEWnuQUT/F4hVPYvaoUJ1tDJCsEWg?= =?us-ascii?Q?k/nYaLnX8y60Tbp9hI6Z/aoUTiQXIU0DE8F3HgzE13UXn/hzs3NR9hF2ijwV?= =?us-ascii?Q?HfZsrvnv1ke409EQFi6LWP0u8p5V4PqLryd4sC/P22S+VcMJ6DqLLTwkdJly?= =?us-ascii?Q?R1e5vfvvId9VJytXe5fkeyzFUzhxnQVrlZw0CNklMRlQwYGzbolWTZNp5Mmt?= =?us-ascii?Q?U1YKOmhBUhX00IjiVqAvkYACSwlcONUqi2a2xvzWGnVScz7wVLdR?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 94aeb237-3959-42f4-e36c-08de888a83fe X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:03.6046 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NFVkwUM+O/h+rDjQIvOhF/FjwIy/a3XnFlI8PfEbL730ZjyhXadeDVv35MuGBzcKFo3d38jK3dc2aNXSsJyURA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" Implement .db_vector_count and .db_vector_mask so ntb core/clients can map doorbell events to per-vector work and avoid the thundering-herd behavior. pci-epf-vntb reserves two slots in db_count: slot 0 for link events and slot 1 which is historically unused. Therefore the number of doorbell vectors is (db_count - 2). Report vectors as 0..N-1 and return BIT_ULL(db_vector) for the corresponding doorbell bit. While at it, use vntb_epf_db_vector_mask() to simplify vntb_epf_db_valid_mask(). Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- drivers/pci/endpoint/functions/pci-epf-vntb.c | 36 +++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-vntb.c b/drivers/pci/en= dpoint/functions/pci-epf-vntb.c index d91033ab8e03..d83a9be1113f 100644 --- a/drivers/pci/endpoint/functions/pci-epf-vntb.c +++ b/drivers/pci/endpoint/functions/pci-epf-vntb.c @@ -1266,12 +1266,42 @@ static int vntb_epf_peer_mw_count(struct ntb_dev *n= tb) return ntb_ndev(ntb)->num_mws; } =20 +static int vntb_epf_db_vector_count(struct ntb_dev *ntb) +{ + struct epf_ntb *ndev =3D ntb_ndev(ntb); + + /* + * ndev->db_count is the total number of doorbell slots exposed to + * the peer, including: + * - slot #0 reserved for link events + * - slot #1 historically unused (kept for protocol compatibility) + * + * Report only usable per-vector doorbell interrupts. + */ + if (ndev->db_count < EPF_IRQ_DB_START) + return 0; + + return ndev->db_count - EPF_IRQ_DB_START; +} + static u64 vntb_epf_db_valid_mask(struct ntb_dev *ntb) { - if (ntb_ndev(ntb)->db_count < EPF_IRQ_DB_START) + return BIT_ULL(vntb_epf_db_vector_count(ntb)) - 1; +} + +static u64 vntb_epf_db_vector_mask(struct ntb_dev *ntb, int db_vector) +{ + int nr_vec; + + /* + * Doorbell vectors are numbered [0 .. nr_vec - 1], where nr_vec + * excludes the two reserved slots described above. + */ + nr_vec =3D vntb_epf_db_vector_count(ntb); + if (db_vector < 0 || db_vector >=3D nr_vec) return 0; =20 - return BIT_ULL(ntb_ndev(ntb)->db_count - EPF_IRQ_DB_START) - 1; + return BIT_ULL(db_vector); } =20 static int vntb_epf_db_set_mask(struct ntb_dev *ntb, u64 db_bits) @@ -1508,6 +1538,8 @@ static const struct ntb_dev_ops vntb_epf_ops =3D { .spad_count =3D vntb_epf_spad_count, .peer_mw_count =3D vntb_epf_peer_mw_count, .db_valid_mask =3D vntb_epf_db_valid_mask, + .db_vector_count =3D vntb_epf_db_vector_count, + .db_vector_mask =3D vntb_epf_db_vector_mask, .db_set_mask =3D vntb_epf_db_set_mask, .mw_set_trans =3D vntb_epf_mw_set_trans, .mw_clear_trans =3D vntb_epf_mw_clear_trans, --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B501D1F5821; Mon, 23 Mar 2026 03:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235771; cv=fail; b=vAuCSrP97uR3H/R3tNIRQc3AAPjPcdhn8ex6Nu3bOCvEqpw094/ZgnaobFcAhCgIM1twiQmL2Zl+lzPSsms2OQPRRqGpZQWy4hA7FvY7pSfd/u1eWyvaftEIfbKB7nF5JRrtju85qSadzO+puiFJO6FZCJmfBsHSiTO1j2A9FFY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235771; c=relaxed/simple; bh=DQSLH26ddC1EMtwNntY7VcJBcfPHqAXdvkDaNeYWJsg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=k8uq/GJt+W1HCljYYIqnF4Zn4DmkWmwx4v/RZ3Tp6vkF7LEUwoE4+2rs4iCM6D2DSm7ng2CVnydKx+D+L0KQ1aN/V/lBVf1RR2AfztVPpnurB4lI7idjRXmXF80E73AW9DRVFD8VTDkjRbdA08W5sroPpjl1x5xtavTfBw3fbCc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=l8xCtXay; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="l8xCtXay" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LKNLfBoeqyOInO9LkA3cZiHL9/dO2ZnFo25t4XWAEUbSPvfVkrHrVsOxnesyUJNxlBMYCh7hORHmguXNCmM13cHi/pGTvzTm7GztkhrEvFW5aFtpETwge6/6+/Md0YIxxcpOZ0JosJ8HFUe+RA2/tF2oZw2kwR4cojqVqYY2TDPol75WOI5lPSPYbTMZxAFBO/326+8q07vO06c/CstMGZajdbCFLIvKBHaLGrCF4Q/A28kk9Z6+KfzZShc2Dk9jRUlm0xvy0ahB+VBCaPhmeKs/56UoJ2dq87ZfypLROmxeQUt2CpbNws2RKsL8wvAHcDMNpAWoEoMt7KI2nvez8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DwoJ4fD8ofZ+rV5jN+pcWS8DvxinyDUWYKMi2mIwnio=; b=WxVMs2qwI7oPj2uVj+peFz1fV864yPk31gf8VE2hypLL/rfgDGN0e7vXwpf6Dp8EbMlESHCq7cviVLPyS8lFZpNBHZ+gr3oug5ColCS+Rl6ct+Kq4+srBqzRYZ7WKHCYOuGC5zvUiw7KHSjN75MpauLVK3rrUBvzDc/HeJuH0NQeVxzE5ETCvSjrN8BkdddRoGJ2foxCoFRlkWRUtWIP/xsCO2q982/KGkj5G440Act7uxtAwIewiSYxLVZvlHKYWQ8ApTQi4+kP8Ko49PYKlQgsKMdN0HuR3pgyzMPHF//9GohRPoEK6FAsHRT4PximBujn5Yt6wVSCU+X0HwoqpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DwoJ4fD8ofZ+rV5jN+pcWS8DvxinyDUWYKMi2mIwnio=; b=l8xCtXay2mJGsaEQi1k9ZcYN4GXcJ3d1qXNw6jp7ZmXsuZy3j66Cqr+imKJT1DwQTRTxU1zjY3OtLVZi5JZA7lk5ROVMbygl2tMrReC4ktJZIAB2kPxXJoPPF4ffnakXU46LzB0S0Ws2t+YRap3rVHR7ivr+m13NUyiunZ4vgDI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:04 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:04 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 06/10] NTB: epf: Document legacy doorbell slot offset in ntb_epf_peer_db_set() Date: Mon, 23 Mar 2026 12:15:40 +0900 Message-ID: <20260323031544.2598111-7-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P286CA0126.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:37c::19) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: 32a35fdd-e57a-4fd7-b278-08de888a84ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: jKfHkgkS6TZ5cxO6nLz+fnY0cTqRp8oVKWbyaPpOYR+zmqI1muESY7rTkAZfdIEY45IPXrClINqYbBDEGhVhLvfbfIg8ZKW0QSKL5RFUTI8iTTNZb4cNju5fl6s0cg9TYwYDrV1n2cgXDoF7jKPuE4Owr7mLTrIaG9sGBcv8vP1lM5AkBCfrqkX0wC5Z3t0Om64OyjU4x2pJsuP/rWT+gOmz3qjWlvKuBLZLSo60IbatpbsvZYBBwYFgRrrXc40YwAtWma0w5+mBVON8o8/AZ3WNtBfcTWC94u6P7UHCUrmeNjh0GCL6xZ16yqk29U7Ybt6IPdTwrt5k7dvbGTSMn9A28IwuLmXgerx9PjQ/xp+g8cOq74QQdliqPSeqO8gy20A7INXX8wucD/Z4b4Cq9jPt1mvBvcgu2mJXPMs2W+E5cjq55ylh4XRgoPYjZlo0SnJhFD74IjDJWOg9fzcbPlC6tVbRAQVm0502FTIloNVoJb3CpnEgTMCk0lhRO9pfcOCC25BRDL3jfYob6/p9LlcQu7gWdfaYUll/ARYA6FYAUtweMrUOfuY7nkUiy6qHh/vIhWLuA4SfmiGB6Ra0t7sC+4X7XqaWbVdQ0cIcYs5IpBAmmOoBvJvUPTK/gOjexd2AQY00R8uYaY4AVjCo0yIQL2+qoM3CQKBLmikN1xwj2G5z+VVmuIxnLJZtorANE6h0tg3gN+81WBO+5k9aC2dQYkpCLGCKquaJYuEq7P38pLAQXchnhi9+YeUUAmPvRakNk4MRrRL3lee8tJ/SpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yLPgjp8KKI61imag5OThwJRuoNDvDSsK9SWJmmkIHGpKQrfGZVCiddna4zYz?= =?us-ascii?Q?b3LqS/mhr1hn1NHYhsRRCIEkd0MVh/3xpHF1maVGegjla2XO2EYC1AGbev59?= =?us-ascii?Q?r5hV4XB2LaDuy6U2F4Vd6Fa9yJBrvI//q4r5mJ6TlbRyIG4PhUkMjAYxggKf?= =?us-ascii?Q?EQZUQahCA8V7zgPOI6dG6oNmPzk6tqOaY+xocuDlBK8qNU8hUejnO7auUkl+?= =?us-ascii?Q?p57ei2fSh0BfNPoDKA+xovsA7pk+Le5RSkum5agE5w7Y6TeZjCjHbNrmYz7K?= =?us-ascii?Q?3FpjyapMvJsHFQpgUaJENWECiU8qMF12k78NxfYSzn/bT8OwxibmQYmCg7kS?= =?us-ascii?Q?w1SNktLGIohaeBuuh4b/Y5irM5XZr+PzZayT708kNeLyVwuh1Xl6i/bCVyFs?= =?us-ascii?Q?aXqYCYTbXiwRuvs3WeD9TjJIsHX6j92XRke/b36TcGhxyNc6C1bg8/7XTufx?= =?us-ascii?Q?TN93eMD+Be4NuD/U8DFlBBJ3vB+7+YxIlFaaUhHMHyrzuaZeeMbde2+wTq4C?= =?us-ascii?Q?qHYNl4h0mfrUCY2jirdXeXLvI70sjtojCHGcbX/+a6/fpkpidMNmuvQ/pBvD?= =?us-ascii?Q?f8FgnVBIKy2DdBbSKlAaSwkaLMqlFnwcGb3GD4U9boK7b89x09WffLwYqIen?= =?us-ascii?Q?Y5nx2fcFDIA2rwj2UD3l7v6Ro9+12VHzAublTIqwu14ykyXRjC6qZjsxWC4T?= =?us-ascii?Q?rgESrB+M+lKgbFdmPYOdiL/l8jQRzALVOqnGcfyjCkTndyhFxvL/sN9FXKRo?= =?us-ascii?Q?dSphnErPxna7T8IpviIe9iLzXPXJRhDFPc2VJBlqP/j2QjXns4uPGWHeV3Mh?= =?us-ascii?Q?EfGS/H/8237qMjIcJOj0N0Ubdsu2wUMC33qZDE18FV00rTWrshWHALmBrf4o?= =?us-ascii?Q?uQVduQKSzO7A6TyocGMrw4bVOSfPDWGmYeg6HKLSoNsfnXQSYH1t5KaFYZTC?= =?us-ascii?Q?SG7uuzjwlZkkGUQtG7nIJ78N8qh2Dn/FoLAa3wiIs5g1wklIiLMREMLFMP8B?= =?us-ascii?Q?4fcjSIKkRjAzozCo5HCd5tfz+ODurG0kVdIirX9kAfEeYUg3TtpIsx8yQxDD?= =?us-ascii?Q?Mu0s7nZaR3IRzhZJg6sgguOstuaYycghOipdH+sTL8LF3l9pxLWGJHA5MhUw?= =?us-ascii?Q?NFTPwY1Y8Wo2pO5DPinks3OLaevhSg9APS+aVWWp8NV2OcQmzVjvMM4ompDK?= =?us-ascii?Q?q2FNQ2sZSJb6SPjLKQ1E6X/rom8bLoFSoopIF1jMJxlAs5lJZ4nmBgK1TdOW?= =?us-ascii?Q?wv1kz9EenKY+Izp3p06M70mBf8LkyQBKXeke3H5o9uwD9M9zMWXDD2fCRcL/?= =?us-ascii?Q?sVTR7htE7PnAu2UqlynR/Zs5f6yISnm6ZnIxFr9K2+qZ/GCQVuRiDTtuxzvM?= =?us-ascii?Q?2fhA8TZQFq6r3ulSfJpBxmdVqsr1BvSaj2Wh0VrHlR5emzvQJef0ssg2irqA?= =?us-ascii?Q?ttmkpUWCboKRPOM09rcnpZg1FTj2Y5olGXoptnH3wGVeUbMGlUax1EY7kMgI?= =?us-ascii?Q?ekPBWkLxgjetJSIZXuYeSOj1E6jCdENxdodnKKKaorkZvLHe0oLYC5iQsgrf?= =?us-ascii?Q?wAU5IEdK3Ct1UByVDvNjJhYok6Co4sBZWqoTUcys5XS+HjxV/HkZT1BDPFrP?= =?us-ascii?Q?BBk5S8SIbiz84cN5w87vXV8ITILKn4aWeytdOqjHyLko+fHbiSxQjwpoESP1?= =?us-ascii?Q?AGRNZeL/tIukP66aRMYXjytTXgiBQoKv3ZIGVa73aUgTYedgWEY9kmsiLaDU?= =?us-ascii?Q?4zEz44CfcOZDHclyw4mo9dkQYz90v3cC0RV/GBpSUB37W1tJZm8h?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 32a35fdd-e57a-4fd7-b278-08de888a84ab X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:04.6705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 95D9M5UQErCAhbRNM25ogxFj5MtI5fvFwUYSolABD6LVhIubC6BA+xANAEE4wj+Sz4HvVK5Y4Yy5vZHoDgce8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" ntb_epf_peer_db_set() uses ffs(db_bits) to select a doorbell to ring. ffs() returns a 1-based bit index (bit 0 -> 1). Entry 0 is reserved for link events, so doorbell bit 0 must map to entry 1. However, since the initial commit 812ce2f8d14e ("NTB: Add support for EPF PCI Non-Transparent Bridge"), the implementation has been adding an extra +1, ending up using entry 2 for bit 0. Fixing the extra increment would break interoperability with peers running older kernels. Keep the legacy behavior and document the offset and the resulting slot layout to avoid confusion when enabling per-db-vector handling. Reviewed-by: Dave Jiang Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- drivers/ntb/hw/epf/ntb_hw_epf.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_ep= f.c index d3ecf25a5162..bce7130fec39 100644 --- a/drivers/ntb/hw/epf/ntb_hw_epf.c +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c @@ -43,6 +43,18 @@ #define NTB_EPF_DB_DATA(n) (0x34 + (n) * 4) #define NTB_EPF_DB_OFFSET(n) (0xB4 + (n) * 4) =20 +/* + * Legacy doorbell slot layout when paired with pci-epf-*ntb: + * + * slot 0 : reserved for link events + * slot 1 : unused (historical extra offset) + * slot 2 : DB#0 + * slot 3 : DB#1 + * ... + * + * Thus, NTB_EPF_MIN_DB_COUNT=3D3 means that we at least create vectors for + * doorbells DB#0 and DB#1. + */ #define NTB_EPF_MIN_DB_COUNT 3 #define NTB_EPF_MAX_DB_COUNT 31 =20 @@ -473,6 +485,14 @@ static int ntb_epf_peer_mw_get_addr(struct ntb_dev *nt= b, int idx, static int ntb_epf_peer_db_set(struct ntb_dev *ntb, u64 db_bits) { struct ntb_epf_dev *ndev =3D ntb_ndev(ntb); + /* + * ffs() returns a 1-based bit index (bit 0 -> 1). + * + * With slot 0 reserved for link events, DB#0 would naturally map to + * slot 1. Historically an extra +1 offset was added, so DB#0 maps to + * slot 2 and slot 1 remains unused. Keep this mapping for + * backward-compatibility. + */ u32 interrupt_num =3D ffs(db_bits) + 1; struct device *dev =3D ndev->dev; u32 db_entry_size; --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32F9B2D0C7E; Mon, 23 Mar 2026 03:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235772; cv=fail; b=gRtytXPnLW5gCUMHmJ1w6BJ5Uv1q5oPsNpx/ZGwe3wwh1APB8lp1DvZFDBJw7/19yGrOBr/Cd1wNMc/iXXtsJvqWR/p5g27zQI0g54nqUwLZrU0o7EusmFRlMQcMJ1GsU1b+yHWNsXeGohpPt5MHWTZh34doewZA0zbWC+NV5cs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235772; c=relaxed/simple; bh=oK5aNPczH9hampVJVXa/X1nQLH4R1+K/btOcgzzwuug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=UVNGtmYAUjzyEyvl+gl5V0GpJc55twUr0Z2ncNicULX980sJjo1p+YJNKRuDK70Cja+iOhM0krYXCJOgbwYg6ePkCp77PLBunL0e7BKezhtAn1dvqB/95iyikWAl86ldjp5D5twBJfXYloWIpW2AH4lpH0D4398f2VsRCHiwarw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=s5YKLuBt; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="s5YKLuBt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HYe5rrJ+GPJMSyrFY6DonPE6Fhk0zx1VluydUygsEB5xKiL6N4/QKUOfG+DTZoyTcWfqhEd281S1qVH5hLLefdXBr34Xe1PfaV28v/2H4A9nMvXbGU7+iFYOuBFD1teuxoZOaogGpe+zaFrrPVu7DwqGWH/EiAm69vapSuJdhuDghXcBlN2vPxghvK5D83GPwFWDVidMjaycnWImbLgsqiZN9qVE7Fsef9JY/Tnw3aYKOHPtdxuuyJzeyvzPim37sHFX6xfbYNXxIRtAvlSaw/aDx/pD1XlaeJQsJt7j+XR+43l1G2OacW3t3hLNDa9DDudJQUpoxKzD3+5XDmpLvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BbdLwShg/N0PqmxqrhlJuRm2kLPvQXzQ9FnDk+Ewkgk=; b=G8IMDMcbvI4FToAGOgOXiE6obg43c7RCtiPNp/HkH6hC2kfpIjNyT0T9dkw/fAuStuArpfQwfyTPa1mkrrdYnbRyty9lrJ+o+GcqPYSKZz810na/iemJRfNfo0EZwjh3PODTUcB5BwHZGI71gQK28TJhyhtmzH0W4wR0iFqwyxYpw9a6ACupiL1BYM1WuRCPirpWZVBTTt180So5UfyGOVkguoeGJcXxf53vlpybcBy9cbZZfj0gcARjZ8KfkaczYid5/dweHJQ+3f24Wv0agsEieCGdJfKeXJVt/kPlmFq50jv7iWX1jKpjqRyT4BldP920NgRfpdMMKwE97umg/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BbdLwShg/N0PqmxqrhlJuRm2kLPvQXzQ9FnDk+Ewkgk=; b=s5YKLuBtj9kjrN8TwIRTxAa51/qA1Z03Y7r/OV9Cjrye5IuaLjhCKX+HuvMNJFA+LakWfbAgYckJx99QfZsBM7N6eTGnkZ7UIXitV9w53dK5M5eYWBEoTAiRoqhBS7i6K28qHAdYaBTgwkaQah4wE8FWe8+OHiYmcIHKo6MXWWY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:05 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:05 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 07/10] NTB: epf: Make db_valid_mask cover only real doorbell bits Date: Mon, 23 Mar 2026 12:15:41 +0900 Message-ID: <20260323031544.2598111-8-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYWP286CA0023.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:262::10) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e2deae8-4f1f-41e1-fa22-08de888a8555 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: S3OLTL3GiqSswTYicNBpFlWsKi1Q8oNaZHDD8gzv+ZGOj0GVqUAM7m+d/KcQrg4fV6S44zJ7/3BFz1sUdbdt3Fza1v58u9SIbmC3LJfFwAb7qjgAYl61Bwn9oCz2dYeMBiUebrYgfiF8mWLa4YBKgIHAsFexr8ylX7gzkg7qH4quOCx+lAp3FI67/E8h//aDRVR/XCqLQJJlOnraWbZRQPu9RKGW+qin+ma7I8zpmEpB0/dwGN4p3BVbx2WoeCDHp8U3smSkTmRx2IDJgPkjxZ3AxEzhh1YtRQPYOrs0uE6PLMAj5Pi1pO5ifhcCETWku/2pOKxBmJNgeUqeDmWEk7QA00QuWsTdCw0EM0fDxuGeRFlBtbhIYJNF4cKYuCesYVIiXOsqnah9atLpntY8OAJ2wgGdqTfF11CCWDzvH6Zu5y82YyIctGzZBKWGkEd0rFAnwVcSjp8Bf5D02Y95CEd2nHH+rccekxg8nsdPZzuOwM4B3tvcCk4YO/jsU5Zl+sjf1x2P3HpS7fuRxJh7HWDx/Ga+pqKh2AWittXnNQKTloeO5LzAQFUkb+4mucQrtRyRQ86lURDzylTt50DW7i9YsDhGFXttv8B9wBbPNRkqrhq/e3sKcgnWTiKeckmKQ+pWcgQxH9dcXzcI81bmbrJL+79yx2WyOPFRMKHVNx0KS0vsxjyYA4AmoSXXTuQIEekXvcwaXZNoD2+STcyuGMeHLQPNF/blHQXykDEZSMLR24PzzzUYPpQuD9lUbT6KVZANTVKVG8LgD812CrdWOA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WDdkMleKa+Gnz6c65O7LUEyBwAUL91wp6qEW375/NYEeyijfMqBDn2YSXe8R?= =?us-ascii?Q?fbvCw42XGcBpNz21/NJrjWQDesKIpJ4B6QScnRRwy2iNMCBBYIkKdkhV2oWX?= =?us-ascii?Q?P31wYfacXJTskbjFeLGY4OWkUZnw73HE5wedhYbb4F7H6IbT47d/XBtsmmsD?= =?us-ascii?Q?iz31QbKhTfcGtr2ndbJmDkLinNZGgKUxP+KCooYqcXGvYxAmSNw1fYpbIVbQ?= =?us-ascii?Q?jmlg7u5II4ovkaJFbEw/VkxLEfF0ZFE9eWokBlbbtgEUJPZ2HdSmw70Ie4/e?= =?us-ascii?Q?0dLtxRRKWzeCXG2V6HeZ2n541bezQ+OmO8JzNiBa1dz4uiElobxp+DJ6GHOa?= =?us-ascii?Q?ErV9BC2ASyGYIGTTyTz3NLRlnxAGwOUj7Gah8BPqkfDlsTFLFkqk4AE7oP3N?= =?us-ascii?Q?1ZGQzSdk+K3YdRe3vmFmq85gpSM9C5kQmi2hS/eVGusrtT+2+MWnS3qT8b6B?= =?us-ascii?Q?LF+otFbacpEKqqP+AvpZgZjaVThllBwJvg8z+bHr7VqVbxrUqOvfu+aHpNLN?= =?us-ascii?Q?skgS55ac/a/FNjlUlvItux5yzmwu6MOE/a8gXAX5SJLX91VtF4EH3KomfunX?= =?us-ascii?Q?nnEJDm9fTm0TNZ2vTN8TmvqtvhUOK4Sw9ayzJlAV71x919I9ufDXE2ANbSNa?= =?us-ascii?Q?tOLtfT99BnjGrWnxtvoH4v811+iTQcKP2nHYj6pIH/9bi3+jZxuyVIL+EWqA?= =?us-ascii?Q?HEtzr0PMJfewUv69PwSYxXu1TL/9kNpSbrk/q12+A02eju0v4Gv/h3VRzfxX?= =?us-ascii?Q?/jO7RAp+RYCMt5CcziXfv3Gv5d1/g2Xj3ageLY488PE2sqX0GvXe0AqYLl8T?= =?us-ascii?Q?AYQ4cHZ+zvQBLr3CcJcHiub/way2QVtonQFMOEgBk2pl3nO8BkKCOASY3mEq?= =?us-ascii?Q?7tkcLmdBbNAMIOn3WJ77c+p2utGLL22pzTYQk8vLTldO7t1SxSkfXPhEYWOL?= =?us-ascii?Q?H5DsihF4rWXJ33ysz6E6GbJQ6AJfyd3QEBKxtF2+ZiGNWh0YBjBEFpdpVmY8?= =?us-ascii?Q?fDQP7AtkNq80XJ2njk4ScoNNgfyCgnVLPr+CqcjU4gafCxPUZPf9WwZOELli?= =?us-ascii?Q?JPv1q6FUXcSCkWB9kCOHI7LNCL+4wpSCrXnwUpjcfqCSkfWDybxYVnHTTtNd?= =?us-ascii?Q?XXH+jr9Kv2hvFsDCcaXk9eApR22C7/U5i15+yeHMUa2H+HCZwS8eHvSq6G/E?= =?us-ascii?Q?SJUPkl4KQaJGnbr6HLBOuQ18HrcvjLCirXLvBOzcyRqKS4DjoLJOhDbCBV4d?= =?us-ascii?Q?HEzOdXGdpb/fkI89rl7HOHjOZL1UPn5dWu+ySJyy2L2ORfknO2gQk282rjZP?= =?us-ascii?Q?kALJDKa6c3zKMP3Ye/iez95xFWUkW7U6elxILahuqGPpByhmUeOT4+O3xgO2?= =?us-ascii?Q?n7Md+kxIE/9Rv6mTqxh2OXp8IhHxHNBsrZtVA8VHIIKepy/nZlRAIyv8yTxa?= =?us-ascii?Q?XehbMG8prTqMn985gFv98bMjNpERyUBQtKVGZs4VnSLQ4L5vDJ0XRgO5KYl8?= =?us-ascii?Q?tKH/SRnAEZPCeBoy6CgCHfSzrYsruSQ72NtPSrabdExAkvbmTtjWuk2ma7FN?= =?us-ascii?Q?5dfUGkl8ak08rxJfongJ3SQc891LF6ynseZYFEby+jquj6CJnEU44tEkGWtr?= =?us-ascii?Q?RpHmvBuc8kQlQhDdUJJXMx2lPMsYTKsQgxmDLH3MIcQS6m508Jtrlc6sPUEn?= =?us-ascii?Q?nJ2fAB8Sgrk01/efiui7X+KDZHZrauI5TuN9iTT6kVfBSAQmxZhpxVObvdzc?= =?us-ascii?Q?KKnxg/Qy/YXjx8hDN6O0Vs22AxBMgIjgZWxkME7i1RgB26Y8ascQ?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 9e2deae8-4f1f-41e1-fa22-08de888a8555 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:05.7828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UKk8qD2EkVTBWLbMoWLB7+LOmpXpdcZfnt8iEUmI3VBRmVvcFKYV2TND6DybIuyaRwScCvG8pWNH6nnGtz5w1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" ndev->db_count includes an unused doorbell slot due to the legacy extra offset in the peer doorbell path. db_valid_mask must cover only the real doorbell bits and exclude the unused slot. Set db_valid_mask to BIT_ULL(db_count - 1) - 1. Fixes: 812ce2f8d14e ("NTB: Add support for EPF PCI Non-Transparent Bridge") Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- drivers/ntb/hw/epf/ntb_hw_epf.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_ep= f.c index bce7130fec39..07dc97d3270b 100644 --- a/drivers/ntb/hw/epf/ntb_hw_epf.c +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c @@ -580,7 +580,17 @@ static int ntb_epf_init_dev(struct ntb_epf_dev *ndev) return ret; } =20 - ndev->db_valid_mask =3D BIT_ULL(ndev->db_count) - 1; + if (ndev->db_count < NTB_EPF_MIN_DB_COUNT) { + dev_err(dev, "db_count %u is less than %u\n", ndev->db_count, + NTB_EPF_MIN_DB_COUNT); + return -EINVAL; + } + + /* + * ndev->db_count includes an extra skipped slot due to the legacy + * doorbell layout, hence -1. + */ + ndev->db_valid_mask =3D BIT_ULL(ndev->db_count - 1) - 1; ndev->mw_count =3D readl(ndev->ctrl_reg + NTB_EPF_MW_COUNT); ndev->spad_count =3D readl(ndev->ctrl_reg + NTB_EPF_SPAD_COUNT); =20 --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 980262D2491; Mon, 23 Mar 2026 03:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235773; cv=fail; b=ubnKHxbQFQaoy3BxqFTWAQd0Ajt7tVyvUD012orryLHYU8Cn0WRm9xo413nEXCD7I7+H00kt4UkqGjvrUcGSFe/9C/wqzBnfe0aYRQD7iYX7fW7toyk7usr4jY4EaZmp2yA1kOW+orRZZTcufejTZlLC2NMC2vQV1movRt6sNLs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235773; c=relaxed/simple; bh=kMX8Xabq8caChuSpi70GzmFU4vh+NdM5LaY2m+JLAWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=o94YM7ZtJQbka9uTVhDYqyjXPLGprb1G32QpBa6UXE8UJypUA/9WeFXsE2MZfC9bOLpkcKobsHq7obVFmiJEAhW0oLtiMaCCARdXvqHz3V4ERIojmTg3vjhcUIl5Xr3UKdLG06ZGnBBrDQMOHiLXVAoO7vdJQkSmreW89QIbwZ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=oEJspvg1; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="oEJspvg1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N5N+E69xCn5+jnMLLky91D6Jnd3W+QY0IDuG2jNKHbJMPcpcpmo7zgU87rIMC+z6BeLUgZMmSKq7w3BR/hanRdTpH6pOr8ZF7V6gf4TA42cFzjKoBRd4/A0+P9Gyu9IZzelAkNE4bdxOJDqMB7mPcVARPrayVo4qzHd4EUcX1NiMtSiMSM/AVkAe9FEQiJBHSwUNkq8sDDXd+wyford9HTAQqeTtTbKJT4UXF62OJUW/z9fD3dJzE55BbOB0YVBOejc/CHruoo/ewrhLCM5XZ9uWseI7CNSuLaSn0f+ArjR+n0PhMjrxlXL+iG7weLS6zfkN7rEb24sIwIuwbfWs8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oN8gA4shE48oVu71dEOre0m+r+Hc7KPSDGqXl1V8lTA=; b=Q9XXbTxnXszOz0pgd8HS5b5voT93KkXKoW727zuvYcbKYjuPN0vSJ+jrUsW4fYTnGWLGoyZF4OPNxSvLWb5TsqflM14IZe4vB72iiVPdjr9UTYQO59vNtv95Uz0qxgNaXZ//pNa6WhOZuxMr5v99qOnoLxEYqUW9qQmRgy+JtbrrnmOvB6QBQY5C/8ISIv8LQ+pq+uqPbPlUtA0JD8nIzajuzK1j1vcwjapYaILPJMnCgtfKPuSuY/Cc/yShZgCEvn003+vC0YLuTj1RFCLZSUN7cGBnVHzzOmeH9NXsmOSkD9d9Vdwb/TnbeT1/AO6Ebz73j5IlrniLY3UYywn3Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oN8gA4shE48oVu71dEOre0m+r+Hc7KPSDGqXl1V8lTA=; b=oEJspvg1HxjbpOBot+EHtJpFtgo0lFItjnnhMyi61K+iS7Hj2Ck1Dwpe56bE6Ozj2Cn1ETKW/8gK+3ckznpBMKtGrY6YYz4UU6Bbynh/Tj0nbqW36YWUym7fLOXuwyvR09kNtjGaEVeHanR5i2AVhIAJK+tLM/6XsQrrRZhYkO8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:07 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:06 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 08/10] NTB: epf: Report 0-based doorbell vector via ntb_db_event() Date: Mon, 23 Mar 2026 12:15:42 +0900 Message-ID: <20260323031544.2598111-9-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4PR01CA0031.jpnprd01.prod.outlook.com (2603:1096:405:2bd::9) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b8387fb-e61d-4916-ba0b-08de888a8600 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: RKO3DlpZuWqvmOA20Etxj6WG2OkYqyUgFDhEQZs3IiuKRwdz3upIFT6ZSbmfTy6H8ni+Fi0v2A1JyXR6UWooxkp2GqB9kR6UZwcucGODlxEzh/HIcD7ihChf1sFBY1BtJ45jlXoMCcOy3fc+YQXPi8uFO0UxWS0zcRs4MxtzL9n+8inn5vj0TgUgia0jR7ThZSHbVz4IngNdbyQqbx9mILUfJCoTzHT13fPon8nxAmS/lIJiwi9MXtfmzStw962dpdlFh8hBPe1zLzb7UawEuwzM6IFHmYbs/PkkMxfQkeQhZ86CrJXnEWs09BzcHxdVhIpt8u4VMCLrDBOsHw8jpfzbjDUnxj6qVtn5mqXWjpJx/o6ZYtQoyz9BcUG7IIDY4K+jp+9yYv0QoxsI7L1X22zxkvEMh6l+Rb78CBNPhXgNLRN+Bgwcl8cjDKm1PM3p2RD3nUClZ4CUObCurQG76V52fspvxkoLrGiKaQxSOF+RZ+9qfhLUd3H2w4lzICCTQdJDv+5RNwg4PDGytc8fb/ORAttr7Ho/O5OAyCkg3OUQ4dTSecQ0P/2LTeeyFkZX9pNkrDQZ3Fo5n2gM2Tg0Gozb65znIJDKEdx9qcjsMakoC5pIOgG28c8rB4dJTMDpWHw+iSTDAUAIB0nXGBZv9XK3KKvp9vyQ44qyudkzWWdCO3rw1wFSWxX/yiRbp3HBh9HbZbcl0vduA8+U5q6Zt/eBoz1QkWsJNKvgI4z/NJtex34Uyn2VtB87cihJFGziPIU6lTtm1ZsEThxgMdL9AQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6gs92SFKpy6RTlmRNO3hJGI++zpyT4S/eXjmPG2GUp8pihT+j0bSR8ZGNgKq?= =?us-ascii?Q?KD7LQ/w3vc4tlQVFJd41sKoiFsp5jTfwBID7Vdqlau6yfDM0f1unahbMJVki?= =?us-ascii?Q?njxhSEVIbWD07j9X0tsGBaKcU+OOW+BXYzuLACmxokRldTrwV1izuqiCWbXR?= =?us-ascii?Q?SeFKx2UEKuqfU1L81n7MAJ9kk2nF5avYIuEvuyItqKVGODpJ7ktTU30Pxmo3?= =?us-ascii?Q?C8vIQVa+/UDFQ85LtLkNB1Egmb0XPjfhce8oAguuJMLGST955NU7Hpra04So?= =?us-ascii?Q?O9tLwyYmxoPj5+gdFjIbHSs8j6ORU30QJUGVA5P8gQmRQVqtlRzteOR2xUYS?= =?us-ascii?Q?NUwgYAaII+uJFfA8jkjuDW3Pc5ntixYb5Ebbpwnsvzxjb+BgEtZtVY7vcc2f?= =?us-ascii?Q?TRiAUZ95VzN7TJPHyFYVkmnINMM3FrrSwxDGG0WGlocY4pGdUDCWj6pY8q6d?= =?us-ascii?Q?h8cSQ0iVmINekzmPo7RiEbpOwVBO8AGNUYENJiG6FzMyTsvo7ygLFS8ecIAV?= =?us-ascii?Q?A23dmD19n8hAkgurQz8a33ebE0I13JlcPWayP2YeV72SAoV3LI221lTWIeqE?= =?us-ascii?Q?NcEwUZftqT4Rvnry50r77OQsKJE55/+26ijCZblp+TDqndcdC4akEz/mzvp9?= =?us-ascii?Q?zPcMzv7qoZ7K3R3SJORkUSq+Ci4zBXKm78hxBe9tCVjW/vEznddUMvtfgBsM?= =?us-ascii?Q?Ng81yCtjvA94ZF6LvU+O1zebEibCiLwRbHho0myROMuCnGcyg90T5rjSP/uj?= =?us-ascii?Q?PYhkEvSxALcNKJHp7ixVLYSKWI3IVYTeUkqZOZIPQYa/cnP8WhUrwxlBD0/O?= =?us-ascii?Q?pM/SEioNNNBn4drIprcOKglqVONPoJk30t56KAk+1u2M+KCjYQzjN//fhe59?= =?us-ascii?Q?Ote4JQ2fpH+QPFiYc5Uiys9KU63s4OcxJgLPxhdFkdYI/+wEgcgTgbv+uHhE?= =?us-ascii?Q?iRA1qkywvRbBnl8erLOdb5ezPCPV3heTIeJ1rGwVZB2TMk8dQKrvvzVGVAhp?= =?us-ascii?Q?AFi+Bv0Y/FFKOeM88tjldWBM/M6/4Tzt8/PA6IMF78vrqB/FabL1oq3y7sZp?= =?us-ascii?Q?CGiOSxe6ta2xidnPjWn3exFXwU76TsVRHY3PooQfmv8BGTrXS70AbPUKzia/?= =?us-ascii?Q?Bi2vd1CAq1o1taKgRB79FKu2YKsiMCTsO2FUfwAuyrK4wmFFxzxzkt/uD1GP?= =?us-ascii?Q?5pP3gzoZ/q6QoJKCo/4tEJyaLCMNXoLdktCSi1ne4YYNqkIYiaydKeB+JkXT?= =?us-ascii?Q?n7kDGycadakwkds4x+BxkWztx4aS0bSN/Mfzid7KRzMhuJqlkvcQDCQFtz2d?= =?us-ascii?Q?2iFlOQ/hBQbtUeyNGHdShnN83lyRtkz/ICn4sHC1bSiXX7AtBG0essWCV2Nk?= =?us-ascii?Q?nphoCRQpAAszzJGuNCysVDLey7Gt0BCwrhGHa6zjXo6ebCz81sN0Auc5HvZV?= =?us-ascii?Q?ruJ/vFgwyYZVnv1XVigubvGqqvOwRiANpTStTcxPsq4fGMkdJJiLJmBNjOnG?= =?us-ascii?Q?xx4DfS8TzmXaezZ8qUy/SopmOKcfqZrOFDKT7A0blXLHq2bl80y/7BF3495V?= =?us-ascii?Q?DhWUv+M93uRc7Tp65N3P01ccTjM0/An945sJuN5FdYAEed3xxmJrOlt7ihK3?= =?us-ascii?Q?ww4p3daI4WmS76TYBDjprKkGR0vfHNC9hLDD9xQK4lGQGiLlEVG24ASQ30vw?= =?us-ascii?Q?GbktJzHzpnk+CTRo8pvTVBbNM9h4+k3N9sUZIQTTO4DznubDt0sWgmLWTT2D?= =?us-ascii?Q?LfQn4LlM8blSxUCMm/OgkuP7ZDOHOp7YG4vV1UeaiILnHFdgZ+5q?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 8b8387fb-e61d-4916-ba0b-08de888a8600 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:06.9294 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 32aCXRwlrW49TPRgUdhPY6LkAn+OqmXLVwy8UAXKevymDswUYrCyBNwA8Y4FmP2OaU/CVpWwwHbwx6HIrC/A/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" ntb_db_event() expects the vector number to be relative to the first doorbell vector starting at 0. Vector 0 is reserved for link events in the EPF driver, so doorbells start at vector 1. However, both supported peers (ntb_hw_epf with pci-epf-ntb, and pci-epf-vntb) have historically skipped vector 1 and started doorbells at vector 2. Pass (irq_no - 2) to ntb_db_event() so doorbells are reported as 0..N-1. If irq_no =3D=3D 1 is ever observed, treat it as DB#0 and emit a warning, as this would indicate an unexpected change in the slot layout. Fixes: 812ce2f8d14e ("NTB: Add support for EPF PCI Non-Transparent Bridge") Reviewed-by: Frank Li Suggested-by: Dave Jiang Signed-off-by: Koichiro Den --- drivers/ntb/hw/epf/ntb_hw_epf.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_ep= f.c index 07dc97d3270b..67cdc5d729d5 100644 --- a/drivers/ntb/hw/epf/ntb_hw_epf.c +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c @@ -81,6 +81,12 @@ enum epf_ntb_bar { NTB_BAR_NUM, }; =20 +enum epf_irq_slot { + EPF_IRQ_LINK =3D 0, + EPF_IRQ_RESERVED_DB, /* Historically skipped slot */ + EPF_IRQ_DB_START, +}; + #define NTB_EPF_MAX_MW_COUNT (NTB_BAR_NUM - BAR_MW1) =20 struct ntb_epf_dev { @@ -333,10 +339,15 @@ static irqreturn_t ntb_epf_vec_isr(int irq, void *dev) irq_no =3D irq - pci_irq_vector(ndev->ntb.pdev, 0); ndev->db_val =3D irq_no + 1; =20 - if (irq_no =3D=3D 0) + if (irq_no =3D=3D EPF_IRQ_LINK) { ntb_link_event(&ndev->ntb); - else - ntb_db_event(&ndev->ntb, irq_no); + } else if (irq_no =3D=3D EPF_IRQ_RESERVED_DB) { + dev_warn_ratelimited(ndev->dev, + "Unexpected irq_no 1 received. Treat it as DB#0.\n"); + ntb_db_event(&ndev->ntb, 0); + } else { + ntb_db_event(&ndev->ntb, irq_no - EPF_IRQ_DB_START); + } =20 return IRQ_HANDLED; } --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A3852D738F; Mon, 23 Mar 2026 03:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235775; cv=fail; b=sa4jGwc5/IXQyPm7nSbMSAPCzLaYI8bFHk0Awe1ZaO9OFZk5LDZgwf+eX82fp+gEJxHtqQDZC7+6etVas+u63z7t5EOt3kNUF3bYsE2moBcQ4OsPN4zah8RfFtziPFmw7gcUOAXGirNlvEwa1znVHKJ0J73TYhuFDRUPCb+CqJY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235775; c=relaxed/simple; bh=kPP0A/AR1ebZqUwSTgUol69K4dSKle4AwfbfAdy7tuQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=EDzoo508nXhocr4o73jib1mdQYrN8r0/QoL75imy8vOayM5OHUj0Vst9BMEzyfWMKoD9juNUGpyZkYe4Rw6G4dkCNMb81Ah1ZSbLPxiW8n4hpLq8qePiZ0rNgJtDba6jtikDokohri197TNd4ywdR1Zk/26alNUplNx35fzbXww= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=UruKTosq; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="UruKTosq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SRIKY9iPsqGWAI0Qf8xFqEj20WGRw2Vd7POU5eM5/GYKk5LyWiUkTuY4WuzC5wrH5DALDp3KHKxxYrtne3BC6Ogfg9c05tXzlOdywRsMJ85Jjmu9dsV9NyC6vZRW9Kb27lb1qdIx0xNtRzC6aahpphGftw38L6NPVcmHMRM549ei1cF8lBcaepHhSAA6F8T6rzYzI5c1HtwRg2ovDMZGA3abz6wCx6adLNgeK/iA+cqb0p10kAFbWalMC3VZ2jhvAawAYBCIi3h95F8ncHXjwOZLmltkbkzhVR0rCFEOVLYCFbNZcRuUtDNYUrwyl2okQcaUVL7qhC0m6QRtsRwpcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9TEfxpn/KOB8dLfXpvJYFyka4rnviraWJ8+TBIbOLRA=; b=YhlxQWUhJoaX6WXlDHWfmZLN2RPYj2AqjbyQLLRTw6YvrslBopTnwDDMPW2DT9+sBjkQojMCSZvkzvWazhF1M0VLWX32iXDA9JGmzVlREcMqboFZJc0nb256RRwDiuS+djEj8DlM4rx45K7RBTw3kYAyGWCpjyREvwsniKgMRnP9UqjcQ7XzPQ1amDIE73o/WJUH+VnPfY8zlmaq4AncPqsO8DRFsgSnZrPbO6PvWCIDc7naaREqvkTaZuEDpUs1V4ZsBeYjQ0o6D5XeSapAKTIw1sTycG58tPO9HkC7keWKy/u6zn7A9MvJdHuwcdJireYIaA8UaSzxVJMzeyBd9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9TEfxpn/KOB8dLfXpvJYFyka4rnviraWJ8+TBIbOLRA=; b=UruKTosqikEqp4RJaKTVt/I6kN5EBJ5FMDXgRMt6q+WL5n4fqbshBqwKtwU3RqssswvqZXfg1baBvdImzcpchKZtvesOEAq2nsg6l4DFKmNuW/omqcRSpc40iuQxQ84sege2l3/fZyOsJ77N8OeyLkUiVPHWVPUgjiDqHWaxgPQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:08 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:07 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 09/10] NTB: epf: Fix doorbell bitmask handling in db_read/db_clear Date: Mon, 23 Mar 2026 12:15:43 +0900 Message-ID: <20260323031544.2598111-10-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TY4P286CA0028.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:2b0::10) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: 000a165c-ed26-4d5b-c4d0-08de888a8697 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: rJC37j7FrQiu6ym+zTMLeOwKn+6UO8KNUe17Xb5U9EW4z72fWXeuk9DoIuiytouw8WqH+SFfnnS8IhxwkLdUmtoTlbftSPBB2JLdWztPvanBzZcjjfkt/NuPHhPWI4dPfpUbtnfMs24Nw7MZf2LzQmNUnEPMMuww+AlT4Pz2P5S427nIVvWUZi+8J/icHX8O5ogc6nkPVfVv29nWBtIePU3tg8dQYRAGYhQvuXoUXWodyS+sjUKUPP/RNk+yaH8cMpZkwNScfk6ULPiSazEhDc14659XTvENjM7A4p379cuvjcFB3rNcRYDqEbK0+4b6Cq5uSQxuzpZ1Kfd9Hv+Q/BzUf4nbBJGVFgbrBzD6all3NHD2WAcVlyhPKBWhs9Jo3s4Gk6Se3rEtjK4400XOAzL0/+EtZenpy89rhhRl1XEOAn+wFLzKEHamV5bc6g226AOKol/djXyVoQA8hQPQAxEi4/Fhjnb5s3TJq91HQgX47C1dB3w0zBY4xrQODZa1Rt+4wZ1W/cHqaKhai3AqhgkyFar9I/sl5St4XWz1m+ZuNi1tdcP+UuxYJ0fZD4qqVVJW980HC2xBXQLLsZsrmXs0kAtCfR660JBQ+ydkIqSWY/g++qf83BrNjlhhXEktFevd39gW2UjCJBsHwQezLmOwm9muGdUD5NYn/RL+/DhWLVCbdWis/gaR65y/lOZPYsLEjMTaRSFilK84jstSA7hRHwZDuhlv+X817tYFagELHuIvq75DQJdOKKk8pc+DUG2nrf/HN7U1i3Qca+tlNg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CVVuT4JH2mts5AQaNJaGlPXyePUdATw/3BxSmwMzLUL4MkmvDOgOhWNVNki1?= =?us-ascii?Q?Rg+e/VzihxhTIKaaitqze/3je5oftOPOfcruaduDFLotnx+KUbxPXO3NwtT1?= =?us-ascii?Q?eLvjwlTEwJyEpkws9IJe26oTYmdDzITOvxlmllklIiGiOfVgf3XK62NW0cbo?= =?us-ascii?Q?0TUGhG+NWRqKNDN0nIIpS2wc+qVetBxlqE48e0HS8bUQy9btyOXXkJwQvqZ1?= =?us-ascii?Q?QuFpK3OSAWEQG/vRP2LFU/Kc+inoG7yYfhpzgSs5XDDczEi2lnEaWwq9vIfg?= =?us-ascii?Q?rV2szUdds1seB8mHJ27LNXE2ss8ZlCMeeUvDXTsWsAMJ/TQFKmP1FqU7Js0U?= =?us-ascii?Q?Vo0LFriX4h1xsSNOwA+0RKKniupUea8UphR4fBxJKoDCDoJ6bBtNVbBfj4sG?= =?us-ascii?Q?bzlplWP4o2c8hwkEmonUI479wYx7e8M4b94Trqf9QLzZGj/aSCO+d9qUEPr3?= =?us-ascii?Q?emrF69bgvntHo63sbZrW6EEBNaghie0MDHCeyvacu/r5auYtEhjm6kiybsRJ?= =?us-ascii?Q?MYHttcnAYNuXax21k9cjWYmtGOTTlPQfDlR40EaMjP6q2Jm8jFfxEcGmHQmE?= =?us-ascii?Q?KM1Fh/xeOZxpsOWwiugiGMade1dxsAy2T9wfvFFeIoovvmIoJvkDJQ7qvF7u?= =?us-ascii?Q?y1MpKT9M0b1iP+23IaJ7Sld8/hqHukPG06RaFwbcWYlp8/Bo934XIACYQICG?= =?us-ascii?Q?7Vv9tx7S0vEKGbLKUynh+ULBr0XGL9AiyXsw2a+ssDIt1scVXoTAAzFZ1VLV?= =?us-ascii?Q?m1r0wOCFlom/pL4a6Xv3uNlJQQ6/ai05j2MLOgI8uUQujwWHuuLAxyEKRb3N?= =?us-ascii?Q?0cd0WEuUVAFWObM4xAkGB33eUcbhZCX8el0aGew6o5raEucmFT4ElMM3HHzv?= =?us-ascii?Q?zeSlDmMgQfxSuQsjNwBkxuXqbSemXI9u32B14MIS0JA5pwVY5B4COTK5Ce07?= =?us-ascii?Q?l7AMjeMPkOpd6Q6sMG86V6aePlIk+edsYLJ9mSsn1gfaKlhPnvP331Jr9FrW?= =?us-ascii?Q?H8iPq76NHYWQl3ZwV4+HuNK6/pgsgrmR6lTXv58cRUfLPf4i7AmC27whY2DN?= =?us-ascii?Q?iJ/G5HhN20pnp1BMusFo+x8crrsbMyaPh7BQmlVgZHhYYe+iwcVWz26DKqyS?= =?us-ascii?Q?PehmEIWZNckmtap6T/RfT82KhLgNlrPw/KvnzdR8ylRWj+Et8roDkibXYys2?= =?us-ascii?Q?SLjoAds2AhOh/QEvHgEQQxUplDYiVqezvPDKdtPgjFvfBi2IYMYoTtnMvPWY?= =?us-ascii?Q?OCrA72gxMc1Me2dzGvgu9koGg1nTH9tATe3MYia9fDyynnbOv/zyj7bn/uir?= =?us-ascii?Q?2cdbSDzxqiiOwQ0Gd6RuM4P3zut0cLVHU3UVA89qzpKuvknLrFcWeAPH8gw0?= =?us-ascii?Q?tCa+nvHLR83i7GAjq25I52pR2OMldOmVyXlriEIj5K3ujvOTgLiGbgbMhnQY?= =?us-ascii?Q?3ivoEyOAyfAIye2WTwbiZBmU9wZzLFZlDJspHs8oP2uCw7cMlbdMfoTorC3Z?= =?us-ascii?Q?j7UbkJOidN/q2ApA7k9htdc49IozOlVL2XejRnSghpt1MxXIZHmPIc8994mb?= =?us-ascii?Q?WMPjh8xUHlZLaswYggyIluxqIhEmEycmAgJqGPiRU8kSaOC5ONSBRjyfbSFB?= =?us-ascii?Q?0TSwf+WbGP18RT65svSyi88rXVPV5pJrMK+7hwx2zSIeGuxScBXTTLfpFA9n?= =?us-ascii?Q?JgGEagTLKdrnOEC5y6Eek4RjWcWx0SBUXNXwlKg3rjM2qUZXKhCQfwh3ICWg?= =?us-ascii?Q?S92/pyHA90Ze4tLW5UI315Wko9edt5qIr+XGck8ZAOb+ATurGKUl?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: 000a165c-ed26-4d5b-c4d0-08de888a8697 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:07.8847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4x/E50OJ9P+mXNjLRjGMD9htTCTi5yZol4Gnab46YM+X9FuuMK3gbE34L0klJ1SZhID/0wzjih4o9yIHly64bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" The EPF driver currently stores the incoming doorbell as a vector number (irq_no + 1) in db_val and db_clear() clears all bits unconditionally. This breaks db_read()/db_clear() semantics when multiple doorbells are used. Store doorbells as a bitmask (BIT_ULL(vector)) and make db_clear(db_bits) clear only the specified bits. Use atomic64 operations as db_val is updated from interrupt context. Fixes: 812ce2f8d14e ("NTB: Add support for EPF PCI Non-Transparent Bridge") Reviewed-by: Frank Li Suggested-by: Dave Jiang Signed-off-by: Koichiro Den --- drivers/ntb/hw/epf/ntb_hw_epf.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_ep= f.c index 67cdc5d729d5..741d30821390 100644 --- a/drivers/ntb/hw/epf/ntb_hw_epf.c +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c @@ -6,6 +6,7 @@ * Author: Kishon Vijay Abraham I */ =20 +#include #include #include #include @@ -108,7 +109,7 @@ struct ntb_epf_dev { unsigned int self_spad; unsigned int peer_spad; =20 - int db_val; + atomic64_t db_val; u64 db_valid_mask; }; =20 @@ -337,15 +338,16 @@ static irqreturn_t ntb_epf_vec_isr(int irq, void *dev) int irq_no; =20 irq_no =3D irq - pci_irq_vector(ndev->ntb.pdev, 0); - ndev->db_val =3D irq_no + 1; =20 if (irq_no =3D=3D EPF_IRQ_LINK) { ntb_link_event(&ndev->ntb); } else if (irq_no =3D=3D EPF_IRQ_RESERVED_DB) { dev_warn_ratelimited(ndev->dev, "Unexpected irq_no 1 received. Treat it as DB#0.\n"); + atomic64_or(BIT_ULL(0), &ndev->db_val); ntb_db_event(&ndev->ntb, 0); } else { + atomic64_or(BIT_ULL(irq_no - EPF_IRQ_DB_START), &ndev->db_val); ntb_db_event(&ndev->ntb, irq_no - EPF_IRQ_DB_START); } =20 @@ -530,7 +532,7 @@ static u64 ntb_epf_db_read(struct ntb_dev *ntb) { struct ntb_epf_dev *ndev =3D ntb_ndev(ntb); =20 - return ndev->db_val; + return atomic64_read(&ndev->db_val); } =20 static int ntb_epf_db_clear_mask(struct ntb_dev *ntb, u64 db_bits) @@ -542,7 +544,7 @@ static int ntb_epf_db_clear(struct ntb_dev *ntb, u64 db= _bits) { struct ntb_epf_dev *ndev =3D ntb_ndev(ntb); =20 - ndev->db_val =3D 0; + atomic64_and(~db_bits, &ndev->db_val); =20 return 0; } --=20 2.51.0 From nobody Fri Apr 3 22:15:09 2026 Received: from TY3P286CU002.outbound.protection.outlook.com (mail-japaneastazon11020137.outbound.protection.outlook.com [52.101.229.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C8752D8795; Mon, 23 Mar 2026 03:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.229.137 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235776; cv=fail; b=bebEoWG8jEMKYdOcCFKXdiBz3+VHJKC3kKnMe9FuMP0sXSotCwGMVQ25GO3SYERyTDnDgOIi4JFPWmmH7+dawJVqYAt8Z6xt4xYPBqWy6bWOZlACoc3mUaw7os4KELWTIfNjcQBEshRG4eRhbElvxuMkcwx5JGE3C+aUhuULxBU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235776; c=relaxed/simple; bh=kAkciJLkkV49DuqUiVs/lIlddw4yBQ48zUQdiAM8mOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=BKSQK+kAdlhqq88OTJXI/3tqqcpqIWXQ3QURhIs/2SIsgk03I2xPrfd07Vz/byfTHZG5b/erQf4wcmHfeDBErwroPF1SY+cuBKENssk0xNhLo8fnBlDdI64vwsLltPSlW7LonoAGq/t3g8JV4lMf7I110NadmsiERb39Wqi513A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp; spf=pass smtp.mailfrom=valinux.co.jp; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b=Ej0GLGx+; arc=fail smtp.client-ip=52.101.229.137 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=valinux.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=valinux.co.jp header.i=@valinux.co.jp header.b="Ej0GLGx+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W08ZZXJWfOXlZpnRu85UGXNk/2JOv3bS3eR60F3ewiK3THaA0c2M+Kp19CBctB//8tXKW4LwHTk1FshOIzlmWnDOt5R0+owlKAkgADhSgvkfXXlTWg7jnjy2ozeTiGW/6fVso3t6lk4NG5CPipqW6P81bw6KY8EyQsy7Bv/b0DxbIUk7Xyc4Wo343nygk9zixgiMJaL7LzMiVlgp5dd2CTFYu0ck2lnJjYRaGuz9Y4UMdfHwjKvElxGxz89k76ak/qhjbX0BhOqmsTgorw6WLqzcuiFRfQ6DteN6Y8iMx3TkEbjyIf3K2MNm/AZHQs/v1cTBvuUkrDcTVwSto/rjkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TfamhXT5+lK6qNPenNuwWWw/vsKs0erujM6csx7Zjeg=; b=MHZsnMcjN9ANKkFEXkjv1GGNDKIvOzYDxpwmP0ZlJwVwB5MNufscdbeQaq/ovhQtkwsQPdK1WmTvF6JnsYluoH8nFkeaYUfOjGfiSXYdz57+g7P7D70ryTrx4ldZe5uQ3BOiy9YTFLdO9fRo/QtsJhmB13PJGq74irS0H1+gSWwSgyLPumC/WIt5hqEqAB4UHrETgz2Na4DCbyF7ZYzVBrOpV2XEnA3fOTCGQxHVRrkMaT0Gi0io/zrmXqnC7+Pgj/0YCx1QUMY5RiHHWDYehwSSe0hq0kjE57tiXRVkt1pGayymG6H+8BF3zg9LgNIFKgcYaAmtomPbMnN2tHkHOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=valinux.co.jp; dmarc=pass action=none header.from=valinux.co.jp; dkim=pass header.d=valinux.co.jp; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=valinux.co.jp; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TfamhXT5+lK6qNPenNuwWWw/vsKs0erujM6csx7Zjeg=; b=Ej0GLGx+2ygN8Kbgrg32GzVGzHgKI2QTgHKb30P4bNHTljbH+xBONZDIRJra7vmxSy4Bi+d2/15eJJ42FC25RUOdoTgT7ZGjiVNwokpi14a9jihwaaCyxL0qyKbII7bkLNZbbqZPe4A2yUMEuGipiEQ2lcp5Q8jbFc5etyYny6A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=valinux.co.jp; Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) by TYWP286MB2385.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:16c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.25; Mon, 23 Mar 2026 03:16:08 +0000 Received: from OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71]) by OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM ([fe80::b7ab:6af2:d18e:4a71%3]) with mapi id 15.20.9723.022; Mon, 23 Mar 2026 03:16:08 +0000 From: Koichiro Den To: Jon Mason , Dave Jiang , Allen Hubbe , Manivannan Sadhasivam , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Frank Li , Jerome Brunet , Lorenzo Pieralisi , Niklas Cassel Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, ntb@lists.linux.dev Subject: [PATCH v3 10/10] NTB: epf: Implement db_vector_count/mask for doorbells Date: Mon, 23 Mar 2026 12:15:44 +0900 Message-ID: <20260323031544.2598111-11-den@valinux.co.jp> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260323031544.2598111-1-den@valinux.co.jp> References: <20260323031544.2598111-1-den@valinux.co.jp> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0133.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b6::20) To OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:468::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OSOP286MB7730:EE_|TYWP286MB2385:EE_ X-MS-Office365-Filtering-Correlation-Id: c494783b-097b-41e1-8b59-08de888a8728 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|10070799003|366016|1800799024|56012099003|18002099003|22082099003|921020; X-Microsoft-Antispam-Message-Info: opfwuiVbMHmNBgGIesDGXebowLngmpUedm8HK/V43KH5fcLoFnH2ScwvVdUYqhb1eAzJPxVhb1tqthMR6/Vd3qqFAxh1z2D6fCfUVeD3UtR+lGXVQd+u1qkRMOtUhxNf3xyV/Ve7pYIXRJJp5JWh1mIHve+1whEK7ozd6hYOCx2XKGE4XABk3UYSFMExHCzBvDUc2Dw2eEMn3OoQQzcjkvgVzWJZ7M3mgX5xTmdtXRO0ErEGDDpiTnvV3Z5k4A3yIhyWTEgcw+zf6Fip0Bf93w1u+enUlPxXRkZzEmGiUyM1nl8A/GHwL7qRgVplIkSkgiyv9WSo7+ynnjlYJKjZgSLFAzVPyeDDBamilSKNizlJ2zPBJe58E0aCwO061kabOa49Kw4Y2TT/pkhqxSNJCoYe6CFI1rlEd1LP5SWXSL8Gj8Mwlyapuz6cngghUcyJIHX4c0aXJMPJYMTpj9AlwpdhJ7tjxaFQN4jzyR2ONW9s7Hv277S50I1DqtUnVyc1TQDXdlttqJKT8sTaArn3ApW/hNwPaIyFKF1nr+56tDl0L2XaS7P9ixTpYVT1Lo7VrEjBKMBfJvPgPSDQqGzrhSL8aYMv9bca5i02Cb9uvLz1LDFYwLO9iPUFBsr4JRrzZTy2mr3oSB7yleTwSEBbUJpg+9o9fA2fNuIDuXJm2xi2Bic4DLHfoL6YssVviIk7iayrnlwLBcxry7Kkf3aOI0R4r/tRaikdlElTujdeSkdnBML3FtIKoKFqldzFu4OlPwdFElqGN7oGNF/y99fSeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(10070799003)(366016)(1800799024)(56012099003)(18002099003)(22082099003)(921020);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aOwO/9VeY2zZGp7EYdirGpJzN2GSMsNKjW6ElrP4n7lOQC71b+awe/5ju/CC?= =?us-ascii?Q?0yRY6t+MwW0XcWYc84eefwRhhaJFwVessoIA+1jw+wyCt4HoR8hPTe5mdpjq?= =?us-ascii?Q?XpB9JS9iwVvcjhbLbI+RTfQBgckhVes5B22PgMIu+jkWbF8EY5kuR9j6YVHM?= =?us-ascii?Q?hLynWOhHnq0JaKEGnhfazqh6plzqfsLUXAoSunDssO74WQSKucbF4UC95FkX?= =?us-ascii?Q?QIgp5q+7zA4RaubTsNNjWWKWqhC7Wd/jmKgcA9jGnRr78T/KlPQyFqX+Q7Be?= =?us-ascii?Q?Z0zBGq3Sp85LZv08p78XvLgkrWL6whjzDEI12FzeOdNTkA+5cn2MIVnn7Rzn?= =?us-ascii?Q?XKngxgPQfpV9GZ+9E6Bw0I9+/6yPoJEyLnTdw7P1smHgU1Wyf4HiYejolmQN?= =?us-ascii?Q?zHNo8o79l7KS2QCWNhcxaN4wiNlyn3d2jdxB3BDMP074KG41eVLIydLUqfKF?= =?us-ascii?Q?1VHOZNuncN+PqXMpyefV0tSabk62A2+PQP11qvOOHEkhz8+aT3CKznwRYH01?= =?us-ascii?Q?34Arc38mCideWDFOeQ0Gg9av/jM1YiexACkEyImStaU8f8YWRMf9TdbHH1o+?= =?us-ascii?Q?GMAPCbj14UJjhD4zjgHe5RJ74mmpR2PR4Hpl5bFC1Te9P1rW92qoCvQV5GVR?= =?us-ascii?Q?LYYSIAEHRpDlaLRphOdn56SlgdcvVqsc33BIefTY3jmePwQ267RylFo1eFRK?= =?us-ascii?Q?8Sxg8vLEGXNOYP6gQ9fw3YQBnp7/65tHHNqricQwdK52yxxv4Hfj3Svk/qqZ?= =?us-ascii?Q?6h/g5BVKnf82KfL3bemqqfsj9G6rElkyi+ana6tnc+4DOEKBmaPqxRPwaNui?= =?us-ascii?Q?3hCrgT6c9l6QElHQLYkkFR1ycRd8n6xr4v4hSSMte0DanKBsFobmqn2KfkSF?= =?us-ascii?Q?EJtCk0qP6t1UDB2LKnehRwuHzeSb3W9AjK/BB0PoJlt8SjxjTjQSb2ENqaEf?= =?us-ascii?Q?CW1Fp0R6aw9bwzHji7A3viVIAiUK3SFjv1nGcDol8kMY33I5kLpA9OraxQXQ?= =?us-ascii?Q?LeBkfpPUrNx/HnND90zFWVwwnFkCibwB1cHLX7ftPvqDmlpzKNi5xlnoVxQx?= =?us-ascii?Q?a6jh2vccC/t718iJBCyQFrn3o0wbfAzpwSfz0BUbSLVziQtNUrvjdxmn/pUk?= =?us-ascii?Q?IhBZomeHkjeQ5CY8VN64zJvi/jAPJ1vNeFH+xXsqV6qu61lRWQPW1DkL6Vr6?= =?us-ascii?Q?nmuLYqVYLw653Jk/2WIRvPoMmueFHl4RhwUVfZNL2l+yiCeOxHVu/gznzukz?= =?us-ascii?Q?l4nGAMrUGDA0mn6nCO2tDt/guW7I4W0rBtTRNlWmcZYmEEohYiGm+kncHIZg?= =?us-ascii?Q?pJ+Yt/aXNPM2QUf+9czRH58F0Je8myyoqycRjB3oJJfj4BWWwJayI5adz2oW?= =?us-ascii?Q?iwczNg2xHM4m/vsI5Bbqb6j48DJfyZnY4m5yfvq94QzqokihhjyEcb3txlhJ?= =?us-ascii?Q?lJPXnLWk8KAfaQGJjRiOEj4frhHZYuWDiwUir+u8pQB7TZ2AXqCq1YI5gCyF?= =?us-ascii?Q?fhDKKFTnZvFZDnkItrJ/vQI5OEpE6o7OMBPBmGxKS0qQM53IPvaGCoQl+BEh?= =?us-ascii?Q?XzDOMgzA5qcS/+GB4B9NPSrPjJebZnWkLnUb2hq1OK6T8FYl7kOXA37XBjsl?= =?us-ascii?Q?iekJEGzJz9dpmq/2K+G7sx8zbWuathKqlG3QyZot0V0s6oujdR94DW8YnIDq?= =?us-ascii?Q?W+sOZmI1VDbKaMywO4vBRqJXgopa8gTDd35CEjfbe7reiavG5d94Xwu+nzB8?= =?us-ascii?Q?s2d+xwEpE4wwBhwFHMXHZ6QPWsbCcKf8J9dtCAzavjqLYutsDazi?= X-OriginatorOrg: valinux.co.jp X-MS-Exchange-CrossTenant-Network-Message-Id: c494783b-097b-41e1-8b59-08de888a8728 X-MS-Exchange-CrossTenant-AuthSource: OSOP286MB7730.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2026 03:16:08.8222 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7a57bee8-f73d-4c5f-a4f7-d72c91c8c111 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Y8BB/WohpyU75iCBFroIhzR6N+PfKjZfVq9cRvQMMNWSNiRw9s12VpQQN0A0p41PsTW6AXIuEdywooQtjc/Nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB2385 Content-Type: text/plain; charset="utf-8" Implement .db_vector_count and .db_vector_mask so ntb core/clients can map doorbell events to per-vector work. Report vectors as 0..(db_count - 2) (skipping the unused slot) and return BIT_ULL(db_vector) for the corresponding doorbell bit. Reviewed-by: Dave Jiang Reviewed-by: Frank Li Signed-off-by: Koichiro Den --- drivers/ntb/hw/epf/ntb_hw_epf.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_ep= f.c index 741d30821390..d420699ff7d6 100644 --- a/drivers/ntb/hw/epf/ntb_hw_epf.c +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c @@ -420,6 +420,34 @@ static u64 ntb_epf_db_valid_mask(struct ntb_dev *ntb) return ntb_ndev(ntb)->db_valid_mask; } =20 +static int ntb_epf_db_vector_count(struct ntb_dev *ntb) +{ + struct ntb_epf_dev *ndev =3D ntb_ndev(ntb); + + /* + * ndev->db_count includes an extra skipped slot due to the legacy + * doorbell layout. Expose only the real doorbell vectors. + */ + if (ndev->db_count < 1) + return 0; + + return ntb_ndev(ntb)->db_count - 1; +} + +static u64 ntb_epf_db_vector_mask(struct ntb_dev *ntb, int db_vector) +{ + struct ntb_epf_dev *ndev =3D ntb_ndev(ntb); + + /* + * ndev->db_count includes one skipped slot in the legacy layout. Valid + * doorbell vectors are therefore [0 .. (db_count - 2)]. + */ + if (db_vector < 0 || db_vector >=3D ndev->db_count - 1) + return 0; + + return BIT_ULL(db_vector); +} + static int ntb_epf_db_set_mask(struct ntb_dev *ntb, u64 db_bits) { return 0; @@ -554,6 +582,8 @@ static const struct ntb_dev_ops ntb_epf_ops =3D { .spad_count =3D ntb_epf_spad_count, .peer_mw_count =3D ntb_epf_peer_mw_count, .db_valid_mask =3D ntb_epf_db_valid_mask, + .db_vector_count =3D ntb_epf_db_vector_count, + .db_vector_mask =3D ntb_epf_db_vector_mask, .db_set_mask =3D ntb_epf_db_set_mask, .mw_set_trans =3D ntb_epf_mw_set_trans, .mw_clear_trans =3D ntb_epf_mw_clear_trans, --=20 2.51.0