From nobody Fri Apr 3 21:12:39 2026 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF1B3367F46 for ; Mon, 23 Mar 2026 09:53:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774259637; cv=none; b=SJZZQZsEhzlOamj/evhqcR2XJ0yVZEyoDWPDn+OYr3MaEOzsBfO9J094dk4L1dCjCd6n29EkBh1aG41FNDZ86VnKAfzI76HpVi9VUN5WAObSU9F/PXyQX3I//3PZdDcVh1rQIul8fg1rpoPvSivvSxCUmzs7HUyYtMUVD4QCjMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774259637; c=relaxed/simple; bh=7nX3sTt/HHk78LCRHGp/T8MQmjxV+5Jspx16d02xISI=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=dFYEIKfYjlCvJojvrrBm8YuBks36hkQiHSl2QLdkSQlAD5bG9YyY7xa8idBtzp9iCsyAJv6ZRqR0+kpnngVYk5KWqSQ/qLaNt51oqubF3zP7Fp/xv3Um3u26QCRt1G8WvejB7vNO3oinUQAzVi7PZkim1typFPCwW8rLN3nE/Co= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=dn3jYl7y; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dn3jYl7y" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5a27a90a7b6so4715268e87.1 for ; Mon, 23 Mar 2026 02:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1774259634; x=1774864434; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=1wesxPwsa5G6ez/hsJiH6ntPa2AociaxpZkmVcnrrmU=; b=dn3jYl7y2Y7TV0qXrdPmpa5Q+Y/h85kHvwFL34755Kiqe0LtemSQZkwp4wPdRWwz1G zS8BImJ+D1q53i9Pw+FnrRcI9FLUOLYVWLsPIs/WdtzRceMVmzfW/hAjtFU0SD55TWAq UK2IFOqtzvKjcJ6bD4bw6/qRLmxDkTwSTGTd8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774259634; x=1774864434; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1wesxPwsa5G6ez/hsJiH6ntPa2AociaxpZkmVcnrrmU=; b=UqcCh0NfkDXY75AR1CNurTOCMHVcjHLFWJyqm06Uayh9Y8KUVIWJQVd+flv1k+mNtD AmcjKyW9ee+d5I8KeD2K2zZg2b9ysXz2EhzT54ib/HQ/vvc1s3yazRRFYif7q0ARCAS7 lw4yKRVSSo2IAL0T3vmvPCC+t4TucTdj3mzTgT+wYn5oPaPiybLvWgx2g3cLbtAQHTG3 XIQVIDoOTMSXn8X2A8rOdPa52qF5wMsmSgSSmMTenO6z7bWkGfO1mkwd6KOhdmQjnHC5 hholsiLkfMMhNoILPQf9qgjzy42gekvsN0FsAo0ssb5HEs1s1QOJ8K9ilQT0FWRpaI38 IA6Q== X-Forwarded-Encrypted: i=1; AJvYcCUMgVIw5OK86LImA28vaQ2KUwW3xJni9AFJiYuEI+iNsX/YdA4XdWJRaJTvEAwhNGxIf9aqiEEd34LBXs0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/CqJXNYcBuOSLhQhJS6uaJN9uXOFLXnaNalkMI38l3Loi6bjT jpRiXG722ETmJ8LO8Cm6UqatOem8+xwzekfavTvzvUQcuBbdXA7bBUIrzHBFBT0vlg== X-Gm-Gg: ATEYQzyhyKHPoKgwZRaZ76ldnq4djlDyekwUEpSW4W26sspDUITgcph0nzVdv28LYbp 8l9W9dQjsXAXJ1BHZwV/oIR5DRrvtBg5dgf4SY0fsCVQiKFpoRoOiLuJ1QQuBEPiNKUEdzBBTQL EZAtpik6Tvq10GijMNC+PnSy0d+GuGQZYWTYXJcFT2aALDv6YlWdIO0simuU8y5r3sEORrDJ2NI yyjDRpBtdfwNxPtKW3BVrq4/sR1lj+EaHEhR1fG52/UUnNmogGZ2VG2N8MlsLjnjEdDMM8EDoz9 9pThvr1BQIVqMEf5pU5+UeFiDSxIhjA++zZqqP8+9PZAtys4Pr2OMHzIv0cp1ioc7WFnPbFBNRF AMIBGYnY3zliEMVwplWYO88WpwnEp9PQKOSApkEw6e0FNE0dpTaUpTQlriEZOanKjawO7ics7fP bVGCm7PpCvPfo7bK9HGfJLWs3fOgX+ZmFZLL3dNNZxp68guVeEA60+/LYbTMECuQiOYFMdCSX3E nymBDo= X-Received: by 2002:a05:6512:108d:b0:5a2:8516:a53a with SMTP id 2adb3069b0e04-5a285b9b5b3mr4046943e87.45.1774259633988; Mon, 23 Mar 2026 02:53:53 -0700 (PDT) Received: from ribalda.c.googlers.com (252.116.88.34.bc.googleusercontent.com. [34.88.116.252]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a285192e93sm2430001e87.13.2026.03.23.02.53.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:53:53 -0700 (PDT) From: Ricardo Ribalda Subject: [PATCH v5 0/2] media: uvcvideo: Fixes for frame sequence number Date: Mon, 23 Mar 2026 09:53:51 +0000 Message-Id: <20260323-uvc-fid-v5-0-e2858b657aac@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-B4-Tracking: v=1; b=H4sIAK8NwWkC/23Oyw6CMBAF0F8hXVvTdvqwrvwP4wL6gC4AU6TRE P7dwgaiLO9kzs2d0OBicAO6FhOKLoUh9F0O4lQg05Rd7XCwOSNGmCRACR6TwT5Y7KgTgnNVSU9 R/n5G58N7bbo/cm7C8OrjZy1OdLn+dySKKRYOlDVgFGH8ZprYt2Fsz32s0VKT2J7CRlmm4FWpt bSacHVAYU/lRgETbJQGyPulrsQB5TvKdoN5pp5xT+XFlMzrHzrP8xc75a7CUgEAAA== X-Change-ID: 20260310-uvc-fid-e1e55447b6f1 To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yunke Cao , Ricardo Ribalda , stable@kernel.org X-Mailer: b4 0.14.3 This series fixes a couple of corner cases where the frame sequence number is not properly handled. Please note that the first patch has not been tested in a camera without EOF. To emulate it I have used this: diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_= video.c index b66d701f2582d..097bed2f7845f 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -1360,6 +1360,8 @@ static void uvc_video_decode_end(struct uvc_streaming= *stream, { /* Mark the buffer as done if the EOF marker is set. */ if (data[1] & UVC_STREAM_EOF && buf->bytesused !=3D 0) { + printk(KERN_ERR "Ignoring EOF\n"); + return; uvc_dbg(stream->dev, FRAME, "Frame complete (EOF found)\n"); if (data[0] =3D=3D len) uvc_dbg(stream->dev, FRAME, "EOF in empty payload\n= "); Signed-off-by: Ricardo Ribalda --- Changes in v5 (Thanks Hans): - Swap order of patches - Remove duplicated conditions. - Link to v4: https://lore.kernel.org/r/20260320-uvc-fid-v4-0-f24f168ca2f9@= chromium.org Changes in v4 (Thanks Hans): - Fix 2/2 logic. - Link to v3: https://lore.kernel.org/r/20260316-uvc-fid-v3-0-c793354469b5@= chromium.org Changes in v3: - Fix typo in commit message. - Add new patch - Link to v2: https://lore.kernel.org/r/20260313-uvc-fid-v2-1-3f7a996d9047@= chromium.org Changes in v2 (Thanks Laurent): - Improve commit message. - Remove original timestamp and sequence assignment. It is not neeed - Link to v1: https://lore.kernel.org/r/20260310-uvc-fid-v1-1-5e37dc3c7024@= chromium.org --- Ricardo Ribalda (2): media: uvcvideo: Fix sequence number when no EOF media: uvcvideo: Fix buffer sequence in frame gaps drivers/media/usb/uvc/uvc_video.c | 110 +++++++++++++++++++++-------------= ---- 1 file changed, 61 insertions(+), 49 deletions(-) --- base-commit: a7da7fb57f2a787412da1a62292a17fa00fbfbdf change-id: 20260310-uvc-fid-e1e55447b6f1 Best regards, --=20 Ricardo Ribalda