From nobody Fri Apr 3 22:33:34 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4870D3A63E1 for ; Mon, 23 Mar 2026 12:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269615; cv=none; b=RyqBjOO+eKEJcTcafxyR+uh3eZ2l2w4evJJwQuGL4pvqDp41Faghchlhl0pZX0xcyI+wL8QnBTe2Tp9I7qH9JohpR9Fj6CimIQ+jJZOdyQNdW6iWe050IZywn/daLkg6CJd4AWmZPDZPq1yRiHaxQZ2t/TX6FIxcoc0p1n/QKuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269615; c=relaxed/simple; bh=K9TqCoaBbHPmex748VEmZR3l4Y6+GcAOH4Y9WtHM3Oc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FBBdJG9SzZujV/0grIEGkyeaa1X44AP8uu/rGPwA3oUNIb8BPiId4Bc9437caN96futLhACrz0aXqYYNg7uINCEskUV0xme5TRclczHD20/5/KVcwsPBbJUKwcd/ktANh/LcUZ+lz8c/LgFvPPO+LBQC8wY+7MJOb7Syvo7k3KI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=e6OAvtS9; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="e6OAvtS9" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852c9b4158so31390895e9.0 for ; Mon, 23 Mar 2026 05:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774269613; x=1774874413; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D7063JLfjPY8E1q6l/OOvU7fhhY+O+9jreO5/yPYmUY=; b=e6OAvtS9P28nJXRSQqzNpdBJ/NotTGJKq1PwlA5NihyMP/kAGGNbstsSUETRpIqm4b drRQDSbJ50aYlu1wMjE0sQs2qhSDkv9pyLkOphaBjf/DE0a5Yxr72nCACk6LvL7BK0qK WEG3jKEilvS3ipsBCkHWKTcaioZQqOtl0gQvlMEEhGDOc2e8z7kRJn3ka3GGsx7Cebv6 LdUNMOzmK2J5bH70NwXC7AQwLYylBe4SYqbSuaIWWt+g6GBk+fVGTG39/FOYhHf4i8JG wCqcyBQy+l7ncby8tewjb0HMcBmLINLN6HabgBcQ/U5Lfd5xEo6ldnRakSall1R7uZ80 2idw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774269613; x=1774874413; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=D7063JLfjPY8E1q6l/OOvU7fhhY+O+9jreO5/yPYmUY=; b=Klzn+JAO2/PGnRCZgOaUUXKMsB302GW0r+N1omVE3/yvhTR/c2zOqMZZn2XIgxEXW6 kG0Man35MJDUzXdq8Z8XhhV/J5NRPwqiVE/HXeY/rMqtyS6ygpfXnWewWo/ANKW/8wAS 5sJp8yP/omqEJ9q4RBM0F2jRXBB7hIsUg3Z2K94QSzSGRUw+L/EOWp2fUsycBuHSC/Wg IKXmocg4KwP4qs92pl0CVYtMolW+F75au1ikWbbzLCTRSy4+2f8gXSrVx5Kj9KSeq+UV jxiacCGqragTarag1KsYKE970+24KpFNHeazc71dS7vCCEGyENcoJ+9KHwKSBHYhwy2C 8lEA== X-Gm-Message-State: AOJu0YzO9XqlEaoQPlElipnrcG5+r1Iwjxdzl1xdmNkKiYKQGXCegwAu hHQ2C/swBHJlhGnDaVTYNdq0Q7vA2d/wrEpTk5SvIjxOHAVTBCHstslIlDE0QS9k8Bs= X-Gm-Gg: ATEYQzzObNKbgOSBKap8NsPe4V0Z/zyrYzI7bSM0MfF1U9GH6vk7CY8MRK318spxAhD aCVkSHtHIlo5lnpHZcsqVJ6YjTSGLSijPnLx19cMJYWm94BelGZ7k6wXQu6+Za2CVNhKeioM/1i kvBBhM2wA/nOzrdrwpIi/DheRdnKmwaBQDfqHGr1SAqxr/gYkkoCr1/Q56MI8/U5Sh4/Im2FwAy jnLCErCcIc+8vYOPEaro8shXLIrSJafScblr7RzmZmCuapUtrBSMipfZXJTM51tER103pmJ9nVp zfaRPCUzdsIvDEzAmerMwn2K5rK69rTjjlsITs6j3zOifGN6fZF7son6s0d3b1ClQg/Wbv3VWyc g+oinjQuqSs5RBxTgqJuKx2HWBa32D0h164G5YH6SVL7nsLwfEvvM0HMZSxVKw+M0CI6xQlJFZA MYQ9o+Nt+fAcHudrmC1jqNLpQ0hcMGFtkh7WrkYrch2rA= X-Received: by 2002:a05:600c:4848:b0:486:ffa3:592 with SMTP id 5b1f17b1804b1-486ffa30bf0mr91483495e9.24.1774269612655; Mon, 23 Mar 2026 05:40:12 -0700 (PDT) Received: from blackdock.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470393fsm30608008f8f.17.2026.03.23.05.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 05:40:12 -0700 (PDT) From: =?utf-8?q?Michal_Koutn=C3=BD?= Date: Mon, 23 Mar 2026 13:39:38 +0100 Subject: [PATCH v3 2/3] sched/rt: Move group schedulability check to sched_rt_global_validate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-sched-rert_groups-v3-2-1e7d5ed6b249@suse.com> References: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> In-Reply-To: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: linux-kernel@vger.kernel.org, K Prateek Nayak , =?utf-8?q?Michal_Koutn=C3=BD?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1465; i=mkoutny@suse.com; h=from:subject:message-id; bh=K9TqCoaBbHPmex748VEmZR3l4Y6+GcAOH4Y9WtHM3Oc=; b=owGbwMvMwCVWZ8v0fMrtHxyMp9WSGDIPmix6e2URv2lUZ3DLjPmJ3xZ6Gk/Zd7pQu9TPo2Fi4 TO//Jy9HRNZGMS4GCzFFFmchPNY53+QcbM83fUFZg4rE8gQaZEGBiBgYeDLTcwrNdIx0jPVNtQz BDJ0jBi4OAVgqhUvM/zTeHNvoUHLkpylDCqi9ietVB7fm97+2n5vh7TJ5eBdi/JaGBkuiqZxPSp sk5Fv3WaxeYeLiMuppT6ik7zvFn2QcNaYEsgDAA== X-Developer-Key: i=mkoutny@suse.com; a=openpgp; fpr=9F2AB6F1F2BBEE7621C1B620CFDED9A2FD1314F0 The sched_rt_global_constraints() function is a remnant that used to set up global RT throttling but that is no more since commit 5f6bd380c7bdb ("sched/rt: Remove default bandwidth control") and the function ended up only doing schedulability check. Move the check into the validation function where it fits better. (The order of validations sched_dl_global_validate() and sched_rt_global_validate() shouldn't matter.) Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 37e6ce3604fd7..d3b6483fc3e7a 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2818,15 +2818,7 @@ long sched_group_rt_period(struct task_group *tg) #ifdef CONFIG_SYSCTL static int sched_rt_global_constraints(void) { - int ret =3D 0; - if (!rt_group_sched_enabled()) - return ret; - - mutex_lock(&rt_constraints_mutex); - ret =3D __rt_schedulable(NULL, 0, 0); - mutex_unlock(&rt_constraints_mutex); - - return ret; + return 0; } #endif /* CONFIG_SYSCTL */ =20 @@ -2858,6 +2850,13 @@ static int sched_rt_global_validate(void) NSEC_PER_USEC > max_rt_runtime))) return -EINVAL; =20 +#ifdef CONFIG_RT_GROUP_SCHED + if (!rt_group_sched_enabled()) + return 0; + + scoped_guard(mutex, &rt_constraints_mutex) + return __rt_schedulable(NULL, 0, 0); +#endif return 0; } =20 --=20 2.53.0