From nobody Fri Apr 3 21:12:39 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1BCF29A1 for ; Mon, 23 Mar 2026 12:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269615; cv=none; b=INLzHq8mdMJFKyTk7saTzdAloARqTI/moD3luw+82Cg+lRPBG9qJMA17utDmwhNEEcocGgjLboPMx+D+PMcaScYb0CMYisQNXn2CwZpkB3DEQ5s+tYmeC8ac997Z/mWc1fNI1PNRsq80nt3OuOHU+8u7HTjQ2PznYI0RS85DmAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269615; c=relaxed/simple; bh=ETkk6X1fHslEtzTthMQL4uiXn0e7TKA04ds5WgokxWM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p/6/57Fz9hRsr/g1GIuwvCjwdlAhEzhl3b09dkL7MfEZRW1XjUQDEw6EQmch+ywBPc4qNO26lw0iT2NsFHnog/VTdwQ81UJuDbscUn3Zn053IRbDkZPnYZ1HDSBCzxJGsXtrAITjG2xcfgnS/Cqdt1ft3VEmVFEOJwiPkA2Eg7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=U6K2mI2S; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="U6K2mI2S" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso24936495e9.3 for ; Mon, 23 Mar 2026 05:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774269612; x=1774874412; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+kA8Oet9YqUqsdNfVJ+PDluDp4O4YSk9Mv9KrqbEq6A=; b=U6K2mI2SLQxG7nQBZL8mz+h7CqWMDpuO8WJjeOfMLP7ykhLp4IQvDo2scQ1f8uILnp 4cO97ntfQjqj4mvEv4dhKAB+kHdbDhHiQdsro92DyrwKbFUkPxXmfLdGbZnZLAdizUbQ g2uWHthlUWqxnYo7wP49ZxZ+wmNqtfNPpE4kVxkHR+7GBfzLJhzIMDeyM/M+khC+u5fQ 5gOqxuUvDzuOqz67D9PXkaVFkTKs1Fl12gzZQWL2ACa0NcO/9Ibo/EvgjfSqVNSPpkEg RgjEg79iOB5Okb9Jh4KR66zxnDppaeibsIREOuH3FfME7kgvsJkuo1lannP0z0CNg2LA PdmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774269612; x=1774874412; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+kA8Oet9YqUqsdNfVJ+PDluDp4O4YSk9Mv9KrqbEq6A=; b=b7JNg4gjF3uhVyvDzoXdSZEM7nq/O5ciUhm7PZu4GzYVeqc0vwVQa7jSoRrAjyBGRW xlrQzMsVRwJv5m3qdU1AMP7uGa6DtCxbK0EXqxZ6iSUNRTCzoMNJQLLDqz55ohgsN7JV P9ye1So4s3Sx2dRTP2RGfcxmXml91vfgvZAiMBnwkqijPTXpLv/bAL5GHJlm0BxTD6rN B4ZdetrQlXXIkgiKFNzTp4ZnmS8MKc0gK5Vk54P2HL50VhYeRLO5+atUXHUGZShIh8g5 zlNiAnFDEz2RZp2NRvSL+QboXTmv0T02T1MgsANHSLEFCdN+qe3igxCWS1ivsslVJ/2N Ce8Q== X-Gm-Message-State: AOJu0Yz6A7nH+1aCJY0X2A7cCtnf9q56Bzb8oD/H9zeK6cGqGVQa4fYD hYzcm7t8Tc43b5MswxaENyqSa5dtvueTQnJ7udKNgEQth0aVxeEyUbBCAdVAwTQjNKQ= X-Gm-Gg: ATEYQzzNhsJsdoayenxxmDVvMu0/HS5l0l0rzrxOgysHgcFDlDhz60GlIKJ2N4MXvP3 VkLElNbE4NrIRinYyDMM2mFHEewOUypyZ4mF2NnTN+D2qZYMdL8YCXcsezOAwmnJh2I1vgCXpp9 P0OUhJoqV9YVoTFNbluWZDQ0HfZw1xEIhJmj8AXpvB/CSI9N/wsyKxkYvy4nE96dvkLjwPZ3ITV 2+YwceI8mVxkFZjkWbmhLpB1XSs7i/3aoRaVzWIq27tjRTBeORQRHPFaDERNZftQoP+npWf6kYg Vb+J/GRAlXJkyN2CdZweuuBpmRAjPVE1G4+1Q2w+3+DqF/jNx7MLQn9al7ZaPTfwDo1emePPonO aAiscKgbMiNNGYEjGeu0FKeqJLboooq3jvzOtogNmIhJQn1mVDKNT1PJSVlKlEbEYJ4X3N/IGVQ MJffwGWr4tpPWFTSSNPt4fOT+e2ikkwtW6qPaClZgyGda9h6QnG1t9WQ== X-Received: by 2002:a05:600c:1f12:b0:485:3ff1:d5ed with SMTP id 5b1f17b1804b1-486fedab455mr173334185e9.1.1774269611916; Mon, 23 Mar 2026 05:40:11 -0700 (PDT) Received: from blackdock.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470393fsm30608008f8f.17.2026.03.23.05.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 05:40:11 -0700 (PDT) From: =?utf-8?q?Michal_Koutn=C3=BD?= Date: Mon, 23 Mar 2026 13:39:37 +0100 Subject: [PATCH v3 1/3] sched/rt: Skip group schedulable check with rt_group_sched=0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-sched-rert_groups-v3-1-1e7d5ed6b249@suse.com> References: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> In-Reply-To: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: linux-kernel@vger.kernel.org, K Prateek Nayak , =?utf-8?q?Michal_Koutn=C3=BD?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1729; i=mkoutny@suse.com; h=from:subject:message-id; bh=ETkk6X1fHslEtzTthMQL4uiXn0e7TKA04ds5WgokxWM=; b=owGbwMvMwCVWZ8v0fMrtHxyMp9WSGDIPmsxtiruUMy9OSTRV+XHsy/mzfhteFrXKbO9a22kn7 P9Abj9zx0QWBjEuBksxRRYn4TzW+R9k3CxPd32BmcPKBDJEWqSBAQhYGPhyE/NKjXSM9Ey1DfUM gQwdIwYuTgGY6vdLGRl6O6xXXJQ7+FglxUvPXr3NX2H6ow+F7x2vRUmZpyS8vbmP4Z95zoSP2xi dzLU2sk3WWDfxKPfT6tjSXZdTT25wOXicxZ0HAA== X-Developer-Key: i=mkoutny@suse.com; a=openpgp; fpr=9F2AB6F1F2BBEE7621C1B620CFDED9A2FD1314F0 The warning from the commit 87f1fb77d87a6 ("sched: Add RT_GROUP WARN checks for non-root task_groups") is wrong -- it assumes that only task_groups with rt_rq are traversed, however, the schedulability check would iterate all task_groups even when rt_group_sched=3D0 is disabled at boot time but some non-root task_groups exist. The schedulability check is supposed to validate: a) that children don't overcommit its parent, b) no RT task group overcommits global RT limit. but with rt_group_sched=3D0 there is no (non-trivial) hierarchy of RT group= s, therefore skip the validation altogether. Otherwise, writes to the global sched_rt_runtime_us knob will be rejected with incorrect validation error. This fix is immaterial with CONFIG_RT_GROUP_SCHED=3Dn. Fixes: 87f1fb77d87a6 ("sched: Add RT_GROUP WARN checks for non-root task_gr= oups") Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index f69e1f16d9238..37e6ce3604fd7 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2676,9 +2676,6 @@ static int tg_rt_schedulable(struct task_group *tg, v= oid *data) tg->rt_bandwidth.rt_runtime && tg_has_rt_tasks(tg)) return -EBUSY; =20 - if (WARN_ON(!rt_group_sched_enabled() && tg !=3D &root_task_group)) - return -EBUSY; - total =3D to_ratio(period, runtime); =20 /* @@ -2822,6 +2819,8 @@ long sched_group_rt_period(struct task_group *tg) static int sched_rt_global_constraints(void) { int ret =3D 0; + if (!rt_group_sched_enabled()) + return ret; =20 mutex_lock(&rt_constraints_mutex); ret =3D __rt_schedulable(NULL, 0, 0); --=20 2.53.0 From nobody Fri Apr 3 21:12:39 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4870D3A63E1 for ; Mon, 23 Mar 2026 12:40:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269615; cv=none; b=RyqBjOO+eKEJcTcafxyR+uh3eZ2l2w4evJJwQuGL4pvqDp41Faghchlhl0pZX0xcyI+wL8QnBTe2Tp9I7qH9JohpR9Fj6CimIQ+jJZOdyQNdW6iWe050IZywn/daLkg6CJd4AWmZPDZPq1yRiHaxQZ2t/TX6FIxcoc0p1n/QKuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269615; c=relaxed/simple; bh=K9TqCoaBbHPmex748VEmZR3l4Y6+GcAOH4Y9WtHM3Oc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FBBdJG9SzZujV/0grIEGkyeaa1X44AP8uu/rGPwA3oUNIb8BPiId4Bc9437caN96futLhACrz0aXqYYNg7uINCEskUV0xme5TRclczHD20/5/KVcwsPBbJUKwcd/ktANh/LcUZ+lz8c/LgFvPPO+LBQC8wY+7MJOb7Syvo7k3KI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=e6OAvtS9; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="e6OAvtS9" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852c9b4158so31390895e9.0 for ; Mon, 23 Mar 2026 05:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774269613; x=1774874413; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D7063JLfjPY8E1q6l/OOvU7fhhY+O+9jreO5/yPYmUY=; b=e6OAvtS9P28nJXRSQqzNpdBJ/NotTGJKq1PwlA5NihyMP/kAGGNbstsSUETRpIqm4b drRQDSbJ50aYlu1wMjE0sQs2qhSDkv9pyLkOphaBjf/DE0a5Yxr72nCACk6LvL7BK0qK WEG3jKEilvS3ipsBCkHWKTcaioZQqOtl0gQvlMEEhGDOc2e8z7kRJn3ka3GGsx7Cebv6 LdUNMOzmK2J5bH70NwXC7AQwLYylBe4SYqbSuaIWWt+g6GBk+fVGTG39/FOYhHf4i8JG wCqcyBQy+l7ncby8tewjb0HMcBmLINLN6HabgBcQ/U5Lfd5xEo6ldnRakSall1R7uZ80 2idw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774269613; x=1774874413; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=D7063JLfjPY8E1q6l/OOvU7fhhY+O+9jreO5/yPYmUY=; b=Klzn+JAO2/PGnRCZgOaUUXKMsB302GW0r+N1omVE3/yvhTR/c2zOqMZZn2XIgxEXW6 kG0Man35MJDUzXdq8Z8XhhV/J5NRPwqiVE/HXeY/rMqtyS6ygpfXnWewWo/ANKW/8wAS 5sJp8yP/omqEJ9q4RBM0F2jRXBB7hIsUg3Z2K94QSzSGRUw+L/EOWp2fUsycBuHSC/Wg IKXmocg4KwP4qs92pl0CVYtMolW+F75au1ikWbbzLCTRSy4+2f8gXSrVx5Kj9KSeq+UV jxiacCGqragTarag1KsYKE970+24KpFNHeazc71dS7vCCEGyENcoJ+9KHwKSBHYhwy2C 8lEA== X-Gm-Message-State: AOJu0YzO9XqlEaoQPlElipnrcG5+r1Iwjxdzl1xdmNkKiYKQGXCegwAu hHQ2C/swBHJlhGnDaVTYNdq0Q7vA2d/wrEpTk5SvIjxOHAVTBCHstslIlDE0QS9k8Bs= X-Gm-Gg: ATEYQzzObNKbgOSBKap8NsPe4V0Z/zyrYzI7bSM0MfF1U9GH6vk7CY8MRK318spxAhD aCVkSHtHIlo5lnpHZcsqVJ6YjTSGLSijPnLx19cMJYWm94BelGZ7k6wXQu6+Za2CVNhKeioM/1i kvBBhM2wA/nOzrdrwpIi/DheRdnKmwaBQDfqHGr1SAqxr/gYkkoCr1/Q56MI8/U5Sh4/Im2FwAy jnLCErCcIc+8vYOPEaro8shXLIrSJafScblr7RzmZmCuapUtrBSMipfZXJTM51tER103pmJ9nVp zfaRPCUzdsIvDEzAmerMwn2K5rK69rTjjlsITs6j3zOifGN6fZF7son6s0d3b1ClQg/Wbv3VWyc g+oinjQuqSs5RBxTgqJuKx2HWBa32D0h164G5YH6SVL7nsLwfEvvM0HMZSxVKw+M0CI6xQlJFZA MYQ9o+Nt+fAcHudrmC1jqNLpQ0hcMGFtkh7WrkYrch2rA= X-Received: by 2002:a05:600c:4848:b0:486:ffa3:592 with SMTP id 5b1f17b1804b1-486ffa30bf0mr91483495e9.24.1774269612655; Mon, 23 Mar 2026 05:40:12 -0700 (PDT) Received: from blackdock.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470393fsm30608008f8f.17.2026.03.23.05.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 05:40:12 -0700 (PDT) From: =?utf-8?q?Michal_Koutn=C3=BD?= Date: Mon, 23 Mar 2026 13:39:38 +0100 Subject: [PATCH v3 2/3] sched/rt: Move group schedulability check to sched_rt_global_validate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-sched-rert_groups-v3-2-1e7d5ed6b249@suse.com> References: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> In-Reply-To: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: linux-kernel@vger.kernel.org, K Prateek Nayak , =?utf-8?q?Michal_Koutn=C3=BD?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1465; i=mkoutny@suse.com; h=from:subject:message-id; bh=K9TqCoaBbHPmex748VEmZR3l4Y6+GcAOH4Y9WtHM3Oc=; b=owGbwMvMwCVWZ8v0fMrtHxyMp9WSGDIPmix6e2URv2lUZ3DLjPmJ3xZ6Gk/Zd7pQu9TPo2Fi4 TO//Jy9HRNZGMS4GCzFFFmchPNY53+QcbM83fUFZg4rE8gQaZEGBiBgYeDLTcwrNdIx0jPVNtQz BDJ0jBi4OAVgqhUvM/zTeHNvoUHLkpylDCqi9ietVB7fm97+2n5vh7TJ5eBdi/JaGBkuiqZxPSp sk5Fv3WaxeYeLiMuppT6ik7zvFn2QcNaYEsgDAA== X-Developer-Key: i=mkoutny@suse.com; a=openpgp; fpr=9F2AB6F1F2BBEE7621C1B620CFDED9A2FD1314F0 The sched_rt_global_constraints() function is a remnant that used to set up global RT throttling but that is no more since commit 5f6bd380c7bdb ("sched/rt: Remove default bandwidth control") and the function ended up only doing schedulability check. Move the check into the validation function where it fits better. (The order of validations sched_dl_global_validate() and sched_rt_global_validate() shouldn't matter.) Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 37e6ce3604fd7..d3b6483fc3e7a 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2818,15 +2818,7 @@ long sched_group_rt_period(struct task_group *tg) #ifdef CONFIG_SYSCTL static int sched_rt_global_constraints(void) { - int ret =3D 0; - if (!rt_group_sched_enabled()) - return ret; - - mutex_lock(&rt_constraints_mutex); - ret =3D __rt_schedulable(NULL, 0, 0); - mutex_unlock(&rt_constraints_mutex); - - return ret; + return 0; } #endif /* CONFIG_SYSCTL */ =20 @@ -2858,6 +2850,13 @@ static int sched_rt_global_validate(void) NSEC_PER_USEC > max_rt_runtime))) return -EINVAL; =20 +#ifdef CONFIG_RT_GROUP_SCHED + if (!rt_group_sched_enabled()) + return 0; + + scoped_guard(mutex, &rt_constraints_mutex) + return __rt_schedulable(NULL, 0, 0); +#endif return 0; } =20 --=20 2.53.0 From nobody Fri Apr 3 21:12:39 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B90C03A9D9E for ; Mon, 23 Mar 2026 12:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269618; cv=none; b=JLm8S5mC2TafXl0x4zMpI1Edh9EcWaC0gN6oSu0us0Sim9Wps1cww42BJHJv/zTiXmgcmETFYhFF1ye00t8iSNFfTWNbVhcbmuZ05duPUuUTy3qnh7wjFbogQToflIO/ZI6GS8u0eGyr0OWhMkGpLHStEcacRC4t/jyqIqYAr7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774269618; c=relaxed/simple; bh=w76eWlKFvPX33VN8ZvO+nZ9SHttTzIcOygSnsa1y50s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L8RoQx6Dh7BsxTJ3HGdBwuO8mtJT+nyUWOAouYKT8cHojZo6/udWogQE3d13WtJvoSsybnwW/3T1DUIyzrR8l2b9TY9uIdGzwVcSO4KT4voKiGUNKTXu03B3Saobu4IsoK9e4p+w2TDtX96pXrQwln0eZF38Wlbpw781jUNj1DM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=JfMmzsD7; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="JfMmzsD7" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43b40fb7f95so111819f8f.3 for ; Mon, 23 Mar 2026 05:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1774269615; x=1774874415; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9Q++a21A6AD2ql0w0oWjfHIlT8Hq6H6aMR3VORpq6as=; b=JfMmzsD7vuA//HsW4ulyRc4686h07NUoFFG1pw8jC0wuYxJ2ean0bxiwBRGq0RrBWb CUxL2whVNgY6Eb61byBne0/cLo7bAAfc9GAlu30aeNmPZUYYbw/RgfiJZZBMbYY4j63v DpvvAC2N7RYunUIPMrojV/1DwdnViGQVVEfDXwf/3lSyHf6YeqFdDXGZS5RAXq2Qt7Al r4pij/dtGj1Y7dAMGN3pPpbFwzoTypMSyHq1VGluEagjEtlj41i9uZJ+o7GAs+klY4fw PAA2dS7DNXHFvWO0JBpPvYu8zSvdEU+++B8ydxIeR5+ZAdAxyv0QKT5ULSG5dJzjmb4a 3jcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774269615; x=1774874415; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9Q++a21A6AD2ql0w0oWjfHIlT8Hq6H6aMR3VORpq6as=; b=ChDWdINRCOVXSQdFe4F8bEyBvi7UfmiXUkp/WF9Kwh4PTgH84E0tOuCLkgjU7aB8lQ 2c5oxrhnc04VIfpUwat6j3nkNWB5LrpGuoGz4ElswY9z2ge9l/TtlyTHJSghb1pp9jgU JXjuT3Ytd6qK4SrK9HTRtjCIjURDmkLoK5EBn/if0Ry5PxG6a19qj0N94YyLN9Llft5m U44KVkqOv1ClE+rCZb4hpVFkBG63XYKPgnhnWVLmjCqH65h5Ryk8FmJs4KIOuJCEtz8/ UtbY+nNbldnu9kWECCqcd96HZC2qjS4vgJYMMZNkmhjmXcYez03Vl4YDgpmNPd8ijDmP jkNw== X-Gm-Message-State: AOJu0Yz/cmx/gQixSE7ZfhQHnNR4fzloI1zes8RYQTePodBnZGnnkDNK 6bEDMjmWqaHMUyjjRr72uwmMi1KYqmGzDS9j8G9EXROy5y7/bjn4GwCXWcmwnvnK4mQ= X-Gm-Gg: ATEYQzyireBmgqewBVIIM8Gj0A8VhHshlyEXR4dTfozuxHPuv2Wl10xBSidS5zWEWVI YVwfgfnaG+4QflqMBxG/YYq8/vbj7TD2eVAMFacE2OmL5j8mqj4B5jrzLfRegxkpdAu6kpEJE96 FdVAFNauJruQ/KP7KkoRfJt+IJ67cbjIc/PpaIWWhtkM4wsKPEShVcmxxcLAdNo0bgi4df2v3uV +fSk1kqgoySKUgxr9fdVCZeU3SHeIUlRYNdD9anavrzjbAU+m6t7ACV5TS+DPv5FUuM0RGL44FD RdaoCILGa2EKm+2FRwF7XUPpzbyaIBSHdrYuGc2gH8H0Ne0akhynd2azmdgofGeQxsO5tF0YNIk KO+KMkt1w1R9LFSYlQ6z0FLZG+8LIfCxVd4gZBNU8IqSdQa3zj8iSKXrk73ZESnnv4f6ok2eKZu wxiHBcfm+BnMBdKoLOaFLqUH5eWk5A3P4Cz+pMkarFre0= X-Received: by 2002:a05:6000:22c7:b0:43b:4d25:959b with SMTP id ffacd0b85a97d-43b6423bc16mr19707044f8f.17.1774269613792; Mon, 23 Mar 2026 05:40:13 -0700 (PDT) Received: from blackdock.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470393fsm30608008f8f.17.2026.03.23.05.40.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 05:40:12 -0700 (PDT) From: =?utf-8?q?Michal_Koutn=C3=BD?= Date: Mon, 23 Mar 2026 13:39:39 +0100 Subject: [PATCH v3 3/3] sched/rt: Cleanup global RT bandwidth functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-sched-rert_groups-v3-3-1e7d5ed6b249@suse.com> References: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> In-Reply-To: <20260323-sched-rert_groups-v3-0-1e7d5ed6b249@suse.com> To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider Cc: linux-kernel@vger.kernel.org, K Prateek Nayak , =?utf-8?q?Michal_Koutn=C3=BD?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1725; i=mkoutny@suse.com; h=from:subject:message-id; bh=w76eWlKFvPX33VN8ZvO+nZ9SHttTzIcOygSnsa1y50s=; b=owGbwMvMwCVWZ8v0fMrtHxyMp9WSGDIPmiyT/nSZ9ybfEesIsxmXdmwSbDm21nj+hye6x1RSv wXOSStn6pjIwiDGxWAppsjiJJzHOv+DjJvl6a4vMHNYmcCGiDQwAAELA19uYl6pkY6Rnqm2oZ4h kKFjxMDFKQBTvewhwz/zPN2LKyLr3XW+z2bL+rwgNjbzru+h+NCQRVwR3zycP+9kZGjom3nk4hN l/VC+z5UKwjIGWp5zJit7Vlx9r7Q8scDqNRMA X-Developer-Key: i=mkoutny@suse.com; a=openpgp; fpr=9F2AB6F1F2BBEE7621C1B620CFDED9A2FD1314F0 The commit 5f6bd380c7bdb ("sched/rt: Remove default bandwidth control") and followup changes made a few of the functions unnecessary, drop them for simplicity. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index d3b6483fc3e7a..87ed7268fd547 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2815,13 +2815,6 @@ long sched_group_rt_period(struct task_group *tg) return rt_period_us; } =20 -#ifdef CONFIG_SYSCTL -static int sched_rt_global_constraints(void) -{ - return 0; -} -#endif /* CONFIG_SYSCTL */ - int sched_rt_can_attach(struct task_group *tg, struct task_struct *tsk) { /* Don't accept real-time tasks when there is no way for them to run */ @@ -2831,14 +2824,6 @@ int sched_rt_can_attach(struct task_group *tg, struc= t task_struct *tsk) return 1; } =20 -#else /* !CONFIG_RT_GROUP_SCHED: */ - -#ifdef CONFIG_SYSCTL -static int sched_rt_global_constraints(void) -{ - return 0; -} -#endif /* CONFIG_SYSCTL */ #endif /* !CONFIG_RT_GROUP_SCHED */ =20 #ifdef CONFIG_SYSCTL @@ -2860,10 +2845,6 @@ static int sched_rt_global_validate(void) return 0; } =20 -static void sched_rt_do_global(void) -{ -} - static int sched_rt_handler(const struct ctl_table *table, int write, void= *buffer, size_t *lenp, loff_t *ppos) { @@ -2887,11 +2868,6 @@ static int sched_rt_handler(const struct ctl_table *= table, int write, void *buff if (ret) goto undo; =20 - ret =3D sched_rt_global_constraints(); - if (ret) - goto undo; - - sched_rt_do_global(); sched_dl_do_global(); } if (0) { --=20 2.53.0