From nobody Fri Apr 3 22:36:37 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A74C2387348 for ; Mon, 23 Mar 2026 09:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257557; cv=none; b=H4WDBQTJMuNuPKlk5IKiJj/1wimivKMiZc/tEei3i4NZz9u5NUCFiQWy8v+LjNUfzh0azBkrXITupGxTq6qei+VnLtYJ/M4KiXhja6C4h7WVhktkWs8wX8hFqgE8ETp1cQVbAkndWDF/bE4gpVu77mBRrGiLB6wYzruoL5Zp5L8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257557; c=relaxed/simple; bh=LS4FXm8KnlrTRJlZxpGWlu2f+zGJuXdncoQPyY79QG0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZUuAkNUocEdrNTX27qIGQtwkZ3gEP5cMItUMKERkNW0jx0EsNvVsLp6pbx8kmSH/h4YUeN5tLpiEFnZifZCcbmxzZBnGFhb51ncD5V7b0XX02X8C3HuS8PxQNF52urOMtu1jX3geQrEP48VE5G532EZuxBqBfAlnADj7x62sOw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CfIH5dAX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AkunuRhL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CfIH5dAX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AkunuRhL" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N4PTxR2754488 for ; Mon, 23 Mar 2026 09:19:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0kPiIhTgCf9OoUIvaI3Ju9pKAKStgsxqhL0qjTgECzE=; b=CfIH5dAXHmJjhTex A2CjDdvi7Cqhz26WgkPJR9mELbgvlucLaeFaF4vlWSbXA4KtzF24Ti3/e7iEgZab f0EWn+7xsRDITPZ9W64SnnVg2LtowA8pLmZafC6CDgpLpHwO1m7IzA2IOiL1mgDr JhlAUhWFNE65Az2jXX8ySzPHzcF88bq3e50qWf6pHdokI975EObzp2Jro0QMTKGO jrz+yYCZOu+ACOOzQlB9wGpmfkiSMOHswWVlnw5VpeSuhjIbvdHivyX5EAyOk2jc g4AGQyseUEoUpEriRsoiDMXG8uhyiQdCSflYR+ORjaUHjwYKo1zs5wVef/I3fUVM FY3mFA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1h1e4t9s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:19:16 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3568090851aso5100081a91.1 for ; Mon, 23 Mar 2026 02:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257555; x=1774862355; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0kPiIhTgCf9OoUIvaI3Ju9pKAKStgsxqhL0qjTgECzE=; b=AkunuRhLk8zN9R2Oc4hrDEOzuzBnRpjogSqgyf+wPDSuyIgGQsd+S6u++H+bu7erXa 8JxNZayJFOt8EjIuVYCKQkHsWGG9LX7b45xChrq60umJMOHha7eYZhS3nZpQH8tIhF87 i4GUKvZqEHdDlVbChstF/3bAxtk5ROI4Ivrq2yvClaR7EVK0Jb2fxosw0sGey86sZhLl QpkUHMKHOEgZyuSlPCZHX4tQY36C2F5ruxMclSofgUYtTLvdsZbC+NIwPpbvvNHoxig2 uSRYTEb62qEnMgPSUSKyPq2+aWU4Y6fnUZIiuRoMdg9bvauNJqG84+uM5YVOCP+K8kjW RHgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257555; x=1774862355; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0kPiIhTgCf9OoUIvaI3Ju9pKAKStgsxqhL0qjTgECzE=; b=ONmeOa7aiLadVkMiWIEMll3TuhxxKKOl2GI6wkRk7xLVdKmMViDnO0ftYb3D9FoVTz Z1mPz4xDaKS4dcC9rSUTHMlxz0J5oz124oXSUV5wGjx6l4+4in8iYitxSRGrxGBGKdLY 59EsINljfi7KpT/BTgVKLKrSz6GbAhCTpd+6Z3SeD3F7ZcMtIBc+xMtnDmXtYPWuwwgF shKqeojtxUYtbG8rosP0+qUi9X6ENuJn2z2ItEts8v6kwKRU3pmttxFKARZPlicnztwx 6nVQMgOxdU+o3iKKkBvxOoYlPHG6EvHkaGFkH6b5eoQXg6ZjsiSSeCJw0yDNyc0w4Aol kAHw== X-Forwarded-Encrypted: i=1; AJvYcCUKKHUNd13nDT8Sr/0xa35XFawM+fcpV/8glZ8AWInGttn0N4NunBoOsOtM4txM7c0wxBVyIOJ6Cu0uGAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzGmfEMT1mjpEIgxWOygeEw16Vc9GhjCV0eoKbCYBtVj/tnA6eu jPQXtOKmPv3aV7YZoSeOzu8A2FdpDkb3eY/+GZ9+Nww6j9tnSdrgwffMnR7wd9c1qzabQuh+lQt kK2i0fBwvbgjrOKmd0Z5KOHjiMnlFHXEMI7UuZByhQWYmWZIr+ZDi8Z6/NpoGbRhiiPQ= X-Gm-Gg: ATEYQzwHU9aAIFFbSaB6oHPB/lFE7rL2Az6PCgl1UwVbKmfY15CR84nAQJZV4TSryV/ Bb++eZlvZgC0nyvrRGEOc1rQS2RYRwSraaIZ5QYcRMyzP7hfghUErMuw33WAuebhJuNs2vPVQtB aFvaHIZTUBrCjp4uFKPPljS7oU++9PbMMUfnTWdiak1Eeh2c4k4G2y7xFMtPVy+EogKBrKIdlu0 43aQMsZ13vdG8qfjhBTdGsMoGeovQh7gvDSwz1D0Kw0NvXYAyre2EtWztAXktuuLsfEHLzPqkF1 VSLbcV8Jj/ZAfJcR7QiXHJihwf9aEaFG4bRxQaZ71npR0FzVeZJZ2fzeTbjwQdZ/Mmdswwbh7vg GXIsqBtCxv8UJjoX8q8NN1PD7bo1rlWx4cTNG0mNi2Ky+tBM= X-Received: by 2002:a17:90b:35d0:b0:343:7714:4ca8 with SMTP id 98e67ed59e1d1-35bd2c69ef3mr11216532a91.15.1774257555423; Mon, 23 Mar 2026 02:19:15 -0700 (PDT) X-Received: by 2002:a17:90b:35d0:b0:343:7714:4ca8 with SMTP id 98e67ed59e1d1-35bd2c69ef3mr11216507a91.15.1774257554914; Mon, 23 Mar 2026 02:19:14 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:19:14 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:48:00 +0530 Subject: [PATCH v4 07/11] arm64: dts: qcom: kodiak: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-7-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1513; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=LS4FXm8KnlrTRJlZxpGWlu2f+zGJuXdncoQPyY79QG0=; b=biRYorjV9jV7YU0YAsnA5858q5QwIrCqCidA4lchyItfLEu9ysEGLe/XL8uHLOG3QJl06gLZ8 YklGA+Hy0nqBxf57auSkbNCDdiMjzxsQMdMCc+jIs/2ibF5OBOPFf/o X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: o94B4V9H2Xuaezulam9GpQnDYurm2t-4 X-Authority-Analysis: v=2.4 cv=epXSD4pX c=1 sm=1 tr=0 ts=69c10594 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX0AUu+Rt0ZFZ8 AsEMp57trKTmYHnwVTXvILbse1ny7hSMcbRcR+o0/eskbzLk+JYvvZSG8BpPoWm8rMU6ZaUuo+3 y1eb/1GnjqXslkNC22y/Nw7zKXJwPCYj8/I7CGuqogbnxLS3iShQ8cTCajzEmmb3yYCQ22c2lLh KTA4lpFSi81aeaAGbRYIPxEZa6RApcP/JFt0G0mqkoAqcKrZ8pX+zehHGBg3ygGccTpQEGt8nf8 cQQO5Nnb2ZX2qf/+Id9eQ7uOAtbR+NpB/7qWykikYz+DHEdtIAUo64D/iCH+BL5ILkiH0gh0RGW kJVIxr2v/kqpPb5dBOYjWrwxgx+q6tJ6+v2P4XWPLiKabs4Q/veCXZ5xQeKpWQ0uw4VnLmhHpFm 7QMtnPDE3LQiugxRJet7vpN69dIbHPC15K0MoEAd7+2zcU4WDyHyPy2BWE+gGm6+HYdc2pCbHVS Y1GzRJA2wZ59J/3Y/hA== X-Proofpoint-GUID: o94B4V9H2Xuaezulam9GpQnDYurm2t-4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kodiak. Fixes: dfd5ee7b34bb7 ("arm64: dts: qcom: sc7280: Add inline crypto engine") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh Tested-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qco= m/kodiak.dtsi index 149954a3eb7c..9765bf361db4 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -2579,7 +2579,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sc7280-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1