From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4005C38645A for ; Mon, 23 Mar 2026 09:18:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257504; cv=none; b=oePp6y2/6m0k0Na1gueE8lkykDfZIeOAcfCt3JHyFLdMr3Ts7xgZJ+euWGjfkTkymw9G4/dhDKr3dEnmxwLY68b20qsDW9refcuIx+TGG7erOOnB/2y4OBwcgDy57SrhyLZjiIZ1XHSR68QWppyW1THrlxCZiiyo0zlvbwNbftU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257504; c=relaxed/simple; bh=ZkSKYFbNGjak0Dho+sw2XFyENeFl4F9edtmWT5qEn8I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UrtVc7/dca+sFRONpa/nUZ2KeYG87gvSoYEZaWBzFaAs1FduCRXh7urdycP29+5Lffov9RyfWd46zlFevNoHfWccd8qYm/h9o/M/j24NoKyoKId0Apd9waT2kUeo0lJLlqEnybCUCs1GXgW+On8eHK/Kan/Q01QOBYcr1dRE4cc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AEj0+6TD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WJi+Zuc5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AEj0+6TD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WJi+Zuc5" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7tANY2291136 for ; Mon, 23 Mar 2026 09:18:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fBQnVcwBQGVsncjSxa74jLLcr1ZR+vADPj+TOnhgQ0E=; b=AEj0+6TDepAkektK gl929XK97X92Xj93AxV5AMxxWbZom6YkZdXiZWCBqykDIHXFpzxKVwJD0dHRCeFr XNHFOmWIF1RBeKruoQtt6fxkP9nGgZ5ETa4KCFPbdqhTzNtkNqI26Su9h7clpcDR Uas5LH7W3j/cHt5pxqF+8V1xYVoFBWuE+N5vQDovgI0GfQLTZ/44j2QkcjJa9+z4 3evruiak/jJDHJWatURiQQzcgQxmjF0GyXhHYo7N3SPO4ZnmsBcr260Z+PdnyuJ5 KPs1AAaBsBCkiQjAFMS8v/54J29lLzaFKNLvGebDOnIpNZhUjNbE5vL8WkSz8ykQ pJcyVA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31j70915-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:18:21 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35a032cdd78so2745784a91.1 for ; Mon, 23 Mar 2026 02:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257501; x=1774862301; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fBQnVcwBQGVsncjSxa74jLLcr1ZR+vADPj+TOnhgQ0E=; b=WJi+Zuc5J71l0KxZASwWcNcgY80c/7tsmd8SQHLeqAS0z5lO9nD0lwH+2LRfKgINSn LBa88ojq8IyGnGDrhCptUMBtg28vLxmkNUOWcdYhdTb9GxwhBbHk++7KVdAQu1ld+D8t Y67CH2iKGQ4YTzi5plLDz/lorhiX9xGThXirlm5xqYZfcBRnTdV4s/EJjeE5zCzVrp0F BsNeO637rTYjkU5vIsC6UfTWp/NzxUboLLLb2jVHkBYk7EG6vrsiDxRdz55CsR8QyD93 wKcMATRHJd7G87m4KVtKH2G+F4GMXN6w+HqS8xN5sVG2QKDolfad+r30aZs6FJQgr6Bj RiWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257501; x=1774862301; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fBQnVcwBQGVsncjSxa74jLLcr1ZR+vADPj+TOnhgQ0E=; b=ZUvDOwK8bEe1yyJ0h78Aj3x/uiJTQAw8BFq6r47iD0NeBeXOpq10cauXoBXKOovb/B Y6gr5jTg6DuAKY1uqlYVqwJ2KxFWo465VHlzz4TyjHl7VHYM+nno78r6u5KhHAWjju5t 6eaRcIhC5LOIhl0ydBTqLeT208YaNTo4mpQx/NHUIoNxpNjBv4Krvk8nLDRHXLTUaUKA odGtO1pUjDLs+enJCFDhkUsVsKWmmVsKbU69wR+erzuSyZmNeV4lCotdAo+vQh+J4XBM KAlUQFDBWmRj8lEfIeRkhgh20BAnWW6+nleq3vj/NrE+gVIO7I9g9IqZPlAxMtdfkiuc /p8A== X-Forwarded-Encrypted: i=1; AJvYcCXpE4liE3Cl0DiEjopmvQq00k3oYyJmxS6N5Std0mzUZX9ShjQBIU7mJ3TMQv9OjxuyEvqImQ4DmOW5nBA=@vger.kernel.org X-Gm-Message-State: AOJu0YwGdLFqUAMqSj22lj/XNw9zXE35yzc4nQAHdd0+IVUHrlpy2A/8 8AY3xtykiI2ADPwbwtxVwXIJLeFDIgUe6zqW7fwJlYiz7qyd7mTemfRP31QAZUkrAeWoHnZgeGw goPpDUbZEfkKPw3c7KsUO6sYsWSKhf2UbdJzCxSN5GPjmX3gzBsRave4eak8ZICxefUY= X-Gm-Gg: ATEYQzxU9jaXYlXzwOWglaWUCzJ3+WgNxNrUDhZd6313bpUABciqwXt+emdy4eQG986 dF6MdCO3v2qt9vSD78/+lh35+CcOZu//jBeaEh8AhqbdFa3i0AiUh/VwhDVLBSx6/lQ2mQl5rjR uFDeYlFLkdBQlC+tIHhbjxoqiuvi4hCX1ZWJSLf0gC3XczBZKGMMkzYPj+/z3KaBo4k3TnTgomO c2lwSyH4bBit9n8RM0TYKd4GPCxhzGX8GxbH1MGtdrnvwW/qAp21r9yaDUPefH7jvwXAxiZ+9j3 iVYJj4lmeqigbgCCII718YymG3QPV/enpvrD0gQ1EqsYu7GlukYj43wAp47dF9e/32tgRrEn1Ze ylqY9RlyiYklPYVPQqWb6RlhTv2nLQoNmg33/vnuvTTxyFhk= X-Received: by 2002:a17:90b:4b04:b0:354:a284:3fff with SMTP id 98e67ed59e1d1-35bd2d187e4mr9885912a91.25.1774257500826; Mon, 23 Mar 2026 02:18:20 -0700 (PDT) X-Received: by 2002:a17:90b:4b04:b0:354:a284:3fff with SMTP id 98e67ed59e1d1-35bd2d187e4mr9885892a91.25.1774257500337; Mon, 23 Mar 2026 02:18:20 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.18.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:18:19 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:47:54 +0530 Subject: [PATCH v4 01/11] dt-bindings: crypto: qcom,ice: Fix missing power-domain and iface clk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-1-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=2604; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=ZkSKYFbNGjak0Dho+sw2XFyENeFl4F9edtmWT5qEn8I=; b=3ogJNiFMZD+SsmLzmxVbrbnwcmwDDcXVV2MpBtJuZ7PqL4ZR4j9qyX8pHgxnnjUpQcLljmBG9 kiHfJkPAbWTAAnYi0vsijUZYjfStyZ97yHZSTuEpLah8Egi4FW0Emrp X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=ArXjHe9P c=1 sm=1 tr=0 ts=69c1055d cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=nlf9mDh_Z9TmLa7YYksA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: 2De_qBXbN9bpaoUeVgkaxOd1-kBgLPon X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX+Ypx4XP9qFe2 N0yo8pMOsnSdU3dE3CSHHJum61eog+hxIOVTfcI4DLSqXmq3vq1rifu4qwc9Py2LAL50Xidn62A tyo858YbbeCdK4q7sgiYZgVgbvdjm0NfjEpsrsDWBECShyZVUi+jPF6WInvlJytj0x4w3xRoIbv h5Ad42I5REbHiULbAncLC7oGvzebuCE2aa1LkdYjTMFf4nJvA+LzSQZunVwQx6RTp4OrxDFJwFF mSd1j4lInqxf+eh9aJx+5IH7smUubRPBAMVk3wLSLy3YAt8RCPwu0L5YYZYTLCObncDyjNpsD6G Mow+65IaE5gwDZ0xm25w1HBOLRUNS7JVs4W7Jm75+3hvKM2EbEoone1W8hhSPl4Ig9MISB++PlS xlirIEoPTY+vORpCEwiQWeexAQ5jMQwoO/VWRGEzhfMTr1qL4EeSFKKFakb2G0HdIRnBwbTvN+D 8OWAiDMjQtjluQSv64g== X-Proofpoint-GUID: 2De_qBXbN9bpaoUeVgkaxOd1-kBgLPon X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 The DT bindings for inline-crypto engine do not specify the UFS_PHY_GDSC power-domain and iface clock. Without enabling the iface clock and the associated power-domain the ICE hardware cannot function correctly and leads to unclocked hardware accesses being observed during probe. Fix the DT bindings for inline-crypto engine to require the UFS_PHY_GDSC power-domain and iface clock for new devices (Eliza and Milos) introduced in the current release (7.0) with yet-to-stabilize ABI, while preserving backward compatibility for older devices. Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Docu= ment the Eliza ICE") Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: docu= ment the Milos ICE") Signed-off-by: Harshal Dev --- .../bindings/crypto/qcom,inline-crypto-engine.yaml | 35 ++++++++++++++++++= +++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-en= gine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-eng= ine.yaml index 876bf90ed96e..ccb6b8dd8e11 100644 --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml @@ -30,6 +30,16 @@ properties: maxItems: 1 =20 clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: core + - const: iface + + power-domains: maxItems: 1 =20 operating-points-v2: true @@ -44,6 +54,25 @@ required: =20 additionalProperties: false =20 +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,eliza-inline-crypto-engine + - qcom,milos-inline-crypto-engine + + then: + required: + - power-domains + - clock-names + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 + examples: - | #include @@ -52,7 +81,11 @@ examples: compatible =3D "qcom,sm8550-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x01d88000 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; =20 operating-points-v2 =3D <&ice_opp_table>; =20 --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41D3438645A for ; Mon, 23 Mar 2026 09:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257513; cv=none; b=X1vHAyMrc8Adu4efD3cHW31J92/hmoUsVCO+7SHPNMWjAuKRqhDtxBtOp1LcRTKNr3TT01zWfGxCi8dpksN+yAfidC9cmnSN8jsVkEcdhdM+od9p6Gbgq1awSU+ImwZFUMI0b0DwMDuMUj+Jtdzti4zrBiWrwZ/fzrjYd64fyWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257513; c=relaxed/simple; bh=GRasFOQDQnuoi6LdOvdCuvHUGo8tuUdcLZv2gGWTa7I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JwlBIUlYOTeAm/6Csr9mcpB2HlS8tbc7G5JcQVp1O2qw3g79UhZ5gmadqEfDBqpQAIZa9fb/fA9HT14ZbkGI707mf/jZioGrqyr8dYFbaS8nseBqj52EanQ/I3NOz9l8+fVDlcUnVgKVPh9ZP5E5XNdHntGwGlNECW0CKr/9sXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bmOMaHrS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SvYcnUn5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bmOMaHrS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SvYcnUn5" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7tboD1627188 for ; Mon, 23 Mar 2026 09:18:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K38ecOXWBMhUStpTWn+W7TDtJFk9bdxlpPeuhwPlVTc=; b=bmOMaHrSpkRUjCi4 mxpsYzlaH/hvSwoLZc8KGvFWSK4KbTGcnBp52OI6GAv6O0eXNAzm3urSN2sbuEr/ TN37j5/6zjOovos6vQ+82ktCIk8c5Pz484x/7pKb/L93wwyhObApJhHjFNG+D3SC eSvo16EEaN1yDZVGEWFnMqIRwf/RopzUYF2FJGxUWFueIslGd1VwLRJpUtVkCV4J wVfbbqq/zZ0ef1OAhSoBJgLCU4pqJRq0EjHvhQsg15HcTTnInBZB3Zl8xy4TEMAr 4GfbwI97fq8j6WWCK15k2EW7pBHvO+geNFqAQM8S9+J4yQ3uf4A3tFHwBQcBH7W2 q1oXUA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc0995-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:18:30 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35b8f351debso4879269a91.1 for ; Mon, 23 Mar 2026 02:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257510; x=1774862310; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K38ecOXWBMhUStpTWn+W7TDtJFk9bdxlpPeuhwPlVTc=; b=SvYcnUn5MIW9czobkiH2neGDmBcVOH4miEhmNIMAgOMNsOdxC++KDGoQVqhIHZnLzU mxGqRGI0pYEW+sAN/alPME9Xl9ofLeACD2AebaaVmcrtNWz7nVOxFsajkRpHieXYAGDS XjbZ/ghKpVMgwCrdijoXDD/kdfJh+1bJh74ctcmsj/Qc3vViORkvB/tEfQT2ugXYmpMw UK0Wi0xNZH77j/3i4gy27dBBfPn7MnCfChM6GKtt8Q6AqZfyAjK5heXh2sIN4THgZcq9 3MUqYIfduin/rdUd6mQ87SdJ23F0MxxAqdL2aYE1ZwNv29B8G9LvTe3C/8iWQuRRdrNo 8JCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257510; x=1774862310; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=K38ecOXWBMhUStpTWn+W7TDtJFk9bdxlpPeuhwPlVTc=; b=ctZXGGmkCunahAKCfD5TQ0JSmOtagaj0uoah7kV66fZxF9X9oY4TiqQD+QDeldKdj4 mXMzzLMwhdTN6vBD+cMGyjLJrouYslbgxPSZCiwJdYI8pfRqVhqT1EXtk6eouRiOQ0Lg pTlmWH4XkBAuaFFayLj7KOOP6XYgIVgzzCAtqAQPsZ6m0rC2A3eRaRPfC9wJxVPOysbS 4AemW31Zi4gXKGlx0fJQmG05ExrFFZLwDtPWY+UnlXYOBkAAxYFQfYN4v6Nqdjldln0p QlCdm2tVbJRQDwLR9jKxxPieLwe3ZDsypl+v6uHbTrIEfHGXQb3YwvbgusJ3QYGXdyj7 LhPg== X-Forwarded-Encrypted: i=1; AJvYcCU6uo0IYyN82qNS84icqnSdfGI/ocGFZIwcFAO7ikeNIrdmgdhhAM7SdQGutRByPwI0Ur4rwzsJPFs4Xlw=@vger.kernel.org X-Gm-Message-State: AOJu0YyeOkmktwnox0wRDuQcd3iMpBSJ0odZjbAwsy4ROke6WR5fx4BR oYDFjg5NOsaiIL8l5/g0+R+lVkWQt4HdTbSHn4r4LZxL7exmxpd2Bd3fJnPQLioJ4BnrS+O0kXw KTnaVfOu40VCvN1PLXi7F3jiRSnHUOsuxpPtJqLKHPaGXW37hqN3O7D3dLWc6OolhLEI= X-Gm-Gg: ATEYQzw/QtiW0uQ28J6NzPcu/xu2PA608qzVHJ5XKHk28lnJ4JWEgd451qlKNDGeD4+ 9VT1ZcqSQqxvjeQvvS/0a+DasllJ5Tgmnf5AytwfZamAq46O24p2Ll7dEZRskB2eAiNTFKRjhI2 LrnJLHF7FlN8e1Dbw4T91xAM9gzGyJ8B3Cv2b92ZJ6nD6t800P6vg2R3TTAj1T6sGDqmnGMRs+B imvN1nmXxMkjX0bKQvBm/UEdxFNEbRr1hkaGfQOhI4cJPyQxty4LGR1iSKzxolnLJ8RrFGB/Lyi 05CVpqmsGK+axwL95rPtnKMnw4Cv3TtTtWqoKJOIIelw4UeTE/kn+JVUCB1zteO7Bjhz8EGGZrS 52xLhVNsC2A7beas+A6dL3/eyTGsZ0AgDQVknE4rRJvHPhIo= X-Received: by 2002:a17:90b:28cf:b0:35b:e566:15a6 with SMTP id 98e67ed59e1d1-35be56625d6mr4506779a91.28.1774257509882; Mon, 23 Mar 2026 02:18:29 -0700 (PDT) X-Received: by 2002:a17:90b:28cf:b0:35b:e566:15a6 with SMTP id 98e67ed59e1d1-35be56625d6mr4506758a91.28.1774257509385; Mon, 23 Mar 2026 02:18:29 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:18:29 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:47:55 +0530 Subject: [PATCH v4 02/11] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-2-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=2504; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=GRasFOQDQnuoi6LdOvdCuvHUGo8tuUdcLZv2gGWTa7I=; b=0AKNRl6KfF/JYgXrtGC4dExbf3Ox7uxMEZ6hQ/OzDCKpAt31J5XhaBXgEeDlTCqSJjJZuQYds bmivaZvOYjPDXR3cTODuxf7D9DSQNwkbi3lePlT0YgGyra7M2ElG3TS X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c10566 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=DGDWbsvPyNGGEFbMfx4A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: IxCAvymhpR99dwc0EueQcwcqNDx4yHTN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX3QImbFyKpSNf PRIfdDlpclmu4Nf1c26+kCCUr4LfuYkczQGAVdKpcTgLP9O4if6tU89Rk3fkdxxPFsUXPa209oW ilhjjOqurJsIWdwUFHC+WkPqL2wyJaFtEquzlmMEuDQQqkcFoOn7Mqak+THMCyXxivWcx6JQUMT Ndl+Fz4pMmhGOfcOBBbc3y40dz0O5SzGnvLztUPqsEU0cuYlIDOJI5Bw8Ovx3/5eM6j7e6MwGV9 6xgUOfUaYnsF3BQtQ15znCDAum+Acxd+GRUhXWoBl9oEKSOpHNdfztSEjVyqu7kYZQsU5AQROj7 zL+hYJ38EBjQBViKD4IHzbeS/zvHCXFopGCWUkGVHRFZs/GGzCDj42Us6bh74bPr4lU3IuddJQT jRNhT7a1vL0pTkBKVjtq11mOUEm3SZ0Aixxm+quDBn9ZmDC2B/kwoxZ6hoFneA7sW8xXKL7OpbV oBpnd3ve5nlCqhTld3Q== X-Proofpoint-ORIG-GUID: IxCAvymhpR99dwc0EueQcwcqNDx4yHTN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver de-coupled from the QCOM UFS driver, it explicitly votes for its required clocks during probe. For scenarios where the 'clk_ignore_unused' flag is not passed on the kernel command line, to avoid potential unclocked ICE hardware register access during probe the ICE driver should additionally vote on the 'iface' clock. Also update the suspend and resume callbacks to handle un-voting and voting on the 'iface' clock. Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicate= d driver") Signed-off-by: Harshal Dev Reviewed-by: Konrad Dybcio Reviewed-by: Kuldeep Singh Reviewed-by: Manivannan Sadhasivam --- drivers/soc/qcom/ice.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index b203bc685cad..bf4ab2d9e5c0 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -108,6 +108,7 @@ struct qcom_ice { void __iomem *base; =20 struct clk *core_clk; + struct clk *iface_clk; bool use_hwkm; bool hwkm_init_complete; u8 hwkm_version; @@ -312,8 +313,13 @@ int qcom_ice_resume(struct qcom_ice *ice) =20 err =3D clk_prepare_enable(ice->core_clk); if (err) { - dev_err(dev, "failed to enable core clock (%d)\n", - err); + dev_err(dev, "Failed to enable core clock: %d\n", err); + return err; + } + + err =3D clk_prepare_enable(ice->iface_clk); + if (err) { + dev_err(dev, "Failed to enable iface clock: %d\n", err); return err; } qcom_ice_hwkm_init(ice); @@ -323,6 +329,7 @@ EXPORT_SYMBOL_GPL(qcom_ice_resume); =20 int qcom_ice_suspend(struct qcom_ice *ice) { + clk_disable_unprepare(ice->iface_clk); clk_disable_unprepare(ice->core_clk); ice->hwkm_init_complete =3D false; =20 @@ -579,11 +586,17 @@ static struct qcom_ice *qcom_ice_create(struct device= *dev, engine->core_clk =3D devm_clk_get_optional_enabled(dev, "ice_core_clk"); if (!engine->core_clk) engine->core_clk =3D devm_clk_get_optional_enabled(dev, "ice"); + if (!engine->core_clk) + engine->core_clk =3D devm_clk_get_optional_enabled(dev, "core"); if (!engine->core_clk) engine->core_clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(engine->core_clk)) return ERR_CAST(engine->core_clk); =20 + engine->iface_clk =3D devm_clk_get_optional_enabled(dev, "iface"); + if (IS_ERR(engine->iface_clk)) + return ERR_CAST(engine->iface_clk); + if (!qcom_ice_check_supported(engine)) return ERR_PTR(-EOPNOTSUPP); =20 --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EDFF33F588 for ; Mon, 23 Mar 2026 09:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257521; cv=none; b=jRtm4L8kqD2IIhCRERsheGxCGWZ0L3hgulNdSN+eptTzrNY3Ts8WKvvidVYaswU8xJ5NZIZ7gNXN2fJvcz0QPal+p8oH++99ISLjfAvi1LGtwVF93IFrIz301jo6eXBHeISh0cIJLL2gfLTM3d706CQZmGUM9VXf5x7gAZ0/bc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257521; c=relaxed/simple; bh=Ua9PTxyD06FOiJfwJksvZzTwKT5wpUwMmmC6XVvXSlw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LdLqonGFA3lM27oZ4s0p/Hc17KJBKl5Bhryxp9DePaESSc06TXT13c+XeGcliyDme3NY3Jh27W7uqjyKZpbQ1+iu+Bw3lPMARGPgoYC3DXs9vPIeaez77FgrqWSRS40D/thQKPci9p5Y2T7Fbn/4qJtIdMIDuJZA23IeZKeRAuQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M7LREpL7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XrYEiMoW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M7LREpL7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XrYEiMoW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N76ZIk3294366 for ; Mon, 23 Mar 2026 09:18:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pPxK0Zd5FBsVZsqHeJ+/TpVgmVWSK2RRQcl+tl0GiZg=; b=M7LREpL78c21oNC0 trOQJJa2IF+2bqRDglgFkpi/t+gfGaGmJSBsfV4LIAtazVQ+NtzaKCg+JtDxX3Qd sCPMupgEtqTiOlxqoZZiDtk4lLLRsVB+DdoPHbdYZ8dvghGvxCNu8072bLFJh5JK PZJiU1zbP2nl4ijdctpCn10NuvikZnUAqT+k/od4l5PM+W8f8M/LpUkKBChSiBlU Sp/TgW0rV7FIaC0JwJraMqWnqZukX/cMS7qf2Fra8qDBE/AxukaTogwxh6cjGpTi g1KZTsLREfEXx8SwgyTwbfHFD3R69bJGPNW0+b+Xw5zvsBiOYD6C/7Sf0sZTA5gk EZSUdw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d2ca8jm9y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:18:39 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35678f99c6eso2307103a91.1 for ; Mon, 23 Mar 2026 02:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257519; x=1774862319; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pPxK0Zd5FBsVZsqHeJ+/TpVgmVWSK2RRQcl+tl0GiZg=; b=XrYEiMoWVxBm3poc0f3q8vvQUffnRxd/OOhyuje3LDdGqXf3zfCR8Eulg9jT3KOt+T VCSlDVnDOYNLbVzi4wL1XzR9CQnD2ZZuHjGIYo/fIM2b2+diIcRJpJtMeHL6cBz2L+aM vzOqlPWk6KSSaCftvUjmyL6sxEmyuNQ1AlNgGerw6RcLCSgUh7W5uwoUc+S/6ZhXOeT7 MrKCSv+2vauQdRrLzsp3AsYTPehD55rNar+RGe7KZ2dxCVn/kGnaZ/APZACanWU2zubP lFePW26/YONH4FoRH86t8m3Fd8AvKTdB5SpBOOpDLDWKSwqHM/l3uevwDecx0XTryYTa we5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257519; x=1774862319; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pPxK0Zd5FBsVZsqHeJ+/TpVgmVWSK2RRQcl+tl0GiZg=; b=AHG234jeAeTWDA1q6caBiDwAHXCr40i29cV9TR3TxNdw1x1PqT7wXv3wnsEeWMdG8P 5d2yq2R3glbzyFu0G0BM4teHILXNa3GV5rQfH6vIIdTEZkPuPi1X3vnlQpprYki2mhlH YDnKpw91X2ZRwNWlcHKYP8tK12JRDAoObdSRU2NuBp/U+S1ygw5Reyuf9Wbv+39o+noP Ij6BH/6F0dkLyQOLoNhmH8uuxCQKzhdGFumgep0C6jSF2xs9e4uXq/Ptnu8brmxA0WTN keWgma6r9TQ+4rU1a1gtUuqHwEtU2tSwxjoniNisNaPkcT34+erF1c66+t97qzugFlS3 Zt+g== X-Forwarded-Encrypted: i=1; AJvYcCXdyTpwwdvlj2tyt8BHFabYH4w/hhspJ5u9Xz9dDuCCjW3jXKNuLLoOfvb9bdjsTfMl16JAeG4W9g5BNdU=@vger.kernel.org X-Gm-Message-State: AOJu0YzxOPqo6cTnb/3intNMGZt9fmOgVE0ysp5ChlvIvz/efqa+lEpM 5gGmTKTaJ6QKONAELXKJ0I7aselrA1wcPMwQujFH+GHmDA0RhH3qHLwlkk4pGRjCpnpglhbnXwC CaAaTPGT511B5SEgXVXdvzUIwoq+m9PIbenpcUzC/JwuoWXwZuI7playXcUMenyk8KXk= X-Gm-Gg: ATEYQzzPtAp3LXaBW8G5uDZChvp6nen+5NHL5Vpvij3mZSpQt0L7Ogh63z4M3shCCi+ c816/0w1npIjbGVdYZ2q4+oPKcLiR1ZSBVMakzy9iV65pb5tLa7MEghHMrgXoHNsYp1RZV9Fml4 d7knr6sApuKYS0BEdOpY9SVLX3i+2z/6twW4tWT/vVSqMS+65KcW+FzGgsO73DD7lX2nlzQ3f1T OTytsf/8eg/kIj198GRltlgXrELUn2T0y9/uIT94WkamnkwdhWnaywdUvvXoihsmqKfhj1sMdJ4 MWOUKE/sTkB0kg4CJcDNOd61W6GV7w/RnwdaVum427E7llAOcFa19vpuya66vMaiSa7A+oiEHEX 7RnkiuFEBd0Di5aJYOm9W04srBH4HPl/P/d9LY5v7qrG7Bp8= X-Received: by 2002:a17:90b:1848:b0:35b:90e7:c44f with SMTP id 98e67ed59e1d1-35bd2b9e110mr9337027a91.7.1774257518922; Mon, 23 Mar 2026 02:18:38 -0700 (PDT) X-Received: by 2002:a17:90b:1848:b0:35b:90e7:c44f with SMTP id 98e67ed59e1d1-35bd2b9e110mr9337005a91.7.1774257518409; Mon, 23 Mar 2026 02:18:38 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.18.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:18:38 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:47:56 +0530 Subject: [PATCH v4 03/11] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-3-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1467; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=Ua9PTxyD06FOiJfwJksvZzTwKT5wpUwMmmC6XVvXSlw=; b=Zt9Vok8cFWr43GPyTQ8eChP8X0EScM2ktgYLjs7L77NOj4EDJ0QpFsKI2OJFEqVj+TI0E3jXR ZMnVc6/JUiQALlY7cNnYd1huMnhW/ScGFFJu+/wZX7z9U4Hi7xMEFDF X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX7vsZ339Izw7p IVCMCuMl1VwKYDQ48giIKV6DUcHEojVDh2abHaySi/i3TbNgYuMFiyKxUzAUw5RiTQa1wQ2gRTu UC7Q3gMGa0/Q/0TTL+M05bz1jdhQLJKFGo0yqhy9p01jdr+VlVwc0t6kzNweV4zCMQt/KTnKDIU 1evMjI73/Izy0Dhq92n2azq0NHQ4GzwDIdCAOa7256+orn6b04giz31iRv+bIeWp0pVJ1GKES3j WOGV9fGAhFe0Hse/6ktGpZ6lUJPCxEvFdA0kDNLEQgnOasm4DiUuazo0/z9NPb6AuTAxZP8QvZx 2SsYYopuYDg8L3RzYfUAE3pcR9bvoqetxiUQBGAKq7kWwDVi4hbzlrzm4jQ52LpfL2Yn4hkLKeX lWJU78ajMK9d4FgP/ZveauQuUNqcnftz6Mrv3cwVO1OcNoLuADpthrMB/QG0Tk/AdDarRYxylWD IkVqwbx1kpOMLmJ4y/A== X-Authority-Analysis: v=2.4 cv=cf3fb3DM c=1 sm=1 tr=0 ts=69c1056f cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: uij7raSUQ18YXgDtDhI9fsl-ZSKA4BpX X-Proofpoint-GUID: uij7raSUQ18YXgDtDhI9fsl-ZSKA4BpX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kaanapali. Fixes: 2eeb5767d53f4 ("arm64: dts: qcom: Introduce Kaanapali SoC") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/kaanapali.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/= qcom/kaanapali.dtsi index 9ef57ad0ca71..52af56e09168 100644 --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi @@ -868,7 +868,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D97E386545 for ; Mon, 23 Mar 2026 09:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257531; cv=none; b=KuM01kpcexrYSip4XwImsB4rrJz49vdD2GaZaBiZ1EPTd9YLmLG3/i7mvGIjhRM0F4qUUQbW6uqYpvHELSYm7uss1DpjA8xxomjohXcDspu5gb3LwQ8IHQ8F32FbGka2OrzAkq2N/UgSS9/7H3UlcBX2/+DvchncZH12+hRhoiY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257531; c=relaxed/simple; bh=Zc7nt/v6+4Q7rzRTQIetV9Sk5jCVdJFZJuVL1p8pYhc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IGjAgfP5kjX4woD/eBRvE7kaznizwqoWNDmwS9JIn0wEGxGV2sP+WYD3yWXs607iWzuv+NHzHb52mqkv2tmimY+NueqJSoAWHHrHvvcB2JEh8JxFVOEEzu+VQbPRIF9EMHJlJ447O5RMY2buO2WGoaVaSKyykjesXSx53dsnP4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VMU0dnsw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bCvlVxQR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VMU0dnsw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bCvlVxQR" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7tUEA1627075 for ; Mon, 23 Mar 2026 09:18:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3wUQtjDfxAgI9iPYpnIrhTEYGD2QmgwM9MarVNUOQ8Q=; b=VMU0dnswjZspbU7G /N4n/8wEWPRLXnehHZj/Gb2UwtWyXVZUbEk40MJlVFFGQRUNUc90vRx2+jKoRCWX U2QrnSvq5QTHMFqH/nhB2/gi5tW5mVK5SyC/5Heu9Y1tGNg8ASvZtl5wWgK1cHqi TaCFH3chltEO53gALyiFKCgFpSNIk1GsqN66xQ0xvlE2ya8CLda+iL+zIl6a5Lyp Ip5JSLT6+nla/Z4kn0UkRtmYvGeCWcRRagpIDQdwXqmjhMF5OYavpC2h1Q0JQ1Do rdawgG7M0uJo1V4TC+VRxJbqPtcS76Hm/bj+BcgzLpymkpf8IogNH7o3RKsi8tOm unnxcw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc09av-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:18:48 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35ba237d2e0so3015613a91.2 for ; Mon, 23 Mar 2026 02:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257528; x=1774862328; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3wUQtjDfxAgI9iPYpnIrhTEYGD2QmgwM9MarVNUOQ8Q=; b=bCvlVxQRZfSgH0Fd64Jk0PEDqTile4T7ORvbBwijTvlIDiN/Nf+xQ4GuxJTHLyUIo2 ALVYISc1DScsmmBedPx/sLEyOWUtutt5663Yc/kuLVFLA8AOeYWzmeqUzc2vGz7Hmfcx JNzohNpEiF4Cu7gn7EA170QKUNt3qMPmJ71S5X5a8Uh/GtBrqNQUawXkHdCeirKSaL1Z pgXcl+VJ0mJZfmqbo5K+MXXo83pdNViks9cxndWyPavXvXU8VLOoxi41NSPWSvkcyvUT K6hNhb4BL+jueeR7JyzrFB3a6Z9SMTKnNWgF1SA4Vob1xGtiC9mDN32tr5ND+JhcOP9v h3Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257528; x=1774862328; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3wUQtjDfxAgI9iPYpnIrhTEYGD2QmgwM9MarVNUOQ8Q=; b=YCrBHiUwHbwYn2lReC7hm4PVZgZGEuGt4Dj/qFnEkZWcDRyYN2TPdhKMFhXJJUzrE8 c5xAMWjvh1HHuC2uVbMLpVm++lK/1OpokKRDdpbP5ISpHHghxi4kl+NHyJQSTBgVkUCr 0icMnl50LQVc6B82PsJsv7weRiwr7u6TgFr2esnuPs1HwB1zGDOHQhfvd1tjr67pedo+ zMfrSBsnKyfMXShqZdn6MeQWtlpE/7q4Sk5Ai8lTej3Nkv5llv2aZ3DuV+0RsAkgpp65 68MqEF2m4404CtWRsqQt63LtvFVk46cxloXiShGTGGTN5L5U2Ob5hlepFqwOsn+Fnlly wv9g== X-Forwarded-Encrypted: i=1; AJvYcCVqIPMsoLnQvC/iXVGc37MZwyJGLd9h2xtP5mqDKIqA2NZ3jvA9ZdxInmI9RIPd8PLRENobENVlnLLjXCY=@vger.kernel.org X-Gm-Message-State: AOJu0YwBqByIe7BZllGs5hcwtRAb3D3fFjUMw3WafHS5h0nBPNGy7f8/ qWetzW07Ij33p/OmgBIIya+nfn8ckB3rzNBpD/fe3k03KVWOL43a5dc6NBmEIYeUtWwZAQAr6hi SL8H+h6xVZvwgMAr9lLKHxFRS9bYT7rCVwzUpwllocaLttNw1MCOgaXOXPsYyJXGpUKg= X-Gm-Gg: ATEYQzwpabQ/bGntII/xPr97uoNPK6U4R3hfdx/vcrWkp6HQ2t2ljzhxfoV3Ht68xsL 33RGobz+imQQy8XdwIDdOkozPW7PeuF7MuWBtmUgGImYenL2PLbYhyOhQP1gNEtkFnulzlt2nLc MtQtHvrihIy8lntaw05pfDB4CscUcnWvAD4c3nwlEtWdcCJaOglZwC0uhML9PsVk1QkvLlokxAh u6Ht/BlSzez56rWnqCLs3pAzLsVu4Londvt3Ly/eOQW39v8xzosd9BpwuVRz05pOAyoxTReLJ8e DA8TeQKYkJm/Q9T7imWzs2Z1QEwGsPJKBRoQknDL9onf4KkpqJHsmXGa9P5j58n+GZCMmm2gI8+ 9NHvbhat+oZDEjAtm/rVU6i7pk/ms3/nZyvar1uchNhrwVOI= X-Received: by 2002:a17:90b:35c3:b0:35b:9c97:3d18 with SMTP id 98e67ed59e1d1-35bd2be82e6mr9113844a91.12.1774257528057; Mon, 23 Mar 2026 02:18:48 -0700 (PDT) X-Received: by 2002:a17:90b:35c3:b0:35b:9c97:3d18 with SMTP id 98e67ed59e1d1-35bd2be82e6mr9113810a91.12.1774257527549; Mon, 23 Mar 2026 02:18:47 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:18:47 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:47:57 +0530 Subject: [PATCH v4 04/11] arm64: dts: qcom: lemans: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-4-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1514; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=Zc7nt/v6+4Q7rzRTQIetV9Sk5jCVdJFZJuVL1p8pYhc=; b=5hNvbZtfnL7IY/SldlqnstGyVUDFeLL5lhoy3GKb5l/0fva5UllvYuBDBtmI9nUtOTPRNsOwm eGzu2cehjSpB50a8Y0VWiojkQl4MKmwojr5gWF46wGvi0lVKZMlCMzx X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c10578 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: C9mgUobdQtttBlrVKjiYlWwOILkJj038 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX2PlnA1DG0/m+ 7QDGFhqZcX6EVZ1I1WFDRZObbre+uO5XuEd9XaPlUDLW7yXpDdkhWKMo8tsSNiGSMzzthtxInQL 397s+y0dXisz0Vb4Lts6O+WapfXWMAMFwsd9YWUG481+bL9FogIwGEzax8lAcL1JuUy4creTtd5 rbPwo+KtXvl+oO7Knz1Ilr1ExqPOwt6KsL99diR6XuSWpYbds/TEvNQLFUhwUnUtF9KwSGrj5G5 5xbx9OG+fkLSgVFjiMZ1HAdy8vOXf9BOe1poXCndm78io+AQvN6p+zzLhPror3fBTFYScTgrf8x 1OUA02kWv2uNDQzH4sN0MBzbVvZNh8OIkyHWOKDog9bsCToWo9JxX4sLZ6dGNZRxC/t4YwIAbup dCg+TiIWoHX0Nay8B/okg2i8yTYldlWVvmY6Vz+GWMvsSrJi5RdzJsT+NaCoekuepK888uNCNHn dLVUNQbEfLKxR/QZ7hQ== X-Proofpoint-ORIG-GUID: C9mgUobdQtttBlrVKjiYlWwOILkJj038 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for lemans. Fixes: 96272ba7103d4 ("arm64: dts: qcom: sa8775p: enable the inline crypto = engine") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/lemans.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qco= m/lemans.dtsi index 67b2c7e819ad..cdfa42293022 100644 --- a/arch/arm64/boot/dts/qcom/lemans.dtsi +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi @@ -2758,7 +2758,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sa8775p-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E27A3793DD for ; Mon, 23 Mar 2026 09:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257540; cv=none; b=gJHw5OzKA1KyYgl5ArAGX816HZSSLKmQon/lAV1lcSoktAItwjqn/HQpHYMZEIja7DScBDAh0Ofrj2W/0H3iti4Z2ZRj5t7EpB2IgeWRn9A9FOiyrNURNcqiUXvE3KymKwueqPA+kGSO5SRP36/QgHJa+LCO58LXW0jO7ZHEO3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257540; c=relaxed/simple; bh=zSf5B+scx1LHzF3C7LbBC/eyKMhHBwfouTQryzgofZ0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QDZuXvBw05O3YMvvuNFYvA/ssyglBvDdiFRmMUmexh6FeD7fQkttKL9kPovHNqA1yew9l2YmmkZ2QAUyX1NTVN0rcDEY2Y3kmz1P2BurtFYl2GwMrzHuaxWL39DwgDWO+qaUwCAD3U4CmLUGlYP4GI2eYG9bateMsH39codmRaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c08vod+7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J1ixJ8lK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c08vod+7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J1ixJ8lK" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7tCuG2291198 for ; Mon, 23 Mar 2026 09:18:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pxOtgD2NGLF42PFt4g53gf0KWjA7/Alkky956K2USm0=; b=c08vod+7aXUZjxq5 mP5rGz0KG2Iv3ICJ4p2/BY9yUkyPnYLys4qen1FcUiCmTPYuO3jdOGwMUeGkdk2m uOWBU69cpHyCmcPY1Cj+8/oq9Ny8BuwlMNQnGwmQDRH+IZajm0x28Qq2pDdQaNn2 9tdw+7BbduaNchvYl9ZWzR03PV4YKlw3F6VC0R6pdmhAuPXCFqrlb1HehH5f3z8c tZ3My8H6XWeMzLubIBxZh9y16jGp8I8gAXYy6j4sroSvDj2QR9Ds2DbtWIsbnjCJ B733J4ZzSZ7XPQrpWQTdkgaNbaFBnTmcp2WCyr9otFJxkc5GCJRDKRkxdpLnWyr4 m7+naw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31j7094h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:18:58 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-358df8fbd1cso5348351a91.0 for ; Mon, 23 Mar 2026 02:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257538; x=1774862338; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pxOtgD2NGLF42PFt4g53gf0KWjA7/Alkky956K2USm0=; b=J1ixJ8lKBo/66S99A9yv4YgYPf1KUirM5IKlwOAeeDReFYJdf195538Gt8jrT5H4r7 t3UoPpzlEAttFlDynTg6PH/xMuck7rvuNmkvUlTIdLt8ph+QK8QEHwmm7S6nYi/PqwD6 Nd7l+FdOI04T06jNdf2jVP4a8AF0JjmKyYFJI1zQry88vzckYdZfsXlBpQ3RDCzkWPBU xP2G6uMJBNa9e9ZvfWrXZGlIL8rjax4aycFE7s8ypP3w/YecZbrfMVI9ql63Ta+1TmJK NYFO1PDF3lDEXH3bQvOpyRweVlqenstfQPCJcQyGGQ0SUNzotUQ0H1H9davBijPgxfwg yYSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257538; x=1774862338; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pxOtgD2NGLF42PFt4g53gf0KWjA7/Alkky956K2USm0=; b=VBPrq2gqZLs0fbI4ZzmeDG67G/RjaVXIHrJEuhtAHIaoA0HIfxxlLA6dguYBCUvz4B RnhMaRh2OQDk8KRu5ZuXYiodsVsQmxvEIpdaDPDGSkS4dnLeyYEgax+8znGClaGQccwG DkWMm+kElOSIY/mlGT0NkNwl2uTk3wW8RxQqH8isekRf0YaJhYRy7Jl4lZkGVU0w/jHb 76RhalHlW1gFnYJucHNf2rtCfH1DpafYm2hAHiwkT8SxHfdsAJRTSGnhw4FG7Bse/MPI 9S8D6SPL9eplUPLCp9XIfb92YZEGCrsNpz3JeJgjogSe/yT89En/54H9Rl6H9yFokA5O UHQQ== X-Forwarded-Encrypted: i=1; AJvYcCU67t5BDKdKSyQ+ZBZf5cnDDhfLBtRk8W/li1+jlw+1sDD6bY79ebXHp3hqEo2IIw2WjSZbRUor6Yxxjkg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkf+ZRKpD82om8PSJzhze+v/rWq/szv0rL5BhFiK4XS/VzgCJW T2PyOu81KdPoVdLZfhHA/wBBswqyoC/wtFWEHmc21VAsAuacZiwhS8qswVzP4u42frVnjumUC6Z Y3sSMX/XRL/wIp4aFJG5X0MP8wFzAK1Himdx88pF5C2WHQINpT7ofqX1vfSO9HvcFFC4= X-Gm-Gg: ATEYQzx9Pu2JVBORsq6tqeUgUASXB1GveXePwAb2tBXGzmobuXM2hsyoI47mFGEjc4B EM7hE5hEpcQQNE+z9pc30uC/7KvLUuWB6qgIZesfmEar9ulxMYCVp9Xh1gM2qIk5XCor6uDKVSv I2fHaSayhGGrEdOvU9thn54DRNvKl05sKu7PGCIV5FuNPvaW2heBSXHS6dEGlKe6e9/j0kboHvf nCt5Sy27mt1t+rGKFwZAmuv8VQyygEOdvf4oDPlPyxMU/7JgR3EjbOpgi32FNq9973imHV/c4hi nUmU07OYF9qDgz3RxQkzjcLeWIGCcToFr7OY5gh0txVU1yBVYVbhh3LHd8OH4GbILVtxYPcpdf6 H6mcTaohcHNx56gwY2RSZKVlZguwplrUJ/Fp+/0RK9I6iWSU= X-Received: by 2002:a17:90a:6c82:b0:35b:e4f8:7cc7 with SMTP id 98e67ed59e1d1-35be4f8d75dmr3257292a91.17.1774257537118; Mon, 23 Mar 2026 02:18:57 -0700 (PDT) X-Received: by 2002:a17:90a:6c82:b0:35b:e4f8:7cc7 with SMTP id 98e67ed59e1d1-35be4f8d75dmr3257259a91.17.1774257536589; Mon, 23 Mar 2026 02:18:56 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.18.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:18:56 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:47:58 +0530 Subject: [PATCH v4 05/11] arm64: dts: qcom: monaco: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-5-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1516; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=zSf5B+scx1LHzF3C7LbBC/eyKMhHBwfouTQryzgofZ0=; b=KE2Bpeyxt+9POWeOYoFJl1S7PQnufeCWHtYVTgveOr+XvgBnLh9rgpPsTldA2Gh6Vp0GXWmNS Xe8uo99AM0wDLgJw8n9TK2D0vSedbmuBcBoLlrc+fMymHylZB4Bo2fU X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=ArXjHe9P c=1 sm=1 tr=0 ts=69c10582 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: yoeIKaQXHC6Oy8s50g0fG51dCNBJJfPQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX4wxgpiNZwLrJ jwNVNoT7dhst+S1ljk80KwncqG5SxuUzpi+LfV7cNnrWPjoVl215nJ/BiG9U3xYMAcAt+0RuXax AqwypXQ6l9JbG22Jr9M/pfK/Wg+CwFHa7mrABj+tpNdHR0cSqRnGucUtgtaa3ZE/6cKNIkcyMHr u/SldXhOzekRe/k6FE0/S22oAn4JKU9H4Nya4heCKrkGVJ4ekfn7lPSSkyRSzq9DFKFG4Pss9iM qKzDT/is8XsqfOoThKKAtj6DAlOeOBWGhWgH3yZB//znODyW9uwlG76Vy3gSED7OcodnC3iflbl YOd/mBe6dizvB6IV5St/lsH/MGDifMh+PZD8jFF5+IAdLcpaej4kgBsezVMEpgVR13H7FFR7MmS DiNqstPcWZmxzjRKCiW1/6gp6j55MLBqXD5293f0/9q3YeRBToZk9tXI8ua2Wkqz6mheXT0etIt yLrsQNZgL5yp659m3kw== X-Proofpoint-GUID: yoeIKaQXHC6Oy8s50g0fG51dCNBJJfPQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for monaco. Fixes: cc9d29aad876d ("arm64: dts: qcom: qcs8300: enable the inline crypto = engine") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qco= m/monaco.dtsi index f92fdb1cefa0..e408f102a8b3 100644 --- a/arch/arm64/boot/dts/qcom/monaco.dtsi +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi @@ -2725,7 +2725,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,qcs8300-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 crypto: crypto@1dfa000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A4738655E for ; Mon, 23 Mar 2026 09:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257548; cv=none; b=esW5nedkSMqqhLVNAVMS42bcY85SpbBa9r4/jzxPCg8vIw5MrCOsEKSsALIK4KQjiUkPiKzmbyBPCYZgkf1RwPSEp/8MfN2qPp0tQJ4Z8HuRaTB5I3KFFuhUfl1tTONBnOjRR8FYxtV2DAgHO2ENIuk7ypLiFzhGZp8aE7WT6Sc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257548; c=relaxed/simple; bh=EwhmDrGZNvqtgUBvADKeZk3zEc+b1+NVILPNP1cvda4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tTIafJdlgV9XtI83YUh50CApZcPcyVsTLZu+oDaoQVa86ldW3JjR7mq6sBLTusuTRDFoxKV1YFTaFxrH5Jb7KpkIqsY03P+tZHKYPkTogjCQUdApvQMt665wXFd9HA8D9dkN890jBrP3vRx5+wq64/lCGNN2PUV6p2PhHmB5sXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V4KqKWT6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q/4bxm29; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V4KqKWT6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q/4bxm29" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7tOpe2292005 for ; Mon, 23 Mar 2026 09:19:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o3Bop3RZU7UVuQL/J9eof3yYKpMt9O43PmyrVI9D8cM=; b=V4KqKWT62WjO81B6 xG6aE7zIzb6QzafsgDa6PaOTLYH7KwAJUb9fAlL89r83lmnqM8LgXqRfFq40eqew 7OQOF9ukcTPgjkaDucxQauTCjkQzWzHvHf/dZ1rzje7Unpns3pJ6BzTl3lE/TaxP ae8Z0tPRayUHpUKiQpXhkWok2i8LTGgUfL+hla/zg5iNTgTW2OaZG+fO/cbhze25 8ALxip4erGdaDr6SvENZYy3RL+TzmpRRPcxF9p9zHUTcAOMdmeEhWLyj2311P5nr Tb+n3uuCljmS0ZWRsdKLn8au1EsA3d6mPWHTc/nTuUtZxgUkiSeF5Om58oFLmXDO C4ttaQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31j70950-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:19:06 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35ba237d2a1so3672529a91.1 for ; Mon, 23 Mar 2026 02:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257546; x=1774862346; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o3Bop3RZU7UVuQL/J9eof3yYKpMt9O43PmyrVI9D8cM=; b=Q/4bxm297IpKukc68kSSmewZ+MHpQ34nKuATDvDqjIw2tm6AvOqQ6DUYRmX4eIUZ9Y lujbr/VX2ajQzRZQvmHySmxtHes51OxRvEnf8DZTrCORVB9Ni5Ubm3rZOY8L1TgMLKwp RmtzogORV+1qwHasjwBbb8mb73GjZmdfCBQnVRQlKa1yZ+BzXwKVWLy62CKglJhTx3Kq w5it9EKQhuUUyqYyG+qauffcnhQJOLpbyiO+UZfsMSPHQHqc6H9IozhBBitkGdfYOp15 /GbXw6RWVExAgbyo3JeOWq/fGwvkr09oR2zbsaiFbdJjQ2YaH5DI4IyJBmTu+5oIn+9r AJ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257546; x=1774862346; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=o3Bop3RZU7UVuQL/J9eof3yYKpMt9O43PmyrVI9D8cM=; b=CXtI7lz5kGbGhnCvVrlIdvsvWflfaYbFd21fHsTERuszJpvypkQ+sQgJkGNd3WmbdB zw8LgW2KpdDKboqXJmP9Lk02ZGEkACVEWTpuHhTlA9yXj2p7orvw53TQ/2VGvviuU6WP WaIl+0RPfbQYd4St/3ZzuqGIC9rDj/M6yymUCHp7EpszYVXJ0rkmBtBhgqDY0ZIJsxXE aD1quL1LAaAYpvWZZCiSxlBE9tanGdqTH/vMNqdDytMScVNXjG9eyGyUqR6f8JftmHHM s4DqGeub/kXk+IAXUEw+gHd4jtNmQOsmt1TSKyQKxff853o8Ee/HdMOw3VyAeVTfAo2k Hy8Q== X-Forwarded-Encrypted: i=1; AJvYcCXg93gPVQ+FdNnQY420N1IjHcPF0hiMSwwCP3fhmP1jOpjIrFTtNQoQn6z1QODFbpiSoTnmJiPJiBYtbhk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9eZGcYiZYbL9ZiS1k+28KARItOp4nqG7RXK81bNRWr6Tzdo54 FiKsO1KUPcHgr3k1rIWe3ERhrrlxVaxp45j5cJO9JF2EsMO81sdZWyjMcgrL/l5YN+aophZM2QN prP6opwv7/top7YQeZCpOPHJKK6kUlf7YLRWqMJS85Nh4P7zBf8lI2ndtotNIYdQIMW8= X-Gm-Gg: ATEYQzwnlBPlmKNswNXbKPnYWkSJ27Y6zcSHnoIo+v892PYsq+npeNUj80d8vMef2KF vjDv4zElC6aEYKpZbKU45fEMxQmRKXXMA0mbIB5uTuUQM0BVQvs7KsMigqtk5tIYMIVoIRQoRQe vUTrhtKXUdJFR5h419kSaLJLr0EYS6/gRUDCuSsdLFoUYSn4JSq9+Mel0ITj77ZYwBnkhbzMG9K l5WKTCvFz7E2/aeOiS2X/OwEdZVDSptPvJKFqBlBIAscRTuCo8CaLJWviWSE/8R/ReVbjIla7KC 4oJmBMot2fW2+8fQ3uFtvow0wCYtD/MDt4FF28MQVmhRCamx5W89Dm6NJ0DZO4RIiZVfHpvJo77 eYxq5HFHv5LUNapL1VQExCUcfPWil3zuwaqAzAt9vcMuaai0= X-Received: by 2002:a17:90b:2e07:b0:35b:a0f0:8327 with SMTP id 98e67ed59e1d1-35bd2719d1emr8246524a91.2.1774257546299; Mon, 23 Mar 2026 02:19:06 -0700 (PDT) X-Received: by 2002:a17:90b:2e07:b0:35b:a0f0:8327 with SMTP id 98e67ed59e1d1-35bd2719d1emr8246504a91.2.1774257545762; Mon, 23 Mar 2026 02:19:05 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.18.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:19:05 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:47:59 +0530 Subject: [PATCH v4 06/11] arm64: dts: qcom: sc7180: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-6-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1472; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=EwhmDrGZNvqtgUBvADKeZk3zEc+b1+NVILPNP1cvda4=; b=vT2/ftKHtEaH7CUVN4lWEQEvuEdYuuSb85FTBKC/vZ/b9t9mf1oHpDvFgKk0blZK/KoN8A6oW a+0dbhGyUiCCkCL31W+BaHE6h1JgfLujox9nBV7lg+XBhItpQx4z9Wf X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=ArXjHe9P c=1 sm=1 tr=0 ts=69c1058b cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: piqGUSYMd1yVFLDgEq4qL8sd9OzPGzIc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX3GqC/QMifJBv iSCln4nr/YoVCxNHI4//ys2AhZCincczsmRYctO1FyoWooBVQfh38qizOJI2clkT0UL4QX1ShZB 8zLgpiGADKXitpw9A7nAglJgtpkatIdqcDqABmuq0kVfcBwxzpqel4CjGEvCCsQ+n08pCu27/cS z+zFYBiNczrlegxbdRwR00r8XidiUuLXf8+cb9Ezbq6GaQGQz/13Woiu3F+YC8T5251phVvEs8S /AkT/MY7vRRzMlVUCsG7oE3IrFvjJXZBG46uUr8DYWvvucc5eRK2ypohsK4+NUGJFNIui60SIv6 zJqd1I0P7p0TRtxhFLbgFtHhm5DEXGbLrQXwGbUO8v9av3sddvepvIpl/hoBbfjrJZ4KuKt36AR yLqKpsroKDTbdfGUEmaWPg2S/MUm5mUAppi2WjOUgIzmFOAJ9JzXVjRpUzgOqu+9rVKjaB7rUmY 8IhyDJvlHPwTt5ey6EQ== X-Proofpoint-GUID: piqGUSYMd1yVFLDgEq4qL8sd9OzPGzIc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sc7180. Fixes: 858536d9dc946 ("arm64: dts: qcom: sc7180: Add UFS nodes") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 8d69225a4271..9eaee5dc824c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1605,7 +1605,11 @@ ice: crypto@1d90000 { compatible =3D "qcom,sc7180-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d90000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 ipa: ipa@1e40000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A74C2387348 for ; Mon, 23 Mar 2026 09:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257557; cv=none; b=H4WDBQTJMuNuPKlk5IKiJj/1wimivKMiZc/tEei3i4NZz9u5NUCFiQWy8v+LjNUfzh0azBkrXITupGxTq6qei+VnLtYJ/M4KiXhja6C4h7WVhktkWs8wX8hFqgE8ETp1cQVbAkndWDF/bE4gpVu77mBRrGiLB6wYzruoL5Zp5L8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257557; c=relaxed/simple; bh=LS4FXm8KnlrTRJlZxpGWlu2f+zGJuXdncoQPyY79QG0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZUuAkNUocEdrNTX27qIGQtwkZ3gEP5cMItUMKERkNW0jx0EsNvVsLp6pbx8kmSH/h4YUeN5tLpiEFnZifZCcbmxzZBnGFhb51ncD5V7b0XX02X8C3HuS8PxQNF52urOMtu1jX3geQrEP48VE5G532EZuxBqBfAlnADj7x62sOw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CfIH5dAX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AkunuRhL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CfIH5dAX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AkunuRhL" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N4PTxR2754488 for ; Mon, 23 Mar 2026 09:19:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0kPiIhTgCf9OoUIvaI3Ju9pKAKStgsxqhL0qjTgECzE=; b=CfIH5dAXHmJjhTex A2CjDdvi7Cqhz26WgkPJR9mELbgvlucLaeFaF4vlWSbXA4KtzF24Ti3/e7iEgZab f0EWn+7xsRDITPZ9W64SnnVg2LtowA8pLmZafC6CDgpLpHwO1m7IzA2IOiL1mgDr JhlAUhWFNE65Az2jXX8ySzPHzcF88bq3e50qWf6pHdokI975EObzp2Jro0QMTKGO jrz+yYCZOu+ACOOzQlB9wGpmfkiSMOHswWVlnw5VpeSuhjIbvdHivyX5EAyOk2jc g4AGQyseUEoUpEriRsoiDMXG8uhyiQdCSflYR+ORjaUHjwYKo1zs5wVef/I3fUVM FY3mFA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1h1e4t9s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:19:16 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3568090851aso5100081a91.1 for ; Mon, 23 Mar 2026 02:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257555; x=1774862355; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0kPiIhTgCf9OoUIvaI3Ju9pKAKStgsxqhL0qjTgECzE=; b=AkunuRhLk8zN9R2Oc4hrDEOzuzBnRpjogSqgyf+wPDSuyIgGQsd+S6u++H+bu7erXa 8JxNZayJFOt8EjIuVYCKQkHsWGG9LX7b45xChrq60umJMOHha7eYZhS3nZpQH8tIhF87 i4GUKvZqEHdDlVbChstF/3bAxtk5ROI4Ivrq2yvClaR7EVK0Jb2fxosw0sGey86sZhLl QpkUHMKHOEgZyuSlPCZHX4tQY36C2F5ruxMclSofgUYtTLvdsZbC+NIwPpbvvNHoxig2 uSRYTEb62qEnMgPSUSKyPq2+aWU4Y6fnUZIiuRoMdg9bvauNJqG84+uM5YVOCP+K8kjW RHgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257555; x=1774862355; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0kPiIhTgCf9OoUIvaI3Ju9pKAKStgsxqhL0qjTgECzE=; b=ONmeOa7aiLadVkMiWIEMll3TuhxxKKOl2GI6wkRk7xLVdKmMViDnO0ftYb3D9FoVTz Z1mPz4xDaKS4dcC9rSUTHMlxz0J5oz124oXSUV5wGjx6l4+4in8iYitxSRGrxGBGKdLY 59EsINljfi7KpT/BTgVKLKrSz6GbAhCTpd+6Z3SeD3F7ZcMtIBc+xMtnDmXtYPWuwwgF shKqeojtxUYtbG8rosP0+qUi9X6ENuJn2z2ItEts8v6kwKRU3pmttxFKARZPlicnztwx 6nVQMgOxdU+o3iKKkBvxOoYlPHG6EvHkaGFkH6b5eoQXg6ZjsiSSeCJw0yDNyc0w4Aol kAHw== X-Forwarded-Encrypted: i=1; AJvYcCUKKHUNd13nDT8Sr/0xa35XFawM+fcpV/8glZ8AWInGttn0N4NunBoOsOtM4txM7c0wxBVyIOJ6Cu0uGAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzGmfEMT1mjpEIgxWOygeEw16Vc9GhjCV0eoKbCYBtVj/tnA6eu jPQXtOKmPv3aV7YZoSeOzu8A2FdpDkb3eY/+GZ9+Nww6j9tnSdrgwffMnR7wd9c1qzabQuh+lQt kK2i0fBwvbgjrOKmd0Z5KOHjiMnlFHXEMI7UuZByhQWYmWZIr+ZDi8Z6/NpoGbRhiiPQ= X-Gm-Gg: ATEYQzwHU9aAIFFbSaB6oHPB/lFE7rL2Az6PCgl1UwVbKmfY15CR84nAQJZV4TSryV/ Bb++eZlvZgC0nyvrRGEOc1rQS2RYRwSraaIZ5QYcRMyzP7hfghUErMuw33WAuebhJuNs2vPVQtB aFvaHIZTUBrCjp4uFKPPljS7oU++9PbMMUfnTWdiak1Eeh2c4k4G2y7xFMtPVy+EogKBrKIdlu0 43aQMsZ13vdG8qfjhBTdGsMoGeovQh7gvDSwz1D0Kw0NvXYAyre2EtWztAXktuuLsfEHLzPqkF1 VSLbcV8Jj/ZAfJcR7QiXHJihwf9aEaFG4bRxQaZ71npR0FzVeZJZ2fzeTbjwQdZ/Mmdswwbh7vg GXIsqBtCxv8UJjoX8q8NN1PD7bo1rlWx4cTNG0mNi2Ky+tBM= X-Received: by 2002:a17:90b:35d0:b0:343:7714:4ca8 with SMTP id 98e67ed59e1d1-35bd2c69ef3mr11216532a91.15.1774257555423; Mon, 23 Mar 2026 02:19:15 -0700 (PDT) X-Received: by 2002:a17:90b:35d0:b0:343:7714:4ca8 with SMTP id 98e67ed59e1d1-35bd2c69ef3mr11216507a91.15.1774257554914; Mon, 23 Mar 2026 02:19:14 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.19.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:19:14 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:48:00 +0530 Subject: [PATCH v4 07/11] arm64: dts: qcom: kodiak: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-7-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1513; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=LS4FXm8KnlrTRJlZxpGWlu2f+zGJuXdncoQPyY79QG0=; b=biRYorjV9jV7YU0YAsnA5858q5QwIrCqCidA4lchyItfLEu9ysEGLe/XL8uHLOG3QJl06gLZ8 YklGA+Hy0nqBxf57auSkbNCDdiMjzxsQMdMCc+jIs/2ibF5OBOPFf/o X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: o94B4V9H2Xuaezulam9GpQnDYurm2t-4 X-Authority-Analysis: v=2.4 cv=epXSD4pX c=1 sm=1 tr=0 ts=69c10594 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX0AUu+Rt0ZFZ8 AsEMp57trKTmYHnwVTXvILbse1ny7hSMcbRcR+o0/eskbzLk+JYvvZSG8BpPoWm8rMU6ZaUuo+3 y1eb/1GnjqXslkNC22y/Nw7zKXJwPCYj8/I7CGuqogbnxLS3iShQ8cTCajzEmmb3yYCQ22c2lLh KTA4lpFSi81aeaAGbRYIPxEZa6RApcP/JFt0G0mqkoAqcKrZ8pX+zehHGBg3ygGccTpQEGt8nf8 cQQO5Nnb2ZX2qf/+Id9eQ7uOAtbR+NpB/7qWykikYz+DHEdtIAUo64D/iCH+BL5ILkiH0gh0RGW kJVIxr2v/kqpPb5dBOYjWrwxgx+q6tJ6+v2P4XWPLiKabs4Q/veCXZ5xQeKpWQ0uw4VnLmhHpFm 7QMtnPDE3LQiugxRJet7vpN69dIbHPC15K0MoEAd7+2zcU4WDyHyPy2BWE+gGm6+HYdc2pCbHVS Y1GzRJA2wZ59J/3Y/hA== X-Proofpoint-GUID: o94B4V9H2Xuaezulam9GpQnDYurm2t-4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kodiak. Fixes: dfd5ee7b34bb7 ("arm64: dts: qcom: sc7280: Add inline crypto engine") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh Tested-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qco= m/kodiak.dtsi index 149954a3eb7c..9765bf361db4 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -2579,7 +2579,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sc7280-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6F5C386552 for ; Mon, 23 Mar 2026 09:19:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257567; cv=none; b=fusgqFYk1yD+repoDJoVC801+27N4wf31uRf+qVm+UOuD2cC+LsGHUnDid9TDZSu5yzeCq2ur3ZIT1iLgkxYwOQ69E/ufhF+w7pjAJ1DEOKObtFpJcJH+Xz6FgD0yTaxwH7R5Lscu6ks5AbmC+5d41cUbMW65nwXacU1SxiHq/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257567; c=relaxed/simple; bh=wxVSM1cYZTl6y1L3GXr9bkltA1OdyoyjM33HQ9eQ0kI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mYEG5bswSqjHMetaB6RppQ5Y2MmWTii8Q5cjjUOb2w6h2NbiFowT5SWLd1sb1d+iobtHxT7YuGkHtr8jK/YZ1KuTMc3Z5JegbZzaHS3JBHlCfZXnjCUZYf067ftYZ4pxIWMdC4TGBz5blkLlHLVRWkAL5eHc4u+bpW6n05jcR54= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eBGH+7Dh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MnCWwb/j; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eBGH+7Dh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MnCWwb/j" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7tV1H1627086 for ; Mon, 23 Mar 2026 09:19:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= exWlhEApYdywyNwd+GmQdD59+nL1iNRjBE2wEh2mEWk=; b=eBGH+7DhjUs8YHvm f57uM/Yp79YWNj1knWOWUkqnSysJs80rAZZF6QSxRBtMSOotTUzExE48LfnR9VTu e6ABvcvBL4OjWTL9Y6slP+Qy54MxeRSBz/JI9KOoaRonbGMI74cDPOo/vfVpcG6D b7zYRWZsVSnNhMofPeAop2ll662LBCoeY+ElUY4pgaQjUFmFmQi7WrfYsyA9/Vnp TpeMS7VxPzieIqvFz/kbe6BWnArI8MRIqBV8WNuYQaO4iX4N8QL2K4sMr3nyAPSh 0lcWheAiJAhxUGY9xuX2QgSCepTnGldsv/o9encg1RdPLGv/z+UTcDfGLF7BuNIX 9357KA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc09dq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:19:25 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35a0337930eso3907334a91.3 for ; Mon, 23 Mar 2026 02:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257564; x=1774862364; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=exWlhEApYdywyNwd+GmQdD59+nL1iNRjBE2wEh2mEWk=; b=MnCWwb/jQdevjK7GuDd9F/yMybhi0LvSF9fx0sOJqmkm89DNrrWMKJaGcjKwFd1A6A PYxps9ELBPnLS8uNDpz9KQ30G0kBCnpk83agOoOnm0jDxH7+55C1GwZ/S/V3pBfNSeM/ jbcIw3zYDOVhZpejmVJUz94kjiUG6+/kj42ADP5OrjXbJbedg2PyfuPhwEszjfo2tNBI +gK3NdbsP8h2LqHg4bHmif6d/gFvDdW8bTDUBQxkRC5B/jgKLwB0pdwcfA7yyyf7eWl9 rZthJlNk4ukAhzycYyVgmYnpUybLWLyvsGgJM7EUqi21EZRs9UtUXPXJ7JZNnNNwVrub KY9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257564; x=1774862364; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=exWlhEApYdywyNwd+GmQdD59+nL1iNRjBE2wEh2mEWk=; b=N5ioNfOF6kaPwvabalT6Zy6j7sGlryoR3Akohuyyv9fAQ5ZeHAMjlPhtqY3VoJmALj ogHvOGZfvRpSv7tkrsdqXhgJkMY2uzLFhvxO1s3L1RiwBVo9iQbOnGe2ciV5gtbdsyCc UtX47wPnDkltgTiRI+l2KNcBiWRFTWBEm26X6pttAQnjpV7FTNm+GmNJbnJWophQJGuU IBwom3MC/lcWdlWxK0be5OhxGIofVjgR2bx28CFg2jKZlF0l/xLUPtpethoS5Bz93n/w 9zmmeQwM9Wv/AXaSo30g3S+Xbh+ozrcOMSXXz6qMsPsKZ+wJxN25ONAA2R0yPpilBro8 LpVg== X-Forwarded-Encrypted: i=1; AJvYcCVFxgTRaxx4dkv350awxjoq9CglsAfiuQt8311wyi8vvYEVC+uqbghYKvJ2PAKKSqen+fJ6tkO0Wm4vO6E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+r+xzSqvaG/nYgblfbWRxaSl7dbArWWwpEX8ZNh0ODN6WcTX/ p+dqtLKfnnizHJ8vrJ7rIw9de33Egi98bvGZoEhBZz4BFL/8m70vjFIy1y9ahS/gX1FDsbcW139 QUA+YlCbjO/LrJfJaQBVnmnD4hdj55m/sIZ+4ae7Zq7RKlMj1ytZXJ8+fj5DBvQ+W+xI= X-Gm-Gg: ATEYQzzyZO4lU7MIdCDgq9ldzWmF1r4NSjucfNYhUezt7GNv0WGa8C/EKVsMo7k7lQU piM33UK58XfDLaUU+FbiunmRyNOGL7ELBKZ0ykYzx+SXDOoSA2roikbcpquqdxzNjskPVJUmSHK cnpKMhm03UDWYE5AkTcOwnOhSxyEhyn34FqNJwHe6No/8/L2Tnt4SRy9hiBM7NH0lapdxCxy+Gk aaZ1vYSHZ7Lr6n36qO/RjYUdp2qGzAckrAp5ay8NXxuXnxu46nePCbG9P/jO0L43j/GItbna6Sa QeKyC23xGF2HQioR4I70hsLlqPdXLQAUL3ub3+mASjhjg7sfPvY93bt4IK0go7Ro38jdCgzIsGh IfCt4pYwQ4PnWbETaFHFgQkBCTx2QBIKrvub/QiVPzBa+tCY= X-Received: by 2002:a17:90b:2885:b0:359:8abc:b348 with SMTP id 98e67ed59e1d1-35bd2cb2af7mr9861348a91.18.1774257564501; Mon, 23 Mar 2026 02:19:24 -0700 (PDT) X-Received: by 2002:a17:90b:2885:b0:359:8abc:b348 with SMTP id 98e67ed59e1d1-35bd2cb2af7mr9861319a91.18.1774257564026; Mon, 23 Mar 2026 02:19:24 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:19:23 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:48:01 +0530 Subject: [PATCH v4 08/11] arm64: dts: qcom: sm8450: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-8-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1507; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=wxVSM1cYZTl6y1L3GXr9bkltA1OdyoyjM33HQ9eQ0kI=; b=pUdOurWSPgpn1ni1io1/UnjF0vJ6gZka1Qw0Rmj42Wy2OqGRU01i9289L1PtNwdkUZDvqQEzm dTS+THhcD1SCjaGhNMrWXhI8cl6ELNkDJDNtmRwH8rdED+KFm28jL/O X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c1059d cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: ZpkETIn91x5LlsEkkrIAXTCNHbyIMicP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX0Cd/qUydpx5w /U3pmffsuUDdXi7Tx46bPIbtRdNLR+p8i9GoLAUM44ggrYgeQkbKwpy5bA0uUUiUkocz4A/O8gS 3vE073oL/JRhw1oXPtafBc+TciGSSFYbI+4ghlHhmwN1xZ4YjSYN61aq8CEnnYbTk9os63jrO02 B9o8+jAuFQ4xD7GmS6wW9kHdLm1Lj2WedCuRckKat23DW8KuU7P36O/Hl7KdXhasF6bzSAeYHbF qtb8g9x47bCMGJy99qNnegC/f1sV3wy0WKcQaFESPW9Vh3LVa83Lg/nO6CEOSm9dzk707TEsH1d yJ8ZV3UMYcgniPU+5Dt0e4BsDCw3oX8tpPXwVLtWRBIJSqanCutJINUTgm9EgC45MBFhqYhx4KO kY97FJYXY8G9h3dd5amR3G4aGsaLYhj4XvgEFBgkc9Nm+UA3jwIot1kI7+xGgqKvKJHXvHSwzo8 klg1AFff+rhAGy+wE0Q== X-Proofpoint-ORIG-GUID: ZpkETIn91x5LlsEkkrIAXTCNHbyIMicP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8450. Fixes: 86b0aef435851 ("arm64: dts: qcom: sm8450: Use standalone ICE node fo= r UFS") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index fd2d5648b92a..0dba282d644d 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5374,7 +5374,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sm8450-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0482C386575 for ; Mon, 23 Mar 2026 09:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257576; cv=none; b=flyri6pN9RY6INS4/v1RKSWpyU8GCPBgTAtYl4lUvJnzsQmxKTFc+HLrECi0c5I9Hg5OyuPO/BHh4bbguTm3TxSxV5Tgue8fdb7D8N0AHi6F2gkQtm1cW3ZZEME3G2NidexOQoCSPb7vU8Z0PfKY6DQiYqOPkwauh8QnTMHuXfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257576; c=relaxed/simple; bh=VhZ3aS0klwApf9YYw27XCWDp7hkJBDX3kx95A36/HMI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L3/RFESXX7fkhFlotGkHEzOEwXMsh7+++5DOYmm5bsLQCW0Q5yzksJU5mbeeOhI7V2085/ZYFQy02kRkoKTFKBFXebuFbalP1Vu7rfbRnB8Gjlw5CZ/thcNp6GxKMZZyLn2C5VMXLYmzkxImt7gyuEVNjeT+Uq6KE/VEQGT1/vI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=J7qroGpg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PSDJiIHY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="J7qroGpg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PSDJiIHY" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N71SmH949420 for ; Mon, 23 Mar 2026 09:19:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qbF3nOR2X7bJ5MMJnZ3zYoEV/xjt9CKDyAMFmhAWDnc=; b=J7qroGpgmBeQpDT4 gxLyw36ZUFsrHXM6/2Lli+APbiJrbnnBoBgq2Cnafj1b9/YscXlCE/acNF7r8b21 EZxXCStyRBAaMPbJz6pN6OV99VsGPgCYC5UCp2nOmnWZxkAZRTyp0ERRkh2/E3LN epoAlU5FzhLFIRGzYgfmL4yccC1tk4fACtxEDetswJ0CAYd5ARJJewYY3iTkwz0c QP0wtPiKecRXfa9YYfpYLFTz89UnDsqy/wEiEQlp5m9jH/HYBjsPJl7ayKxIlY9Z fgzuV1obNrFd/vVJUeo+PWKUub3d9XsZBRnHXuEcz4r3SC+eg7+iIR7Da0S6fvX0 +kuYMw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1mghcj7h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:19:34 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35ba237d2a1so3672908a91.1 for ; Mon, 23 Mar 2026 02:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257574; x=1774862374; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qbF3nOR2X7bJ5MMJnZ3zYoEV/xjt9CKDyAMFmhAWDnc=; b=PSDJiIHY6AjOKA24364OJCSVI6pKUNNDjovJamibGqFVo2sMbR54UWeGvMGREuCs+9 0k7iBJS+NyyLYNlvqkmpPtGt7naZkQFY5a3B/e4kSbIwJozy/at0Dumrwn1l8rP2pilD jP9Mk3EuFDBXMgGBBeAuwAj8xuczpkg6DyePHDSSDOOJR1bbTE5qx1zfJ/LPg94ZU1c/ ePhPuT5RBqLWb5WJdft38VA3QLbZ3zIhYNeGJCwHG+9SnogWA9ZYtMs2Jlq1YjF8fp7o 8+rLFcDwp8pVEhCXiD7y9qN1MnR+H/yCML/jRew/AYPYA32okNZu2WnoZlH5E01jyH6P PMgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257574; x=1774862374; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qbF3nOR2X7bJ5MMJnZ3zYoEV/xjt9CKDyAMFmhAWDnc=; b=F6FazI1JPBxJfOh0Fm134TLUzDqjjOdZ0CD0lU4oyGnzGx9y777Rt87uvz4QF8FTNA /mPMioQ+wJHB2t+dIRlJI9m6Bo84hvYuf6lxGjsxtKl5JfDAzC1FKLXEjZyxD473lmlc 0lqM0h5yT5FlfC5s7TM5NlR3bRsWYPZOWBhBX6s7uN242VFRq0T7S9AdqIPjKO7Vg5zP j9+ox93xneXIHI9FTAgv0hK8KcW4Mu20seS8j7ISHWHkC+QwkmZJRK1LQe4co377kJJJ /g3pqnBhvx0QNn+Op9dEqQdXuJzebG90gEmjL2VQDmCB+N/QhWSadGMYMhnTE9lnsMZj 6xOQ== X-Forwarded-Encrypted: i=1; AJvYcCU2OPbxUevX+d4uWirrBTqAwb510j8JwWJ8DMy3nRc5xrPFjoKSwavJctW/QPDJFQrjY/Ro271bG/euFrg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0soIbowITPTroOaWtBZ/AmYyR528UBiYuzpNXDaMiTC5g7XQ6 x+VzXpNX9/g1hnoJxgtHYaNag5tLIjkifj+nVbflbjk1rCLBvlhWLFbS+7ARzXzwKyfQZnmRpju QVCejcnx7HyAUdZuZPDrjqCx+enW3KEAeZMnNTGCUenNgoq0QFrfzQ9BLwijH3NWNZtI= X-Gm-Gg: ATEYQzx+tpFeZAbgN2Tvi2CeFq2nBGIH0Kqpwa+TWrs332iT6lUMtg7oTq/Q9neG+Ra ke9BBqjhsIIFKWHgqhWsXGp+uctwmZqbWvDUGtjO+I+EMJ7waBnRVnRDm4lEEOuJ/03VJboIBcv L45FlbXasQfF6fyMP8J3ySatDB0yq/375FM79KERybhFkBTHs33Im5Ng4sKpKlV0DexegWMNzNC oxlBTvRVE4ioFB+OMLqFBglolY81aLbyEEXnPnEsYEuQaHz5Bx7viKd6WG78/GPd7rQfFp8egxH 3zgy43xJta6zTOlHx+gpQkn2Xq6jwRpdq2FB1oNs6m86fvgVbpv2hNJXimTgDd3doalzB1V1etZ yjP/8tpDBhCn8eAdX8LxBMqpV9YC0c0NVwGChhz6Mb/jH1BQ= X-Received: by 2002:a17:90b:4a50:b0:34a:c671:50df with SMTP id 98e67ed59e1d1-35bc60c773bmr12847269a91.17.1774257573678; Mon, 23 Mar 2026 02:19:33 -0700 (PDT) X-Received: by 2002:a17:90b:4a50:b0:34a:c671:50df with SMTP id 98e67ed59e1d1-35bc60c773bmr12847243a91.17.1774257573015; Mon, 23 Mar 2026 02:19:33 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:19:32 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:48:02 +0530 Subject: [PATCH v4 09/11] arm64: dts: qcom: sm8550: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-9-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1452; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=VhZ3aS0klwApf9YYw27XCWDp7hkJBDX3kx95A36/HMI=; b=ziLvrmXi/u/Ru5MY1iY728EwAnpE+MGrhcdKhsiANprQbYqGR99rEMr4wvVnevpj3WKFmQYSq QiFkWFwUBYSBsN/f4yKFjp29iA0ehzJ1CU0MtRz7InoyKUilMzfpBSO X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=HI7O14tv c=1 sm=1 tr=0 ts=69c105a6 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: xzyO2fQ4cgGbPvQvHupWE2nQuOns0k-d X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfXz75unysZSEOR kJ7mvqtAGAp5Q1HG+ljfpyu42PXOieTbZo1WATffSmScQNYXA7ocO47gbY4r6S2aRNAzx1CuVIe 9+JTlnKdHykX+bFvUM2nUlN78n6EFmqryab2i2YKfcM6H5IKKnfnqJdm462aRaSk4Bd57zG2ADW 1Si6yyeJBnKkg0ZWtvFteNNJi1jVCJpylKKQDGRxBat+v1ZI7hVFbQaERL1obqJi1eLlTKykLB2 XdGD3UXlfUr41THl65oInUs3bvL4WBANRtDqRdAlCTC6Ecc4dEX1PzfTnNEFI3yZLNKpVNDYJ60 BUzow06rLTvZsz/kk260enYtcE6qzlS1IunFWSWxwHlVV9a/JXJHvDGFwurSeNtG5sJgrhBcajN sRbt7RMMBttVvxeBz5vaoJ/VB3Ugv5yqPqjaoWV2Gr9bXTyntZtkt+DR98d7xE6jEqiYl+Pr7BR HOlo8ms333TqL9duB6A== X-Proofpoint-GUID: xzyO2fQ4cgGbPvQvHupWE2nQuOns0k-d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8550. Fixes: b8630c48b43fc ("arm64: dts: qcom: sm8550: Add the Inline Crypto Engi= ne node") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index e3f93f4f412d..473fb4748036 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2449,7 +2449,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12A4F388386 for ; Mon, 23 Mar 2026 09:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257585; cv=none; b=ZkXKkeFzsVzyj1jX9jmxGmkyrZhCDczWcCIcnzVKl0RIMXXP5SbHhoKZAeYlfwvCNIfgzKqrk4v6XtQcUm1r1AmwO1InnJrsFphK0Bt5ndTBGYp25pMWIil877DUrQlfbZaDWRs4zBSivIpVCBRNVHSD5Nl8ovDdmGD6w4Ds+oU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257585; c=relaxed/simple; bh=Fih3H3PK3peo75HwJmlC27QMm4Iy3NsQyUEJpIpUgHE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UgBNJly6yQPZ1HA8ewBx4EHBn64GtFFWXEp9oZckTXdiNtVWlV5a18seAvd3rBAlqzk0GZ7YeI/xHOeViUFDWnnhOnDfDpApyKEXkwy2wPd22dd1BcuctKBAeFDmpn2jDMHJZaVInQA0gMka34PEcKp2Xf1bNq7AS6lkgpNd0pM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dYtVPsuH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XduWYMLG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dYtVPsuH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XduWYMLG" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N4Rvnl3737826 for ; Mon, 23 Mar 2026 09:19:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aalq/tAtENNGL1pl0pufJMN8+g9gmCvXgFs8/ig8bUs=; b=dYtVPsuHfCu7VYOt OD37JqTZ20nJnW9bZUtn1iQASHtwouxAQu8wRsfIUvQO7/KiibwymhQFN1cgb/1r gZN4r2uxXifWlWZAasf35iMfdaMnXDqOpAs7VP4dn4Z5KlWTO2rVRYKYUnngQ6Ce Dt5ZQGdxSt+V9Y+mAMrFScTfb1XsMp9iHILS8W1m7ZE7Wz/Z+JjbFR769/yGbiX1 /VNVnXhC8W3/HCpar2v+7SeM4NDu09Sn2C6hxb3DBV848LKjOWbL+srw+NatMNtP vb43Fv4CRSeyJVw5LVQgnx09C3PrVSx7/HW4CO9B0GTzKkQqEHlWvn1HXIBUQcMu D4200A== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1mghcj88-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:19:43 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35a0998a441so25940509a91.2 for ; Mon, 23 Mar 2026 02:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257583; x=1774862383; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aalq/tAtENNGL1pl0pufJMN8+g9gmCvXgFs8/ig8bUs=; b=XduWYMLG1jlvmh4s+1CghyU6d/QFXGynB95x/UR4b7oPqDvN17/oFFJtCeZ3BjOvGP 1YImmbV3IlSL04ZceZNP79JCBAxJR0jZqatLWSayfatr5DWQ+6pK1M+DN95gSI+8W6cz vkDMCDCWJH+O+scItguq+G1lL4EgahBhM25AcR9DLGnbL2koaJi4oZhs2Q8wGnvT6o6S +/oqsVxZNZXwZSsZ66zhFZ2GhxJDfMYalKi2+UNiOJ9xFlQXjeChJ53UA4nygyMQkDmY ZXEH7bo6IEGlE9LJeaVL+fpXLy83eoNhfXoOIuJxJ71sEZyYDXIZPoERUnoYLywVyGmX E+KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257583; x=1774862383; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aalq/tAtENNGL1pl0pufJMN8+g9gmCvXgFs8/ig8bUs=; b=DVSLjhWDEyMc9J3bkisMB7QwAL3pl1A5MbGIF5EtvPYEDWTLqwFumIRkOodLjZy5u5 8IwcQ/6GGJTNliIQjzx3xyizOubsnxmCiUWEs14PkKx0kNP5iTnQvx9SMxw1LIJg6h7D W0DDEdUfd/bkbEwI23hGmCQOrD4e6WQ3W59xI03rM6x6W438E2L3rUIa7bZkk50ihjRh XlUU4L9hSv9UlmtCUZy4Jvwhp7rxj2BtGQL1L2VBBbus5Yt5ygEe48YUeyoaQV61h+oX hfpGmKF4INKMLCgxlxN+y1l1m0jR2rGqDVXcKbI7xrKh90RIH3/IE+L+yZ8YGhzhlJ1k w3kg== X-Forwarded-Encrypted: i=1; AJvYcCVRpGWAoVI3YqMvj0flv4NmFC5Khwd3jjqFagtLh5OthE+bwckvCSaY+dNTbh8KTCV8kT7sSZT69YpXFoI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxt8MaiNetwSdm0T4ed3KoVP1KXGxpTe6grJ4wB+T7JAdRhnFdl FsvBxY3nW5USzgXu5BbkHGWfpEAG8rJs9H2fqHNgM3bm0WoxrZuv4ZV/cSq7CHbzvXr7VZIdC3n J9iPGWqZnCy8feUNcrUfT/ORMuhBBpvB5dirsqz206RP1aNX44BwUTUbeNm0X3YLZE2M= X-Gm-Gg: ATEYQzzDqBDQaX191+zy/T4HxIRsadKkTebN3rC5xfk7nLKjnFbuMQ60FVEFCTfvGWR 4/im9FptQCA/k/GtX4o83SLD6qUqPOEPOJ/xHuntHmG7yd/Cf8fQqFdQP4tTX6zJ8jJn8TepmE8 vWa6HevNvETtRVsDvADduzheoKNjUFK3x4Lpl+IORBwkBPLB56ryZRSpoqdMR8KnCGSDhJSGVWd r59iV6eZyETFbCjdGIM6Jh+ZqQutuujwSWnFHo6lMk6CLlFEHT+a2F/4IxdaoOk/0s/s3xWEFD9 DwlJ3tU47iNBpMeSC+7YnCZs+2oHqxLrMu224ACcAfTZpszqc2tA2f3bYOc4oPt7TsFaTa3HEM3 fwYUgBvP0I02j+coYTtV9YrBD7Ce2l7vBnYUVWuVnkY8Q0no= X-Received: by 2002:a17:90b:1dc1:b0:35b:e671:a527 with SMTP id 98e67ed59e1d1-35be671a6c5mr4626577a91.3.1774257582758; Mon, 23 Mar 2026 02:19:42 -0700 (PDT) X-Received: by 2002:a17:90b:1dc1:b0:35b:e671:a527 with SMTP id 98e67ed59e1d1-35be671a6c5mr4626529a91.3.1774257582223; Mon, 23 Mar 2026 02:19:42 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:19:41 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:48:03 +0530 Subject: [PATCH v4 10/11] arm64: dts: qcom: sm8650: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-10-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1465; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=Fih3H3PK3peo75HwJmlC27QMm4Iy3NsQyUEJpIpUgHE=; b=p3n776ssmKlC9hQM3oCpnh6ItzEMnUlx7FtzWZVKAA5x3Rrj4zsHHqFZpu5sRP/TN5y+FNP2K jCw8dzrfM2QAs9JrQtClgAVCafZwDj//YP8MfBe/I4GmXSp6SxLo4OB X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=HI7O14tv c=1 sm=1 tr=0 ts=69c105af cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: BcMHlP7zcIp3qNI69ig_UpaCu_Mriw-- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfXxTMm+I/M8MGe oQ2jFMdvayBDuB9QTKLp27YVoEu2F2Tdi9sPeeZQ4+UjX8WWPMJXTuDLVIqQFXLVOM6QqwZ4DZW U8P/skgRpLdoWg3PdUjtSBO9icDfDC5Ar0z1KhELLMdiex7a0rvd878xBDNgd1egxB9NWRANJBr gKiTdmvRbPgGF7VTCYU7bU0LoVsHIszE47phtu3G4vI7NFb0FdRQCEH303AdysFs0dgvKNrAhYG mcrjYuabQ3sXE6cYmwWXqVWAEfrLWuhNFJ0yx2EsmHEJsNkUVmSxZeusBpDraCl4n0ZXGFSfhPr Qxxsq17nAhNDLnZhIm4hoHzzWRziLHvLp/Lz4TuurTaFBamvZGUDeyUfbrNWHbSkHZ7MbJFo14j KCFu0jJZngKmJKKvblPkOcuXqRbFcR/O+0v27GWNfNQ16/JNSVNTMDB+rqS7OotyP7pPU2JqaQJ ZFUA0cbhHH04T3PyL8A== X-Proofpoint-GUID: BcMHlP7zcIp3qNI69ig_UpaCu_Mriw-- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8650. Fixes: 10e0246712951 ("arm64: dts: qcom: sm8650: add interconnect dependent= device nodes") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 357e43b90740..d211bd94fb41 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -4081,7 +4081,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Fri Apr 3 20:59:43 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5DF3890ED for ; Mon, 23 Mar 2026 09:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257595; cv=none; b=q56n2sHQIg3LhxkBw4urIgUh/xqg/MCMAR96LqC4E9vRLKrlTjK+I31X4kSsQSgdDnz+XDp4Sass5Bbo5JV7xMl8UlvjV50nQuqwwjttzfOa8bldEP++7xaDbJdj1PbqRohJEYbaN18g3lJDZDrKNuS9Wpl2MusSJGfqoYscoQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257595; c=relaxed/simple; bh=4gCokkHZ2GjRf5B+A9Zqx/4PsUp2LAmyJ4JNgVsWI14=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CEo75jdAkj+UNTMXOg9yC6QgnRe5gxCSFaTMhYAgUR1WBkbfwpGnFossQglV3xH9mgCOThwOTvlcKA3KJwH862KatKNl7m3baobVSlOLhA/vRgqSQzyWL3V8UirjxbhK7qDBywjbqolYFVkfFkd0LCpwjAHb27pgQ2xrtyi34QA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Kddp+ydx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CKXNudTU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Kddp+ydx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CKXNudTU" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7SxD53532237 for ; Mon, 23 Mar 2026 09:19:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zpbpg0hPnfQaJ1hYQGaQ316b4Tnqdwkw1WSwGLLXo6Y=; b=Kddp+ydx6NynhTSU Fnn8ufuOmm5/WZKJ69ZFHmVLX7OLuY7EZ79mFTuDVt2zs3XjC5Vm7BIDUI8hXbRC FUAjBi+BaFQhG5uX+rRdqWVZcG6b3GRkp9Zlge/TpszsfmMEqiW6oQpms3IyFgKh 6fdwj04WeicsYbcskgGAaAR10m9fzW/NCiZqU/x5K8L3q8iMa6QgNQOkyV43m22F YEq20AKdqOpGyoosNBt/G9U8ZStB2DVMPUDcLNieIKw+iYuW2ukmhCOfE+uPGRKa 0A23Tm5UQN2IPav7V1sUSh8h/gyyuCi5IwO5Z/junGeLez7CoK86mskz6OG/1LJQ m6zQVA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d2ca8jmg8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:19:52 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35449510446so4329939a91.0 for ; Mon, 23 Mar 2026 02:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774257592; x=1774862392; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zpbpg0hPnfQaJ1hYQGaQ316b4Tnqdwkw1WSwGLLXo6Y=; b=CKXNudTUTvvT2FPnw11mj9AQaAqnNnFkTQiAn715iVftZ/3HiXklxmZaeRJwQqm57K Ezhu6kgPRlX5af54eo3qlrsXnqH/taM5In3c8k7Y5RQJblbp4TBsXxkZUONwkxphsR0p QUHcLMOCDoKVi1XvBIALYc7+casD9WIyIENFLWxUQdBbBMGOaMR+xJEmjL5twaxlbVza FR1BifX8qqFd9vZ1TAxikLiRXMBjGcA4UlOKElobIWvwjrBorqmSf1Z+WT9yGP46Bo69 gG/Th3zevvNpkVOVIIIWvIP5/YfSch2dhwCvJ6wCexj9PV7f41209HDuycx9nneu1UKE IUJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257592; x=1774862392; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zpbpg0hPnfQaJ1hYQGaQ316b4Tnqdwkw1WSwGLLXo6Y=; b=gcX4PJF/EKaWcRppCNx12kvZ4ND7dugkk8T9RhUuPIU/cWW+IPzPPwFvNwCTW8Rny5 iaB1OzL/GDgUy+RgCqHAV+YwBRR1VAZEgk69SOt/tiS4wxm3g5UgO5ki3o22A549bI9F zYcDiASjXWkw4EjO3ICCB8THibi7OdIMZ6lMM/i5BXk+WOgOCsDdpqPKdEsSUwdRbTDP SSZonOuc6Lk8rnFR7TPafFJ3ZcGayK1Nk+QrJ0qXmQokzc7EHeyETOJn83dIqw1VqRl7 892sxE3fS2TVyCb2yZBByFL8Qy3z73VkTcdHBm8gyF1MM5IUi0BtbyS+IeWFjmA9Le+l FG3g== X-Forwarded-Encrypted: i=1; AJvYcCUNshwQOhr8HfT5d1MjTVg/92LgL2gaoz+jrszeXcEoYrAVELkMbP1MXVzHg10clz3rB15lY2nUQ9AKbMY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb6424VEiY6v42n02mfFM9YHMWHLrItpRf9pTq2kzLPwF2lT2v GlDFxvTSc440bPC+1mPN+iBo5bQqns4DXOa+W+Agp1FX64wydU66Jw8Lqzvj6PWFm3Ea3CeU5ca u4KJgofrD1li4HF/wA+X0JToFlJPO9EE+PeLOtsCOZMcfuRVii726GkBHZLxfhe+Mt08= X-Gm-Gg: ATEYQzy0XpR3FFKlU1EAqTAPe2R1lzY6zpg7GOy1MK3UG7aF6Y8Nnw3be07RvUq3SUe 8oeFi3V3VuwGoP693pHZ/eAqECYSkwzmO2A9L+xPdCYHu7YQbodQ4VZQtOyq3FPz2xyVM1exIB+ sTl0N0OdRQcFzxCMyI7tg8bOoQR85j5SDba+orWMxNjlfyaNJgauKlc+X+QiIaDtMaeqiQYBvBq AJUCAKS4bxc9PrdgHokQpnYSYVmos6XQvQpER0EJvbRk+/3iAV1867FuKKGT7GyU4nv4rvLiDwW s98YekKGgrqQS6QdK0SqaCRFnAFZrnkN02FfD5hp6bqIPx+a+jXYRcXloMJwQ+53CE9j3PV/D9l Zdmu2oekGxbS3tWIoWe5Aqc7cmKDFFRRMtU6TM/G9jqOK3ps= X-Received: by 2002:a17:90b:3d85:b0:359:1063:6aed with SMTP id 98e67ed59e1d1-35bd2cb3e52mr9251837a91.22.1774257591870; Mon, 23 Mar 2026 02:19:51 -0700 (PDT) X-Received: by 2002:a17:90b:3d85:b0:359:1063:6aed with SMTP id 98e67ed59e1d1-35bd2cb3e52mr9251785a91.22.1774257591273; Mon, 23 Mar 2026 02:19:51 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35bd358b5ecsm3923448a91.5.2026.03.23.02.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:19:50 -0700 (PDT) From: Harshal Dev Date: Mon, 23 Mar 2026 14:48:04 +0530 Subject: [PATCH v4 11/11] arm64: dts: qcom: sm8750: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom_ice_power_and_clk_vote-v4-11-e36044bbdfe9@oss.qualcomm.com> References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Krzysztof Kozlowski , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774257482; l=1456; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=4gCokkHZ2GjRf5B+A9Zqx/4PsUp2LAmyJ4JNgVsWI14=; b=RswpYVENgXtuJbX4xVStbksk7BFMx7jSFT0f1TB6KQum/olhlBcJk/LgtEnVSjBqp2WNzexDI j24z+9Fl6TJC6vKXj+9p1xre4eFuyfcqRcwxcl1ntu5GX3AGZpbp+7L X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3MSBTYWx0ZWRfX+eGjxJX9wv0Z WTUKR+/TZtRK6+T9KluW9Myfj9smfH8BqTp2fdaOWv3EONGltFApedq8uW4Bl1MYVUifnYy4gqI bUt8J1AIdwrdOE3ilNPQsCzXhaiiR/Gz9XB1dpfuClNLT4mI1RoSeK/aeHXHT6znYAjansjvL3v DPeyD8S6XjU4C9CXL50U6xfGn0lgd71MmAjIw3bOfHIwN0NfSTlz1y//eIZVNipKPmXfhDXpieQ S+mGmwIXZbyobcEu1UYVb0NvXFPMEOAYfsD+zX3Xyq05cYnHuf5wjW2pkicXPT+RwnfZg1KVPi9 /9AU+Knwuql/cgLZ7Vo7UJP4UQHS+zaXOzv0NTB7yN5ODoHiFrC+xOTdnhyoknio6vzl+utkf7x 5F2o41yp59PKNhQrqrhH82yxOX0nQlYpfcaEHlMn6ulZMY2RQ6C8YErm2cUAYI72om/JWflfMyT wezMBNzjGAz5Z3HPgrg== X-Authority-Analysis: v=2.4 cv=cf3fb3DM c=1 sm=1 tr=0 ts=69c105b8 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: POFgnL2W5Vr0EflKRjqkJCP3nSjGqsN7 X-Proofpoint-GUID: POFgnL2W5Vr0EflKRjqkJCP3nSjGqsN7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_02,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230071 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8750. Fixes: b1dac789c650a ("arm64: dts: qcom: sm8750: Add ICE nodes") Reviewed-by: Konrad Dybcio Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh --- arch/arm64/boot/dts/qcom/sm8750.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qco= m/sm8750.dtsi index f56b1f889b85..8c33bc3620ef 100644 --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi @@ -2083,7 +2083,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1