From nobody Mon Mar 23 21:29:21 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B6DE3C65F0 for ; Mon, 23 Mar 2026 15:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279079; cv=none; b=YUYPTz0wAD9iPL1ex+Eb21ie8GsO0sTYSdSDRdQOi2gfejEoGEImaeZlT6iKah6T3ENZuf6BQmwn5WvzTUZqaK4smOmA8XmhT/6aXLR/PxP8RxIBfd1F/NKm+rNy7/9DKXXm/FXCFGVBQO5Cv8fCHYKrip9VJlWNyJryMxBCwA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774279079; c=relaxed/simple; bh=0l3gdVnkPeEhRWmaFMSjmRRcTqey535uYCWAXzuHtwc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A293xsnsZKvmBMpFIBy5qN1yzZxjNXIADSkaGdDJNWSclbbfnpJj5yratWimqQUDIU+7Hfe6M1BZ3XI74DMNq/ivPYl5d3xeuxycLWpkToesHx1NlyN7igNmyItYqsHvQvVoLZI0TGj6q1FP8W2r8yRDoiA0S3XTtm6HnFx+qn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iMqbd+8j; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aI0tOOsT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iMqbd+8j"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aI0tOOsT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NFGjbS2627427 for ; Mon, 23 Mar 2026 15:17:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bP+u/9sMDsi5B9HZu73nJnAW0uvD7B1160U6L0iNO8E=; b=iMqbd+8jDFG8wUga CcAfEqrkXBhSqKa2mXvbxhMVq27SxEF4NFxU0fYhH2zkE9AQ827iCpiT8W0krEvD FRKYlEzzZNsyx5yLBaobqqSp38YUrgh11j72wbi6Z99og4kBRRuX0DUGKW1YcgPb JEu/rO8tCeQGHkzdusiLa5gX9Feh7n7xE442r/Ocj0P9fnfOaNONqB9qp7GAEy75 telyxJjfOPRgmo0iAHvDQ0SUZWsKqZMYKESaYdFI1uiiqnQL+/CDel8vXKInCJyA IF7+XVgJcr1ObmM4T+odC7PAVgykfDysiktvMlq1FqHahth6YzPFHQyZRWHGeCX4 YhPyMw== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc1kbh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 15:17:56 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-60132c655bfso41592978137.0 for ; Mon, 23 Mar 2026 08:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774279076; x=1774883876; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bP+u/9sMDsi5B9HZu73nJnAW0uvD7B1160U6L0iNO8E=; b=aI0tOOsThrWNUMOipkqCm8inB7pmKAfoQR7vYiiFI7SRWtFUrlKHOszFy/zCBGM1Rn eY2KzG53o2zIB56ZXiktHZo1FAoXEtahPnOUcW+X6qkpiawiB9E34+85+h5gXSlZB9Vb SOxVassT3z1Gc95g/PFDGBsQ3YWRMcyby4xajt6xtDOFsdLSEAcJ8paqwxpzdeS+7HAC QorjF5adLqdj9Gp1uV9SZQSWlqsZ5uJJs6zjehrF4GJkn+HMPsQOsDezzm4RpAlrkIey QmoyngPB/dOJFjch9VQ41VZJ3p317Ea21AijKv8NFKZ205bdOoTRGtV6aUbyinMVpQZ3 IhOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774279076; x=1774883876; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bP+u/9sMDsi5B9HZu73nJnAW0uvD7B1160U6L0iNO8E=; b=nM1EPPiMQlzj3jmpAbHAnrNZxIq83CG2ISYzev9O0kxuGBA2WiU5XdJAiDeqwsR1zv CJ1a4BtMDXRisMZSVyYkWOBA+ETWmIkBAIPntGwtQtpMShgB2Z/G3nj3b4oslfRUoLsJ 7lg1VNGrZxEHWZ8fFMDTxhTlQm6uv6fBw3pfmrQeU/FtBfH/PC+C308oisPhZuJuOKIy SN9SH2+mixjUGNlxExzaaEkNnr+3JrhnjIKAGoGxgQVdiXCdu9XSHeH9vTuLXrT/HvJf 8DEzdAOAOxjyral6a+ukeldH0CJveMhI6NlzA2rOHVFBM+sa4St6mSZTn3xRlCs71Ozh z1OQ== X-Forwarded-Encrypted: i=1; AJvYcCUucxZDDEDND1GDYA8JXF762TczZNTFHq/lx8O5M7eq9OH7tUvKKkDHmUZv/8hXsFQaNCxkx6bceviKP6Q=@vger.kernel.org X-Gm-Message-State: AOJu0Ywrc8Kta6n8ZLh+v2Wh5lEkPg/hS39R7TxpMFppyjQAWKshutZB 9fsiQ6qIlw8Zvnp0FhNtKvZqqRHCBljuxbgYicec7QpBqcBOaQEi0+LmthZcyurLVMPibsI2Adf HnOXcMsUTMQdimW2uFEzXzMTSy2CywG4BibfkWeX0zhWKDYWM8V/esP01I6mNJrgrY+w= X-Gm-Gg: ATEYQzz+hs88+9PjBvE4bk225haR5EGBMfYCQXKZUYZYjYNs/ylsALkhZk/8q3/XgZX 5T4v3jtRswrLuhUXtvUSZfS5szSFLC5905xUXgx27utaSEexvlU3Y2Syp0Twkmzm69yqKmrlCQG T4Mwl3wmxCntJLF9I0ZMdiHK8vxdEMnrWW/xgajrwR7mYWyzfKj6PUSJH5WwF3507Fao++Ir8j4 1t5XfY7lBn8Ny7we46SxhvAEhBbgUyDrogdVhYsGX6VUbyWVjGI9Qf5ql1HSnB2yWc6wwIMofsj H2Ql5NXUV542JqP5yeiEEUd1VlhEHGEg5r1l3BMDMmOjTH76H/N9SQrbJ1lLFrL6seKQiaIfOK0 pIzNTK2y1xdzkyvkHWNqShvT7zRQG/e1wfKsyYMPCyLBsj5ZkVCph X-Received: by 2002:a05:6102:c06:b0:600:d0f:bacf with SMTP id ada2fe7eead31-60295c26f91mr7717441137.11.1774279076014; Mon, 23 Mar 2026 08:17:56 -0700 (PDT) X-Received: by 2002:a05:6102:c06:b0:600:d0f:bacf with SMTP id ada2fe7eead31-60295c26f91mr7717424137.11.1774279075565; Mon, 23 Mar 2026 08:17:55 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:f9a0:d7e2:7eb6:79b5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bd923sm35936993f8f.12.2026.03.23.08.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 08:17:54 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 23 Mar 2026 16:17:15 +0100 Subject: [PATCH v14 09/12] crypto: qce - Use existing devres APIs in devm_qce_dma_request() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-qcom-qce-cmd-descr-v14-9-f323af411274@oss.qualcomm.com> References: <20260323-qcom-qce-cmd-descr-v14-0-f323af411274@oss.qualcomm.com> In-Reply-To: <20260323-qcom-qce-cmd-descr-v14-0-f323af411274@oss.qualcomm.com> To: Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Md Sadre Alam , Dmitry Baryshkov , Manivannan Sadhasivam , Stephan Gerhold , Bjorn Andersson , Peter Ujfalusi , Michal Simek , Frank Li Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, brgl@kernel.org, Bartosz Golaszewski , Bartosz Golaszewski , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2266; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=azGHQ+ypZ4Lhe2NPlFIx77n1JCkKbs9Xx9/yXH7ccEw=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpwVmC3BbPHKUcjTHe5TMiO9yZ10QstnZzV0KUR 6F5bvI+cXWJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCacFZggAKCRAFnS7L/zaE w+PoD/4jky+pkIFkSZLdWX+ThdxlM9RmeODxR2zkQT6LI57HgVk3z9BMCHOQ1Pz+OT/TA9CQ9Pa hXgiG0yEC9HzAPG/BRj2TrT9xW2Pd3uWJC/YrJ8K6e7+8StGnr4i4blBASj2JACX+3grCEa87ti l8QZyxaI1lf9Y/Bdp+Ir5qD6Lb1h36J5hTJpT/ejECOzGNWczCoEC4WR+gtKErgAcAN9uLw1dF6 kEi8NeSIepc/u0MZzAg8gnbtpE1xbg6DTk4BaoKY1e3u03BP3+k39hy5byPZsYjR+kYrTIc9BHs EJIARINSvQXi5b0xbRSRU2aptScYC6NCtpSWErfUnjQKay6CX0/nL1/9QIoLD2VKNKt67Fud60n +9ud9d11eAourrQz8CfxHjzcHdjQiyM6QdY9pUhN7vCZmQUrgoK6n2JuNSgkgeiuH+EtIKdY+Hq yLZlRPPr7bAIyoy6jvD8Gm4a960+4mhH9mBmGJLXIGhF0fKxgesM+1MR3rCce6C4nVl5ou37pxu y/kX3I0mvNVxEPsUOaBNciWbXxzlo/uUK2EWoBcv8ua1U2pQwiNJpWKSNpeG04FEuim21W60srn 8XgoXRsMXbYEDQX0KHMLCjwltIhidgKB3zY2dSjwTxl5StlU9tp7jJX4m/MOGFQqqobVMylscmi yWsF24FWKBVEPnA== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c159a4 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=r78XHnC5kAO70zNBxnsA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: DRwAVDhfI_XJwSHr2MUHzYApP6NIQjxP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDExOCBTYWx0ZWRfX8wvcKv2w0GXN vlvyBrAGvCi+LpoE4ItZaYEP3a1K6GH4j3XIsD+qrZ3NUW9ckdJrECwEjS2hUGY0KWGOnJsOXa3 /ouxqJmgmNYcB4BgbojNCEP3p5ydDHOufBc3iEybMxxCQZTmlk6VuoZrbRoKPnrIayyLE32qRnE tntavqawwTzLTd5jmqK9aM7Uf9HOy5Nsm8gW8BH/jU9PqGlqxrp2kF+v1Ki34YsH5peV6sGS/d/ 0pu+WDVa57bIuh3xk0Ol2n3zj0P/YWiqPzcGAs4C/IoKsEYysJdfGYu/Q8MRHP5myp1nL8fjp0A /rlk0hjADkdLU+Ser5cZGzDSE/OwL1BKvmVE/GsjHkFU3MiyVRjqh2EZ9UAJRwJz4oXxJhHBsso qFW7CallOdP8HdVcPttvRQjyBUYcbiEWe2qO43DU4GX3C5nDbKI2fkBPLHjLSwaq2HSv/Dh9Yr3 HfB2rVNdbUBiiXG0Rew== X-Proofpoint-ORIG-GUID: DRwAVDhfI_XJwSHr2MUHzYApP6NIQjxP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230118 From: Bartosz Golaszewski Switch to devm_kmalloc() and devm_dma_alloc_chan() in devm_qce_dma_request(). This allows us to drop two labels and shrink the function. Signed-off-by: Bartosz Golaszewski Reviewed-by: Konrad Dybcio Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/dma.c | 39 +++++++++------------------------------ 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/crypto/qce/dma.c b/drivers/crypto/qce/dma.c index c29b0abe9445381a019e0447d30acfd7319d5c1f..a46264735bb895b6199969e8339= 1383ccbbacc5f 100644 --- a/drivers/crypto/qce/dma.c +++ b/drivers/crypto/qce/dma.c @@ -12,47 +12,26 @@ =20 #define QCE_IGNORE_BUF_SZ (2 * QCE_BAM_BURST_SIZE) =20 -static void qce_dma_release(void *data) -{ - struct qce_dma_data *dma =3D data; - - dma_release_channel(dma->txchan); - dma_release_channel(dma->rxchan); - kfree(dma->result_buf); -} - int devm_qce_dma_request(struct qce_device *qce) { struct qce_dma_data *dma =3D &qce->dma; struct device *dev =3D qce->dev; - int ret; =20 - dma->txchan =3D dma_request_chan(dev, "tx"); + dma->txchan =3D devm_dma_request_chan(dev, "tx"); if (IS_ERR(dma->txchan)) return dev_err_probe(dev, PTR_ERR(dma->txchan), "Failed to get TX DMA channel\n"); =20 - dma->rxchan =3D dma_request_chan(dev, "rx"); - if (IS_ERR(dma->rxchan)) { - ret =3D dev_err_probe(dev, PTR_ERR(dma->rxchan), - "Failed to get RX DMA channel\n"); - goto error_rx; - } - - dma->result_buf =3D kmalloc(QCE_RESULT_BUF_SZ + QCE_IGNORE_BUF_SZ, - GFP_KERNEL); - if (!dma->result_buf) { - ret =3D -ENOMEM; - goto error_nomem; - } + dma->rxchan =3D devm_dma_request_chan(dev, "rx"); + if (IS_ERR(dma->rxchan)) + return dev_err_probe(dev, PTR_ERR(dma->rxchan), + "Failed to get RX DMA channel\n"); =20 - return devm_add_action_or_reset(dev, qce_dma_release, dma); + dma->result_buf =3D devm_kmalloc(dev, QCE_RESULT_BUF_SZ + QCE_IGNORE_BUF_= SZ, GFP_KERNEL); + if (!dma->result_buf) + return -ENOMEM; =20 -error_nomem: - dma_release_channel(dma->rxchan); -error_rx: - dma_release_channel(dma->txchan); - return ret; + return 0; } =20 struct scatterlist * --=20 2.47.3