From nobody Fri Apr 3 20:51:53 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 703B8344D85 for ; Mon, 23 Mar 2026 11:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774263929; cv=none; b=lp0RQXG7OBSAC1VOHxHxItVixydwG1Ytou/EeEuBeBwpU87moo+MIPUsJPLq1l4cDedwm4r/3dEkHoaoipJFDReEzud/Z44goU2I9ryaf4W2a3IF+I843r7SX5UXjHD+Usfsnui9qoULqTPS0xy5nlm8uJaT9MZguO1z+bATos4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774263929; c=relaxed/simple; bh=dKKs0G/Wa3KBfAb/TZIyIIQz+VdKNwuAztiiDQx4WYY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=OJqtyctUXZlfQfO/dB2UsT2CqPEj1w28kZmLHxpTkmAZ3uQXfO3vzW7wwShx/hnfksRlxCVZPlYTXlPr+kscZhB2foQHWHrk6pwJ8dtbDPJP8uVH4UgIJzcJ3WsOJtTahLCfWoXh/cJTrnhn9Lo90RAAR0u8rkhGhhAJxZsH8WI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ffvxxWY9; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ffvxxWY9" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c742882d2a4so1116500a12.0 for ; Mon, 23 Mar 2026 04:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774263926; x=1774868726; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=WjDPWCi+UxS6zX6zYKH/Qn9Bf2hHL2LIeyIwDf04qlA=; b=ffvxxWY930WyhDuZU7ZQo+CbWS33+0onCu5HjvI7LtV17UzvkouRIgmJ1ZTWm/p+MX aJcH9nPVxvEAz5ma67H9KcDRu3TpwKks6JRfR7XsDw55tKry8rot0Pz3WHh/AFZfsnqC Hxd+cOo51yJBEHmDGiRMbP/PDlanfT7CeKW+Knrr4zxge+BQuZ9zkJzDOva369U+LBZl n1FY7g9BWTGztrhDNp2LXTUk3l9ReTuO1vwjcX2Spxm2naGq5Dz7G5K+KI/ImiybTD+3 5To0n1SWoTzgMhLaBB/YBrLTZbdrHuEqqbcauVZ9m2jPi4rKtq43Elzqz01IpnDu+qVe VRaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774263926; x=1774868726; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WjDPWCi+UxS6zX6zYKH/Qn9Bf2hHL2LIeyIwDf04qlA=; b=mMqy/BeK4N3AMzJzLXwYbHULMXSvPIbXOjhM6Cgiy8/rvtq0MmrewEOz6qAHuqxlIp hOHroZufoDW1f3nZUO2O2NAUXWxyukW5/JGiqQgC2MBFgVxrxfaCCS/gwIanFq42obpT mPOdAM80zDMOoIXzy1aWE+PYvyr9pMSQ9tvxcri3jLuEuEcyJ2ikyVYzEqRR/GAt6pSP PBrEvcKbMokz1u5NYtmBgXo+ymhqg6FUVD6hQ3CppwQPApOBmCbEpMBcgNdYvJoOlJ4O noFv5bV+w9G8jY2NIxV7TcLQq49JR7v/fmsCHnPyN74qJb8wZSN0E0ZQbr2MlGHm4Xj8 VYhg== X-Forwarded-Encrypted: i=1; AJvYcCWiuY8H6rQiKktexgDxhaQlx+Ys7oqL1gR3xtsSXV3uZ/DDrQebOtgmigHzDtmL02iVk9YbDm3rx1MxYJg=@vger.kernel.org X-Gm-Message-State: AOJu0YwrxI1qJx3PsDniebFm3zHynxwYXhKlEjF0yb7yAfT3fXeO6DLA GyJHAl8trVnAyCBDLaSZ27YsU61GFZidXpjxQ81H122yP1Ur9Uq3/NYD X-Gm-Gg: ATEYQzy76HPpI/nusx/swKWWPV6okq08nybgkM2Qn+g+r5eg3jmKBOeRnHtmywSTNPI lDf+8GqRnFuHg/HiHt5Zn7JmK1nSI4A9tQQEoRfvKqzSup2IGjJ4LzllESfkh4fYFC6Tjq/pkl6 3PyrelzPlpDm0qR5RtnLX4lbhkRLdA4MJXlXBWinTTbWaSPCA3uRC9Ho2LuN1v67YloQqlY38gc +m8vWYnpPkrEN/5Ef4aK7GLbCCkD0KddNwSokuClcga4v3Hnnjk8+1XITUaHSjOkSjEWGzPv9gW xga6HDLxJPz7fc8DxaI9XeTCkSDOtoQNOe6waegiVMyMka9WJS/k44+nit2sxbshlQSiVkngRIG 3NNBsT5kFos1rvhBlQH00t2wGANPHp/UGdQh5EOFVlxATcdDkxIj/TCS/gXt8gJvkjMv4SOT6bq BktCCGsH+S7ewqesLVMvzv+OhN7/ka40SOTP5w X-Received: by 2002:a05:6a20:a12b:b0:398:b619:b624 with SMTP id adf61e73a8af0-39bcea63274mr10869998637.29.1774263925537; Mon, 23 Mar 2026 04:05:25 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c744560683bsm7576673a12.30.2026.03.23.04.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 04:05:25 -0700 (PDT) From: Felix Gu Date: Mon, 23 Mar 2026 19:05:22 +0800 Subject: [PATCH] PCI/pwrctrl: Fix device node leak in pci_pwrctrl_is_required() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-pwctrl-v1-1-f5c03a2df7fb@gmail.com> X-B4-Tracking: v=1; b=H4sIAHEewWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyNj3YLy5JKiHN20VAsTgxRzY2MTE2MloOKCotS0zAqwQdGxtbUAISm t51gAAAA= X-Change-ID: 20260323-pwctrl-fe840d733443 To: Bartosz Golaszewski , Manivannan Sadhasivam , Bjorn Helgaas , Krishna Chaitanya Chundru Cc: Bartosz Golaszewski , Manivannan Sadhasivam , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774263924; l=1158; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=dKKs0G/Wa3KBfAb/TZIyIIQz+VdKNwuAztiiDQx4WYY=; b=tKDL6KmyltfmBlY0kMXjM7oHz+dIX6zkAsMMU57BxYyZTdRQxaPcxh/CKwywSlea+5lz+ZnuK vSMtD4tzFQdBNKJuWNEUsl6vyYlz+XumZ0H8waOYmhDHVh5vwBl7yTa X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The for_each_endpoint_of_node() macro requires calling of_node_put() on the endpoint node when breaking out of the loop early. Add of_node_put(endpoint) before the early return to properly release the reference. Fixes: cf3287fb2c1f ("PCI/pwrctrl: Ensure that remote endpoint node parent = has supply requirement") Signed-off-by: Felix Gu Reviewed-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam --- drivers/pci/pwrctrl/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pwrctrl/core.c b/drivers/pci/pwrctrl/core.c index 7754baed67f2..97cff5b8ca88 100644 --- a/drivers/pci/pwrctrl/core.c +++ b/drivers/pci/pwrctrl/core.c @@ -299,8 +299,10 @@ static bool pci_pwrctrl_is_required(struct device_node= *np) struct device_node *remote __free(device_node) =3D of_graph_get_remote_port_parent(endpoint); if (remote) { - if (of_pci_supply_present(remote)) + if (of_pci_supply_present(remote)) { + of_node_put(endpoint); return true; + } } } } --- base-commit: 785f0eb2f85decbe7c1ef9ae922931f0194ffc2e change-id: 20260323-pwctrl-fe840d733443 Best regards, --=20 Felix Gu