From nobody Fri Apr 3 17:36:52 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 007B23C9459; Mon, 23 Mar 2026 17:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287735; cv=none; b=I+jH7e3fjtc2ipTv+q80GS9/RHnGUmtGF4/ZD2aE2vif81FggrOUXTacq7mrHJ/KVkRqJYo/UYfxqn18fBkBJ/fRKvBTnGMb7802Wxm/CETkOB+XD3Xe0m4E7UvmZ5VwfTKUIo+fL0MEyhYY3KXX+FoPl+0vSZ+/uD2CYiqDCbg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287735; c=relaxed/simple; bh=UzzwLVN5fQWfPj6BIVjZr5XKGWPpBGZV+Stj5naA0CM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j9CjgecGS/xxy2LpinZEcO/Ks8rkwVbg2gQ7PyIiOqxmhpkUL4hZ8py3Ew69IHdxptqa6gSCdny6GTPm7tv/6REZdRRR4jesPjrt/zYjuks3Nw5gHXZqS6qtBuW/NSWrmNGaYl/wOyG0NWPO3nkeK+5/bmJIIo+/viX3rql4h30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=XZ+LE/xq; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="XZ+LE/xq" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62NCmnpE4107185; Mon, 23 Mar 2026 17:42:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=I6oU1k iE/GOW86cTR2R+90Z3xRFmH3Qi1yucw1jAJK4=; b=XZ+LE/xqT+NhZdJvV30Ew8 RYoLQK4kj4YmBQFhy+8qMobQc7TD/WyyCFUKqjq1qiqrBGSiVOPAFkAVQJgv7f/M TXWFKB6axKiwnfDwo9vO4jkWePNvCqKyT3Pu7prAyDI+8WOYKQ840EmRZ+rFZMze UA4KL4GBfhHGbFnBH8gSgOPXdTGRXxhlBy1oLBJdTo8tG8OP5yX6xVHupeigTvIH RGqwZhCbgbOWClblyN7BKzE814BJtZexaCRDTvbs5UuHAjoXYLmCr6NxLfF0FCgw 55F7pCHZS9gfUQUpIIhOz3Ta1A1yG5j/9397y+ZTEdMtnpy/e0ReJpRSwWYFh2Vg == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1kxyypgd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 17:42:06 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62NH6ogU026685; Mon, 23 Mar 2026 17:42:05 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4d275kpa2j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 17:42:05 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62NHg15a45285688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2026 17:42:01 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5134720043; Mon, 23 Mar 2026 17:42:01 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1477A2004F; Mon, 23 Mar 2026 17:42:01 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 23 Mar 2026 17:42:01 +0000 (GMT) From: Gerd Bayer Date: Mon, 23 Mar 2026 18:41:50 +0100 Subject: [PATCH v5 1/2] PCI: AtomicOps: Do not enable without support in root complex Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-fix_pciatops-v5-1-fada7233aea8@linux.ibm.com> References: <20260323-fix_pciatops-v5-0-fada7233aea8@linux.ibm.com> In-Reply-To: <20260323-fix_pciatops-v5-0-fada7233aea8@linux.ibm.com> To: Bjorn Helgaas , Jay Cornwall , Felix Kuehling , Christian Borntraeger , Niklas Schnelle Cc: Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Leon Romanovsky , Alexander Schmidt , linux-s390@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Gerd Bayer , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNyBTYWx0ZWRfX8aQVnSJZR6xp 5ZupDXjinE2p8qmuVrrU/kEtJSOhBDSlfw+bEVOTTJ/FFlpdSDeonTCAArexse3geiOyPeklbxa 1iAHXxoGf6RNwy1fcpeCTqVw9UA6PuEJ5+/XJRyLURhcgDDekBe6ZDY2THFlmC7iuwETeXqK7nU 0myEEGxCfs2CSN/cvOtDteLAY0cSmeutGzfIYh+2dtgLFrlqIfd+yIFR8hG4bbOMXCssWnVmEPD QExWOJ/eIIxxPbaFXtI3zGwgZEVa4TKBkMR1nqnvcd0270t/UQarpTDpWFZzTPp1ULyqZ4Yjlt/ WmP/GGGHh6HGjrR07tCcOmA+cubkNXOWhJTjswrrFmLosKdXzS4EBAxILQI+35GPkFBHxFXm+zq V+4PEnAtfPyHsCQTne+BGlAkEwTcTJPa7y1tSwmGgayRWmrDZ7jeyU9CNq26j6wuH7D7VoTbMrI 39tN+wAwz4cJmABUpvA== X-Authority-Analysis: v=2.4 cv=JK42csKb c=1 sm=1 tr=0 ts=69c17b6e cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=VwQbUJbxAAAA:8 a=Hx5SdpTRtzwH465PzOMA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: ed4KDtjBNk18OlPzCI46e3YvU6vXg7Tp X-Proofpoint-GUID: Dz8NA6si3VQAcceB92T1gKZAhs8-1yW7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230127 When inspecting the config space of a Connect-X physical function in an s390 system after it was initialized by the mlx5_core device driver, we found the function to be enabled to request AtomicOps despite the system's root-complex lacking support for completing them: 1ed0:00:00.1 Ethernet controller: Mellanox Technologies MT2894 Family [Conn= ectX-6 Lx] Subsystem: Mellanox Technologies Device 0002 [...] DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- AtomicOpsCtl: ReqEn+ IDOReq- IDOCompl- LTR- EmergencyPowerReductionReq- 10BitTagReq- OBFF Disabled, EETLPPrefixBlk- Turns out the device driver calls pci_enable_atomic_ops_to_root() which defaulted to enable AtomicOps requests even if it had no information about the root-port that the PCIe device is attached to. Similarly, AtomicOps requests are enabled for root-complex integrated endpoints (RCiEPs) unconditionally. Change the logic of pci_enable_atomic_ops_to_root() to fully traverse the PCIe tree upwards, check that the bridge devices support delivering AtomicOps transactions, and finally check that there is a root-port at the end that does support completing AtomicOps - or that the support for completing AtomicOps at the root complex is announced through some other arch-specific way. This announcement is implemented through the new pcibios_connects_to_atomicops_capable_rc() function - with a default implementation to always return "true" to leave the semantics for RCiEPs intact. For s390, override pcibios_connects_to_atomicops_capable_rc() to always return "false". Do not change the enablement of AtomicOps requests if there is no positive confirmation that the root complex can complete PCIe AtomicOps. Reported-by: Alexander Schmidt Cc: stable@vger.kernel.org Fixes: 430a23689dea ("PCI: Add pci_enable_atomic_ops_to_root()") Signed-off-by: Gerd Bayer --- arch/s390/pci/pci.c | 5 +++++ drivers/pci/pci.c | 46 +++++++++++++++++++++++++++++----------------- include/linux/pci.h | 1 + 3 files changed, 35 insertions(+), 17 deletions(-) diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c index 2a430722cbe415dd56c92fed2e513e524f46481a..a13235d3218e8ca451e25fe8d90= 94500fa21aa26 100644 --- a/arch/s390/pci/pci.c +++ b/arch/s390/pci/pci.c @@ -265,6 +265,11 @@ static int zpci_cfg_store(struct zpci_dev *zdev, int o= ffset, u32 val, u8 len) return rc; } =20 +bool pcibios_connects_to_atomicops_capable_rc(struct pci_dev *pdev, u32 ca= p_mask) +{ + return false; +} + resource_size_t pcibios_align_resource(void *data, const struct resource *= res, resource_size_t size, resource_size_t align) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 8479c2e1f74f1044416281aba11bf071ea89488a..c1143f8e6b2a0f029feb3c4390a= c6f33837f6de1 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3660,6 +3660,21 @@ void pci_acs_init(struct pci_dev *dev) pci_disable_broken_acs_cap(dev); } =20 + +static bool pci_is_atomicops_capable_rp(struct pci_dev *dev, u32 cap, u32 = cap_mask) +{ + if ((!dev) || + !(pci_pcie_type(dev) !=3D PCI_EXP_TYPE_ROOT_PORT)) + return false; + + return ((cap & cap_mask) =3D=3D cap_mask); +} + +bool __weak pcibios_connects_to_atomicops_capable_rc(struct pci_dev *pdev,= u32 cap_mask) +{ + return true; +} + /** * pci_enable_atomic_ops_to_root - enable AtomicOp requests to root port * @dev: the PCI device @@ -3676,7 +3691,7 @@ void pci_acs_init(struct pci_dev *dev) int pci_enable_atomic_ops_to_root(struct pci_dev *dev, u32 cap_mask) { struct pci_bus *bus =3D dev->bus; - struct pci_dev *bridge; + struct pci_dev *bridge =3D NULL; u32 cap, ctl2; =20 /* @@ -3714,29 +3729,26 @@ int pci_enable_atomic_ops_to_root(struct pci_dev *d= ev, u32 cap_mask) switch (pci_pcie_type(bridge)) { /* Ensure switch ports support AtomicOp routing */ case PCI_EXP_TYPE_UPSTREAM: - case PCI_EXP_TYPE_DOWNSTREAM: - if (!(cap & PCI_EXP_DEVCAP2_ATOMIC_ROUTE)) - return -EINVAL; - break; - - /* Ensure root port supports all the sizes we care about */ - case PCI_EXP_TYPE_ROOT_PORT: - if ((cap & cap_mask) !=3D cap_mask) - return -EINVAL; - break; - } - - /* Ensure upstream ports don't block AtomicOps on egress */ - if (pci_pcie_type(bridge) =3D=3D PCI_EXP_TYPE_UPSTREAM) { + /* Upstream ports must not block AtomicOps on egress */ pcie_capability_read_dword(bridge, PCI_EXP_DEVCTL2, &ctl2); if (ctl2 & PCI_EXP_DEVCTL2_ATOMIC_EGRESS_BLOCK) return -EINVAL; + fallthrough; + /* All switch ports need to route AtomicOps */ + case PCI_EXP_TYPE_DOWNSTREAM: + if (!(cap & PCI_EXP_DEVCAP2_ATOMIC_ROUTE)) + return -EINVAL; + break; } - bus =3D bus->parent; } =20 + /* Finally, last bridge must be root port and support requested sizes */ + if (!(pci_is_atomicops_capable_rp(bridge, cap, cap_mask) || + pcibios_connects_to_atomicops_capable_rc(dev, cap_mask))) + return -EINVAL; + pcie_capability_set_word(dev, PCI_EXP_DEVCTL2, PCI_EXP_DEVCTL2_ATOMIC_REQ); return 0; @@ -3813,7 +3825,7 @@ static int __pci_request_region(struct pci_dev *pdev,= int bar, =20 err_out: pci_warn(pdev, "BAR %d: can't reserve %pR\n", bar, - &pdev->resource[bar]); + &pdev->resource[bar]); return -EBUSY; } =20 diff --git a/include/linux/pci.h b/include/linux/pci.h index 1c270f1d512301de4d462fe7e5097c32af5c6f8d..498f266c9838c55e9b03d03fef4= 9a82358047f4f 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -692,6 +692,7 @@ void pci_set_host_bridge_release(struct pci_host_bridge= *bridge, void *release_data); =20 int pcibios_root_bridge_prepare(struct pci_host_bridge *bridge); +bool pcibios_connects_to_atomicops_capable_rc(struct pci_dev *pdev, u32 ca= p_mask); =20 #define PCI_REGION_FLAG_MASK 0x0fU /* These bits of resource flags tell us= the PCI region flags */ =20 --=20 2.51.0 From nobody Fri Apr 3 17:36:52 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B0833CA4AF; Mon, 23 Mar 2026 17:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287735; cv=none; b=utKoP/LXZnrwCCsP1dgQsvidx5bGRh69B+M2fWSTTkehkjJPGIA8VlqKsI82XoZ+ynMg0vrdCdFZBS6GzlBAvXT0CBgsCbTsvEx//uJJGjwilf0mnlmS2gCkF51XxyTXWkNTtEy4OMCuqlm9dBDpD4m1mIKzbOrV3UGJswdEBa0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774287735; c=relaxed/simple; bh=zrLVJdsj2xj26f+5MMV71txjt9WOFbmNImdJJSiEXBg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eAqFh7Vub5Ai34AqlUx/jo0Tj7m1903yyhGibmd9D9HTUZJI1BeQlHZ+M9XxBBOhcdHCF5kVzwSH/OBJDy6gdoPBY1EwZlQ5qq5m7cgCGePHv6n2mfDRVqj0DQANGjgZNWGI5OM44hU4nj4UYFtNCSDokkgrALjamwS7LHcPGVg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=CbbIcVxL; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="CbbIcVxL" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N8sYjj3255707; Mon, 23 Mar 2026 17:42:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=QwswFw tV3LAFfylhjXBfUeHEfQMdVgAYk5tz+zm7JvQ=; b=CbbIcVxLsqqIOLEfPOUUni 7UlzXTvla2cetxnbRlMuutL5AtqB9R5jA6peHwZipIwlPgESkWacu/4HARiWwjQM H+zW9Fo81GyTRl/RNc3K2yl52zogiIXGd+J9MLqzFSg1GdhRGftvjhTQfB3o3YgH hMd/+ernXW28NCSq3tvTQBELQjGigp6VCfkRqyWU1wNF3AAh5cU8Ollb/H8Lk5H/ J50QFfv7qKoBP3lIPx/scE/qfDMhnid29dE5tZ6HHQ+ePY5yLsAaPkU4Wu7wO8/Q ubcHnp+k2cQTUgB2TbROfAHde5dFnuJ7GsEuO3fVbyA5ioyYSKbrJV6YEC/hxE0Q == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1kumfrs6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 17:42:06 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62NFriVg031592; Mon, 23 Mar 2026 17:42:05 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d25nspgwq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 17:42:05 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62NHg1VV45285696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 23 Mar 2026 17:42:01 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D4C520043; Mon, 23 Mar 2026 17:42:01 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 55EEE2004D; Mon, 23 Mar 2026 17:42:01 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 23 Mar 2026 17:42:01 +0000 (GMT) From: Gerd Bayer Date: Mon, 23 Mar 2026 18:41:51 +0100 Subject: [PATCH v5 2/2] PCI: AtomicOps: Update references to PCIe spec Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-fix_pciatops-v5-2-fada7233aea8@linux.ibm.com> References: <20260323-fix_pciatops-v5-0-fada7233aea8@linux.ibm.com> In-Reply-To: <20260323-fix_pciatops-v5-0-fada7233aea8@linux.ibm.com> To: Bjorn Helgaas , Jay Cornwall , Felix Kuehling , Christian Borntraeger , Niklas Schnelle Cc: Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Leon Romanovsky , Alexander Schmidt , linux-s390@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, Gerd Bayer X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: eWgJrRiVhxH3dps7lrlp1t5Vod0TM67w X-Proofpoint-ORIG-GUID: H6kcuBex_MfWrPpLOzOjXuvIj5egMWF1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDEyNyBTYWx0ZWRfX55AyJXs8QiFa n1JR2Ug45Wyl6m5BTOUWVT1BAGjsa7sNYdwNCX5bV84N4F/Zc38NVki4STtxvkrnsZsauk/RAjY zbqEYxQlK2MfcLCcB9E4YMqBF5PZfVf8bISfQrrxS/hIWiXdGEQSdTk0elcI5c/y2626WHzNcep dPSzL3SDAd3eGpuzsItCmtl6mmqAnHhagRZrqUOZsc7Ne9vx0uMfzStV/Dl05uSJu2DXZj7AlQE 8U+/o8c/u0JKk8bknYyRXhr+vtIJIe60AiW4FQD8mq6fw6kzIieKslCsJiJq2zCwa1wHZKjX2Xx O+np1Vu90p9USmpv6txnx4/GxqlJKsGJj1goqOVAWaPrnLqWbqIJqV85FsoWF50N0by8meKat/9 bcYZ4/gt8DFHcRJAsrw625TGYm/FrYW7YMxFaWOjtsCcWNIBFIbhXIxsP07ATxVgGghDlUvpuwX Z7Q35AbYZs7kagAVQiQ== X-Authority-Analysis: v=2.4 cv=KbXfcAYD c=1 sm=1 tr=0 ts=69c17b6e cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=GT8QqqGQBE3YBt8_gt0A:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_04,2026-03-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230127 Point to the relevant sections in the most recent release 7.0 of the PCIe spec. Text has mostly just moved around without any semantic change. Signed-off-by: Gerd Bayer --- drivers/pci/pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index c1143f8e6b2a0f029feb3c4390ac6f33837f6de1..d0d52ccf1ac18ce5a1917a713af= 9ab87b61cb7f9 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3695,7 +3695,7 @@ int pci_enable_atomic_ops_to_root(struct pci_dev *dev= , u32 cap_mask) u32 cap, ctl2; =20 /* - * Per PCIe r5.0, sec 9.3.5.10, the AtomicOp Requester Enable bit + * Per PCIe r7.0, sec 7.5.3.16, the AtomicOp Requester Enable bit * in Device Control 2 is reserved in VFs and the PF value applies * to all associated VFs. */ @@ -3706,9 +3706,9 @@ int pci_enable_atomic_ops_to_root(struct pci_dev *dev= , u32 cap_mask) return -EINVAL; =20 /* - * Per PCIe r4.0, sec 6.15, endpoints and root ports may be + * Per PCIe r7.0, sec 6.15, endpoints and root ports may be * AtomicOp requesters. For now, we only support endpoints as - * requesters and root ports as completers. No endpoints as + * requesters and root ports as completers. No endpoints as * completers, and no peer-to-peer. */ =20 --=20 2.51.0