From nobody Thu Apr 2 06:31:59 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4743876AB for ; Mon, 23 Mar 2026 09:50:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774259407; cv=none; b=Srfe+jtWsYvNJfRNn0FldnbE+kPjm8+HRAbKMKZSTLYAr3BYaJXI5O3Vj+UMQkFnj5K1mEVhvdKNjWEHvOcJDGP2iMAGwHNnszWGL21wmP7bul4PUo87Dok5GacCUQDMEBrrEwF47EOaNbh+ha3HsD0EtenPFqAcCpV3Q5QGv8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774259407; c=relaxed/simple; bh=0THtAIFi5jelKh7Fknxn2c5M5CE76ThTcdKm3o+68rg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wj36Zro+3oxj47gxuNi71dG8pO+1iJofheSpWW0QbCb8XUm0vZy8rS/WK+pMohLTMivgxwW/AgvWWjTdWSuKyYPrvLrqJBwoUFZwktEGhPfC+9A1W8zXJyA5Vq+qsMtrLW+CT6iw0tquKPn6LnNpkzPfWV6YOeQziudda86TdaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bk0WrT8e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VGTNvID3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bk0WrT8e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VGTNvID3" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7560l199272 for ; Mon, 23 Mar 2026 09:50:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +1wWjC7fh+aHAvyftVm0FHkxDiI5MU51E2SCcX00kUs=; b=bk0WrT8eGYhDHQ/8 kTp58Qqov/XMKk5Qvbh/+vkZ3MFovJvBlCrkXh/ssLFW79GgxvDhVT3pk55DEPn6 87/pTCPXxC5naCzh+wB+wmFwDZvvW20cZAv/iYk38QTkqrj4knQI7DcD82MPz9Xh UE1Pir65UHTM2AyCaPy64Ag7yftkpSO/jLBjY3wYU7T8lADXS1iUqvuyoTd0n8zo KYlYUQVbehLFaIruIdjYQm391XRKZe5jueXGOvaPvFH/CIwyTsE0K5DnA2d5kzEh RCpYmZztnZcjZnS3TTopX0jMShQU+tYHGTUDG0QHsvTJ9HmSy7yi6ilqLNu1i1N7 1vzN5Q== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1h1e4xc1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 09:50:04 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35ba237d2e0so3038919a91.2 for ; Mon, 23 Mar 2026 02:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774259404; x=1774864204; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+1wWjC7fh+aHAvyftVm0FHkxDiI5MU51E2SCcX00kUs=; b=VGTNvID3+Wt6dm0sFUsx61s+l1OzXRhofzUU/WE0SlMe11onVG3tvQY5Wz6tQ2PxQD tL9RsSlwGeGx6zLXN1nVnkWyUzXXnp0IBpvWMG6TjnodErcIve/SF/N5G9VPDyGCA2R9 XWk8fZDVbgiU1seZxtLdAScY1V2mCoxttWOEsGRMLHL+FV+BF3nHU4xZPGta67SxfEbn VBnDP570yF9lUHJYfNbF4ACqo+OGmal1d2KsxCZjxzqMj8z7v0UQoxhWOKIBS+EZlhtF 4vPcj09OTAIBJC+8NpEzIJj5Lixp3UZGKiJMmrN8IP/5jll5t8euHp7QrJzUBLCFAF74 FTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774259404; x=1774864204; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+1wWjC7fh+aHAvyftVm0FHkxDiI5MU51E2SCcX00kUs=; b=bDrkSO6wpMWFRHM59gjCSecuKUKaGcivVEZXRTkPFMIHn1x6HZMAM9yD/trsj3Kxgz /2SJE72SWoIK+ImRF9GnRCJlcRq05CmkbFkX1Wpnuf1MUNY33/w9+FH6A3zyuYtsfuFT 1hS0kIdgg8n/ZPp+z+MAojlLE3g8e8LI8CLRERLbI1pk3AjGz28pFQWzjmiO8ILPEPmF w7OlWW6FRrR9AEn+s7sYVBaoyNsjFsfn4VXPd0zTl+EXbisdhM2Y+iguF8r2PwWltXgf u4/xe5cUepNzvZTboFnSadamMUHvJQ0CgqbGMWKCAGjh97JMHTWS4P4yUznQvtrT5OBO LMfw== X-Forwarded-Encrypted: i=1; AJvYcCXDcYwuMDXtIeyEzLVNi5+Wr9JiDFkeAnytWN92NheryF8R/Q41ZdJQoJ61pGLwzYIxYREL1wjcgVy3sSk=@vger.kernel.org X-Gm-Message-State: AOJu0YxCm0nFncbYpDAvn7nNz0ZpJiFw1hvz1A3IWcHeI3fIeA8bceRM QqmlOvjTFiFK2HKzE/0D/7uLjfuPXEFCwfQJG8udWIgS1uhBxpDOhFuLj/IutaUbkexrFiveNLO sxQ0JFFEy2dhsJD6xDclPNjtHo9hWY7xA+yhPB6//sj70U0d1Tz4OB525ePFPCe9eDsw= X-Gm-Gg: ATEYQzwB8kSlJGybccuoqGvfgeZFzrqtW0D65zbf/cCUUvBUR1vavI+aJN0JCFhmlmF g+U7AazSPISgcK162O//JXrEXIdgu4YWQqnJ3o8afKDN5sCLQKKhnRsbEEyTfJxYK6zOj5Gsj5Q KKoL7o/cCxL6ygQMGk87+Z0Jr9WF+e3k3eB41ybe7L+HD5FxmKVhLNDUV9JOLn9fmYsXd7OBOuM LnvRuJEozqAjdYiV8Izt4GCVwT3wHLa/GsJHEYhcg6k7t4UpZVFhzef0pa8YzbY0Pe/X+a+RNyK cB1jUTwpqwOrIWm4q3Uiw8EdFuf1vQbwRh74cEoLXoVLUOckg9kJUpjKhQmQHgrWCPp62ZVKhNR M73rpnizhXhV3s5KCECRjWvxIbY5wbvQpZt/S4FZCSm7JqWwZ8uv7evBvZ5jZbwOsWmzova2su6 SibEMVtzof X-Received: by 2002:a05:6a20:7f9f:b0:398:7765:29 with SMTP id adf61e73a8af0-39bceb4772bmr9781610637.34.1774259404262; Mon, 23 Mar 2026 02:50:04 -0700 (PDT) X-Received: by 2002:a05:6a20:7f9f:b0:398:7765:29 with SMTP id adf61e73a8af0-39bceb4772bmr9781586637.34.1774259403738; Mon, 23 Mar 2026 02:50:03 -0700 (PDT) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c743a939af0sm6591935a12.16.2026.03.23.02.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:50:03 -0700 (PDT) From: Jie Gan Date: Mon, 23 Mar 2026 17:49:28 +0800 Subject: [PATCH v16 3/7] coresight: tmc: introduce tmc_sysfs_ops to wrap sysfs read operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-enable-byte-cntr-for-ctcu-v16-3-7a413d211b8d@oss.qualcomm.com> References: <20260323-enable-byte-cntr-for-ctcu-v16-0-7a413d211b8d@oss.qualcomm.com> In-Reply-To: <20260323-enable-byte-cntr-for-ctcu-v16-0-7a413d211b8d@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan , Mike Leach X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774259384; l=5200; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=0THtAIFi5jelKh7Fknxn2c5M5CE76ThTcdKm3o+68rg=; b=wvKikvtR4w0c8IuBLQ6hNVCfOt4BETo1zTmLsmCQTrdtpNZ9EdNhVWueFq/22fodFb/JLm6r2 a+mh0krKnULB0lmLnSI0Gdnj7S5cJ3qWLCjkDmSIZa5e8x1rjkIgcmT X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Proofpoint-ORIG-GUID: NbpLMsxTKmrlyR-xEGhHo2sUOgn-_HOS X-Authority-Analysis: v=2.4 cv=epXSD4pX c=1 sm=1 tr=0 ts=69c10ccc cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=ia3uihG--C1vaqsH_ucA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3NSBTYWx0ZWRfX+5ZSZ2CRuO0q 85kmRCSXpPx+oTH7yCCgyI5BfYv8ExdiTtOy9fcildJQheYv4xJSczxWLS0Nl2NV06p1kQLj4JP SkPrpKJzvtqGjf/nYqlX48zCM8O1ULq3aIbZchTfazdOi9qS6NzyKifa8OeJ5LrPd9DfF+XQN2o CebMXkonT8fw7koIS4DNO+VXCtzBa8nbb83gI3TBDPGq1zEoeXym2uZilj3EBRE1YxoEKaRUca6 ku2een5Qi4K7h7e7gR0nonsPq2jOzbhD1Jij76358FxxsebtvEGx7WrnssziHQkcJKRc2cx0k9r FMWS/dJyszSDaKMEhDjrvQlt7a9Nc+RGSm8T1hnn7hMOu8ahTrnZPs0OCb9WHcZ2Qz/1GH1GXnN IHjHQ272V19koLr8rBFHRHuw4gejK5mKfeyY1QzpWuMk5UfZ7EaFh2qjJR1Nhf/e87cA5WfNvtO VY/ETvZ9ywdpF4NVt2w== X-Proofpoint-GUID: NbpLMsxTKmrlyR-xEGhHo2sUOgn-_HOS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_03,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230075 Introduce tmc_sysfs_ops as a wrapper, wrap sysfs read operations, for reading trace data from the TMC buffer. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 51 ++++++++++----------= ---- drivers/hwtracing/coresight/coresight-tmc.h | 15 +++++++ 2 files changed, 37 insertions(+), 29 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index bac3278ef4dd..110eedde077f 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -228,17 +228,10 @@ static int tmc_read_prepare(struct tmc_drvdata *drvda= ta) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_prepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_prepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_prepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read start\n"); @@ -250,17 +243,10 @@ static int tmc_read_unprepare(struct tmc_drvdata *drv= data) { int ret =3D 0; =20 - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - ret =3D tmc_read_unprepare_etb(drvdata); - break; - case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_unprepare_etr(drvdata); - break; - default: + if (drvdata->sysfs_ops) + ret =3D drvdata->sysfs_ops->read_unprepare(drvdata); + else ret =3D -EINVAL; - } =20 if (!ret) dev_dbg(&drvdata->csdev->dev, "TMC read end\n"); @@ -287,15 +273,7 @@ static int tmc_open(struct inode *inode, struct file *= file) static ssize_t tmc_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos= , size_t len, char **bufpp) { - switch (drvdata->config_type) { - case TMC_CONFIG_TYPE_ETB: - case TMC_CONFIG_TYPE_ETF: - return tmc_etb_get_sysfs_trace(drvdata, pos, len, bufpp); - case TMC_CONFIG_TYPE_ETR: - return tmc_etr_get_sysfs_trace(drvdata, pos, len, bufpp); - } - - return -EINVAL; + return drvdata->sysfs_ops->get_trace_data(drvdata, pos, len, bufpp); } =20 static ssize_t tmc_read(struct file *file, char __user *data, size_t len, @@ -764,6 +742,18 @@ static void register_crash_dev_interface(struct tmc_dr= vdata *drvdata, "Valid crash tracedata found\n"); } =20 +static const struct tmc_sysfs_ops etb_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etb, + .read_unprepare =3D tmc_read_unprepare_etb, + .get_trace_data =3D tmc_etb_get_sysfs_trace, +}; + +static const struct tmc_sysfs_ops etr_sysfs_ops =3D { + .read_prepare =3D tmc_read_prepare_etr, + .read_unprepare =3D tmc_read_unprepare_etr, + .get_trace_data =3D tmc_etr_get_sysfs_trace, +}; + static int __tmc_probe(struct device *dev, struct resource *res) { int ret =3D 0; @@ -823,6 +813,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.sink_subtype =3D CORESIGHT_DEV_SUBTYPE_SINK_BUFFER; desc.ops =3D &tmc_etb_cs_ops; dev_list =3D "tmc_etb"; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; case TMC_CONFIG_TYPE_ETR: desc.groups =3D coresight_etr_groups; @@ -835,6 +826,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) idr_init(&drvdata->idr); mutex_init(&drvdata->idr_mutex); dev_list =3D "tmc_etr"; + drvdata->sysfs_ops =3D &etr_sysfs_ops; INIT_LIST_HEAD(&drvdata->etr_buf_list); break; case TMC_CONFIG_TYPE_ETF: @@ -844,6 +836,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) desc.subtype.link_subtype =3D CORESIGHT_DEV_SUBTYPE_LINK_FIFO; desc.ops =3D &tmc_etf_cs_ops; dev_list =3D "tmc_etf"; + drvdata->sysfs_ops =3D &etb_sysfs_ops; break; default: pr_err("%s: Unsupported TMC config\n", desc.name); diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 6e994678f926..a14645b04624 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -259,6 +259,7 @@ struct etr_buf_node { * @crash_mdata: Reserved memory for storing tmc crash metadata. * Used by ETR/ETF. * @etr_buf_list: List that is used to manage allocated etr_buf. + * @sysfs_ops: Read operations for the sysfs mode. */ struct tmc_drvdata { struct clk *atclk; @@ -290,6 +291,20 @@ struct tmc_drvdata { struct tmc_resrv_buf resrv_buf; struct tmc_resrv_buf crash_mdata; struct list_head etr_buf_list; + const struct tmc_sysfs_ops *sysfs_ops; +}; + +/** + * struct tmc_sysfs_ops - read operations for TMC and its helper devices + * @read_prepare: prepare operation. + * @read_unprepare: unprepare operation. + * @get_trace_data: read operation. + */ +struct tmc_sysfs_ops { + int (*read_prepare)(struct tmc_drvdata *drvdata); + int (*read_unprepare)(struct tmc_drvdata *drvdata); + ssize_t (*get_trace_data)(struct tmc_drvdata *drvdata, loff_t pos, + size_t len, char **bufpp); }; =20 struct etr_buf_operations { --=20 2.34.1