From nobody Sun Apr 5 18:02:16 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 378623CAE7B for ; Mon, 23 Mar 2026 17:25:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774286752; cv=none; b=q7qvtlZXhqI8CsrF2yVm9gtvP1fMw7Ge/H4u+35BjzDLsFMIE9yZ1mPfLa03+zXJVaXGPTvWhnBlXzodzqHIDG/spnIlgt6PAE9NuZ5fUDfMN0KrSng9VoKSwySgc/cH15eo85+br8zfxXRpJImKssYC/jew6DdTYPkBStJsTP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774286752; c=relaxed/simple; bh=WDIE7lt2EMyOXFUD9TIulldMehjU0ziYiCpz80CIxbU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FJGIVOkdueDuSX/tsLblHu4PTGQe7fS5bmPF18j7oZDguEhJ518wInhBOOZytSHX6vkUSzr5PhBwrRBrLQYC4PFs7rKFXDYztC3xnp0bB8ZbCoC4pAv48c06YxAN2p7AsriffNRTxWJ6N6y3xxX0dhWX+mkLv7AfApDSlYtSuzs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CnRirpEQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hFHirqAD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CnRirpEQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hFHirqAD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774286750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z3ukp7lwYjI/rsNx0zgB5rYQ+pIaxNH93AMrhUusdCA=; b=CnRirpEQq4inVDZWRIIG0mSKQSmZKc+WSESa4diewVYhtpwrOJBG0RkfehTwXazjHbhNqP 9gGhrfNARPNRYv3UwRM9v15WbL1fZc9OKs485N49ICEXP2jEIKD9jlBcH0wzwWnVNxfT2l js3daZwE/xv1/whuC5vuqVJR0tXOivw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-9ey77zizPF-W9pMxBJEApA-1; Mon, 23 Mar 2026 13:25:49 -0400 X-MC-Unique: 9ey77zizPF-W9pMxBJEApA-1 X-Mimecast-MFC-AGG-ID: 9ey77zizPF-W9pMxBJEApA_1774286748 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5090e08dcfcso19609731cf.0 for ; Mon, 23 Mar 2026 10:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774286748; x=1774891548; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z3ukp7lwYjI/rsNx0zgB5rYQ+pIaxNH93AMrhUusdCA=; b=hFHirqADkLZ9z1GG0koNOIfTZdub0UGxFX7RzMWtla66a/Ps47/F5PqWKehxtWmXdp bFQFul0Garw+Er2pMyBZAhGTmdondlK8j4J6OZgLv15f5t0WXmW8PVe0+BBFThOeBjhn Q7rflFApGEatx+2sLCV3Xhhg0GOE0xcZye8KDIywz42NVzCRafD22/E8iSILMlWSo4EI RcLtUTHd+7TawMbLKzGp+lekfovScP/nXdbit2rtLXAkDISs1s/KBtMKazP4kJIrpxIA ubF9gmsGykDCU1eFmnSAjLpxvqdAvKy/zKUJLf/RCZ07K088x9mzCfKusuWfUaF2Kl9k xKKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774286748; x=1774891548; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z3ukp7lwYjI/rsNx0zgB5rYQ+pIaxNH93AMrhUusdCA=; b=kWp7h3INn0aaYGKeXkNjExE4gMe1Dlqs/+WA8gfTAlf+yXrUoxqZyNY6CeE6MFs6t2 OHq59umxJZjlSX5m9lnxr+ba5zFQp2qL5aSiCyYFqM9blGMoT5AYH7NPv1y/3kVB/+7c VSkJUDhi+WwA0a0STBSAIIS9PQmz5HXlP9r8CfdOG5tfKjdu/CeOaikYh6PkYgIVYNuL Ah7lKZya9HJCnv8eckKU5EzIeyTDfYo2GU9F0yHybXi0CRmQxqUd1tB3lVrMPLQqGh+m ZukbovUuURu5hqmtHrotxhBDlLEZqt9U9bWf5oXI887G9ie2MI4Y560oZaL0mMsBcLKm CQJw== X-Forwarded-Encrypted: i=1; AJvYcCVWq5IR/V0fPM8oLhL8P8JMA7aBJGWKue43gOwx6bGZQvqlidrYH1hnTvO8wTpI0kKJdoh3f/4NVHxZZfE=@vger.kernel.org X-Gm-Message-State: AOJu0YxEfiSX90JtNcOkovLMJYn++7Xu5XFW7WgIzrsJl61O+l459j/i dJAqfydfO/msMDoCm/sZd2EAQBAoFU/6PUpfwgWxAD8QnZorqm6GVCRiOxPoksz/CWVZjNDQawm 49ZHXClp8uygVJ8qXBTYqBZeij/VKosJy+Y2pp7sYQQ2M2p+rVTEH3Ra8dfAMcvVwow== X-Gm-Gg: ATEYQzwJg1hj2sZUeP7jB7la53aHWe7kOfBCXmB7yUhMMNmHd+beT/jfw1peFUDZG9P Zrk06R6fl+H0DJbQo6o22FaxjE/BmEpp0YNRKxfIpePTGuIT1xof3JcXY68WOmQ4A1yktQCo5b4 DTl+F+fRn2DdsyCVmk6t6e7CEsJRUHi99BcIlBtMqhJl+edTMICL/R4y20HTxA5y7rPx/31LnrY S0B9SM2OBLJcBXR+ik0dOAX4bpKJxihUbpTwktLi1+1d5ek4aDE9EgyEHvA9qFn5QCeXonlP+DW boJ49lvlOywyoFC+iiyqD5TxPiHteX6iIo4d7PYb183rxbJNt8hKJs3PDUax6qqd9kzf4X99G36 eG5MDmdFcycw4XbC20KXZu0kJU8sA9kOfxwIjDdf98csXHrtMkE5wiMQi0a1W X-Received: by 2002:a05:622a:1b91:b0:50b:3895:facc with SMTP id d75a77b69052e-50b38964598mr190997811cf.14.1774286748525; Mon, 23 Mar 2026 10:25:48 -0700 (PDT) X-Received: by 2002:a05:622a:1b91:b0:50b:3895:facc with SMTP id d75a77b69052e-50b38964598mr190997271cf.14.1774286747947; Mon, 23 Mar 2026 10:25:47 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50b36e34f8bsm108249661cf.15.2026.03.23.10.25.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 10:25:47 -0700 (PDT) From: Brian Masney Date: Mon, 23 Mar 2026 13:24:59 -0400 Subject: [PATCH v7 8/8] clk: divider: test: mark some tests as supporting only v1 negotiation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260323-clk-scaling-v7-8-8e7193dc9405@redhat.com> References: <20260323-clk-scaling-v7-0-8e7193dc9405@redhat.com> In-Reply-To: <20260323-clk-scaling-v7-0-8e7193dc9405@redhat.com> To: Michael Turquette , Stephen Boyd , Maxime Ripard , Alberto Ruiz , Brendan Higgins , David Gow , Rae Moar Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2824; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=WDIE7lt2EMyOXFUD9TIulldMehjU0ziYiCpz80CIxbU=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIPlnd7nekL2qX8bduML9Myd8kVr5HjsOVqK7KZxF29k rlZa411RykLgxgXg6yYIsuSXKOCiNRVtvfuaLLAzGFlAhnCwMUpABPpEWL4K/78FOOH2VHrQj+u Upsw6VKjbPkOA56bPlKvJI1/feTt72H4p1jnZVS79fZtlqqAm6tSlVaureJJenehqH12x6e6Bwc TmAE= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 Mark the tests that only support v1 negotiation to make it clear exactly which behavior is under test. Link: https://lore.kernel.org/linux-clk/aUSWU7UymULCXOeF@redhat.com/ Link: https://lpc.events/event/19/contributions/2152/ Signed-off-by: Brian Masney --- drivers/clk/clk-divider_test.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/clk/clk-divider_test.c b/drivers/clk/clk-divider_test.c index a16c04d5d8a86952b42750d326f88754fbc91eb7..646307f1d78a08130a8a552b578= 74e21b07f7b4a 100644 --- a/drivers/clk/clk-divider_test.c +++ b/drivers/clk/clk-divider_test.c @@ -54,6 +54,15 @@ static const struct clk_ops clk_dummy_div_ops =3D { .set_rate =3D clk_dummy_div_set_rate, }; =20 +/* + * clk-divider.c has support for v2 rate negotiation, and setting the pare= nt + * based on the LCM, however we need to be able to test just setting the p= arent + * rate based on the LCM, and not set the v2 rate negotiation flag. This i= s to + * demonstrate existing behavior in the clk core when a parent rate that's + * suitable for all children is selected, a sibling will still have it's r= ate + * negatively affected. Some boards may be unknowingly dependent on this + * behavior, and we want to ensure this behavior stays the same. + */ static int clk_dummy_div_lcm_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { @@ -197,6 +206,7 @@ static void clk_test_rate_change_divider_1(struct kunit= *test) KUNIT_EXPECT_EQ(test, ctx->child1.div, 1); KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ); KUNIT_EXPECT_EQ(test, ctx->child2.div, 1); + /* This test is expected to work with both v1 and v2 rate negotiation. */ =20 ret =3D clk_set_rate(ctx->child1_clk, 6 * HZ_PER_MHZ); KUNIT_ASSERT_EQ(test, ret, 0); @@ -229,6 +239,8 @@ static void clk_test_rate_change_divider_2_v1(struct ku= nit *test) KUNIT_EXPECT_EQ(test, ctx->child1.div, 1); KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ); KUNIT_EXPECT_EQ(test, ctx->child2.div, 1); + KUNIT_ASSERT_TRUE(test, !__clk_has_v2_negotiation(ctx->child1_clk)); + KUNIT_ASSERT_TRUE(test, !__clk_has_v2_negotiation(ctx->child2_clk)); =20 ret =3D clk_set_rate(ctx->child1_clk, 32 * HZ_PER_MHZ); KUNIT_ASSERT_EQ(test, ret, 0); @@ -265,6 +277,8 @@ static void clk_test_rate_change_divider_3_v1(struct ku= nit *test) KUNIT_EXPECT_EQ(test, ctx->child1.div, 1); KUNIT_ASSERT_EQ(test, clk_get_rate(ctx->child2_clk), 24 * HZ_PER_MHZ); KUNIT_EXPECT_EQ(test, ctx->child2.div, 1); + KUNIT_ASSERT_TRUE(test, !__clk_has_v2_negotiation(ctx->child1_clk)); + KUNIT_ASSERT_TRUE(test, !__clk_has_v2_negotiation(ctx->child2_clk)); =20 ret =3D clk_set_rate(ctx->child1_clk, 32 * HZ_PER_MHZ); KUNIT_ASSERT_EQ(test, ret, 0); --=20 2.53.0