From nobody Fri Apr 3 22:12:19 2026 Received: from mail-yx1-f44.google.com (mail-yx1-f44.google.com [74.125.224.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DDBB23643F for ; Sun, 22 Mar 2026 23:27:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774222024; cv=none; b=cMHmafvtXcYyHTOZGr5/OsS6Vs5976+3Wdo+igBK8wuqHKtHUbm5ByyBHFVqktc3rS2DSSF2Ecuzytxd75w+y+qkP3LvxYsRiK9gfndH4ZNzZtgcR72yv/nzi2Qzhc62M5JTaR6mZ6wWDqjvvUuMFO4k6/IOOejRwo1GpVjg+Vc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774222024; c=relaxed/simple; bh=W/yF5lL7zNLB/RmCqoV0rM+9jBDhS3izJTYQh0pbg9Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HGgvn2Pd+d9gflA2gX3aPydvx5rqT4WfpoahOb5JRZZFOuH2nRkYUzZcxZThy8Ee3p4w0crqoeKzY3i7kDh8PErPzQej8HuwrAWxL27CxwvmSMs90PVfSLqwU61TzKI7+K/aUZaULCqzGbofyZGAGlJLGhstoOCPqGyzFNeLzG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=euCh2Dz4; arc=none smtp.client-ip=74.125.224.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="euCh2Dz4" Received: by mail-yx1-f44.google.com with SMTP id 956f58d0204a3-64ca4dfdd88so1995705d50.0 for ; Sun, 22 Mar 2026 16:27:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774222022; x=1774826822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=79irvevPis3NJOuw3eys97iKO1lUPGBxfD6xP3kvDIY=; b=euCh2Dz4Yy1g217Zm9nYhnofrAdd390pEnStmcUoQ/PvdZat2PSilLNGnm4FKSlgUa 2ePLLoO02M3t+8dZspAVo12mNrbM3VZorIinPySKsrVnNoRGkkf8540Nr6dMpNCsoeKm wDT/IcbPBSfQilMJxxdUtiuo4fXpbYjDJrT6FSjBjEayJAjjmiKhfstnEunT2kwttVko pQfyKsJCU336x9E/kTqIkv/NY5RoNxGOFUwtf9GzwhRAJkvLzPMxYcTWfr0BfsokmIzR gbnRsM+t7JZOGvUXDICAwDN6yCcj7JOhnsmcOFMkmdz5sn8Zddpj+IW1v9U34b0P2hir 6SCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774222022; x=1774826822; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=79irvevPis3NJOuw3eys97iKO1lUPGBxfD6xP3kvDIY=; b=DuNB8cnlZQoFe+sek7wVbWLSOMOCdy2O1N0jZN7pavQFXmS9Gb0nPdtRfdLHL8hAbX FWVJRNwsW7k+WHZv7f2gCz7KA3Qnf2mBxEYyvfgAbwndYAY5cI0z8laJUPYZqKBo1LLe pfPBZlwXyl3ZxvI58YsD+SnDlkFnAb9EBReqKX10qAlUGNB7MemKTeJkQGILLfB2hkRo ep0JtxhMPAOpg6gzy2H90JWUZQhjRvsciYuHiPcMKQEnzNE4+BdDaz/LCG3Ih6YxdEbq 81XtftWkmxkYg9ZDTJGa/0zvQfa3AZ0bcJKcUnhj1NySG3waQ4J4gmSMdiiUlxFHWEcZ spsg== X-Forwarded-Encrypted: i=1; AJvYcCUg34VLro9IyRRbUax9AsWP7NTfadyo66mApptR89/FkD5m0qb43H+h+QOlLb+2rkDh6eqHmecswo3L6Yw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6qO02BKxO5qUi8jc4Vd6dfsMWhzg40havnNqkzF7gAVxw311c /jJZ37pbgr+nxjDCdN4EiyNEThzTXonldaYKNUKOoWe/XrhafJexKN7i X-Gm-Gg: ATEYQzwR8UJs74L/XPgR4GPoy4OCMH8pYiIJt9orN6W54LT2qYgF9IsIQWNv7RIGU6b qLBiHP/Adlai2bD6h4U4kiE++C0GGvKuTIsaI4QFSVG1Vpj84if2ibcWeouhuKZOneIBhtKRXMm Vwl+gJ+sluwQmwcnipQr0GRBr84OZ1bG/c1V6riSd1NTbLQ46mLkyKgJjRmgpjAPK1hwQz889rL Tyq6otR4borlO4wLElYb0PbZAMbFp3gV+VDw9j1+NLAAYT78fhB2MYXCl0ibWekMPjRcR1mO+aJ 5ICMg+U+66Rlh9l8CxYXrqWnEr6Vs84vze/buc4ey3bE2//cjBLVk7JTwwGGicEsa76fMHD1jqA cL1tOXE88l0byNJYwmnjDF6Q7cQgQdChgopXJnoQEOs/YKJ583EaDJjw9UAhbqWZ9OqGTcFI0R5 /ZBvqNl6TKwWjs8BVq1vXTExkGa40J1Sinjru/vDWyLFrkmvrQWiJqu+9+9DF96RX7e+ZXcuu8O 23tcx7SWBi1hJtbhjSPGaZV X-Received: by 2002:a53:e184:0:b0:64a:db1d:2d57 with SMTP id 956f58d0204a3-64eaa69eeebmr4054217d50.2.1774222022375; Sun, 22 Mar 2026 16:27:02 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::f769]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64eabe7e343sm5337755d50.11.2026.03.22.16.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 16:27:02 -0700 (PDT) From: Ethan Tidmore To: viro@zeniv.linux.org.uk, brauner@kernel.org Cc: jack@suse.cz, amir73il@gmail.com, paul@paul-moore.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] backing_file: Fix error code swallow Date: Sun, 22 Mar 2026 18:26:55 -0500 Message-ID: <20260322232655.1164614-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macro WARN_ON() returns true if the condition inside is true. So if there is an error with vfs_open() 1 is returned. Capture the return value of vfs_open() then run WARN_ON() on it. Detected by Smatch: fs/backing-file.c:52 backing_file_open() warn: passing positive error code '1' to 'ERR_PTR' fs/backing-file.c:77 backing_tmpfile_open() warn: passing positive error code '1' to 'ERR_PTR' Fixes: 7ea30795d6b7d ("backing_file: store user_path_file") Signed-off-by: Ethan Tidmore --- fs/file_table.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/file_table.c b/fs/file_table.c index e8b4eb2bbff8..0898b1816c14 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -69,8 +69,12 @@ EXPORT_SYMBOL_GPL(backing_file_user_path_file); =20 int backing_file_open_user_path(struct file *f, const struct path *path) { + int ret; + /* open an O_PATH file to reference the user path - should not fail */ - return WARN_ON(vfs_open(path, &backing_file(f)->user_path_file)); + ret =3D vfs_open(path, &backing_file(f)->user_path_file); + WARN_ON(ret); + return ret; } EXPORT_SYMBOL_GPL(backing_file_open_user_path); =20 --=20 2.53.0