From nobody Sat Apr 4 00:05:50 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A7A637C11C for ; Sun, 22 Mar 2026 19:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774206435; cv=none; b=jkErbU8ASSHnd+dtYkzW2Evw0QTb2aMTzVxS4+FGqE1zC4KZqD+k4/hXiQn6XPa7DA8rJ4oWuWgKXcmSjkeGWZBOxXdJYBPUf69AwB70PRU5hj0Ra2hEy21i1c7UMUeX2k7cMoGaS8wwvVxGNpb546XE54Q7HhZ7bXvt406UMBM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774206435; c=relaxed/simple; bh=cUQdFgJp+vRzURST+mEj40buJgJjr19u5nHUQ/zSxsE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jPFcJoACNaTXC6CUIoPD3OcUqvjDtvo/I3BXsejv+QEED/It0BnkHZrnOKga0JjbMkwuc6UEkdroT2jKudeB7fI6gKh95cHguT1DvRF6bn5mPEWV2ZnPu7Hikaos28krpUVuFuUJqic7J3rW+Zs+QIGZFUv/+VvN9gRamo0gP80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VpE7PO20; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VpE7PO20" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4832c8f9d87so5658125e9.3 for ; Sun, 22 Mar 2026 12:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774206433; x=1774811233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SMegNoYPQ15g9bb1XM2RAfuMgiTFEwFZRaFEUS/laHQ=; b=VpE7PO20RaA12vy8qad625wgY5ngwlA/fZLv7AumhMvhQnASbnO9T7fkje4n2Nj9u2 ++oYH2PkYYo1oBDXnClSWSZ6JSZuFyJc9kFOorMHFTSbDVueN643yUI+JZ+Klm0NX3YB Wx7nMw5lzejQ1DS/6D3CnbE4HyG6jfveISMyzSwUjzNIx0Mi7zds572YTUy1KM5Xgnl1 ZUsRGtszDU2AYa9QXWZBvjmQtGs7a0sibX5iysx+A4XU+1wM+MUSnX9AWs6+4DHU6Nbo 4OaChUSDAZAoowzYk008HZT3DZQtrEZI7X9uouk0MHylxtuQYeeuqmmnZNfTVRqKGiko bsgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774206433; x=1774811233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SMegNoYPQ15g9bb1XM2RAfuMgiTFEwFZRaFEUS/laHQ=; b=UBLC9aF74bNAst1xvyEoF4/nP1+uveYm5KsXG7I0FYEDAr2j2pE0uaMf199Ugn7ajU brwd8v5GMS5cjn/XkjiwkajINpajGNm3OMfvTN9uzzRkmnRGhZvYbfKjD9Ulyfipmucp rDC19Tk+Bko8RdesH3VFF0dMX2xBHFSU7IeV7CKTqT/KWdbPxgKfa7xIlatNH3ONcJM2 qJEvvLrvcW0x3uRKUvHw7C+mVi1tO8yHyTq9gT9WuQpq1ZYBnFdknsWkKkHe4nJ0jf8D lRWaK/udP8Fmo69j+G0etKN0SQ2ULd7D8iydca2yrdFNW1T8Lw5NR54SrsCd6tMCfHqO CESA== X-Forwarded-Encrypted: i=1; AJvYcCUyiO/kQLLfja9/cCwtfPVnAIR1CIRZDHLzYtbSDgQaRvnHAtBfO0a4sp642s8Sv+S4pXERWMMsHIuEVfs=@vger.kernel.org X-Gm-Message-State: AOJu0YxUt1V4s2CSl+ZkocrUAopXhFDe/bwSVjHd6saMaha4OQCORLVZ tandUUl7xEAIYXSEcm/9p2NZBCedQAf0PJvUZDBrhDwF0fWRTVrdGMm39R6ZX7UL7Tf5hg== X-Gm-Gg: ATEYQzyGoIjxh/Fs56OyFgjN3SyeUybVbFRxQfTCJTsx3Y4WydUO0LIWgkYdUqxZTU8 9pd99e4BbidgL+J3PKIMhnkOJLhQ4SgeRmjdqM6RxHdIlzONi5PM2hgQwq4b6gwFqyM1u+YbdZs 4NpCmr0lD8h2eb6UiVmrFSzvPzzNUGpsws/mzOC9ObVXmZnBKpVnAWrOY1EmZOW7jPgTp9OVZrI v8NswA9tTHjQLIpWEs8Ac/Cq25I7BOViS1NDkkSI6YqzFGQCsZa8+m1beRx0MnkwAf1yBjCbABU sripWqB/Yjs8TZM42dtIEiLZ9lnhXzG2oiJtNgBBFcTTCvziwmeRZa0baDMHpXlBaBBI4Vl6Dun 9lUvL2I40oLz7mguwi4kDrTifJ20G8z0FzrmOUgRK3IITLcJix/wQ2F7nO6oUXthit4HkCTpjMA EdJRrcrZ9ZVcXMmND1bOal1ORRH8YPBxlnU87fpTb2dE+5UbuMRBn9PYxmu1FkE8bhKD1tzms= X-Received: by 2002:a05:600c:3554:b0:477:aed0:f402 with SMTP id 5b1f17b1804b1-486ff01d81amr85441425e9.8.1774206432823; Sun, 22 Mar 2026 12:07:12 -0700 (PDT) Received: from localhost.localdomain ([46.155.1.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe868cb1sm63340595e9.5.2026.03.22.12.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 12:07:12 -0700 (PDT) From: Emre Cecanpunar To: platform-driver-x86@vger.kernel.org Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org, krishna.chomal108@gmail.com, Emre Cecanpunar Subject: [PATCH v2 2/5] platform/x86: hp-wmi: avoid cancel_delayed_work_sync from work handler Date: Sun, 22 Mar 2026 22:06:21 +0300 Message-ID: <20260322190624.35162-3-emreleno@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260322190624.35162-1-emreleno@gmail.com> References: <20260322190624.35162-1-emreleno@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hp_wmi_apply_fan_settings() calls cancel_delayed_work_sync() in the PWM_MODE_AUTO case to stop the keep-alive timer. This function is also called from hp_wmi_hwmon_keep_alive_handler(), which is itself a delayed work handler. If the keep-alive work is executing and the fan mode happens to be AUTO (e.g. a concurrent sysfs write changed it just before the handler read priv->mode), cancel_delayed_work_sync() tries to flush the work item it is already running inside, causing a deadlock. The workqueue documentation explicitly requires callers to ensure this self-flush situation does not arise. Replace cancel_delayed_work_sync() with cancel_delayed_work() in hp_wmi_apply_fan_settings(). The non-synchronous variant cancels pending work without waiting for a running instance to complete, avoiding the deadlock. The synchronous cancel in hp_wmi_bios_remove() is unaffected and still provides the final cleanup guarantee at driver removal time. Signed-off-by: Emre Cecanpunar --- drivers/platform/x86/hp/hp-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-= wmi.c index 0cb2a2b31998..41769c0861e5 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -2365,7 +2365,7 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_hw= mon_priv *priv) } if (ret < 0) return ret; - cancel_delayed_work_sync(&priv->keep_alive_dwork); + cancel_delayed_work(&priv->keep_alive_dwork); return 0; default: /* shouldn't happen */ --=20 2.53.0