From nobody Sat Apr 4 00:05:53 2026 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F3E736680E for ; Sun, 22 Mar 2026 19:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774206434; cv=none; b=NYI63eRq3e5u6OrfEPpFaho1Q4PF6+kyqTsXVGUIgd3oOXFMkS2Wq4Oi8QmH6EF1hNzyBVGvBRZFAdisiP3vLPpHBCKBDwbgM13l3on3nBQJZImlvZFlRpuULsXEvhk/BW/VzDo5U6KsSiBRbn0WGumCxT6emuAAWvQo3JiBFE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774206434; c=relaxed/simple; bh=a65n9qrxIlLmhNIbEN4ovVg4f46IUX7I1DiASQ8NWOg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h2XDLsZv2hiYGWgoVOwb/0LHHgNx0cwF18npwwoCvJkvR2Ba+Qq0cGUdXppnN/2PfuSP//yjGgLyGEa9SxV9hTmhLHWqWTIS0p4YUIefCtsBb8BjXVAhf3diJ8GhWMjsNXWQrifEzTxQzg3I7MyIxrKJORyK7CoHu8JhvgQqbBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OHp2OwzD; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OHp2OwzD" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-486fca3245cso4969585e9.2 for ; Sun, 22 Mar 2026 12:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774206432; x=1774811232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P9+vTI8xL38TJIAAcKMuD2MJ4WOoS3U7UcRhiuvjKaM=; b=OHp2OwzDMfAclDebwDoDFfA4rqpAfQ7RXKgicMsgynOCZE2n+RTbvvi6h6FbHLWREk RsA1wb55af78KPnyBN9NTpimfKRVFMyYiZbkG3SdBLXwZYatFL4FpiJQ0VBSJwyCfi8W ha+F+rZnn/KZ3Tvb/UUe576Kki0nAAL6Yv34oOgnZegR4P6nf4cPPGQKcUwXMg+qc/Hv RfglimAQwv3phPoFf66kX9ym/VpxJY7vkoWm0FxP2cROlqZOm5YIxBE2yL7pKOU+aGIK 2OZzrrdomeVJ6ZLBdl2QoDxFUsNmzbGRLds5q1jSvuWXCau+jDWOlQfRN4Q+yGsAW/ZN xbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774206432; x=1774811232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P9+vTI8xL38TJIAAcKMuD2MJ4WOoS3U7UcRhiuvjKaM=; b=ORfghD9Uyev5uMcyVqwJAqVHrp8J6VaJ5ZSUqJYjBSbxo8YDL7BoTQqDw5QclDhlWg z9lJPQ8rfBnSU2lxMMfxGcMtzTlS+rAnZS0RondfPfHBd1FKm8WJh0TGzq1+F8f80YG1 dSUz6C6S0tdOgSJ3DA/BVldX+NT7MOib/BsbN7OE56JY7JDg4zblGPE7VYBb4VS7AFOp xhwh+QgwNzQLHim7XqoMyvHIm2IRdRA57lngc0N4iNdqB89RiLeq4Gush6Das8g6ASwP 7aEJ7KA2519vlVaQfiU0IbaepJHfVSSurjW7tRjJz8hhDUxQWlQvsH+502NwoYNe1E0c q+LQ== X-Forwarded-Encrypted: i=1; AJvYcCXBiIb7GtWS2mlDaD5p+BmO2UsHP4BZMrd+X8h2aR/8ocXvhZSQrq8B16X9RHtKd48LZkxm56KwikChhV0=@vger.kernel.org X-Gm-Message-State: AOJu0YwnWAXwhCS6arb9XWuVW4MllFEwUL5Nygjr2NG53H9LK592OmEd KHBeKPJ+uZ5+jUx2D6AC1B2yT5tLs56Se7mj8Ul/Ca/xFPtHC69bIF4x X-Gm-Gg: ATEYQzwX38ns4iE+8wnu7aKN4g7oPD3f6JrqzQJP4WckLz9cofxXxS9tz6GpPewFtNe 2V9mSxdisz6mjAHRnYAKNr83OOLCd4dLPv1DOIuEE3MdGOhAtYwAg/wpc4BGYAKT+3KhFsycoOJ nGj3zbTlVspJ4f69GFCgGmohOr5zFXw0STO9u4n86/yTGYDah6MFdKUT8P5QN468OnWNr3bXwk7 54HkNdgG2gu97k88kpCC1GY9gpH2qdeue/imHq9iDj5vXl5Y1k6DcwxYmCav3O/zzO6WgQUlO5r B1J2TiW5vi6Dw07ticPhB+MwgGSeXfPAiAQPv6yJCBFYRpwNr//JYn+3sdWAhg73+q+k/YXDb+u nMxif5l03X26HjR2E0thrpP4TPqWRroTs/pR1D/CCfNVyPP8Vh7AC6NOJ2mY2E4tTEEDRStFgTp sRqMnTu3NwQD9k8SGFOeLdTAxrK+/ldKg6yW7+6avpVHLZDFlXPyG3uZiTbtGu6OLoynKX3sE= X-Received: by 2002:a05:600c:3ba6:b0:47d:6f12:de57 with SMTP id 5b1f17b1804b1-486fee11756mr83906405e9.4.1774206431316; Sun, 22 Mar 2026 12:07:11 -0700 (PDT) Received: from localhost.localdomain ([46.155.1.197]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe868cb1sm63340595e9.5.2026.03.22.12.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 12:07:10 -0700 (PDT) From: Emre Cecanpunar To: platform-driver-x86@vger.kernel.org Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org, krishna.chomal108@gmail.com, Emre Cecanpunar Subject: [PATCH v2 1/5] platform/x86: hp-wmi: fix ignored return values in fan settings Date: Sun, 22 Mar 2026 22:06:20 +0300 Message-ID: <20260322190624.35162-2-emreleno@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260322190624.35162-1-emreleno@gmail.com> References: <20260322190624.35162-1-emreleno@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" hp_wmi_get_fan_count_userdefine_trigger() can fail, but its return value was silently discarded in the PWM_MODE_MAX and PWM_MODE_AUTO cases of hp_wmi_apply_fan_settings(). The same function's return value is already checked in hp_wmi_fan_speed_set(). Propagate errors consistently. hp_wmi_apply_fan_settings() itself returned an error code in all paths, but its callers hp_wmi_hwmon_keep_alive_handler() and hp_wmi_hwmon_init() both discarded the return value. Log failures via pr_warn_ratelimited() in the keep-alive handler (rate-limited because it fires every 90 seconds) and dev_warn() in init (non-fatal: the hwmon device is already registered). Also remove the unreachable "return 0" after the switch statement in hp_wmi_apply_fan_settings(): every case branch already returns explicitly. Signed-off-by: Emre Cecanpunar --- drivers/platform/x86/hp/hp-wmi.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-= wmi.c index 68ede7e5757a..0cb2a2b31998 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -2334,8 +2334,11 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_h= wmon_priv *priv) =20 switch (priv->mode) { case PWM_MODE_MAX: - if (is_victus_s_thermal_profile()) - hp_wmi_get_fan_count_userdefine_trigger(); + if (is_victus_s_thermal_profile()) { + ret =3D hp_wmi_get_fan_count_userdefine_trigger(); + if (ret < 0) + return ret; + } ret =3D hp_wmi_fan_speed_max_set(1); if (ret < 0) return ret; @@ -2353,7 +2356,9 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_hw= mon_priv *priv) return 0; case PWM_MODE_AUTO: if (is_victus_s_thermal_profile()) { - hp_wmi_get_fan_count_userdefine_trigger(); + ret =3D hp_wmi_get_fan_count_userdefine_trigger(); + if (ret < 0) + return ret; ret =3D hp_wmi_fan_speed_max_reset(priv); } else { ret =3D hp_wmi_fan_speed_max_set(0); @@ -2366,8 +2371,6 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_hw= mon_priv *priv) /* shouldn't happen */ return -EINVAL; } - - return 0; } =20 static umode_t hp_wmi_hwmon_is_visible(const void *data, @@ -2509,6 +2512,7 @@ static void hp_wmi_hwmon_keep_alive_handler(struct wo= rk_struct *work) { struct delayed_work *dwork; struct hp_wmi_hwmon_priv *priv; + int ret; =20 dwork =3D to_delayed_work(work); priv =3D container_of(dwork, struct hp_wmi_hwmon_priv, keep_alive_dwork); @@ -2516,7 +2520,10 @@ static void hp_wmi_hwmon_keep_alive_handler(struct w= ork_struct *work) * Re-apply the current hwmon context settings. * NOTE: hp_wmi_apply_fan_settings will handle the re-scheduling. */ - hp_wmi_apply_fan_settings(priv); + ret =3D hp_wmi_apply_fan_settings(priv); + if (ret) + pr_warn_ratelimited("keep-alive failed to refresh fan settings: %d\n", + ret); } =20 static int hp_wmi_setup_fan_settings(struct hp_wmi_hwmon_priv *priv) @@ -2578,7 +2585,9 @@ static int hp_wmi_hwmon_init(void) =20 INIT_DELAYED_WORK(&priv->keep_alive_dwork, hp_wmi_hwmon_keep_alive_handle= r); platform_set_drvdata(hp_wmi_platform_dev, priv); - hp_wmi_apply_fan_settings(priv); + ret =3D hp_wmi_apply_fan_settings(priv); + if (ret) + dev_warn(dev, "Failed to apply initial fan settings: %d\n", ret); =20 return 0; } --=20 2.53.0