From nobody Sat Apr 4 01:51:13 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838FA381AE6 for ; Sun, 22 Mar 2026 12:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774182274; cv=none; b=rLzH+2K+n8KN8Dg9RXYU6EiWZmzGDo8T8Prz4LL6l6nIjImsRlhBh/Dw1HV4Fdq3O8/+b8nJcGsvjV0bSDYy3ms61MLew6UD4ylU0L/qLMEx7C/kDufV27fzKqsdbQ70ye0lKjlxlACN2MhRSGHBiU+QzPZcUHGHmO3B/oBtFVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774182274; c=relaxed/simple; bh=4Bp9lpvpFJLHE6GKmGDfWerhcPBCMqideHGuARLZtts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qMiM5o6gMxDnIljPAUyQJDhEDA2Tc6aOWlK63x/pP3ZbIVbW089I/tKDh0D+AqbBQJqxxXyiYYFSIXpORYxexNnYZh0QqPFoYCumzWKDqfKjyybYF1jM5InYv/r4Oa8AO+rLain/W52JXt4FgczF3x9RzX4vZz4M7cAN2OLID0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BBFPFZnX; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BBFPFZnX" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43b3d9d0695so3038213f8f.0 for ; Sun, 22 Mar 2026 05:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774182271; x=1774787071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GNAwTwMGjBXpze3/2lHvMgp/fmlNJqZmlodbykzkXLg=; b=BBFPFZnXNvWbm/NyrI6Dc4QGAZK6l3ZN2shCtDLVwwb6aeICrcTeQIgCUExqGAfwn4 HarLsujfebjDr61n/oMoDFgdlLjBDOTrKeRQSkcIukphP/tKf2YeXoScT4dVaoK2B+NA MiH2pj87cMm/D5a4b48YvGvWy2ihEDGc3axmHGX5Cl1iJyhWG8Zz4c58DfTTHTN0Tt9d HwYKDdyMWgzsqxOX7w1vLic0qslIFLHBdV9YDnlha8kfGSGp/xgX94NJLjnoCPjjsqzn XRR1VO27xu8IvKjzFNMwL68GzApXVQHxAHxEY2hfBcmPRCKBacXjiot4CHhVO88ZuBfc wkMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774182271; x=1774787071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GNAwTwMGjBXpze3/2lHvMgp/fmlNJqZmlodbykzkXLg=; b=dkRDXH0DPgAuUnvPeHx1i/YwGfWEt8+ETnTBADb7sVW71aATvNeeSFNqY2CLNCn4hn m/a+YIikAt4Y/BmilTFo/7RbbVvHoNmvworl8N0NaZfS0nhQCOy0/gxzo/lfx1fHfM7D H7zzBe8rLgTUkJrkrg+RDBHCnBXv+2vfx90f+/Yvgwq4i+sVcpoqOcvjuUUkqAOb9h7Z TK05Nn7ITm0ASi5s2UbW9o/ijjNfEGhSdcZT0CJP6R0pyJ9t+OZ0zfU7E50Tp2oPWFBN Lk0HuO8tEVVnnS7phpQWkjvE7a8dl/d7epEAHW88aq/r6AXvlVdQtg6UY8HcagqnOtQj SM9g== X-Forwarded-Encrypted: i=1; AJvYcCVqa5TWe7VjTzGXQg2gtxj74RA+iJzsERUoHPpOfSxm+yesmRoheCripTPs33nTqKUI4TDgcKsq1yWwWYo=@vger.kernel.org X-Gm-Message-State: AOJu0YxLCmenvSHaiqtKMqnJUk/bzYLUSYku2ucdgRZtOjto8JnuxWW2 56P30WXbxzpo6wws9gbfjQWIPemVQAgRkINSFpf1EJ7otSudOZN5EkuNOUVzIg== X-Gm-Gg: ATEYQzxCRbi6fYPI8oIcGpnIvBBRDDcOPPj/Ch9iSCibkoUElFyX2AFSYGOu5WFPIN0 nZW8Q65lSb53Os7VrIL/B9z7X6fiUj+FUcAdFuqcXFaWasuRiyerSz7ZdbhkFCnMYVuxbSXxAmu hoNy18SoNOH8L+wy07nJjgVA/JoRLxgAQsGr2ntFNwQE+ARuUO/WgG1dsW3nNSktczAQBNSbIIL x7VRs5Me/YKDRqHwrNTNf5Xy1qTpSZvwqNFGkWVKWdD0nJAtaH3lwMd0KPwEd52lghh6LJA2Zvk 0OnmQcyHX9ByxY/DaKDKPBsoKPr7Ee/wOUeJEJHZl6N+e/dVBX0YMPEGoLXVUuI0F50OPLUN2dg PUOSWiKe+Pc8cX3QnSTrythy5GTH9tLlrlqwAdboOqmLLn3SrTPEh89geAr4Pnd8Ge7fgBhX8n5 Kv451KImdpOwDWvgT3JI4g7EiCf7uvnUMf2iiZVzNZsKJ2zrxZ X-Received: by 2002:a05:6000:270e:b0:43b:3c32:d901 with SMTP id ffacd0b85a97d-43b576fc6bfmr14749267f8f.11.1774182270851; Sun, 22 Mar 2026 05:24:30 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:1bdc:7f84:18bc:1e56]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64703343sm21072695f8f.19.2026.03.22.05.24.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 05:24:30 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Thomas Gleixner Cc: Biju Das , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH v6 07/15] irqchip/renesas-rzg2l: Replace rzg2l_irqc_irq_{enable,disable} with TINT-specific handlers Date: Sun, 22 Mar 2026 12:23:50 +0000 Message-ID: <20260322122421.132474-8-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260322122421.132474-1-biju.das.jz@bp.renesas.com> References: <20260322122421.132474-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das rzg2l_irqc_irq_disable() and rzg2l_irqc_irq_enable() were used by both the IRQ and TINT chips, but only performed TINT-specific work via rzg2l_tint_irq_endisable(), guarded by a hw_irq range check. Since the IRQ chip does not require this extra enable/disable handling, replace its callbacks with the generic irq_chip_disable_parent() and irq_chip_enable_parent() directly. While at it, simplify rzfive_irqc_irq_enable() by replacing raw_spin_lock locking/unlocking with guard() and update the variable type of offset, tssr_offset, and tssr_index to unsigned int, as these variables are used only for calculation. Signed-off-by: Biju Das --- v5->v6: * Updated the variable type of offset, tssr_offset, and tssr_index to unsigned int, in rzfive_irqc_irq_enable() as these variables are used only for calculation. * Simplified rzfive_irqc_irq_enable() by replacing raw_spin_lock locking/unlocking with guard(). * Updated commit description. v5: * New patch. --- drivers/irqchip/irq-renesas-rzg2l.c | 40 +++++++++++++---------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-rene= sas-rzg2l.c index 84dded4beae6..78cf451c8798 100644 --- a/drivers/irqchip/irq-renesas-rzg2l.c +++ b/drivers/irqchip/irq-renesas-rzg2l.c @@ -259,33 +259,29 @@ static void rzfive_irqc_irq_enable(struct irq_data *d) =20 static void rzg2l_tint_irq_endisable(struct irq_data *d, bool enable) { + struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); unsigned int hw_irq =3D irqd_to_hwirq(d); + unsigned int offset =3D hw_irq - IRQC_TINT_START; + unsigned int tssr_offset =3D TSSR_OFFSET(offset); + unsigned int tssr_index =3D TSSR_INDEX(offset); + u32 reg; =20 - if (hw_irq >=3D IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ) { - struct rzg2l_irqc_priv *priv =3D irq_data_to_priv(d); - u32 offset =3D hw_irq - IRQC_TINT_START; - u32 tssr_offset =3D TSSR_OFFSET(offset); - u8 tssr_index =3D TSSR_INDEX(offset); - u32 reg; - - raw_spin_lock(&priv->lock); - reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); - if (enable) - reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); - else - reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); - writel_relaxed(reg, priv->base + TSSR(tssr_index)); - raw_spin_unlock(&priv->lock); - } + guard(raw_spinlock)(&priv->lock); + reg =3D readl_relaxed(priv->base + TSSR(tssr_index)); + if (enable) + reg |=3D TIEN << TSSEL_SHIFT(tssr_offset); + else + reg &=3D ~(TIEN << TSSEL_SHIFT(tssr_offset)); + writel_relaxed(reg, priv->base + TSSR(tssr_index)); } =20 -static void rzg2l_irqc_irq_disable(struct irq_data *d) +static void rzg2l_irqc_tint_disable(struct irq_data *d) { irq_chip_disable_parent(d); rzg2l_tint_irq_endisable(d, false); } =20 -static void rzg2l_irqc_irq_enable(struct irq_data *d) +static void rzg2l_irqc_tint_enable(struct irq_data *d) { rzg2l_tint_irq_endisable(d, true); irq_chip_enable_parent(d); @@ -456,8 +452,8 @@ static const struct irq_chip rzg2l_irqc_irq_chip =3D { .irq_eoi =3D rzg2l_irqc_irq_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, - .irq_disable =3D rzg2l_irqc_irq_disable, - .irq_enable =3D rzg2l_irqc_irq_enable, + .irq_disable =3D irq_chip_disable_parent, + .irq_enable =3D irq_chip_enable_parent, .irq_get_irqchip_state =3D irq_chip_get_parent_state, .irq_set_irqchip_state =3D irq_chip_set_parent_state, .irq_retrigger =3D irq_chip_retrigger_hierarchy, @@ -473,8 +469,8 @@ static const struct irq_chip rzg2l_irqc_tint_chip =3D { .irq_eoi =3D rzg2l_irqc_tint_eoi, .irq_mask =3D irq_chip_mask_parent, .irq_unmask =3D irq_chip_unmask_parent, - .irq_disable =3D rzg2l_irqc_irq_disable, - .irq_enable =3D rzg2l_irqc_irq_enable, + .irq_disable =3D rzg2l_irqc_tint_disable, + .irq_enable =3D rzg2l_irqc_tint_enable, .irq_get_irqchip_state =3D irq_chip_get_parent_state, .irq_set_irqchip_state =3D irq_chip_set_parent_state, .irq_retrigger =3D irq_chip_retrigger_hierarchy, --=20 2.43.0