From nobody Sat Apr 4 00:10:55 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2E3C175A80 for ; Sun, 22 Mar 2026 11:49:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774180146; cv=none; b=RyG+pwS5Fw0Vyx2Jd65+T8KzNhtAmO7Qp5nbnB1qc90NkWJY1+D7qAljskoaRpsXqF8N87/1lG4FQc9OT0tttSBfe7U7zpQcYV6rWZmBiReO4OPz9nzaIUjN4fYtUOWN/Q6FCJTGxPukwvdilViCkvv7H3/7OWVjyjRZ2MSefTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774180146; c=relaxed/simple; bh=kzZZMLXdcHfiMEUk5JNV4MEm3KT6sgzDz91FNBgbp/g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dWTAL2Wa8XB2DJrhSQTCyFee07OBgrLtk1Yu1poTZBWNLwTjBnuY4p7F2kJ5SAaJOkW6TPrAt12JoE35kPFRU7TY7uXvVKYLSUE6ZiGcTZm3fQljY1JzHZNy1gTsB4QuNjadHQsrBqpKAxdp5MtERNhZb6eXSaJnYVowmHDPKPw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gd4ZXbbg; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gd4ZXbbg" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-824c9da9928so3567654b3a.3 for ; Sun, 22 Mar 2026 04:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774180145; x=1774784945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vgnOtzRDZTG07BfUHlD3Fp+876x2D+/kzsK/fPZW2gM=; b=Gd4ZXbbgPD7Ccbqt0s1YI6n+b4n7ekx5tqMkqnUCJ9qsOFzSB98rHn3oXmeOD6UMGt Nkxz69k5C67emFQ3EhDnOwzufzq1GGB5ZlICUoOi/OinB5+vPtBr5Htq+Iy68faPnq0W GVYcoLPABB4PLe94uiuj0n5Vv4E/oUwU6XlcUmKOhgpGNuHbTdXItI9A24MEcUnWl55w G8vEBVXC8fJT05nvP9kL1HhT3UUB+CzQCEd5+t7rqHiGV/igOQwQXugoswTLdqZ8VddB vaCFMnIqM5Beo08aAF98h373PcH2g+8M4puEn5+AEN4uReo8SFxlqPqTXG6Q0/MNWw3h 9RYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774180145; x=1774784945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vgnOtzRDZTG07BfUHlD3Fp+876x2D+/kzsK/fPZW2gM=; b=iEugSx5mHIR60HSYwonmL61BiHCmrlkpaJ2WikkrGy93Glfy4WYQQYQWW3nECgDNOF CYoKjpawykSz22Wqaorf8AngKrPtS+GtnxHx233quM6PYc97bovSziWeiEquxht0iTJa ymIrrMYzMCeNpHT9YZH+34KA45q3rtUOHd+66vdPR49Dge6HwaU1L9kjJAmrM6Z1mzOq 5nsbs2xpxjPq+MPliN8Rh/NQ4kvVWD4lhgui1vqCqc/EZKar341EcYX62PWQWlsCjbI9 hishphgS1gLgUcAHR9tJ9/txqFUU2oBTegfK3OjbUX2GNHVkgwZfNk5HiGTSx6LKc1e6 9a9Q== X-Forwarded-Encrypted: i=1; AJvYcCUxsFB6wLQ/LXpnBDEI84ctytnXp3jZs3Q3FjBz/ZxDVXq6zYkD+iXPYxf9tH02Ky4W10bAae/6/aNjGfI=@vger.kernel.org X-Gm-Message-State: AOJu0YwXs4T4I0g9Bjc31E0o03DVxo2ZMeLwZWrgampsPfwl3pppvpfm q/1MzJvn4As4LrHSoZsFVlf5li9NEr8LgfF0zi020ib9uS3NRRMoQfPB X-Gm-Gg: ATEYQzwEo9vO3cBydtwsOtMctgIuwGX4TXVutYV4A9qZ1nP5ZJh/ZdIq2WCwysIk9WM silBdxlo3aI/jPxRWfMEU3YZ+CMqCjNmuEWT/QuqVtzeXWR4KHvh0fjqDg17ScQJjmUSqhdVWV9 ngeBvMFgKA7NONEDvLafjcUufaIizuhsdFHiZfmgmc4GWas5nIqKoXoXss2eTuiFyb5jXj3ayhE eHIryKKC+2mTmKUcc3IkTtQgwdANycs4KLOErJ35uJA46sLHrZ1BKd+zWC+pWUzxKeYs82Kidfx Aq6+Fvmlc4R5Nj6NWcSfOwwwnjgeymdaElRI9D/r+yBT4JmDJGhemYWAEBAa9CU6cyT8L1Qby3+ RNPbh9LOHPxIUASo4Lwx8WSmNGRMGlzpCBYMT++sK3v8GIAhMKOe1oITf2ISa7z4RgZ2473UxnF uoxr1kuHQ0yqtJRK/F0hozF8jOfJPTM0k61cAwuYqYlP9wMEM= X-Received: by 2002:a05:6a20:3d92:b0:398:90c2:f6c3 with SMTP id adf61e73a8af0-39bcebe6be0mr7537046637.60.1774180144990; Sun, 22 Mar 2026 04:49:04 -0700 (PDT) Received: from aadarsh.lan ([2409:4090:801b:f416:7c95:e777:1ffc:9a9b]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-82b0409d148sm6126336b3a.29.2026.03.22.04.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 04:49:04 -0700 (PDT) From: Aadarsh Mandal To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore06@gmail.com, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, luka.gejak@linux.dev, straube.linux@gmail.com, Aadarsh Mandal Subject: [PATCH v6] staging: rtl8723bs: remove commented-out code Date: Sun, 22 Mar 2026 17:18:53 +0530 Message-ID: <20260322114853.11747-1-aadarshmandal9354@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260318021005.6346-1-aadarshmandal9354@gmail.com> References: <20260318021005.6346-1-aadarshmandal9354@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" - Remove code that is not used anywhere in driver. --- v4: - Remove extra space insertion. - Delete remaining commented-out code. v3: - Add the extra space that count as insertion. - Remove unwanted addition. v2: - Restore braces for standalone code blocks {}. - Delete reindented commented-out code and extra space. v1: - Reindented commented-out code;extra space remained. --- Signed-off-by: Aadarsh Mandal --- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 063a0737933e..96a0c8e304da 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -481,9 +481,6 @@ static void _initSdioAggregationSetting(struct adapter = *padapter) { struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - /* Tx aggregation setting */ -/* sdio_AggSettingTxUpdate(padapter); */ - /* Rx aggregation setting */ HalRxAggr8723BSdio(padapter); @@ -635,9 +632,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) return _SUCCESS; } - /* Disable Interrupt first. */ -/* rtw_hal_disable_interrupt(padapter); */ - ret =3D _InitPowerOn_8723BS(padapter); if (ret =3D=3D _FAIL) return _FAIL; @@ -656,8 +650,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtl8723b_InitializeFirmwareVars(padapter); -/* SIC_Init(padapter); */ - if (pwrctrlpriv->reg_rfoff) pwrctrlpriv->rf_pwrstate =3D rf_off; @@ -740,11 +732,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) rtw_hal_set_chnl_bw(padapter, padapter->registrypriv.channel, CHANNEL_WIDTH_20, HAL_PRIME_CHNL_OFFSET_DONT_CARE, HAL_PRIME_CHNL_OFFSET_= DONT_CARE); - /* Record original value for template. This is arough data, we can only = use the data */ - /* for power adjust. The value can not be adjustde according to differen= t power!!! */ -/* pHalData->OriginalCckTxPwrIdx =3D pHalData->CurrentCckTxPwrIdx; */ -/* pHalData->OriginalOfdm24GTxPwrIdx =3D pHalData->CurrentOfdm24GTxPwrIdx;= */ - rtl8723b_InitAntenna_Selection(padapter); /* */ @@ -786,8 +773,6 @@ u32 rtl8723bs_hal_init(struct adapter *padapter) /* ack for xmit mgmt frames. */ rtw_write32(padapter, REG_FWHW_TXQ_CTRL, rtw_read32(padapter, REG_FWHW_TXQ= _CTRL) | BIT(12)); -/* pHalData->PreRpwmVal =3D SdioLocalCmd52Read1Byte(padapter, SDIO_REG_HRP= WM1) & 0x80; */ - { pwrctrlpriv->rf_pwrstate =3D rf_on; @@ -1075,8 +1060,6 @@ static void _ReadPROMContent(struct adapter *padapter) pEEPROM->EepromOrEfuse =3D (eeValue & BOOT_FROM_EEPROM) ? true : false; pEEPROM->bautoload_fail_flag =3D (eeValue & EEPROM_EN) ? false : true; -/* pHalData->EEType =3D IS_BOOT_FROM_EEPROM(Adapter) ? EEPROM_93C46 : EEPR= OM_BOOT_EFUSE; */ - _ReadEfuseInfo8723BS(padapter); } -- 2.43.0