From nobody Sat Apr 4 01:33:06 2026 Received: from mail-dl1-f74.google.com (mail-dl1-f74.google.com [74.125.82.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81BDF367F21 for ; Sun, 22 Mar 2026 00:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774141117; cv=none; b=kXeCb5LLKrciC68W+tahHAAktwZJkQL0PNfPQ6SK1gHefQTz3D0YvlFnk7BEdavdRTru4YNE6vyhQDiSfqSVGmEZZu03viXw9xRsZ2e+bPbL8ov6aBTBfPIO7kY84RWVF1u0QQwyCIj/J/TNgmxf54AL8xmEUq3VQjJCR4raYMM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774141117; c=relaxed/simple; bh=mUhs77h48VhgtyAjhTyDJ3FwTWR5hwo6IbQbkY4le6w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=D2ocLbxdeyTqHrDqarZbI5qNB0fDTQsrCA+rgeQbPn2tE8GOHDz0Y4XUtOfj6xRf4ciy2QBNJPO3KK6jUwOEn7jGt3GTUSDMzKNbkmvEb3+PU7dKpkyRJSEXleEz5VoEjKERn9bHQLGFbbksSfUiGVJZxoQZ948peoiqoqj/tPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RqLYrW3W; arc=none smtp.client-ip=74.125.82.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RqLYrW3W" Received: by mail-dl1-f74.google.com with SMTP id a92af1059eb24-128edc72e5bso2038489c88.1 for ; Sat, 21 Mar 2026 17:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1774141116; x=1774745916; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=g5v2cdYDygdPGNKQ1eUv8N21CjI6pyt8oIsrmu7TsyQ=; b=RqLYrW3W0npk2e3Ve5rZhkWYdxhV6Siy+RF5KolfIF+n8ceaj4wbhfxfsXzpOYqcZh VHvj+BTK8I0LA21nh4V7S/olWcpfKhaC7p5st5rUo4WkIwkZ5JnZtqcj86K7DIBuuaSF NrhXiaRXYAuJjtcIO5q8tsiOKzQ4B2/NKTF8NJ6TW4SuOZ1Vw5BMTQQFmimhIOPNV6ZH su2Ms9oz0NI+dtnh0ADI6deQh4+N2O9K2oHQbQLbCiglhf4T+WJoXB+Yj+kHx2xtxSK+ Nth05p5kwyz/Pwf370ZpCMIdmeKvG392QiGKKtoW+GoNbyjS4TBx1wQ3Se7Yy3gITrl+ Aapw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774141116; x=1774745916; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g5v2cdYDygdPGNKQ1eUv8N21CjI6pyt8oIsrmu7TsyQ=; b=dVoGACWS1/HdUJDsbSOcDEG/Tay71UohxQ1xJRMw1hwuIKHrXlcKslzsWOXS1CWwyC UxKGeR8JFbHBejUNw+wwC8JPjfJdh9nyPqGwt+DcUYPph6QBTjIw5S/Zy9gplkjuCsXZ v0ZdtRbaXvZCtw/wpPLV/SI1jIkDa99QsX/7PFOp+M7nCJWIUNiW28aPY/cFjiqSOnk0 Z7en3hcTgRyixSbEk3yX0bH4dv7/LqDd3GOpUZC7BZGXZWA+A5EFIKSKX13WMYXywbT5 mOIYoZWc8h3z51+msbv8UKkHkpLBTyGcW07fhnuhiGzgFGU3vAgb97IynjIehLiehT0X q/VA== X-Forwarded-Encrypted: i=1; AJvYcCWZynYpVY6j1hDD6EbMR0WjbtxJRvHOo1aOwhdf+r8mX/+KW/ePg+mZFawD7PdZcmRaF1M7m07y2qhCcEE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8Y/H3vJoMdufTzPxtjqVXPgGHZfsH+5iBJnuRJJ77r8RWiaIp QAZdN3GfAuLLhgsZyDcPifQrWtHRyowFO7QCIi6NhWQNN34DGRQcYYd5BRVdKlGBdcB7DQj5JYd MSZ8RSExlOQ== X-Received: from dlea1-n2.prod.google.com ([2002:a05:701b:4201:20b0:127:82fc:dd48]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:327:b0:12a:7181:2f1c with SMTP id a92af1059eb24-12a72682797mr3457147c88.17.1774141115504; Sat, 21 Mar 2026 17:58:35 -0700 (PDT) Date: Sat, 21 Mar 2026 17:58:20 -0700 In-Reply-To: <20260322005823.981079-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260322005823.981079-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.959.g497ff81fa9-goog Message-ID: <20260322005823.981079-2-irogers@google.com> Subject: [PATCH v2 1/4] perf build: Don't check difference of perf and libbpf hashmap From: Ian Rogers To: irogers@google.com, acme@kernel.org, adrian.hunter@intel.com, james.clark@linaro.org, jolsa@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org Cc: alexander.shishkin@linux.intel.com, alexei.starovoitov@gmail.com, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, haoluo@google.com, john.fastabend@gmail.com, kpsingh@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, martin.lau@linux.dev, memxor@gmail.com, sdf@fomichev.me, song@kernel.org, yonghong.song@linux.dev Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The hashmap code as-is violates the C specification meaning -fno-strict-aliasing is required or fixes sent in: https://lore.kernel.org/lkml/20260321024446.692008-1-irogers@google.com/ We're looking to not build perf with -fno-strict-aliasing: https://lore.kernel.org/lkml/20260320224248.536449-1-irogers@google.com/ There is also the continual problem with hashmap using errptrs rather than errno introducing subtle bugs as shown in commits, d05073adda0f perf trace: Avoid an ERR_PTR in syscall_stats 96f202eab813 perf trace: Fix IS_ERR() vs NULL check bug 9f3c16a430e8 perf expr: Fix return value of ids__new() but there are additional fixes on the mailing list. https://lore.kernel.org/lkml/20250805063209.3678359-1-linmq006@gmail.com/ Let's allow the perf version of hashmap diverge from libbpf's so that we can fix its issues. Signed-off-by: Ian Rogers --- tools/perf/check-headers.sh | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh index da3aca87457f..36b91cf1ccce 100755 --- a/tools/perf/check-headers.sh +++ b/tools/perf/check-headers.sh @@ -215,10 +215,6 @@ do beauty_check "$i" -B done =20 -# check duplicated library files -check_2 tools/perf/util/hashmap.h tools/lib/bpf/hashmap.h -check_2 tools/perf/util/hashmap.c tools/lib/bpf/hashmap.c - # Files with larger differences =20 check_ignore_some_hunks lib/list_sort.c --=20 2.53.0.959.g497ff81fa9-goog