From nobody Fri Apr 3 22:38:24 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37B152D781E for ; Sun, 22 Mar 2026 13:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774186204; cv=none; b=oh067v/oeQJY5DIsVJih1en1HVaeDj8sGPZLPAXyFppEvWtc/Le3TPkaoRkZnBat0a63JbhE7rvnCwrgbblIV3pfE7lmchXvxwd5pjrEs6/0zShrZpsPmJ1rbwAYkHb0czRkxTS7A3heo1hd8DyH0dXVQViP4huk07Z1nmBn2fk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774186204; c=relaxed/simple; bh=IgWmy4QA7Nns3VcVuEiMlxkNPJRgKy13zfHehRaQ8LU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=pWadm6PcJGxgDZAVozNexG8xdtDmmgJ6QYkugPfGjHr5QDoQLBO64kLaTgfcbzFhXTBUcXRCs+uZZ2x4YonxZGDt5d6ba4LadUICkKNJd/V3IfMkXX6PWCzTEEmjHIv5n8F38qMFTDCkY1YGFYvWZOMlGsbHfKYibdJUSl5nxw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d6Of1TD8; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d6Of1TD8" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ad9a9be502so12238555ad.0 for ; Sun, 22 Mar 2026 06:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774186202; x=1774791002; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=SrIW8xtAyVysxyWJhbGBQFiTsDupVZxP4JLEp/IdUF4=; b=d6Of1TD8mp2u0u/cGK1f2MdTb4rhOMaCZekqhTz6b1dawbJz/nhchQgaThfrAepWDR tfK3nCHf4m2M7jRlmZCS3A4e/LIqGx2FvqBh42pbet2THMX9iahVKR7nLFCBU6rChTBf bgoxXVZv0vYDt2IOVyeJJkl3tEk+6Yt/9LjtmTcvO129zUb082LzL6A6Epk8o1+v+wxf GnHmZmUjcMuB22GNBB8jRaKLGPTjAVFS37qzWui+S/Rh0QO15abRKlalV1mrDDpwybXw Qn86m2UFUgo7il61jzo3VtQp5j8n20YoLrzZ6gGe8gJWFzXoqspvtOiuPwiX+zzKztvt c2RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774186202; x=1774791002; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SrIW8xtAyVysxyWJhbGBQFiTsDupVZxP4JLEp/IdUF4=; b=tXi51ksLt1xFTEcAmqLe4gaA5897JN/I4bYvMn3Iths4lQOEw8SMQy+TIzE6txkjRA OZT5nf5ZHE0bLyT2Q2VTE4x0DNyuRa0/m3lmTcneO0Yn4EgdmV90pU2TTUWyKQXSR6+v o3gulznmorOmc6/1xJHA16WeYEEE+FusW8SztscIy0MjKOWT5O0N/bUJcDoEJU+Xd5l/ qNludDwQ+9/NSwaPPlduJsMQiYz16pNEtEIHMSuv0sEuw6jpH3MV8v1XwzaCFeH1Eetv o+62JcZaODOWAhT6kO5izyHZHu+AuZ2kgdpjUvSqXcTYBAC0Nfs9xSCEGgNHkG/H5ozZ zjAA== X-Forwarded-Encrypted: i=1; AJvYcCWAmeD7uqPROB1LqlkMvR9e3lpPJuGK5OhQfaevsCgEeAMj5k2+jETutdiFmxWa8vxi9HA9tk87/uLiMfU=@vger.kernel.org X-Gm-Message-State: AOJu0YyqHGbvAlmXSeC2OP0i1/hbuGB55ymSWpfMTY4o13ypsMUnjgPg pYJ/m7GLhc3KD0Lxtjumxn7ok8Fk/q6duZCHGhMIo0zB645su16+Qkhc X-Gm-Gg: ATEYQzwguAJzGWiptWalcVa5pFAB/OMP4Wjx/5Tm0/tW3p7tDlS23zCgDC4FKxRoMuY Si96Aunzb42Kns2GbHo2ZQRvmxcAkhRU+fiUBZBuwYaBHKS4USkXKd7F9iAhA7GHsYvAMM5y8lB yFcU0WUysL7fYwmj8+d2xHzwsgzykCkXz6ZbUlgj2/olKVa4guimvyuWpMB95NPvUCWbskvyKKZ y8k1/3pSbY7ZKHRoF3/ZOQSAWNgGsDT52Z+XZOc2OEJLJbXqS5uEdXGI81xqkYXQzf0uYdKGSJE jW22LN6CsF05L/OXo7BBYiePhW6ojquc2NOhjd/++j/eeXM9QAiXwMxFmBj+jMM2KpNG8bEEgQ9 bjD8icfZPGOyjNTdSAAHMqLs65Cmj/oCKOiXAQW7c9i/DvrtpOvCV0w7ge+xCAU20zADGwz4wHJ tvL08qv8y9QZvvNMfgiQSlG5Bm9hWx+6NNueeA X-Received: by 2002:a17:902:eccc:b0:2b0:5472:ac85 with SMTP id d9443c01a7336-2b08278b1c6mr81255475ad.26.1774186202363; Sun, 22 Mar 2026 06:30:02 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08352ae70sm82428685ad.23.2026.03.22.06.29.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 06:30:01 -0700 (PDT) From: Felix Gu Date: Sun, 22 Mar 2026 21:29:56 +0800 Subject: [PATCH] spi: meson-spicc: Fix double-put in remove path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260322-rockchip-v1-1-fac3f0c6dad8@gmail.com> X-B4-Tracking: v=1; b=H4sIANPuv2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyMj3aL85OzkjMwCXaNEMwMjQwsjM0NjcyWg8oKi1LTMCrBR0bG1tQA QXofoWgAAAA== X-Change-ID: 20260322-rockchip-2a6021826137 To: Mark Brown , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Dongliang Mu Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774186199; l=1052; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=IgWmy4QA7Nns3VcVuEiMlxkNPJRgKy13zfHehRaQ8LU=; b=dLgftTxPLhBEjASFdBodKe9Oa/2BVSKKuobIs2yLPKcz6YEYlPHAm2ZONouYTQlHozSyDTzz4 Hbhn7HkyqvYB/ymGHGdt7PmckUH6vjxfwNcoNmgq+lvWTlIbDGTgtK6 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= meson_spicc_probe() registers the controller with devm_spi_register_controller(), so teardown already drops the controller reference via devm cleanup. Calling spi_controller_put() again in meson_spicc_remove() causes a double-put. Fixes: 8311ee2164c5 ("spi: meson-spicc: fix memory leak in meson_spicc_remo= ve") Signed-off-by: Felix Gu Reviewed-by: Johan Hovold --- drivers/spi/spi-meson-spicc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index a7001b9e36e6..57768da3205d 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -1101,8 +1101,6 @@ static void meson_spicc_remove(struct platform_device= *pdev) =20 /* Disable SPI */ writel(0, spicc->base + SPICC_CONREG); - - spi_controller_put(spicc->host); } =20 static const struct meson_spicc_data meson_spicc_gx_data =3D { --- base-commit: 785f0eb2f85decbe7c1ef9ae922931f0194ffc2e change-id: 20260322-rockchip-2a6021826137 Best regards, --=20 Felix Gu