From nobody Sat Apr 4 01:47:25 2026 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060FB34846C for ; Sat, 21 Mar 2026 20:26:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774124774; cv=none; b=tg6PXRSblnOZSm9GewawZUiIS1CHCyFacyrF512+Ph5IlrU+I5if/4JrnOOgPzsqAEphcnyBDMxgI/F/VZ0AUmJwVewp0TI6+oQFWxTrQt8UNJ1IKyUuBLtrumLZXrz0xHY02i5U2rRZi39pml8aJ8r+uqowJtXqHR/e4oCMCPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774124774; c=relaxed/simple; bh=t4iTwfSbP9CDr6QHSr/r6bwsNo7DCFcSSmYQhYBQhGY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ryQZeiUQlDvgVWAG+vdHf573hxwnbGiQOpBh9ixB03EBwWHZpIwS1QVeqRFgfiYugRlnLFJZjdgWjV2MtMebxRNt0WpaQIL0TqcCIEidWfPZ9IXARUGLKJNHPt2iE2+jh/15XLNz6ukwN0UqUklYNzdkyIzZjzPtqcBbi7fjwaU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d7a27cpE; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d7a27cpE" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-56a857578a8so607971e0c.3 for ; Sat, 21 Mar 2026 13:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774124772; x=1774729572; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2D90xvcAA0cYxqSav09Tazhs8VainBkG84YypcNOQbY=; b=d7a27cpEbBwVLjnfingo/ki9ASUHTKVswX07ny6OgcXEi/wyyYaWWQXalr+kHuGlch CIKH6zJHXCEbXxnOXhJEBEzZiCGTEyUYtvZDxQH2CuPs12A/cWxZMzchXtTj9zFjXfGq ydxKtLXm+ekO3BhiJAYtQL+hGq0E1vKL99DhieRqUtj1HykRHTa9umLUsTkzNL5q3uvD Shh66MalIJBGn5crmMzR4RJO56YgsSKr3vlQLwratnm4SKXZ/1ykGA01RNRh+aGFhQW4 P/5fDYgf1+ENRuMVF6IyxdGfSD3zBmHr5+O4eZrJX03OEnZpsLQEay1E92jgKFVVMJnr 7C7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774124772; x=1774729572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2D90xvcAA0cYxqSav09Tazhs8VainBkG84YypcNOQbY=; b=WpkjYPCwM4DC+xNM9q2+WtIne6KcHltzhGdwBz6fCgxCsNuJMenbBsBpv5jcBbAeHi iWnvBu6eGGdOaabQbeqO0arsy79L7uMHZvFiY7eWs6HccC9/2OzV4XOZZchuWe52G/qW d2BWrDDk3rhhfb3tLMqlRJRO66dO4ophl59Ow4VNPbDZ9cRGeLNwGSXos3DcICajQyhV +O6lhYNGCRtPbEAyMkjSxIfzA93uhrWoaBPBQFMDsDYZ9DT0V02KmNm9E/sP6U66z9Ah +GiS+dEl9EPCPQVA2uXi+0mtGhpSNbXovSfwVrc2HGXcHdbc72MuSmurAYNEsEM7VfPZ cj1w== X-Forwarded-Encrypted: i=1; AJvYcCWHTLfwWLCWA/6ws/cWCZFoXihalL0U0MK2ulV/O4/FYCsAL3dbBYbU8+iGmtPet0+0cS+OvoLC9Qcz1mo=@vger.kernel.org X-Gm-Message-State: AOJu0YxPJPJ/+m3asdlC5Aq4kpCjM3vDyHJ+i67tuxJFO9EN1kHNbpGm dz2u01IsKx3UnsH+B8syJ9stq246c3009NsZB5L6uZH5VQGlYmJbPjYp X-Gm-Gg: ATEYQzw3LqjXxWxeqhdeB+lbozra5QkpDQCYjjjdON/t09ExL43K8DPH/9J2afTlM+B Dprv6AkNSiyXyqXkX+mOzp008FP0wRhVW2Bmy4g1U5aTfSuuew0OBtOpOf8uCx78FBZIA7540tT wWfQzMjaFsaEgd1auKJlptLQa4skneWh6TNgfQY38oEVpyFi10UPIDSb2wabSaYLFb1ugeyJ2/9 hJAJNkU0LNgayKIRVCNRXpptSajqm9UNaMMQK1CyIHCDUjN566mDJhZM/BlcGyLR1Lk0vzXqXSP 98cN/XVnh28n/EWWPvfkWII4r5+KK3bBqYzE5nUAnlOcnZU6HEQprlF9HsP2rXU4y3FPP3FfFXJ BlY5ucNpCdQThotQme21xQkThSEpWVDjKOrwGn3X/MRmeB+hXfQ7Qokpqi+FYilqSBL/Oh56wr4 7yHtYfDyGlxzDD8uyBIfCzhzvachgsjySjnw== X-Received: by 2002:a05:6102:8099:b0:5ff:c794:96b1 with SMTP id ada2fe7eead31-602ae78f43fmr3443168137.0.1774124771975; Sat, 21 Mar 2026 13:26:11 -0700 (PDT) Received: from charlesdias.. ([191.22.16.211]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-95136de53d9sm4144378241.8.2026.03.21.13.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 13:26:11 -0700 (PDT) From: charles.embedded@gmail.com To: Anshul Dalal , Dmitry Torokhov Cc: Shuah Khan , Brigham Campbell , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Charles Dias Subject: [PATCH 1/3] Input: adafruit-seesaw - switch to using dev_err_probe() Date: Sat, 21 Mar 2026 17:24:44 -0300 Message-ID: <20260321202446.724277-2-charles.embedded@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260321202446.724277-1-charles.embedded@gmail.com> References: <20260321202446.724277-1-charles.embedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Charles Dias Use dev_err_probe() instead of dev_err() in seesaw_probe function to improve error handling. Signed-off-by: Charles Dias --- drivers/input/joystick/adafruit-seesaw.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/input/joystick/adafruit-seesaw.c b/drivers/input/joyst= ick/adafruit-seesaw.c index c248c15b849d..177b42446e9b 100644 --- a/drivers/input/joystick/adafruit-seesaw.c +++ b/drivers/input/joystick/adafruit-seesaw.c @@ -277,17 +277,12 @@ static int seesaw_probe(struct i2c_client *client) SEESAW_JOYSTICK_FUZZ, SEESAW_JOYSTICK_FLAT); =20 err =3D sparse_keymap_setup(seesaw->input_dev, seesaw_buttons_new, NULL); - if (err) { - dev_err(&client->dev, - "failed to set up input device keymap: %d\n", err); - return err; - } + if (err) + return dev_err_probe(&client->dev, err, "failed to set up input device k= eymap\n"); =20 err =3D input_setup_polling(seesaw->input_dev, seesaw_poll); - if (err) { - dev_err(&client->dev, "failed to set up polling: %d\n", err); - return err; - } + if (err) + return dev_err_probe(&client->dev, err, "failed to set up polling\n"); =20 input_set_poll_interval(seesaw->input_dev, SEESAW_GAMEPAD_POLL_INTERVAL_MS); @@ -295,10 +290,8 @@ static int seesaw_probe(struct i2c_client *client) input_set_min_poll_interval(seesaw->input_dev, SEESAW_GAMEPAD_POLL_MIN); =20 err =3D input_register_device(seesaw->input_dev); - if (err) { - dev_err(&client->dev, "failed to register joystick: %d\n", err); - return err; - } + if (err) + return dev_err_probe(&client->dev, err, "failed to register joystick\n"); =20 return 0; }