From nobody Sat Apr 4 01:35:09 2026 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51AEC30DED1 for ; Sat, 21 Mar 2026 20:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774124296; cv=none; b=sDuyWQMTatnbsJGhPjFKQ412/xduOJNThUFNiiHpLlB/2aRIVIuG+erCFTgz9xj2yDG0xKeH9IH05x5NyzVcL34ggUBHr7z+jPwoAIhGlZ9j33YPa+OJIkyEzTis1POwcLRW6nFztm5Qeg0s5JVPErxAIIXhctKzuFwHj8r342k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774124296; c=relaxed/simple; bh=21wxwPAzkvw0PM1o1Sir2WjfHA/JhjHvcpA0K/jNURE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ol83q6l+WI08zqe4qCjGGMzNZ4opRLpzZallHUZmnG4i2VqUbpEVIjFbDtiD8Pt1QJHNTlVJJaiGBMQSuQGwsA5/sRKCOPlEmw+hAaEjFL57tgqHHRGrycVrAtDbvniEDePZ1ULbE3B2PkCivrXci59TMQXCsUhy7KFM+ad1U4s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IdXw4xPF; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IdXw4xPF" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-439b9b190easo2253121f8f.2 for ; Sat, 21 Mar 2026 13:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774124294; x=1774729094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AzhecMnJJ9tJrL0eFF0dOc/Rvq2owA/QQje9TjQeQrM=; b=IdXw4xPFfqrhd9B3EQobY1xcQx9UJplCzsWQaE0+wB4EDvZMthfFl250lvN2ofX3ui tlwIXSEB6DDwyQuoDLoszpG7xP0HXRcbOIDildR7dbgM+x0SvZZiTGwMHqutvvFoBgIQ 5DOiVYm/g/HyT2OWHGs//Q2XKaCe3pe/VkZvyfeuO24BkYPqpcoSwjkVvFy6SktAw7Pa bJq01XQKUV1ZBCwgM4YbxN0sY+UmyfKbaV0Z1Le+O5jGY45dFxNTPbMLp7g/MDYnCXlL onwwLfGMMBLDyoccrg+UxFGWi+Msa72WtF6uq4PqPqBDiSEGeIdWFHDLdAI7w/OYPsJd WJdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774124294; x=1774729094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AzhecMnJJ9tJrL0eFF0dOc/Rvq2owA/QQje9TjQeQrM=; b=PuFbfLHjwGt+Wzg7bbURNDHdG/W8yTU5NOFe+4QN8onLPfYkNNZv5sJQiT7RFvLSHG e4o/WrKjMwCqQDCVGlYSlhGEckBVXMFN4FrpYucy9Ci1t98S87AvdvK6fQWFpNYkFX6O UPnfjUjrY6kEPPuiJDT4v/Jdjp4QX5wwK9vF0BsclBTWELWdATW3o1R/A3Kq/uCPPs+k hZVYel1qvBwN1x2tDDJ6KrT7TFOplfz06Rut8HBOTL4BOm5BC847HIEGTifT1xC3HWbZ 58r8bYPJJUT37omjUBPKMpaMZXcqEy45NOW1waQjWdN8tKqaxq776+6OHdbsj+KDYfdf OVkw== X-Forwarded-Encrypted: i=1; AJvYcCU1Elho/GQK0Mw8Y0RNC7j6FaPIRL3Dt1YoQ+9fmEa70gO8wIgjLqxK6WtQHEgCZfim3++M0nSDpMlnCtk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9OGiTez3CjKgJixCrYCQuHQ16EsPZUbZFjukgYC9UwLHZz8cw F6r7u/uIkY6/IECK1l4Bsbo5d6toYmFS09c5JoDoUQhvX8AlzJueuIcP X-Gm-Gg: ATEYQzwVWvP6/SFzaTazy8oCvgutyZMWayXV7ZVd0Th4217Z8bn1+uka6L/z5bzGZgt 9XOhN1KsMlDMqFm8DfzStRE4N6SbNjM61WBKH3PJK2McU+Qj5Egoq9dDlS9Isn/DXTHkqpKeICA VZuMboplf8IKHn2o24kRbptZMZL9FK9qBTqrUlBxIIgAPHf8oYQxcnmMqr5r0IbldldQBPa4hmW TZYP7T2oFm9qDzQs2hNcJyILz8B1M38FQ2cLXhkhFqcS2SuZ/AXZbzEgAreKvQ55URA9anTC9eJ cIbh4V5rnsrZiYK6TYkeXq+/XmNFvXIGJImc8ZcC4h5YkdrHjBakKsEA2io5Rx/X5bpTfdE3/3e zafBQxlmE37EPKUioSTNXEVOJA/15+jLmm2vM+1Sy0F81YaD26uySvyD8KyKavQuN/+rJeVMqlS Txhrb/Ug7bhbYvDJAteiove1KnoZ8fJC8LEg== X-Received: by 2002:a5d:5f87:0:b0:43b:4f86:e996 with SMTP id ffacd0b85a97d-43b6427ea9bmr11643009f8f.29.1774124293520; Sat, 21 Mar 2026 13:18:13 -0700 (PDT) Received: from potato ([31.176.191.249]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6470380asm15876340f8f.24.2026.03.21.13.18.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 13:18:13 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v2] staging: rtl8723bs: change error handling to use standard errno Date: Sat, 21 Mar 2026 21:17:38 +0100 Message-ID: <20260321201738.16278-1-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260320072951.54045-1-omer.e.idrissi@gmail.com> References: <20260320072951.54045-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace non-standard return values with descriptive linux kernel error codes in probe path. Also replace the variable name 'status' with 'ret' to be more consistent with other kernel code. Signed-off-by: Omer El Idrissi --- v2: - Return -ENODEV instead of -ENOMEM when sdio_dvobj_init fails drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 30 ++++++++++++-------- 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..47189c849b05 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -345,38 +345,44 @@ static int rtw_drv_init( struct sdio_func *func, const struct sdio_device_id *id) { - int status =3D _FAIL; + int ret; struct adapter *if1 =3D NULL; struct dvobj_priv *dvobj; =20 dvobj =3D sdio_dvobj_init(func); - if (!dvobj) + if (!dvobj) { + ret =3D -ENODEV; goto exit; + } =20 if1 =3D rtw_sdio_if1_init(dvobj, id); - if (!if1) + if (!if1) { + ret =3D -ENOMEM; goto free_dvobj; + } =20 /* dev_alloc_name && register_netdev */ - status =3D rtw_drv_register_netdev(if1); - if (status !=3D _SUCCESS) + ret =3D rtw_drv_register_netdev(if1); + if (ret) { + ret =3D -EIO; goto free_if1; + } =20 - status =3D sdio_alloc_irq(dvobj); - if (status !=3D _SUCCESS) + ret =3D sdio_alloc_irq(dvobj); + if (ret) { + ret =3D -EIO; goto free_if1; - - status =3D _SUCCESS; + } =20 free_if1: - if (status !=3D _SUCCESS && if1) + if (ret && if1) rtw_sdio_if1_deinit(if1); =20 free_dvobj: - if (status !=3D _SUCCESS) + if (ret) sdio_dvobj_deinit(func); exit: - return status =3D=3D _SUCCESS ? 0 : -ENODEV; + return ret; } =20 static void rtw_dev_remove(struct sdio_func *func) --=20 2.51.0