From nobody Sat Apr 4 03:18:35 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1924280CD5 for ; Sat, 21 Mar 2026 14:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102539; cv=none; b=lK8DTEfzJdryQ0Bsqo7Hr2k2OeqX2cWvNLqr2PpKBQ3+44WvtgjZ/J1LJh+ucTFgPOam62gmRhwhK4ujyJ8Wj9CLfO7rdAL/EOu0KD7hVgbyl+k1Ho3PvO2T96TIBTKUcwq2MlyQrOcYAHW9wICRVaNA+z5UBCf+iBmQ1Y1JibQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102539; c=relaxed/simple; bh=Bj04iTXB7MhKSrOnlUvWs1/LZRy/U40aj1lrebnr4kE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LPhU+MYVQsmMkHur93PFHBIOx631pmLp6YeGru9KDCaCd+2iBO5vTVsy0nbkC7R4/Aju9WAF+ycFKJTQo1dmngxAiBLvdOMsDtrsRClIoWX21M5rSiFN1Z1DqGMGvCHajGO9rpdZeO4JETK6X68NKBuXu83kVRQH5oK9D8s3ONY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wvae4peJ; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wvae4peJ" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2aaf43014d0so17957145ad.2 for ; Sat, 21 Mar 2026 07:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774102535; x=1774707335; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=Wvae4peJeASYU18/ry3ujxdjcrZ9U58sJiuK5vPyIkxaX9ITB5Ia5vJdjJZS/rB+db Ai4CMWn18nGIKR8ZLKS2DqaHc+Mss0vwO6/MQyeinLwHZQJqcRxJ/nmGN4Vmz3NrwaTp /uJfcVT8dn0wD/PvYqFqVZ3iJQG2u63STFpvvTfIlhThPHShAfFRkIYONbAJP73ikTqr rdFnb9lXjUHwXO6EvmsQuYNuVBIXUP+tYYwd66YiRtt1T5VS/GixvlBIC+UZpHJzndpS gBB3ER7fVmCKkbNQH5fEJ4bEB8dzbVGB3W4YHrvFJv9jJcN/f8v8gqF1xm8Yg5LQnREq 61LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774102535; x=1774707335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=lWhYN+0W2eHqOJ4f8cavHoo51iiPTu8L+Z1PHrm17eYgMpHGOrkK3xZRYJzvIQyHEE NqDLJZaFhl/ENW0Vl+oPCQYtXsI8ID0KQrZP2b5gX2g8tuwEmgiOFvaa3kEclVfOn5Zh oMR8W9NTNeSAlI17QRzzgKotl38xN6Jv37gKoQ+G3OtMkTCvu7BKv+TKwn1ILv4LlKKm uxpBtXpnHHQco8u5cO1HIQ6bbqg7+ReDydaMVSKhr+j4cRxZA5JYFYIbcrSDW++DGO6q ylZdkiht52hqSuBo/PTQ6qMAOeYgcdRJglULdrqTOowRyv4MgFvTP31ZTQ3Cvd6LfhSH To2g== X-Forwarded-Encrypted: i=1; AJvYcCXm2LtjopNL1eSx9qrQPbZXy2guxypIIJpAdkBlVkUFd96k3LgRQ0qCFLDMsuIHFCvYZWiOUFuB8mmenRc=@vger.kernel.org X-Gm-Message-State: AOJu0YzorGKjAZanzn2xtx6niVhR75FIO6lFk6j6Bezx04MVxrQi1GXl /PXamAxJ+T9D70JCObU/T4URKCzXWplXkNA6kF61B3LdviSvy9vFLSXv X-Gm-Gg: ATEYQzw5LdEASpbixHiTdRTpM2NXj/jNeu8OrZtqTX+xyXl8Iqi7KKcgZV+X4L6BcDA zShNa/r8ylpPvg5i9W3A+YwmdfhkjDaOY0U8iKwTDeUQMFDgCLRtR/GNqQWIW7GMMw8NxPWhbM/ AOSZ+y0wPCPcR5sGRWgJQiriRxcmt2d+LbNJzUPx23b4mjAAv1gxdWOKVBzISE0naQeODSZg0B0 2a/OWxDXKu1PivklBVJxPSjT2g4bVVY3q0otJ51pbGmdsKpmKgVulMcVu8wX9MnvImxEW/90sGv 08SyeHOxavxOoCPnXunzNd2JbaxnXTM1vG6kpcz++iLoKJkpYlSKjIWGkXXEbIh5uvkNyqWWgqN u1KjvzbtD6Etwgtjj75v87geMsmLxnYOipRPM3v92Yp2cOIW3uB3ZLKSbGQRcMNuz7EIOzyoQ+F 3cAIVwoy/oCTl290cbdYM9yHzpEOaa3WYu3VCwDdRjWV7iAJQwRE4t8x4zMErPoe5v4cvAZqw= X-Received: by 2002:a17:903:1211:b0:2b0:4f9a:b794 with SMTP id d9443c01a7336-2b0827bb54dmr63715295ad.37.1774102535362; Sat, 21 Mar 2026 07:15:35 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08353e94asm52680715ad.25.2026.03.21.07.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:15:35 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 3/5] svcrdma: Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Date: Sat, 21 Mar 2026 22:15:08 +0800 Message-Id: <20260321141510.68214-4-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260321141510.68214-1-seanwascoding@gmail.com> References: <20260321141510.68214-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards in svc_rdma_accept(). Since dprintk() already evaluates to a no-op (via no_printk) when debugging is disabled, these explicit guards are unnecessary. Verification with .lst files under -O2 confirms that the compiler successfully performs "dead code elimination". Even when variables (like 'sap' in this case) are declared outside of #ifdef, they are completely optimized out (no stack allocation, no symbol references in the final executable) as they are only referenced within dprintk(). Signed-off-by: Sean Chang --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 25 +++++++++++------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma= /svc_rdma_transport.c index f2d72181a6fe..0759444bda50 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -413,6 +413,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt= *xprt) struct rpcrdma_connect_private pmsg; struct ib_qp_init_attr qp_attr; struct ib_device *dev; + struct sockaddr *sap; int ret =3D 0; =20 listen_rdma =3D container_of(xprt, struct svcxprt_rdma, sc_xprt); @@ -559,20 +560,16 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xp= rt *xprt) goto errout; } =20 - if (IS_ENABLED(CONFIG_SUNRPC_DEBUG)) { - struct sockaddr *sap; - - dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); - sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; - dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); - sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; - dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); - dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); - dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); - dprintk(" rdma_rw_ctxs : %d\n", ctxts); - dprintk(" max_requests : %d\n", newxprt->sc_max_requests); - dprintk(" ord : %d\n", conn_param.initiator_depth); - } + dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); + sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; + dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); + sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; + dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); + dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); + dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); + dprintk(" rdma_rw_ctxs : %d\n", ctxts); + dprintk(" max_requests : %d\n", newxprt->sc_max_requests); + dprintk(" ord : %d\n", conn_param.initiator_depth); =20 return &newxprt->sc_xprt; =20 --=20 2.34.1