From nobody Sat Apr 4 03:18:34 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FFFA38CFE3 for ; Sat, 21 Mar 2026 14:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102534; cv=none; b=qWLPZYFOnBvfND3ic7PaTUeNz8J8145h5UprXscfP30hELt/0453sBD+P/BtgXcQpyy6GseeSiniqq0pxyjP6LWjXBTbJ+2q2NwbKjTeYJhp6V3comIgnlKhGSAAzG9od/QRMpR9IwILI8kJ13k2NtDfkFaMQQsdv3t5RjX1UWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102534; c=relaxed/simple; bh=CZYrSzJxOTHz3y2+Yn1YrwZjKF3A8fsmk9txEkZG5Eg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kFAgmYA1cOIm9sjuPe6cmGP+/RzusDDQMNU3efwHOX+udBEaWFmph+SWXfc/TW7hfEHJ3N+bU2KdJH/K/+3U7jHytsL2sTe9fuDzMJOq92z8lJ4fa6EfL3WXc/3jSE9HbZY0FtkIetjdYU4YG/Do/UgtFfv3ir9+S7bmHhf32TY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kmA1Qbi7; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kmA1Qbi7" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c741bd1ad11so1335472a12.1 for ; Sat, 21 Mar 2026 07:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774102532; x=1774707332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=capsefnRJybIkJWvu7BICDZ5yODeSG4sK/v0sJ/qwmE=; b=kmA1Qbi7DWrr9wl9XxgOyKJhSkA29clirNv3pc+8FNyfYWZfax1HO+vyQ6xk2LozBV FC4syXzVAN1JdWuKVr4x/PBBP6LyTIAUMeKX2xw3lnkZ2COVn6sFOKnzcggj93vn/NbW br+Qre60lyv4308OfJrpy2WbE7hMgkYHjpQ1sLWD0sciNCGijeth8itNh/kjuQtv56XJ roaGieRghEE+sF9bDYqeCGy0n6rbotEWX1fyaC9iyIE1rQPfJAhsqaUNRtTXJPKmQ7HD nTZzclu0tpZQ9wBDsPwgTQ2RdhFuFOhyU44Rx+NhFRAS5Rs387BC31Bv3PnRHbk/8iup XotQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774102532; x=1774707332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=capsefnRJybIkJWvu7BICDZ5yODeSG4sK/v0sJ/qwmE=; b=lcXo5BWwyoakv0zy0CS7QbOmIO/mHGqFAywkxbbsh+0ZRQvWL+r9bQCoDIgtM/39v3 WNOzlXaLbI3vo4SL69YL+/A+8TYPxWfLxT9iwW8e1MNOl0n1X3++la5x0NOts+MNxiNR lNmevU/3eKmje8yBNAejKACRGXQHRN9s9jOmrmDhd/SiANv046H/9E78bO50cPksk4m8 ApB/8i1pPT0loZnpzh4iU4V4wmyeE7kCM+bawkIlKMUc7w2kJMcs1EyLAOj+DZWOiiZJ o1vRjOQJTNQFLarEcRgoM/y0ECBHNVXQkdYBU83enoYb7V6JM6f2SEwCo27vKE3wzlIK k/oQ== X-Forwarded-Encrypted: i=1; AJvYcCV05zcEje6U+11etWPY5AwO1vrCpPqP0ERXLRFWuhSBu+wXS5TxAoB1IC3+br5rTmCoLcgMrR8q5rFLPvY=@vger.kernel.org X-Gm-Message-State: AOJu0YylyuIw2/36mGjyda05yK1UbpH0Y2xopuKmZNgSY4tsvUMn6uHg w5dnlFfojccKYPM4g9ITUkvAwyNwkZkRVW5e2UC9gu0C/m+l2bMvcEBO X-Gm-Gg: ATEYQzxJ7i5g+aALA9igMw24sLPrWLeHSv/5pR1caq/UqmoI0MZVjBhGDVTM+GtaY9g Nb89Kz6597kttrDc5Y+pavW+OuSHDzEej98L+VwtwyH88o+andB/IYqYSYhSFFt40xSOWCt6Gbl EQvlGFN7Ten6XF4PLyDUzVyEGXShYe/x5EOHL7Dz/0tED/gVPk0mD1GkGKPeV1w4n/paEtXtJ+5 8IxWE2mvUzgHkyHfHkG4rrMoJhTaCaOqw1DXZa9/u6juaMlXbwGdH+OzGmf2U0RiGDzfL9VKh/n NVz2KcovNE/pP3gmJhVVbru6sjwdsbz8OCvfX9b3FrS+OHbRA7XHmBAgwHZg3VKXZXGdjU4KutY V9pd4+zXWUCRPcw4Yn7O+d8E6u+yS4Jk3NGAOagPuFo0uhRLEChfBoKfvIM4Nh0Z26+19LUxJWU EgemyBmp708Tyv7wJTRZT9OqX/PpWPRYihOx+oi04UEUMjyEO8931F1PELzGAPkREQtLkIdW4= X-Received: by 2002:a17:902:ebc2:b0:2ae:a8a8:92f3 with SMTP id d9443c01a7336-2b0827de557mr70039135ad.44.1774102532655; Sat, 21 Mar 2026 07:15:32 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08353e94asm52680715ad.25.2026.03.21.07.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:15:32 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 2/5] nfsd/lockd: Remove redundant debug checks Date: Sat, 21 Mar 2026 22:15:07 +0800 Message-Id: <20260321141510.68214-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260321141510.68214-1-seanwascoding@gmail.com> References: <20260321141510.68214-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unnecessary IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards and #ifdefs in nfsfh.c and svclock.c. Verification with .lst files under -O2 confirms that the compiler successfully performs "dead code elimination". Even when variables (like char buf[] in nfsfh.c) or static helper functions (like nlmdbg_cookie2a() in svclock.c) are declared without #ifdef, they are completely optimized out (no stack allocation, no symbol references in the final executable) as they are only referenced within no_printk(). Suggested-by: Andrew Lunn Signed-off-by: Sean Chang --- fs/lockd/svclock.c | 7 ------- fs/nfsd/nfsfh.c | 8 +++----- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c index ee23f5802af1..9b978a087b3c 100644 --- a/fs/lockd/svclock.c +++ b/fs/lockd/svclock.c @@ -47,7 +47,6 @@ static const struct rpc_call_ops nlmsvc_grant_ops; static LIST_HEAD(nlm_blocked); static DEFINE_SPINLOCK(nlm_blocked_lock); =20 -#if IS_ENABLED(CONFIG_SUNRPC_DEBUG) static const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie) { /* @@ -74,12 +73,6 @@ static const char *nlmdbg_cookie2a(const struct nlm_cook= ie *cookie) =20 return buf; } -#else -static inline const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie) -{ - return "???"; -} -#endif =20 /* * Insert a blocked lock into the global list diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 68b629fbaaeb..91514326d1b4 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -105,12 +105,10 @@ static __be32 nfsd_setuser_and_check_port(struct svc_= rqst *rqstp, { /* Check if the request originated from a secure port. */ if (rqstp && !nfsd_originating_port_ok(rqstp, cred, exp)) { - if (IS_ENABLED(CONFIG_SUNRPC_DEBUG)) { - char buf[RPC_MAX_ADDRBUFLEN]; + char buf[RPC_MAX_ADDRBUFLEN]; =20 - dprintk("nfsd: request from insecure port %s!\n", - svc_print_addr(rqstp, buf, sizeof(buf))); - } + dprintk("nfsd: request from insecure port %s!\n", + svc_print_addr(rqstp, buf, sizeof(buf))); return nfserr_perm; } =20 --=20 2.34.1