From nobody Sat Apr 4 00:21:34 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFECE280CD5 for ; Sat, 21 Mar 2026 14:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102531; cv=none; b=nM51rT1/xZaL6rmjsSHstpHr5JeofF+V7rMwwYaIOYrBOp+Yeo9z5Oei8qbJv6l+5LvcWph6SZTMuDRoTegcLI8HYTLqyZ47Rtl17mSKhz/jSOme4PQEWdjCMJovE+6KHWL1vITdka/ApUitlFu53BfkFeAz8VMI6kIsFGAmdUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102531; c=relaxed/simple; bh=su0qCKHnq3PtTnb31b3a9kZUX/DqBj3yiDnEaH4YW+w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WqDtgYE6RKHxOfjbNCKdwX8NCaPX5/P6+CG3QCKSEJizRu9MjDy1Bwkc1UB4R54QPxoDgKKArI3JiYa5awHPspRJloiEkPaZSTsaE9zHbIEdwuLBngreqscS7Sv1Iubmx1YRHce6A1Rd18RviwaoheQZFZDaj+mIfTKUwyV64Vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ElvlnFZx; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ElvlnFZx" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2b061b6cf36so10977055ad.3 for ; Sat, 21 Mar 2026 07:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774102530; x=1774707330; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=md5Ntsc0rRpCFPPT7+6W0Dr1q7JQYEVArLNrJ+0AKc8=; b=ElvlnFZxfHz5IsE+NIiieqyp1y4CUanqpL/+VmxRX6OTwgIjWefOg0hW5NAactrtJF T8IdcqwpM/8BksWKAkKgyruUo2emVsOxzYlqsJ3DT9r5u2hYhbgqG7nbfFRYMP3NoOtD v8rYJxbTDqGhduY0z3pwsBTG5svvZMxjMQ3yOYFp4aDzElyuiKDvnbj2tjOw1XVzj6tJ qK4hWYEMQbL49rP81NKLLdgZVoWZHwl4BerJDNxXN1j3cypmiBZro0f+t2XiHHf5Gkh5 1leArEHlElBEFf0jJNgsnUSqYnLO1IVbQp1QSKiI3vsXK35MJojhQ/aWXocuND4a69Yr nsAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774102530; x=1774707330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=md5Ntsc0rRpCFPPT7+6W0Dr1q7JQYEVArLNrJ+0AKc8=; b=Z1dUsN1ue5COJnEjn4Gsr1UYGHKUctViUmCRqrRcxYQHs1h3k3+ZjnHUtL0xBsET6y sPeZvNaopAwLQ/Vfa99+lbiK3qXlpMyfHM+h+M3MXABK2UCJf0Nm5ccVpPjO+PjymkLQ 3u/BIMCwL357ntCtH6oRXBHAz3dvygNGI6U+SiaJI/Y/KTI9AJpSu0W8uUA2WHkLK1zE lrtsUlBnM2TfU2qVSlDoAct/asATod4N2QZJ/rDfuk0anYWnsyh2dn9oP4AmcHKhLwc0 ze9RJoMbFpQN6z1/DMfDT4dgFpG+6g39IEQRIVlBDZcMnE3AJBGZe5nLTEr+QkhFrrum hJgg== X-Forwarded-Encrypted: i=1; AJvYcCVN+Frks+5x5FCuhR3ZdpSoFS30tUORJcD9fV5mVEWpKAZ15a4v1af+a0SyRDdvUCp0zUivOnEVUYK8Xq4=@vger.kernel.org X-Gm-Message-State: AOJu0YzhqSYOJjfhqfBBZdF1L3neiza90HnpmOe8cQSvIktEg2I+p25+ F+m9sIpEJ283FlEBGb42w+ASAX5BPTtkT0QtPDxccMZH5Fi2aiPYC9+u8czwDw== X-Gm-Gg: ATEYQzzp/pPPvvRSzsPzfDjMpLkmsQ0TX1oi5EeLwzGoV6n2fty1b0wt/CKm8lF/y+S jhaYISSGwb2/LmbmRqdkkJ9A/wWh7Tc1LLbAMU8MaJoLuXMst6DCBlS0kLEvmdYsLFji123bha+ eToQkRQQsYq57BDwjOKFpC+Z3FgqKsHbF8IlAucRNTYtwwZT9P+LVi39n6QU5pBL7rikTaoL9rE TYivsPyZFhaRLYafD6YZ8kkMAnaiIHDe4srDp50zRXSk0tuFe+0hqbu8p4G8uzGRqhM858TX6G2 4n3cOpvYJHRHGjsmxrsUk+/T0wSZIKoXrl9RJ1cpLbMLgZMHear1Ucvo2PfYATtX6sqxwbNW+Y4 z8wt9sZ7icMRIh8jEpV9yjHpefHEoSidn0oIy7e2vvcHfwqXfQa5me2YLFXGh5Hx1emBBxoVixp ZT4R4Jg0d06RiyJSxL6xfcC3OgGPwAJEc2Z55rDHrrSLWmcNenr2VGRa+pCFqecoZBcJsRw+w= X-Received: by 2002:a17:902:d412:b0:2b0:5fbe:130b with SMTP id d9443c01a7336-2b08271d707mr36438375ad.19.1774102530024; Sat, 21 Mar 2026 07:15:30 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08353e94asm52680715ad.25.2026.03.21.07.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:15:29 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 1/5] sunrpc: Fix dprintk type mismatch using do-while(0) Date: Sat, 21 Mar 2026 22:15:06 +0800 Message-Id: <20260321141510.68214-2-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260321141510.68214-1-seanwascoding@gmail.com> References: <20260321141510.68214-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Following David Laight's suggestion, simplify the macro definitions by remo= ving the unnecessary 'fmt' argument and using no_printk(VA_ARGS) directly. To resolve a Sparse warning (void vs int mismatch) when dfprintk is used in conditional statements, wrap the non-debug definition in a do-while(0) bloc= k. This ensures the macro always evaluates to a void expression. Suggested-by: David Laight Signed-off-by: Sean Chang Reviewed-by: Jeff Layton --- include/linux/sunrpc/debug.h | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h index ab61bed2f7af..f6f2a106eeaf 100644 --- a/include/linux/sunrpc/debug.h +++ b/include/linux/sunrpc/debug.h @@ -38,8 +38,6 @@ extern unsigned int nlm_debug; do { \ ifdebug(fac) \ __sunrpc_printk(fmt, ##__VA_ARGS__); \ - else \ - no_printk(fmt, ##__VA_ARGS__); \ } while (0) =20 # define dfprintk_rcu(fac, fmt, ...) \ @@ -48,15 +46,13 @@ do { \ rcu_read_lock(); \ __sunrpc_printk(fmt, ##__VA_ARGS__); \ rcu_read_unlock(); \ - } else { \ - no_printk(fmt, ##__VA_ARGS__); \ } \ } while (0) =20 #else # define ifdebug(fac) if (0) -# define dfprintk(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) -# define dfprintk_rcu(fac, fmt, ...) no_printk(fmt, ##__VA_ARGS__) +# define dfprintk(fac, ...) no_printk(__VA_ARGS__) +# define dfprintk_rcu(fac, ...) no_printk(__VA_ARGS__) #endif =20 /* --=20 2.34.1 From nobody Sat Apr 4 00:21:34 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FFFA38CFE3 for ; Sat, 21 Mar 2026 14:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102534; cv=none; b=qWLPZYFOnBvfND3ic7PaTUeNz8J8145h5UprXscfP30hELt/0453sBD+P/BtgXcQpyy6GseeSiniqq0pxyjP6LWjXBTbJ+2q2NwbKjTeYJhp6V3comIgnlKhGSAAzG9od/QRMpR9IwILI8kJ13k2NtDfkFaMQQsdv3t5RjX1UWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102534; c=relaxed/simple; bh=CZYrSzJxOTHz3y2+Yn1YrwZjKF3A8fsmk9txEkZG5Eg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kFAgmYA1cOIm9sjuPe6cmGP+/RzusDDQMNU3efwHOX+udBEaWFmph+SWXfc/TW7hfEHJ3N+bU2KdJH/K/+3U7jHytsL2sTe9fuDzMJOq92z8lJ4fa6EfL3WXc/3jSE9HbZY0FtkIetjdYU4YG/Do/UgtFfv3ir9+S7bmHhf32TY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kmA1Qbi7; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kmA1Qbi7" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c741bd1ad11so1335472a12.1 for ; Sat, 21 Mar 2026 07:15:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774102532; x=1774707332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=capsefnRJybIkJWvu7BICDZ5yODeSG4sK/v0sJ/qwmE=; b=kmA1Qbi7DWrr9wl9XxgOyKJhSkA29clirNv3pc+8FNyfYWZfax1HO+vyQ6xk2LozBV FC4syXzVAN1JdWuKVr4x/PBBP6LyTIAUMeKX2xw3lnkZ2COVn6sFOKnzcggj93vn/NbW br+Qre60lyv4308OfJrpy2WbE7hMgkYHjpQ1sLWD0sciNCGijeth8itNh/kjuQtv56XJ roaGieRghEE+sF9bDYqeCGy0n6rbotEWX1fyaC9iyIE1rQPfJAhsqaUNRtTXJPKmQ7HD nTZzclu0tpZQ9wBDsPwgTQ2RdhFuFOhyU44Rx+NhFRAS5Rs387BC31Bv3PnRHbk/8iup XotQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774102532; x=1774707332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=capsefnRJybIkJWvu7BICDZ5yODeSG4sK/v0sJ/qwmE=; b=lcXo5BWwyoakv0zy0CS7QbOmIO/mHGqFAywkxbbsh+0ZRQvWL+r9bQCoDIgtM/39v3 WNOzlXaLbI3vo4SL69YL+/A+8TYPxWfLxT9iwW8e1MNOl0n1X3++la5x0NOts+MNxiNR lNmevU/3eKmje8yBNAejKACRGXQHRN9s9jOmrmDhd/SiANv046H/9E78bO50cPksk4m8 ApB/8i1pPT0loZnpzh4iU4V4wmyeE7kCM+bawkIlKMUc7w2kJMcs1EyLAOj+DZWOiiZJ o1vRjOQJTNQFLarEcRgoM/y0ECBHNVXQkdYBU83enoYb7V6JM6f2SEwCo27vKE3wzlIK k/oQ== X-Forwarded-Encrypted: i=1; AJvYcCV05zcEje6U+11etWPY5AwO1vrCpPqP0ERXLRFWuhSBu+wXS5TxAoB1IC3+br5rTmCoLcgMrR8q5rFLPvY=@vger.kernel.org X-Gm-Message-State: AOJu0YylyuIw2/36mGjyda05yK1UbpH0Y2xopuKmZNgSY4tsvUMn6uHg w5dnlFfojccKYPM4g9ITUkvAwyNwkZkRVW5e2UC9gu0C/m+l2bMvcEBO X-Gm-Gg: ATEYQzxJ7i5g+aALA9igMw24sLPrWLeHSv/5pR1caq/UqmoI0MZVjBhGDVTM+GtaY9g Nb89Kz6597kttrDc5Y+pavW+OuSHDzEej98L+VwtwyH88o+andB/IYqYSYhSFFt40xSOWCt6Gbl EQvlGFN7Ten6XF4PLyDUzVyEGXShYe/x5EOHL7Dz/0tED/gVPk0mD1GkGKPeV1w4n/paEtXtJ+5 8IxWE2mvUzgHkyHfHkG4rrMoJhTaCaOqw1DXZa9/u6juaMlXbwGdH+OzGmf2U0RiGDzfL9VKh/n NVz2KcovNE/pP3gmJhVVbru6sjwdsbz8OCvfX9b3FrS+OHbRA7XHmBAgwHZg3VKXZXGdjU4KutY V9pd4+zXWUCRPcw4Yn7O+d8E6u+yS4Jk3NGAOagPuFo0uhRLEChfBoKfvIM4Nh0Z26+19LUxJWU EgemyBmp708Tyv7wJTRZT9OqX/PpWPRYihOx+oi04UEUMjyEO8931F1PELzGAPkREQtLkIdW4= X-Received: by 2002:a17:902:ebc2:b0:2ae:a8a8:92f3 with SMTP id d9443c01a7336-2b0827de557mr70039135ad.44.1774102532655; Sat, 21 Mar 2026 07:15:32 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08353e94asm52680715ad.25.2026.03.21.07.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:15:32 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 2/5] nfsd/lockd: Remove redundant debug checks Date: Sat, 21 Mar 2026 22:15:07 +0800 Message-Id: <20260321141510.68214-3-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260321141510.68214-1-seanwascoding@gmail.com> References: <20260321141510.68214-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unnecessary IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards and #ifdefs in nfsfh.c and svclock.c. Verification with .lst files under -O2 confirms that the compiler successfully performs "dead code elimination". Even when variables (like char buf[] in nfsfh.c) or static helper functions (like nlmdbg_cookie2a() in svclock.c) are declared without #ifdef, they are completely optimized out (no stack allocation, no symbol references in the final executable) as they are only referenced within no_printk(). Suggested-by: Andrew Lunn Signed-off-by: Sean Chang Reviewed-by: Jeff Layton --- fs/lockd/svclock.c | 7 ------- fs/nfsd/nfsfh.c | 8 +++----- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c index ee23f5802af1..9b978a087b3c 100644 --- a/fs/lockd/svclock.c +++ b/fs/lockd/svclock.c @@ -47,7 +47,6 @@ static const struct rpc_call_ops nlmsvc_grant_ops; static LIST_HEAD(nlm_blocked); static DEFINE_SPINLOCK(nlm_blocked_lock); =20 -#if IS_ENABLED(CONFIG_SUNRPC_DEBUG) static const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie) { /* @@ -74,12 +73,6 @@ static const char *nlmdbg_cookie2a(const struct nlm_cook= ie *cookie) =20 return buf; } -#else -static inline const char *nlmdbg_cookie2a(const struct nlm_cookie *cookie) -{ - return "???"; -} -#endif =20 /* * Insert a blocked lock into the global list diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 68b629fbaaeb..91514326d1b4 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -105,12 +105,10 @@ static __be32 nfsd_setuser_and_check_port(struct svc_= rqst *rqstp, { /* Check if the request originated from a secure port. */ if (rqstp && !nfsd_originating_port_ok(rqstp, cred, exp)) { - if (IS_ENABLED(CONFIG_SUNRPC_DEBUG)) { - char buf[RPC_MAX_ADDRBUFLEN]; + char buf[RPC_MAX_ADDRBUFLEN]; =20 - dprintk("nfsd: request from insecure port %s!\n", - svc_print_addr(rqstp, buf, sizeof(buf))); - } + dprintk("nfsd: request from insecure port %s!\n", + svc_print_addr(rqstp, buf, sizeof(buf))); return nfserr_perm; } =20 --=20 2.34.1 From nobody Sat Apr 4 00:21:34 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1924280CD5 for ; Sat, 21 Mar 2026 14:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102539; cv=none; b=lK8DTEfzJdryQ0Bsqo7Hr2k2OeqX2cWvNLqr2PpKBQ3+44WvtgjZ/J1LJh+ucTFgPOam62gmRhwhK4ujyJ8Wj9CLfO7rdAL/EOu0KD7hVgbyl+k1Ho3PvO2T96TIBTKUcwq2MlyQrOcYAHW9wICRVaNA+z5UBCf+iBmQ1Y1JibQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102539; c=relaxed/simple; bh=Bj04iTXB7MhKSrOnlUvWs1/LZRy/U40aj1lrebnr4kE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LPhU+MYVQsmMkHur93PFHBIOx631pmLp6YeGru9KDCaCd+2iBO5vTVsy0nbkC7R4/Aju9WAF+ycFKJTQo1dmngxAiBLvdOMsDtrsRClIoWX21M5rSiFN1Z1DqGMGvCHajGO9rpdZeO4JETK6X68NKBuXu83kVRQH5oK9D8s3ONY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wvae4peJ; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wvae4peJ" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2aaf43014d0so17957145ad.2 for ; Sat, 21 Mar 2026 07:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774102535; x=1774707335; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=Wvae4peJeASYU18/ry3ujxdjcrZ9U58sJiuK5vPyIkxaX9ITB5Ia5vJdjJZS/rB+db Ai4CMWn18nGIKR8ZLKS2DqaHc+Mss0vwO6/MQyeinLwHZQJqcRxJ/nmGN4Vmz3NrwaTp /uJfcVT8dn0wD/PvYqFqVZ3iJQG2u63STFpvvTfIlhThPHShAfFRkIYONbAJP73ikTqr rdFnb9lXjUHwXO6EvmsQuYNuVBIXUP+tYYwd66YiRtt1T5VS/GixvlBIC+UZpHJzndpS gBB3ER7fVmCKkbNQH5fEJ4bEB8dzbVGB3W4YHrvFJv9jJcN/f8v8gqF1xm8Yg5LQnREq 61LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774102535; x=1774707335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TOf9LcnO5IRemgfOLwtBwbNVtgVrreL+MONpjgDCJOc=; b=lWhYN+0W2eHqOJ4f8cavHoo51iiPTu8L+Z1PHrm17eYgMpHGOrkK3xZRYJzvIQyHEE NqDLJZaFhl/ENW0Vl+oPCQYtXsI8ID0KQrZP2b5gX2g8tuwEmgiOFvaa3kEclVfOn5Zh oMR8W9NTNeSAlI17QRzzgKotl38xN6Jv37gKoQ+G3OtMkTCvu7BKv+TKwn1ILv4LlKKm uxpBtXpnHHQco8u5cO1HIQ6bbqg7+ReDydaMVSKhr+j4cRxZA5JYFYIbcrSDW++DGO6q ylZdkiht52hqSuBo/PTQ6qMAOeYgcdRJglULdrqTOowRyv4MgFvTP31ZTQ3Cvd6LfhSH To2g== X-Forwarded-Encrypted: i=1; AJvYcCXm2LtjopNL1eSx9qrQPbZXy2guxypIIJpAdkBlVkUFd96k3LgRQ0qCFLDMsuIHFCvYZWiOUFuB8mmenRc=@vger.kernel.org X-Gm-Message-State: AOJu0YzorGKjAZanzn2xtx6niVhR75FIO6lFk6j6Bezx04MVxrQi1GXl /PXamAxJ+T9D70JCObU/T4URKCzXWplXkNA6kF61B3LdviSvy9vFLSXv X-Gm-Gg: ATEYQzw5LdEASpbixHiTdRTpM2NXj/jNeu8OrZtqTX+xyXl8Iqi7KKcgZV+X4L6BcDA zShNa/r8ylpPvg5i9W3A+YwmdfhkjDaOY0U8iKwTDeUQMFDgCLRtR/GNqQWIW7GMMw8NxPWhbM/ AOSZ+y0wPCPcR5sGRWgJQiriRxcmt2d+LbNJzUPx23b4mjAAv1gxdWOKVBzISE0naQeODSZg0B0 2a/OWxDXKu1PivklBVJxPSjT2g4bVVY3q0otJ51pbGmdsKpmKgVulMcVu8wX9MnvImxEW/90sGv 08SyeHOxavxOoCPnXunzNd2JbaxnXTM1vG6kpcz++iLoKJkpYlSKjIWGkXXEbIh5uvkNyqWWgqN u1KjvzbtD6Etwgtjj75v87geMsmLxnYOipRPM3v92Yp2cOIW3uB3ZLKSbGQRcMNuz7EIOzyoQ+F 3cAIVwoy/oCTl290cbdYM9yHzpEOaa3WYu3VCwDdRjWV7iAJQwRE4t8x4zMErPoe5v4cvAZqw= X-Received: by 2002:a17:903:1211:b0:2b0:4f9a:b794 with SMTP id d9443c01a7336-2b0827bb54dmr63715295ad.37.1774102535362; Sat, 21 Mar 2026 07:15:35 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08353e94asm52680715ad.25.2026.03.21.07.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:15:35 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 3/5] svcrdma: Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards Date: Sat, 21 Mar 2026 22:15:08 +0800 Message-Id: <20260321141510.68214-4-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260321141510.68214-1-seanwascoding@gmail.com> References: <20260321141510.68214-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove redundant IS_ENABLED(CONFIG_SUNRPC_DEBUG) guards in svc_rdma_accept(). Since dprintk() already evaluates to a no-op (via no_printk) when debugging is disabled, these explicit guards are unnecessary. Verification with .lst files under -O2 confirms that the compiler successfully performs "dead code elimination". Even when variables (like 'sap' in this case) are declared outside of #ifdef, they are completely optimized out (no stack allocation, no symbol references in the final executable) as they are only referenced within dprintk(). Signed-off-by: Sean Chang Reviewed-by: Jeff Layton --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 25 +++++++++++------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma= /svc_rdma_transport.c index f2d72181a6fe..0759444bda50 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -413,6 +413,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt= *xprt) struct rpcrdma_connect_private pmsg; struct ib_qp_init_attr qp_attr; struct ib_device *dev; + struct sockaddr *sap; int ret =3D 0; =20 listen_rdma =3D container_of(xprt, struct svcxprt_rdma, sc_xprt); @@ -559,20 +560,16 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xp= rt *xprt) goto errout; } =20 - if (IS_ENABLED(CONFIG_SUNRPC_DEBUG)) { - struct sockaddr *sap; - - dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); - sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; - dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); - sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; - dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); - dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); - dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); - dprintk(" rdma_rw_ctxs : %d\n", ctxts); - dprintk(" max_requests : %d\n", newxprt->sc_max_requests); - dprintk(" ord : %d\n", conn_param.initiator_depth); - } + dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); + sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; + dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); + sap =3D (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr; + dprintk(" remote address : %pIS:%u\n", sap, rpc_get_port(sap)); + dprintk(" max_sge : %d\n", newxprt->sc_max_send_sges); + dprintk(" sq_depth : %d\n", newxprt->sc_sq_depth); + dprintk(" rdma_rw_ctxs : %d\n", ctxts); + dprintk(" max_requests : %d\n", newxprt->sc_max_requests); + dprintk(" ord : %d\n", conn_param.initiator_depth); =20 return &newxprt->sc_xprt; =20 --=20 2.34.1 From nobody Sat Apr 4 00:21:34 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49D0231C56D for ; Sat, 21 Mar 2026 14:15:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102544; cv=none; b=OnliK6vl8Z0aqC2dKn/CWjmn4jKGnrMIX4lC1WzELATXke0hPhpYfSG7ROBKml1tz3DkT/Mg9YkSDk5ON53beIk/5x+6vUzxZq9ryGtDd5FtuOH67SCdQTJPEbeqLMoNltxoiKAhZz095A3IqEWTZutBU90dwCZun6e2TDYVsgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102544; c=relaxed/simple; bh=S/UgzQXA3QLqhdcPFe6v/HB9WUgH0Mn6KE3pVNm35Go=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dLQ/fSGr9qJtOEsKHfqgAM37IJqlfVy5qY9Lwlop2jXRdrbIyR5e0MouxZTZX1vZ1KqSV0Yw81aSS6RSsTL3TXEc9flWIRgyUV7sqxFeN502OC0nLUnEnO9y+jVybp1qAzl/Eqi5E9ePetoZpS6i4Xd2A0hLr3bTew+PxYqBg9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kp+ztG+F; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kp+ztG+F" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2b0603ee486so19706415ad.0 for ; Sat, 21 Mar 2026 07:15:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774102538; x=1774707338; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RrbOXEwKxG45bbWSYaSRrFiYiD3hpjnUzEitvzAGFtw=; b=kp+ztG+FGkm/U2PLlnzBzA+Gg23QetfBREDEvyWPHjQVIdP7gGZfovMdR1w4gYadww 6GssXfbQqOOpNarqcr5dWzvU/R3U84n7D5h2SGEvY7x/M81DZL2f5xjgGX1YVpb1lIsQ X3JEgvdX7V2jzHhNY3T3nwuSvGaaCo/enImymenBTQ4eBtAbewSLrJ6AQH44oSc3Avaa T2XT6nxMaGDi8eG51rgswh3XSGBMrmhVsXEszzACIJioSo97tu5pypm3vQaF7+/j68Jm T4krEjr5Eu3/AWOwvVrCqsT5HpxzD8/7K8b2xRL8PNZmBjo9Oa9UH3nPBLKbUmqrPjRe 6/Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774102538; x=1774707338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RrbOXEwKxG45bbWSYaSRrFiYiD3hpjnUzEitvzAGFtw=; b=SN86T94LRUV8EfRcrGXKZOmQN56Q8fguq3Ooj1v8S0VhZd8YDQW99SiIfIzHAzChLA GWlICUr+Nw7ogm/BV7Sif6QWMavqrlNMHz6iy/gVrXLssBPw0afSYw95x7bafMhnDP9v nh2oxe3Sxa0e2f3yMuNWPr7bqwPpxXc1UqzbCuQU9zk3woK/FmXt48XEvDNUL/Se9SCC esYfglZctwRuZJbsVmMKJ/6jy5qWuiz3zySWsOAUR+oLBUg87IdFAKRz6xQPHSXniacN npB7KuZryqdS97AffYXlvaZTnAQ1pFnx7mYIi6WC9Lqi5htq0cbuhD8kVbIlGeWMHHNn a/AQ== X-Forwarded-Encrypted: i=1; AJvYcCUGTNBj19eWuI97Un9dV5dmJ9BcltU8YqUaGaIvZkjvABfuFn9wqwSvx2tSsKow2xj8yXpO4mYDJVrN9M0=@vger.kernel.org X-Gm-Message-State: AOJu0YzewkgPFI9fJIUR0tahvwT7boAIrXJYOVFX42t/w6P2TOOYt6Ty SR/uNrzwZwhkOaCiN1FnAw9yG/VZZiBTDRCxnAtwdG6KS/qfLyHptpVk X-Gm-Gg: ATEYQzxnTSg17gY408QGk1LOAUzJqm5xRG6Ob9qu0kBmvx5xG3qxotvtkU/oCLjP7jp b9TchD+poPNAhR5pYKFRfTQfrZoSMcZUHKfCxM0L8x/0lEFgAB0vBYjOaDZVXMj0GDsiektW6Xh oScmAcsOdjCNXivlByGseT2PlIXgLdPHZiKhhs52SXsqKFUivWWe1tcTab6eb+woQCbyF8OgHX6 V7W70oeh0yWnzaW7YcN1DqUAy8bpSBeZUGZPDPgjbfSNPQ9KSPPXfxN84X670S+HgjfK0FH99Q6 wqW9BXci7ZeWAbgXMmLAL13UuojAkuM6A500pCNAfAXx62snP1VZhVkn97JuXbxqrMHYxD5b1Vi 9qIt0iBWRLdgqsk4DMgafag2Fhw2yZ9ftYAnUSuPnAh2fdih62ijflNjg0kx1gx8Kdf/TeoAJ69 ZSUAgkKmB9H9vLNnYHh0ObyfYxLeVXs4WWpK29xrMU0amfIMpcJAihc6HxLtXYLN5PH/1ukfY= X-Received: by 2002:a17:903:2310:b0:2ae:572a:9f19 with SMTP id d9443c01a7336-2b0826fc627mr61129765ad.21.1774102537729; Sat, 21 Mar 2026 07:15:37 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08353e94asm52680715ad.25.2026.03.21.07.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:15:37 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang , kernel test robot Subject: [PATCH v5 4/5] nfs: Refactor nfs_errorf macros and remove unused ones Date: Sat, 21 Mar 2026 22:15:09 +0800 Message-Id: <20260321141510.68214-5-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260321141510.68214-1-seanwascoding@gmail.com> References: <20260321141510.68214-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor nfs_errorf() and nfs_ferrorf() to the standard do-while(0) pattern for safer macro expansion and kernel style compliance. Additionally, remove nfs_warnf() and nfs_fwarnf() as `git grep` confirms they have no callers in the current tree. Furthermore, these functions have remained unused since the introduction in commit ce8866f0913f ("NFS: Attach supplementary error information to fs_context."). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603110038.P6d14oxa-lkp@int= el.com/ Reviewed-by: Andy Shevchenko Tested-by: Andy Shevchenko Signed-off-by: Sean Chang Reviewed-by: Jeff Layton --- fs/nfs/internal.h | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index 63e09dfc27a8..59ab43542390 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -161,13 +161,19 @@ enum nfs_lock_status { NFS_LOCK_NOLOCK =3D 2, }; =20 -#define nfs_errorf(fc, fmt, ...) ((fc)->log.log ? \ - errorf(fc, fmt, ## __VA_ARGS__) : \ - ({ dprintk(fmt "\n", ## __VA_ARGS__); })) - -#define nfs_ferrorf(fc, fac, fmt, ...) ((fc)->log.log ? \ - errorf(fc, fmt, ## __VA_ARGS__) : \ - ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); })) +#define nfs_errorf(fc, fmt, ...) do { \ + if ((fc)->log.log) \ + errorf(fc, fmt, ## __VA_ARGS__); \ + else \ + dprintk(fmt "\n", ## __VA_ARGS__); \ +} while (0) + +#define nfs_ferrorf(fc, fac, fmt, ...) do { \ + if ((fc)->log.log) \ + errorf(fc, fmt, ## __VA_ARGS__); \ + else \ + dfprintk(fac, fmt "\n", ## __VA_ARGS__); \ +} while (0) =20 #define nfs_invalf(fc, fmt, ...) ((fc)->log.log ? \ invalf(fc, fmt, ## __VA_ARGS__) : \ @@ -177,14 +183,6 @@ enum nfs_lock_status { invalf(fc, fmt, ## __VA_ARGS__) : \ ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); -EINVAL; })) =20 -#define nfs_warnf(fc, fmt, ...) ((fc)->log.log ? \ - warnf(fc, fmt, ## __VA_ARGS__) : \ - ({ dprintk(fmt "\n", ## __VA_ARGS__); })) - -#define nfs_fwarnf(fc, fac, fmt, ...) ((fc)->log.log ? \ - warnf(fc, fmt, ## __VA_ARGS__) : \ - ({ dfprintk(fac, fmt "\n", ## __VA_ARGS__); })) - static inline struct nfs_fs_context *nfs_fc2context(const struct fs_contex= t *fc) { return fc->fs_private; --=20 2.34.1 From nobody Sat Apr 4 00:21:34 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB9238C403 for ; Sat, 21 Mar 2026 14:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102541; cv=none; b=cHFYY9Hx/VE06AW7l6yMGDcVTV0DT0MZKoxIAqaSaKJ+sFYhFIiriY4Q0vlMIcfPUpTa0jPUGbDddhWDDRYWMhPW0yYd0jXZ4VRNTKeVd+S0I8ZjG5YbZaynL53F1pUDd8PW/Ej4yDKioAT961HXfRS2NaBuu4brIbAZGSkhME0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774102541; c=relaxed/simple; bh=jzPZdf7Og6HeFXO/l7pOiaD9NwH4pg2nD16c3hH6gys=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=euAPwa18AnpTXLWKMQpg/iVPOoXeFUSsdaI1lLQ9fk0kO+fOTA+cYRE+gNg4xNZ9pyaj1VlPoFErwYBQYg9ak/782yOORKjR1puIqdZsuPBTtEb2fXaXLFux8TvTG7dLeWqus0OKWUwWp4q3LADFDVl/785gO/5NfefYDFD3k5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NYd7EU0c; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NYd7EU0c" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a9296b3926so22200265ad.1 for ; Sat, 21 Mar 2026 07:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774102540; x=1774707340; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uAJIY1DIMzupbpUoUnEua+5LFL/m08GzQPtpfspcCIA=; b=NYd7EU0cfP1gufCqrBWKH/v4MgXV1XbX+CRwp1a2WHdh+LjcQrZ94YP1y4JBVVlFGh Mf6JidkQekGIFXYITEZcj2H/q0BVHJKs7ysTtL102OfQLP54EGH2l8iJIn7yxnJQZTB2 dj9RPGmAP02c4ctaZfJUeGIIjuicHHA0NAxwly8bsJniA8ghDz6upbvPhhBJRq2q/Qg6 CJ5ndGdvpvt7n7UwH9qhXXfgpa53eTivUyWC2XXKcfwvEVAokmpydT+u5PzCKA1UluHZ FAPkUNjyniz/YWogBvZgEjgTzZdvfhiMPyjQ2tafxGykxHWBWD+piLMsAKPi8TLme0Ze FQdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774102540; x=1774707340; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uAJIY1DIMzupbpUoUnEua+5LFL/m08GzQPtpfspcCIA=; b=FMMXaB1UXppXix/KODsK7/cF0w8GClrUs4QvZSSv3wxp6HqzvmV7sTD6UHfkx/8FV+ k9BznuSOkpItdvQ7fVlNZ2adTDuz5a5cHh7yX8b0Z+kPWEPdffr2Lo8bDgvVV3qUGhaY UMn6fEeEBjpex2gdMQWhADtg0F4ikCdsCJfuQWTMw88sHEUgW2PsJlMTlSq68k6HEZpF CXA9sPrQq8jMHjxHWh4Kw1k2c4MS6UJWx+EbGQMdtaAj83HiU0fhlpFDqkj6diysuo/5 TpqZYZuBPrm0kIZ3s5Fkkg/P/34YjbgpUCHiAI6Rh1oycSHNhp4M+SgAw3TtOwGPYV9p IG9Q== X-Forwarded-Encrypted: i=1; AJvYcCV9d5cq35KlpXfQqIpV2kbIPS6LULeqt7AMSWYvjFaKtB4SAtLvh1oDoiI08UmNGA7iMh4Ft5AvBjg5xo0=@vger.kernel.org X-Gm-Message-State: AOJu0YwSRHE2a486ditYZcAcfmgmX+gm3kBQ/aw6qO8CTGyRkhOX4JCK cqwbbYyNOhhEkt4GeCUnbsiXRN2A5QPBpFyj5kLVNXabZ7EftXVeJdVB X-Gm-Gg: ATEYQzy0YbcPr4X4nqTbl5WQqwKC3+NifKhiRmdZDhnFO8gVyEjuE4FGSOfVy7STUED NPpZOBPO5I8vT6XXrjmpuOJmGhE+5CDXAuS5p1GM6n0DNaH2K0emuDkIsAXn/2rXehZ483l9DcD slmDF8FqyPajDVInPmo2XJJF9DBGvN1sxw9ZJ1/Vj9Gzyxmk4xd/GAuf5JIi5miz5kCWkNm0eQw 4Adx7AWVaq1c9NxGyxFH3juvbV2G0bRnpDx15WmzONWYkzTpjtL3esfhU2d+yV4aKz3LoAAd5/5 PSncmEGojsIF1kXs/QieLMp0x3T1DlDXqaAuFpfOODHv+AwhZ33f8TrvSVkwiRzxRZz6dkcYOMO NLJ+/7oli8PsooRl1LmzPTdyIS9W1JgcW2HhqhDBx7RZF+RroXpIhs7AlQK1TOUtGVGlOk3CPe5 T0YPmClVxNuOYMA/NJGWzSbnu+uQmnsuPhe0kPuFLQmnEe5SYMzMOIR0lbBPFMalaPee9jc5M= X-Received: by 2002:a17:902:db03:b0:2b0:669d:3a68 with SMTP id d9443c01a7336-2b0826f36a2mr64480885ad.19.1774102539735; Sat, 21 Mar 2026 07:15:39 -0700 (PDT) Received: from sean-All-Series.. (1-160-226-215.dynamic-ip.hinet.net. [1.160.226.215]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08353e94asm52680715ad.25.2026.03.21.07.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 07:15:39 -0700 (PDT) From: Sean Chang To: Andrew Lunn , Chuck Lever , David Laight , Anna Schumaker , Andy Shevchenko Cc: netdev@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Sean Chang Subject: [PATCH v5 5/5] Revert "nfsd: Mark variable __maybe_unused to avoid W=1 build break" Date: Sat, 21 Mar 2026 22:15:10 +0800 Message-Id: <20260321141510.68214-6-seanwascoding@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260321141510.68214-1-seanwascoding@gmail.com> References: <20260321141510.68214-1-seanwascoding@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit ebae102897e760e9e6bc625f701dd666b2163bd1. The __maybe_unused attributes are no longer needed because dprintk() now uses no_printk(), which ensures variables are referenced by the compiler even when debugging is disabled. Signed-off-by: Sean Chang Reviewed-by: Jeff Layton --- fs/nfsd/export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c index 8fdbba7cad96..8116e5bcbe00 100644 --- a/fs/nfsd/export.c +++ b/fs/nfsd/export.c @@ -1025,7 +1025,7 @@ exp_rootfh(struct net *net, struct auth_domain *clp, = char *name, { struct svc_export *exp; struct path path; - struct inode *inode __maybe_unused; + struct inode *inode; struct svc_fh fh; int err; struct nfsd_net *nn =3D net_generic(net, nfsd_net_id); --=20 2.34.1